)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"c891ec54af5b867201b8d00e7710e932d62f1e73","unresolved":false,"context_lines":[{"line_number":5572,"context_line":"        # NOTE(tr3buchet): tear down networks on source host"},{"line_number":5573,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"},{"line_number":5574,"context_line":"                                                prev_host, teardown\u003dTrue)"},{"line_number":5575,"context_line":"        # NOTE(vish): this is necessary to update dhcp"},{"line_number":5576,"context_line":"        self.network_api.setup_networks_on_host(context, instance, self.host)"},{"line_number":5577,"context_line":"        self._notify_about_instance_usage("},{"line_number":5578,"context_line":"                     context, instance, \"live_migration.post.dest.end\","},{"line_number":5579,"context_line":"                     network_info\u003dnetwork_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_aca25397","line":5576,"range":{"start_line":5575,"start_character":8,"end_line":5576,"end_character":77},"updated":"2016-09-30 10:40:36.000000000","message":"I\u0027d rather think of wrapping this line instead, as it possible we do not re-setup network properly...","commit_id":"d56cffa66a16e81a77c67303c9964a10b4daca77"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9bd60e46eafb013a5c4cc4efe38cc025effe6071","unresolved":false,"context_lines":[{"line_number":5376,"context_line":"                                       self._rollback_live_migration,"},{"line_number":5377,"context_line":"                                       block_migration, migrate_data)"},{"line_number":5378,"context_line":"        except Exception:"},{"line_number":5379,"context_line":"            # Executing live migration"},{"line_number":5380,"context_line":"            # live_migration might raises exceptions, but"},{"line_number":5381,"context_line":"            # nothing must be recovered in this version."},{"line_number":5382,"context_line":"            LOG.exception(_LE(\u0027Live migration failed.\u0027), instance\u003dinstance)"},{"line_number":5383,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5384,"context_line":"                if instance.task_state \u003d\u003d task_states.MIGRATING:"},{"line_number":5385,"context_line":"                    self._rollback_live_migration(context, instance, dest,"},{"line_number":5386,"context_line":"                                                  migrate_data)"},{"line_number":5387,"context_line":""},{"line_number":5388,"context_line":"    @wrap_exception()"},{"line_number":5389,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_2abd1db7","line":5386,"range":{"start_line":5379,"start_character":0,"end_line":5386,"end_character":63},"updated":"2017-01-17 17:09:06.000000000","message":"if rollback hasn\u0027t occured and task state is set in migrating, then I assume that exception occured prior to live migration as exceptions occured during live migration will be taken care by live_migration_monitor.","commit_id":"124bb2145270ad3a6420261eabe718214fdf449a"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"30e0a58ba9fb62ae06f54e05ce9dd82873a4f2bd","unresolved":false,"context_lines":[{"line_number":5376,"context_line":"                                       self._rollback_live_migration,"},{"line_number":5377,"context_line":"                                       block_migration, migrate_data)"},{"line_number":5378,"context_line":"        except Exception:"},{"line_number":5379,"context_line":"            # Executing live migration"},{"line_number":5380,"context_line":"            # live_migration might raises exceptions, but"},{"line_number":5381,"context_line":"            # nothing must be recovered in this version."},{"line_number":5382,"context_line":"            LOG.exception(_LE(\u0027Live migration failed.\u0027), instance\u003dinstance)"},{"line_number":5383,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5384,"context_line":"                if instance.task_state \u003d\u003d task_states.MIGRATING:"},{"line_number":5385,"context_line":"                    self._rollback_live_migration(context, instance, dest,"},{"line_number":5386,"context_line":"                                                  migrate_data)"},{"line_number":5387,"context_line":""},{"line_number":5388,"context_line":"    @wrap_exception()"},{"line_number":5389,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_6b43a442","line":5386,"range":{"start_line":5379,"start_character":0,"end_line":5386,"end_character":63},"in_reply_to":"7a3c09a3_2abd1db7","updated":"2017-01-17 18:54:08.000000000","message":"Consider modifying the comment, as doesn\u0027t a rollback imply some (state) recovery?","commit_id":"124bb2145270ad3a6420261eabe718214fdf449a"}]}
