)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1125076c6bc9a988052a3cbe6a582252599e708d","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def _get_hypervisor_type(self):"},{"line_number":450,"context_line":"        \"\"\"Get hypervisor type.\"\"\""},{"line_number":451,"context_line":"        return obj_fields.HVType.IRONIC"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def _get_hypervisor_version(self):"},{"line_number":454,"context_line":"        \"\"\"Returns the version of the Ironic API service endpoint.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_48a8ca20","line":451,"updated":"2017-01-12 00:27:48.000000000","message":"In most drivers, hypervisor_type is defined as hardcoded string value like the following:\n\n fake.py:            \u0027hypervisor_type\u0027: \u0027fake\u0027,\n hyperv/hostops.py:  \u0027hypervisor_type\u0027: \"hyperv\",\n ironic/driver.py:   \u0027hypervisor_type\u0027: self._get_hypervisor_type(),\n xenapi/driver.py:   \u0027hypervisor_type\u0027: \u0027XenServer\u0027,\n\nI can see the point of this, but this also makes the code readability less because developers need to read the other module files if applying this patch. That seems over-optimization for me.","commit_id":"05afc12b0ccfd8b068a98594e57190bb0bfbdeae"}]}