)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3a361abbf1008c91ccdc2a204f79c20901754017","unresolved":false,"context_lines":[{"line_number":15528,"context_line":"                                                         mock_get_disk_info):"},{"line_number":15529,"context_line":"        # Check error on resize root disk down for rbd."},{"line_number":15530,"context_line":"        # The difference is that get_instance_disk_info always returns"},{"line_number":15531,"context_line":"        # an emply list for rbd."},{"line_number":15532,"context_line":"        # Ephemeral size is not changed in this case (otherwise other check"},{"line_number":15533,"context_line":"        # will raise the same error)."},{"line_number":15534,"context_line":"        self.flags(images_type\u003d\u0027rbd\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_6fdf1f69","line":15531,"range":{"start_line":15531,"start_character":13,"end_line":15531,"end_character":18},"updated":"2016-12-06 02:43:47.000000000","message":"typo \"empty\"","commit_id":"ed994bb4d72b5f93cfb76a5f726264e4896ad4ed"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e8c0dfb21ec78f8769f7b778ba892edc98b30d90","unresolved":false,"context_lines":[{"line_number":2855,"context_line":"        return \u0027rbd\u0027 if CONF.libvirt.images_type \u003d\u003d \u0027rbd\u0027 else \u0027raw\u0027"},{"line_number":2856,"context_line":""},{"line_number":2857,"context_line":"    @staticmethod"},{"line_number":2858,"context_line":"    def _is_booted_from_volume(block_device_info):"},{"line_number":2859,"context_line":"        \"\"\"Determines whether the VM is booting from volume"},{"line_number":2860,"context_line":""},{"line_number":2861,"context_line":"        Determines whether the block device info indicates that the VM"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_4f091c2c","line":2858,"updated":"2016-10-11 09:17:04.000000000","message":"Interesting so it\u0027s basically What I suggested to you [1]. Please move that change here.\n\nhttps://review.openstack.org/#/c/334609/","commit_id":"d22691a539f9d739101d4e0c485f3f50b4960316"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"9270e113c6078939a5a78646b55106be13403fff","unresolved":false,"context_lines":[{"line_number":2855,"context_line":"        return \u0027rbd\u0027 if CONF.libvirt.images_type \u003d\u003d \u0027rbd\u0027 else \u0027raw\u0027"},{"line_number":2856,"context_line":""},{"line_number":2857,"context_line":"    @staticmethod"},{"line_number":2858,"context_line":"    def _is_booted_from_volume(block_device_info):"},{"line_number":2859,"context_line":"        \"\"\"Determines whether the VM is booting from volume"},{"line_number":2860,"context_line":""},{"line_number":2861,"context_line":"        Determines whether the block device info indicates that the VM"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_436509b3","line":2858,"in_reply_to":"fa6399be_4f091c2c","updated":"2016-11-17 07:00:28.000000000","message":"Done","commit_id":"d22691a539f9d739101d4e0c485f3f50b4960316"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fbff80bd3f3a029e8817b1a5a3a4e651bef75735","unresolved":false,"context_lines":[{"line_number":4711,"context_line":"    def _create_domain_setup_lxc(self, instance, image_meta,"},{"line_number":4712,"context_line":"                                 block_device_info, disk_info):"},{"line_number":4713,"context_line":"        inst_path \u003d libvirt_utils.get_instance_path(instance)"},{"line_number":4714,"context_line":"        block_device_mapping \u003d driver.block_device_info_get_mapping("},{"line_number":4715,"context_line":"            block_device_info)"},{"line_number":4716,"context_line":"        root_disk \u003d block_device.get_root_bdm(block_device_mapping)"},{"line_number":4717,"context_line":"        if root_disk:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_49843f5d","line":4714,"updated":"2016-11-17 12:01:37.000000000","message":"I guess that refactor is something reasonable even if we can argue to make it happen on an other patch.","commit_id":"c593cc9f6ed302e0eb1c804728310aaee47a7c4c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fbff80bd3f3a029e8817b1a5a3a4e651bef75735","unresolved":false,"context_lines":[{"line_number":7115,"context_line":"            disk_dev \u003d vol[\u0027mount_device\u0027].rpartition(\"/\")[2]"},{"line_number":7116,"context_line":"            self._disconnect_volume(connection_info, disk_dev)"},{"line_number":7117,"context_line":""},{"line_number":7118,"context_line":"        disk_info_text \u003d self.get_instance_disk_info("},{"line_number":7119,"context_line":"            instance, block_device_info\u003dblock_device_info)"},{"line_number":7120,"context_line":"        disk_info \u003d jsonutils.loads(disk_info_text)"},{"line_number":7121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_89249760","line":7118,"updated":"2016-11-17 12:01:37.000000000","message":"That code is crazy we should really review that part... get_instance_disk_info get a json-string from _get_instance_disk_info, convert it to an object, then we convert it back to a string...","commit_id":"c593cc9f6ed302e0eb1c804728310aaee47a7c4c"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"cd8781ba485429fce2cf6325395500f6de5613b5","unresolved":false,"context_lines":[{"line_number":7115,"context_line":"            disk_dev \u003d vol[\u0027mount_device\u0027].rpartition(\"/\")[2]"},{"line_number":7116,"context_line":"            self._disconnect_volume(connection_info, disk_dev)"},{"line_number":7117,"context_line":""},{"line_number":7118,"context_line":"        disk_info_text \u003d self.get_instance_disk_info("},{"line_number":7119,"context_line":"            instance, block_device_info\u003dblock_device_info)"},{"line_number":7120,"context_line":"        disk_info \u003d jsonutils.loads(disk_info_text)"},{"line_number":7121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_3bc74a65","line":7118,"in_reply_to":"7a77a97e_89249760","updated":"2016-11-17 12:23:05.000000000","message":"It\u0027s fixed in the next patch: https://review.openstack.org/#/c/334901/8/nova/virt/libvirt/driver.py@7117","commit_id":"c593cc9f6ed302e0eb1c804728310aaee47a7c4c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"f70d124e5052042e3c4aae04c5b4b2753ce71924","unresolved":false,"context_lines":[{"line_number":2937,"context_line":"        \"\"\""},{"line_number":2938,"context_line":"        block_device_mapping \u003d driver.block_device_info_get_mapping("},{"line_number":2939,"context_line":"            block_device_info)"},{"line_number":2940,"context_line":"        return bool(block_device.get_root_bdm(block_device_mapping))"},{"line_number":2941,"context_line":""},{"line_number":2942,"context_line":"    def _inject_data(self, injection_image, instance, network_info,"},{"line_number":2943,"context_line":"                     admin_pass, files):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_b747371c","line":2940,"updated":"2016-12-02 11:17:55.000000000","message":"Eww... vague falsey test. Don\u0027t we know what get_root_bdm is supposed to return?","commit_id":"ed994bb4d72b5f93cfb76a5f726264e4896ad4ed"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"7f0b3868283d2badf088206467ccb902c5079c05","unresolved":false,"context_lines":[{"line_number":2937,"context_line":"        \"\"\""},{"line_number":2938,"context_line":"        block_device_mapping \u003d driver.block_device_info_get_mapping("},{"line_number":2939,"context_line":"            block_device_info)"},{"line_number":2940,"context_line":"        return bool(block_device.get_root_bdm(block_device_mapping))"},{"line_number":2941,"context_line":""},{"line_number":2942,"context_line":"    def _inject_data(self, injection_image, instance, network_info,"},{"line_number":2943,"context_line":"                     admin_pass, files):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_9754f421","line":2940,"in_reply_to":"3a71b18c_b747371c","updated":"2016-12-02 13:37:17.000000000","message":"Hmm... may be i\u0027ll change this to \u0027xxx is not None\u0027 on the next rebase.","commit_id":"ed994bb4d72b5f93cfb76a5f726264e4896ad4ed"}]}