)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dfcedd5d2d27edc1476efff8d554b971cf849c20","unresolved":false,"context_lines":[{"line_number":10082,"context_line":"        mock_build_device_metadata.return_value \u003d None"},{"line_number":10083,"context_line":""},{"line_number":10084,"context_line":"        def fake_create_domain_and_network("},{"line_number":10085,"context_line":"                context, xml, instance, network_info, disk_info,"},{"line_number":10086,"context_line":"                block_device_info\u003dNone, power_on\u003dTrue, reboot\u003dFalse,"},{"line_number":10087,"context_line":"                vifs_already_plugged\u003dFalse, post_xml_callback\u003dNone):"},{"line_number":10088,"context_line":"            # The config disk should be created by this callback, so we need"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_71f4c986","line":10085,"range":{"start_line":10085,"start_character":54,"end_line":10085,"end_character":64},"updated":"2016-10-06 06:17:03.000000000","message":"It should be fixed.","commit_id":"2cbf53286b16c8cc5e86fd764148f7ebcf125f5e"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"3bcaae4ed76f0b576dcc21c1d981b7821fbd4acd","unresolved":false,"context_lines":[{"line_number":10082,"context_line":"        mock_build_device_metadata.return_value \u003d None"},{"line_number":10083,"context_line":""},{"line_number":10084,"context_line":"        def fake_create_domain_and_network("},{"line_number":10085,"context_line":"                context, xml, instance, network_info, disk_info,"},{"line_number":10086,"context_line":"                block_device_info\u003dNone, power_on\u003dTrue, reboot\u003dFalse,"},{"line_number":10087,"context_line":"                vifs_already_plugged\u003dFalse, post_xml_callback\u003dNone):"},{"line_number":10088,"context_line":"            # The config disk should be created by this callback, so we need"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_4b5711ce","line":10085,"range":{"start_line":10085,"start_character":54,"end_line":10085,"end_character":64},"in_reply_to":"1a95cdbc_71f4c986","updated":"2016-10-06 10:49:46.000000000","message":"Done. Thanks","commit_id":"2cbf53286b16c8cc5e86fd764148f7ebcf125f5e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fe4ca9c866802f70dbc340db463af082047d356","unresolved":false,"context_lines":[{"line_number":4549,"context_line":"                              drvr._create_domain_and_network,"},{"line_number":4550,"context_line":"                              self.context,"},{"line_number":4551,"context_line":"                              \u0027xml\u0027,"},{"line_number":4552,"context_line":"                              mock_instance, None, None)"},{"line_number":4553,"context_line":""},{"line_number":4554,"context_line":"            mock_teardown.assert_called_with(container_dir\u003d\u0027/tmp/rootfs\u0027)"},{"line_number":4555,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_a524ca0c","line":4552,"range":{"start_line":4552,"start_character":51,"end_line":4552,"end_character":55},"updated":"2016-11-29 07:27:54.000000000","message":"ditto","commit_id":"bddd40f73e88385e7a88fa61e9a9f54093c72155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fe4ca9c866802f70dbc340db463af082047d356","unresolved":false,"context_lines":[{"line_number":13594,"context_line":"            mock.patch.object(drvr.firewall_driver, \u0027prepare_instance_filter\u0027),"},{"line_number":13595,"context_line":"            mock.patch.object(drvr.firewall_driver, \u0027apply_instance_filter\u0027)):"},{"line_number":13596,"context_line":"            drvr._create_domain_and_network(self.context, \u0027xml\u0027,"},{"line_number":13597,"context_line":"                                            mock_instance, [], None)"},{"line_number":13598,"context_line":""},{"line_number":13599,"context_line":"        self.assertEqual(\u0027/dev/nbd0\u0027, inst_sys_meta[\u0027rootfs_device_name\u0027])"},{"line_number":13600,"context_line":"        self.assertFalse(mock_instance.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_05b9fecb","line":13597,"range":{"start_line":13597,"start_character":63,"end_line":13597,"end_character":67},"updated":"2016-11-29 07:27:54.000000000","message":"this can be removed. it will be nice not to pass this in case block_device_info param default value is changed accidentally.","commit_id":"bddd40f73e88385e7a88fa61e9a9f54093c72155"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"d0eb60d4f3a9290a97acdde0015e03a503cc9f94","unresolved":false,"context_lines":[{"line_number":13594,"context_line":"            mock.patch.object(drvr.firewall_driver, \u0027prepare_instance_filter\u0027),"},{"line_number":13595,"context_line":"            mock.patch.object(drvr.firewall_driver, \u0027apply_instance_filter\u0027)):"},{"line_number":13596,"context_line":"            drvr._create_domain_and_network(self.context, \u0027xml\u0027,"},{"line_number":13597,"context_line":"                                            mock_instance, [], None)"},{"line_number":13598,"context_line":""},{"line_number":13599,"context_line":"        self.assertEqual(\u0027/dev/nbd0\u0027, inst_sys_meta[\u0027rootfs_device_name\u0027])"},{"line_number":13600,"context_line":"        self.assertFalse(mock_instance.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_21e169ff","line":13597,"range":{"start_line":13597,"start_character":63,"end_line":13597,"end_character":67},"in_reply_to":"5a74a57a_05b9fecb","updated":"2016-11-29 18:34:03.000000000","message":"Done\n\nThanks. Missed all of that by unknown reason","commit_id":"bddd40f73e88385e7a88fa61e9a9f54093c72155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fe4ca9c866802f70dbc340db463af082047d356","unresolved":false,"context_lines":[{"line_number":13662,"context_line":"            mock_apply_instance_filter"},{"line_number":13663,"context_line":"        ):"},{"line_number":13664,"context_line":"            drvr._create_domain_and_network(self.context, \u0027xml\u0027,"},{"line_number":13665,"context_line":"                                            mock_instance, [], None)"},{"line_number":13666,"context_line":""},{"line_number":13667,"context_line":"        self.assertEqual(\u0027/dev/nbd0\u0027, inst_sys_meta[\u0027rootfs_device_name\u0027])"},{"line_number":13668,"context_line":"        self.assertFalse(mock_instance.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_45af767c","line":13665,"range":{"start_line":13665,"start_character":63,"end_line":13665,"end_character":67},"updated":"2016-11-29 07:27:54.000000000","message":"ditto","commit_id":"bddd40f73e88385e7a88fa61e9a9f54093c72155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fe4ca9c866802f70dbc340db463af082047d356","unresolved":false,"context_lines":[{"line_number":13711,"context_line":"            mock.patch.object(drvr.firewall_driver, \u0027prepare_instance_filter\u0027),"},{"line_number":13712,"context_line":"            mock.patch.object(drvr.firewall_driver, \u0027apply_instance_filter\u0027)):"},{"line_number":13713,"context_line":"            drvr._create_domain_and_network(self.context, \u0027xml\u0027,"},{"line_number":13714,"context_line":"                                            mock_instance, [], None)"},{"line_number":13715,"context_line":""},{"line_number":13716,"context_line":"        self.assertEqual(\u0027/dev/nbd0\u0027, inst_sys_meta[\u0027rootfs_device_name\u0027])"},{"line_number":13717,"context_line":"        self.assertFalse(mock_instance.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_c5f1c696","line":13714,"range":{"start_line":13714,"start_character":63,"end_line":13714,"end_character":67},"updated":"2016-11-29 07:27:54.000000000","message":"ditto","commit_id":"bddd40f73e88385e7a88fa61e9a9f54093c72155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fe4ca9c866802f70dbc340db463af082047d356","unresolved":false,"context_lines":[{"line_number":14143,"context_line":"                              drvr._create_domain_and_network,"},{"line_number":14144,"context_line":"                              self.context,"},{"line_number":14145,"context_line":"                              \u0027xml\u0027,"},{"line_number":14146,"context_line":"                              instance, None, None)"},{"line_number":14147,"context_line":""},{"line_number":14148,"context_line":"    def test_create_without_pause(self):"},{"line_number":14149,"context_line":"        self.flags(virt_type\u003d\u0027lxc\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_6537124d","line":14146,"range":{"start_line":14146,"start_character":46,"end_line":14146,"end_character":50},"updated":"2016-11-29 07:27:54.000000000","message":"ditto","commit_id":"bddd40f73e88385e7a88fa61e9a9f54093c72155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fe4ca9c866802f70dbc340db463af082047d356","unresolved":false,"context_lines":[{"line_number":14164,"context_line":"              mock.patch.object(drvr, \u0027cleanup\u0027)) as ("},{"line_number":14165,"context_line":"              _handler, cleanup, firewall_driver, create, plug_vifs):"},{"line_number":14166,"context_line":"            domain \u003d drvr._create_domain_and_network(self.context, \u0027xml\u0027,"},{"line_number":14167,"context_line":"                                                     instance, None, None)"},{"line_number":14168,"context_line":"            self.assertEqual(0, create.call_args_list[0][1][\u0027pause\u0027])"},{"line_number":14169,"context_line":"            self.assertEqual(0, domain.resume.call_count)"},{"line_number":14170,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_85426eac","line":14167,"range":{"start_line":14167,"start_character":69,"end_line":14167,"end_character":73},"updated":"2016-11-29 07:27:54.000000000","message":"ditto","commit_id":"bddd40f73e88385e7a88fa61e9a9f54093c72155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fe4ca9c866802f70dbc340db463af082047d356","unresolved":false,"context_lines":[{"line_number":14205,"context_line":"        @mock.patch.object(drvr, \u0027cleanup\u0027)"},{"line_number":14206,"context_line":"        def test_create(cleanup, create, fw_driver, plug_vifs):"},{"line_number":14207,"context_line":"            domain \u003d drvr._create_domain_and_network(self.context, \u0027xml\u0027,"},{"line_number":14208,"context_line":"                                                     instance, vifs, None,"},{"line_number":14209,"context_line":"                                                     power_on\u003dpower_on)"},{"line_number":14210,"context_line":"            plug_vifs.assert_called_with(instance, vifs)"},{"line_number":14211,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_e54322ad","line":14208,"range":{"start_line":14208,"start_character":69,"end_line":14208,"end_character":73},"updated":"2016-11-29 07:27:54.000000000","message":"ditto","commit_id":"bddd40f73e88385e7a88fa61e9a9f54093c72155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1296c4d9b0e7633656740a5cc70820c9f74057e7","unresolved":false,"context_lines":[{"line_number":15794,"context_line":"        # NOTE(mdbooth): If we wanted to check the generated xml, we could"},{"line_number":15795,"context_line":"        #                insert a hook here"},{"line_number":15796,"context_line":"        mock_create_domain_and_network.assert_called_once_with("},{"line_number":15797,"context_line":"            mock.ANY, mock.ANY, instance, [], mock.ANY,"},{"line_number":15798,"context_line":"            block_device_info\u003dbdi, power_on\u003dpower_on,"},{"line_number":15799,"context_line":"            vifs_already_plugged\u003dTrue, post_xml_callback\u003dmock.ANY)"},{"line_number":15800,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_d05e8411","line":15797,"range":{"start_line":15797,"start_character":46,"end_line":15797,"end_character":54},"updated":"2016-12-02 08:34:44.000000000","message":"this is left, not sure why its not complaining.","commit_id":"3daa93d00ee48edda2fd66ffec1013a20ea1917b"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"0c5b827b6dcb1eccf334ffeaee3b05cfeebcd81c","unresolved":false,"context_lines":[{"line_number":15794,"context_line":"        # NOTE(mdbooth): If we wanted to check the generated xml, we could"},{"line_number":15795,"context_line":"        #                insert a hook here"},{"line_number":15796,"context_line":"        mock_create_domain_and_network.assert_called_once_with("},{"line_number":15797,"context_line":"            mock.ANY, mock.ANY, instance, [], mock.ANY,"},{"line_number":15798,"context_line":"            block_device_info\u003dbdi, power_on\u003dpower_on,"},{"line_number":15799,"context_line":"            vifs_already_plugged\u003dTrue, post_xml_callback\u003dmock.ANY)"},{"line_number":15800,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_91e32e05","line":15797,"range":{"start_line":15797,"start_character":46,"end_line":15797,"end_character":54},"in_reply_to":"3a71b18c_d05e8411","updated":"2016-12-02 09:38:40.000000000","message":"Done","commit_id":"3daa93d00ee48edda2fd66ffec1013a20ea1917b"}]}