)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bb562946e7ed865619fc744fc9151c4646ca8dd4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"[1] : https://github.com/openstack/nova/blob/9c89e07/nova/db/sqlalchemy/api_models.py#L206"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I79564032fe160421455a57fc2628b2f05d51b905"},{"line_number":16,"context_line":"Closes-Bug: 1630463"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_7e468424","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":19},"updated":"2016-10-05 09:45:14.000000000","message":"FWIW, I\u0027m not convinced that the existing length is a bug. That\u0027s a limitation sure.","commit_id":"4f47080f4db8b92588d613209bad56f05661603e"}],"nova/db/sqlalchemy/api_models.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bb562946e7ed865619fc744fc9151c4646ca8dd4","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":205,"context_line":"    key \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":206,"context_line":"    value \u003d Column(String(2048))"},{"line_number":207,"context_line":"    flavor_id \u003d Column(Integer, ForeignKey(\u0027flavors.id\u0027), nullable\u003dFalse)"},{"line_number":208,"context_line":"    flavor \u003d orm.relationship(Flavors, backref\u003d\u0027extra_specs\u0027,"},{"line_number":209,"context_line":"                              foreign_keys\u003dflavor_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_2b31200c","line":206,"updated":"2016-10-05 09:45:14.000000000","message":"That has a terrible performance impact in MySQL IMHO, because given that we JOIN on that table, it would increase *a lot* the space taken in memory by the temporary tables resulting from the JOINs.\n\nThat plus the fact we lock up the table until we iterate over all the records until the ALTER is done.\n\nAre we really sure it\u0027s important ? What is the usecase ?","commit_id":"4f47080f4db8b92588d613209bad56f05661603e"}]}