)]}'
{"nova/cmd/policy_check.py":[{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"315ea02faf7a6adea4aff1d628f1c1d891e42d5b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"cli_opts \u003d ["},{"line_number":40,"context_line":"    cfg.ListOpt("},{"line_number":41,"context_line":"        \u0027os-roles\u0027,"},{"line_number":42,"context_line":"        metavar\u003d\u0027\u003cauth-roles\u003e\u0027,"},{"line_number":43,"context_line":"        default\u003dos.environ.get(\u0027OS_ROLES\u0027),"},{"line_number":44,"context_line":"        help\u003d_(\u0027Defaults to env[OS_ROLES].\u0027)),"},{"line_number":45,"context_line":"    cfg.StrOpt("},{"line_number":46,"context_line":"        \u0027os-user-id\u0027,"},{"line_number":47,"context_line":"        metavar\u003d\u0027\u003cauth-user-id\u003e\u0027,"},{"line_number":48,"context_line":"        default\u003dos.environ.get(\u0027OS_USER_ID\u0027),"},{"line_number":49,"context_line":"        help\u003d_(\u0027Defaults to env[OS_USER_ID].\u0027)),"},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \u0027os-tenant-id\u0027,"},{"line_number":52,"context_line":"        metavar\u003d\u0027\u003cauth-tenant-id\u003e\u0027,"},{"line_number":53,"context_line":"        default\u003dos.environ.get(\u0027OS_TENANT_ID\u0027),"},{"line_number":54,"context_line":"        help\u003d_(\u0027Defaults to env[OS_TENANT_ID].\u0027)),"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class PolicyCommands(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_b65c75ee","line":55,"range":{"start_line":39,"start_character":0,"end_line":55,"end_character":1},"updated":"2016-10-06 12:46:27.000000000","message":"I think I should have removed the config options and set it directly with environ variables. will do it in follow up patch after getting reviewers comments.","commit_id":"0914be73bfdf4228ec1bbd3ecab143fef788c141"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"d97c1981df64e313fd51aaff56f654837877e57f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                          \u0027\"instance_id\" is used, the other targets will be \u0027"},{"line_number":53,"context_line":"                          \u0027overwritten.\u0027 % \u0027,\u0027.join(_ACCEPTABLE_TARGETS))"},{"line_number":54,"context_line":"    @cmd_common.args(\u0027--project\u0027, dest\u003d\u0027project_id\u0027, metavar\u003d\u0027\u003cProject name\u003e\u0027,"},{"line_number":55,"context_line":"            help\u003d\u0027Optional project name\u0027)"},{"line_number":56,"context_line":"    @cmd_common.args(\u0027--user\u0027, dest\u003d\u0027user_id\u0027, metavar\u003d\u0027\u003cUser name\u003e\u0027,"},{"line_number":57,"context_line":"            help\u003d\u0027Optional user name\u0027)"},{"line_number":58,"context_line":"    @cmd_common.args(\u0027--roles\u0027, dest\u003d\u0027roles\u0027, metavar\u003d\u0027\u003cRole\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_24f54a56","line":55,"updated":"2016-10-07 18:01:47.000000000","message":"The config help texts explain that if not provided these options will default to env[foo]. The help texts here should do the same thing.","commit_id":"13d4a6e9ee913276d0509497fa20051c0a7d61d3"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d76c26d6006ba32963797528a3a42e2171613d74","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                          \u0027\"instance_id\" is used, the other targets will be \u0027"},{"line_number":53,"context_line":"                          \u0027overwritten.\u0027 % \u0027,\u0027.join(_ACCEPTABLE_TARGETS))"},{"line_number":54,"context_line":"    @cmd_common.args(\u0027--project\u0027, dest\u003d\u0027project_id\u0027, metavar\u003d\u0027\u003cProject name\u003e\u0027,"},{"line_number":55,"context_line":"            help\u003d\u0027Optional project name\u0027)"},{"line_number":56,"context_line":"    @cmd_common.args(\u0027--user\u0027, dest\u003d\u0027user_id\u0027, metavar\u003d\u0027\u003cUser name\u003e\u0027,"},{"line_number":57,"context_line":"            help\u003d\u0027Optional user name\u0027)"},{"line_number":58,"context_line":"    @cmd_common.args(\u0027--roles\u0027, dest\u003d\u0027roles\u0027, metavar\u003d\u0027\u003cRole\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_368018f7","line":55,"in_reply_to":"1a95cdbc_24f54a56","updated":"2016-10-07 20:38:27.000000000","message":"Hope my new change looks better.","commit_id":"13d4a6e9ee913276d0509497fa20051c0a7d61d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"483bc59df9249cc10f41a2f150bbcb73507cb2fb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            return 1"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _get_context(self, project_id, user_id, roles):"},{"line_number":88,"context_line":"        if not project_id:"},{"line_number":89,"context_line":"            project_id \u003d os.environ.get(\u0027OS_TENANT_ID\u0027)"},{"line_number":90,"context_line":"        if not user_id:"},{"line_number":91,"context_line":"            user_id \u003d os.environ.get(\u0027OS_USER_ID\u0027)"},{"line_number":92,"context_line":"        if not roles:"},{"line_number":93,"context_line":"            roles \u003d os.environ.get(\u0027OS_ROLES\u0027)"},{"line_number":94,"context_line":"        return nova_context.RequestContext(roles, user_id, project_id)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _get_target(self, context, target):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_641a6c70","line":93,"range":{"start_line":88,"start_character":0,"end_line":93,"end_character":46},"updated":"2016-10-18 13:25:54.000000000","message":"nit:\n\n    project_id \u003d project_id or os.environ.get(\u0027OS_TENANT_ID\u0027)","commit_id":"7670161cd4c4889106cd233dfcc6e030c978df63"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"6659e3694bae4ae7770fc26a160a7729d77b3991","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            return 1"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _get_context(self, project_id, user_id, roles):"},{"line_number":88,"context_line":"        if not project_id:"},{"line_number":89,"context_line":"            project_id \u003d os.environ.get(\u0027OS_TENANT_ID\u0027)"},{"line_number":90,"context_line":"        if not user_id:"},{"line_number":91,"context_line":"            user_id \u003d os.environ.get(\u0027OS_USER_ID\u0027)"},{"line_number":92,"context_line":"        if not roles:"},{"line_number":93,"context_line":"            roles \u003d os.environ.get(\u0027OS_ROLES\u0027)"},{"line_number":94,"context_line":"        return nova_context.RequestContext(roles, user_id, project_id)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _get_target(self, context, target):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_4e03be0f","line":93,"range":{"start_line":88,"start_character":0,"end_line":93,"end_character":46},"in_reply_to":"fa6399be_641a6c70","updated":"2016-10-18 17:00:02.000000000","message":"Done. Thanks for the review, code looks cleaner now.","commit_id":"7670161cd4c4889106cd233dfcc6e030c978df63"}]}