)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6e6af10867d387a23bc3e5741b24454eff4f7a76","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix API _workers options to be backwards compat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In e8436283e45b6716fb61d6f6590fadb5fb4ba45c we changed the nova"},{"line_number":10,"context_line":"defaults for the osapi_compute_workers and metadata_workers options"},{"line_number":11,"context_line":"such that users who deployed with them set to 0 (a previously working"},{"line_number":12,"context_line":"default value) would now be broken. Nova API fails to start."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_65421a6a","line":9,"updated":"2016-10-06 20:31:54.000000000","message":"We should have a unit test for this because obviously we missed the setting it to 0 case.","commit_id":"add824197ce6de1c191b2b851d60a805e9d0eebf"}],"nova/conf/service.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6e6af10867d387a23bc3e5741b24454eff4f7a76","unresolved":false,"context_lines":[{"line_number":108,"context_line":"requests."},{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027osapi_compute_workers\u0027,"},{"line_number":111,"context_line":"               min\u003d0,"},{"line_number":112,"context_line":"               help\u003d\"\"\""},{"line_number":113,"context_line":"Number of workers for OpenStack API service. If unspecified or set to 0 the"},{"line_number":114,"context_line":"default will be the number of CPUs available."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_05a6b652","line":111,"updated":"2016-10-06 20:31:54.000000000","message":"Yeah, so if it wasn\u0027t defined before, we default to None here:\n\nhttps://github.com/openstack/nova/blob/7c3fd3c59da133bb4fb832dde3a47d3eb38748b8/nova/service.py#L296\n\nWhich then defaults to ncpu. Similar if you provided a falsey value like 0, it would equate to false and we\u0027d use ncpu.\n\nNow if you have 0 it blows up because of the minimum.\n\nI don\u0027t know why you\u0027d have 0 to begin with when simply omitting the config option will get you what you want, but I\u0027m sure there is some deployment tool wrinkle out there that says the option must be defined but you want to allow default behavior.","commit_id":"add824197ce6de1c191b2b851d60a805e9d0eebf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bb709bb491fc4739e82aa163485e3b5d7aed2a64","unresolved":false,"context_lines":[{"line_number":108,"context_line":"requests."},{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027osapi_compute_workers\u0027,"},{"line_number":111,"context_line":"               min\u003d0,"},{"line_number":112,"context_line":"               help\u003d\"\"\""},{"line_number":113,"context_line":"Number of workers for OpenStack API service. If unspecified or set to 0 the"},{"line_number":114,"context_line":"default will be the number of CPUs available."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_343921a5","line":111,"in_reply_to":"1a95cdbc_05a6b652","updated":"2016-10-06 21:03:40.000000000","message":"So this probably stems from a number requirement here. Setting to 0 or -1 to trigger a default value would be more ideal than setting it to a \u0027\u0027 which fails numeric validation.","commit_id":"add824197ce6de1c191b2b851d60a805e9d0eebf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6e6af10867d387a23bc3e5741b24454eff4f7a76","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    cfg.IntOpt(\u0027osapi_compute_workers\u0027,"},{"line_number":111,"context_line":"               min\u003d0,"},{"line_number":112,"context_line":"               help\u003d\"\"\""},{"line_number":113,"context_line":"Number of workers for OpenStack API service. If unspecified or set to 0 the"},{"line_number":114,"context_line":"default will be the number of CPUs available."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"OpenStack API services can be configured to run as multi-process (workers)."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_857006de","line":113,"range":{"start_line":113,"start_character":60,"end_line":113,"end_character":71},"updated":"2016-10-06 20:31:54.000000000","message":"If we\u0027re going to do this, then this message should be fixed:\n\nhttps://github.com/openstack/nova/blob/7c3fd3c59da133bb4fb832dde3a47d3eb38748b8/nova/service.py#L301\n\nActually we could probably just remove that entire block since the oslo.config validation is going to handle that for us now with the min field.","commit_id":"add824197ce6de1c191b2b851d60a805e9d0eebf"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"886ef38ca8b1730a366e0494a67fa0c703e56c37","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    cfg.IntOpt(\u0027osapi_compute_workers\u0027,"},{"line_number":111,"context_line":"               min\u003d0,"},{"line_number":112,"context_line":"               help\u003d\"\"\""},{"line_number":113,"context_line":"Number of workers for OpenStack API service. If unspecified or set to 0 the"},{"line_number":114,"context_line":"default will be the number of CPUs available."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"OpenStack API services can be configured to run as multi-process (workers)."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_5b44ed19","line":113,"range":{"start_line":113,"start_character":60,"end_line":113,"end_character":71},"in_reply_to":"1a95cdbc_857006de","updated":"2016-10-07 20:02:15.000000000","message":"We\u0027ve got explicit tests in test_service.py that use CONF.set_override (thus bypassing normal oslo.config validations). Would it be reasonable to fix this patch and then address the removal of the line in question in a follow up patch as a broader cleanup effort.\n\nAgain, I\u0027d like to land this quickly as this effectively blocks TripleO CI from promoting until we fix it.","commit_id":"add824197ce6de1c191b2b851d60a805e9d0eebf"}]}