)]}'
{"nova/virt/libvirt/vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea0bc6b869f493984ca6795d9bf57d4bbcf1458a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                           model):"},{"line_number":128,"context_line":"            raise exception.UnsupportedHardware(model\u003dmodel,"},{"line_number":129,"context_line":"                                                virt\u003dvirt_type)"},{"line_number":130,"context_line":"        if (virt_type \u003d\u003d \u0027kvm\u0027 or virt_type \u003d\u003d \u0027parallels\u0027 and"},{"line_number":131,"context_line":"            model \u003d\u003d network_model.VIF_MODEL_VIRTIO):"},{"line_number":132,"context_line":"            vhost_drv, vhost_queues \u003d self._get_virtio_mq_settings(image_meta,"},{"line_number":133,"context_line":"                                                                   inst_type)"},{"line_number":134,"context_line":"            driver \u003d vhost_drv or driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_c961293b","line":131,"range":{"start_line":130,"start_character":8,"end_line":131,"end_character":53},"updated":"2016-10-07 14:14:13.000000000","message":"This will evaluate as:\n\n    virt_type \u003d\u003d kvm\n\n    -or-\n\n    virt_type \u003d\u003d parallels and model \u003d\u003d VIF_MODEL_VIRTIO\n\nFrom [1]. I doubt this is what you want. Try:\n\n    if (virt_type in [\u0027kvm\u0027, \u0027parallels\u0027] and ...):\n\n[1] https://docs.python.org/2/reference/expressions.html#operator-precedence","commit_id":"e5d4505449252ce92b8dfe4c8b002a12f50e2e03"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"9b55c04a564da702688e04a9df74d6ed1b534fd4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                           model):"},{"line_number":128,"context_line":"            raise exception.UnsupportedHardware(model\u003dmodel,"},{"line_number":129,"context_line":"                                                virt\u003dvirt_type)"},{"line_number":130,"context_line":"        if (virt_type \u003d\u003d \u0027kvm\u0027 or virt_type \u003d\u003d \u0027parallels\u0027 and"},{"line_number":131,"context_line":"            model \u003d\u003d network_model.VIF_MODEL_VIRTIO):"},{"line_number":132,"context_line":"            vhost_drv, vhost_queues \u003d self._get_virtio_mq_settings(image_meta,"},{"line_number":133,"context_line":"                                                                   inst_type)"},{"line_number":134,"context_line":"            driver \u003d vhost_drv or driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_4927d9c9","line":131,"range":{"start_line":130,"start_character":8,"end_line":131,"end_character":53},"in_reply_to":"1a95cdbc_c961293b","updated":"2016-10-07 14:17:56.000000000","message":"Oh, sure. Sorry for being negligent.","commit_id":"e5d4505449252ce92b8dfe4c8b002a12f50e2e03"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"05a533964d4e554d0be2a9b8cac46b4170da2809","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        if image_meta:"},{"line_number":111,"context_line":"            model \u003d osinfo.HardwareProperties(image_meta).network_model"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # Else if the virt type is KVM/QEMU, use virtio according"},{"line_number":114,"context_line":"        # to the global config parameter"},{"line_number":115,"context_line":"        if (model is None and"},{"line_number":116,"context_line":"            virt_type in (\u0027kvm\u0027, \u0027qemu\u0027) and"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_79b8992a","side":"PARENT","line":113,"updated":"2016-10-10 15:41:07.000000000","message":"You might want to update the comment too","commit_id":"f83499f4c0c81eaec7d1300a930d2105f6228c49"}]}