)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6db159b255c1c9e21c707937b576a7b96e434c30","unresolved":false,"context_lines":[{"line_number":742,"context_line":"                        try:"},{"line_number":743,"context_line":"                            instance.destroy()"},{"line_number":744,"context_line":"                        except exception.ObjectActionError:"},{"line_number":745,"context_line":"                            pass"},{"line_number":746,"context_line":"                finally:"},{"line_number":747,"context_line":"                    QUOTAS.rollback(context, quota_reservations)"},{"line_number":748,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAQn%2F%2FD%2Fc%3D","line":745,"updated":"2013-08-07 18:27:15.000000000","message":"I don\u0027t think the try/except is needed... because there\u0027s not really any way the constraint can fail.  (There\u0027s no race with setting \u0027host\u0027 because we\u0027re not to the point of scheduling yet).  Anyway, I\u0027m okay with it... but this looked like behavior change at first.","commit_id":"6322e53a95b0bbbbda57df9090fee5551af64e8b"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6db159b255c1c9e21c707937b576a7b96e434c30","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"                    self.volume_api.delete(context, bdm[\u0027volume_id\u0027])"},{"line_number":1362,"context_line":"            self.db.block_device_mapping_destroy(context, bdm[\u0027id\u0027])"},{"line_number":1363,"context_line":"        cb(context, instance, bdms, local\u003dTrue)"},{"line_number":1364,"context_line":"        instance.destroy()"},{"line_number":1365,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1366,"context_line":"            context, instance, \"%s.end\" % delete_type,"},{"line_number":1367,"context_line":"            system_metadata\u003dsystem_meta)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAQn%2F%2FD%2Bs%3D","line":1364,"updated":"2013-08-07 18:27:15.000000000","message":"This also kinda looks like a behavior change (because instance.destroy() checks constraint now always if host is None).  But I think in this spot in the code we always have a \u0027host\u0027, it\u0027s just that it can considered down.  The block of code at 1213 handles host\u003d\u003dNone.","commit_id":"6322e53a95b0bbbbda57df9090fee5551af64e8b"}]}