)]}'
{"nova/api/ec2/cloud.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b6d7db397b11e8743e1ad7f000b3b30800727d15","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ec2utils.ec2_id_to_id(val)"},{"line_number":60,"context_line":"    except exception.InvalidEc2Id:"},{"line_number":61,"context_line":"        raise exception.InvalidInstanceIDMalformed(val)"},{"line_number":62,"context_line":"    return True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"validator.validate_ec2_id \u003d validate_ec2_id"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2BJQ%3D","line":62,"updated":"2012-02-07 06:50:54.000000000","message":"Is returning a boolean necessary when successful execution is indicated by the lack of a raised exception?  I\u0027m guessing this is a holdover from the original that indicated success or failure by a boolean return value.","commit_id":"801e747c830f059f26609fee5fe2079af76bf0c6"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b6d7db397b11e8743e1ad7f000b3b30800727d15","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        raise exception.InvalidInstanceIDMalformed(val)"},{"line_number":62,"context_line":"    return True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"validator.validate_ec2_id \u003d validate_ec2_id"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def _gen_key(context, user_id, key_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2BJM%3D","line":64,"updated":"2012-02-07 06:50:54.000000000","message":"Is the intent of this monkeypatch to modify the behaviour of validator.validate_ec2_id for all callers?  If so, please consider modifying the original in nova.api.ec2 instead, and ensure that all callers will be able to handle exceptions where once only boolean return values were expected.  If not, please consider defining this module\u0027s implementation as a standalone function.","commit_id":"801e747c830f059f26609fee5fe2079af76bf0c6"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"9d26a759dd3bd24847c1f29ae7305f0cff540f16","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ec2utils.ec2_id_to_id(val)"},{"line_number":60,"context_line":"    except exception.InvalidEc2Id:"},{"line_number":61,"context_line":"        raise exception.InvalidInstanceIDMalformed(val)"},{"line_number":62,"context_line":"    return True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def _gen_key(context, user_id, key_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F%2BIk%3D","line":62,"updated":"2012-02-07 21:01:41.000000000","message":"As per the previous comment, this return statement is redundant and should be removed.","commit_id":"0deba8300e180b7ca2c505e3208ffab71d5e15e4"}],"nova/tests/api/ec2/test_ec2_validate.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b6d7db397b11e8743e1ad7f000b3b30800727d15","unresolved":false,"context_lines":[{"line_number":37,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class EC2ValidateTestCase(test.TestCase):"},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(EC2ValidateTestCase, self).setUp()"},{"line_number":43,"context_line":"        self.flags(connection_type\u003d\u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F%2BJc%3D","line":40,"updated":"2012-02-07 06:50:54.000000000","message":"Since the test calls are almost always identical (excepting test_attach_volume) whether the id is malformed or valid, the tests might benefit from some data-driven simplification of the form:\n\n(in setup)\n\nid_exception_map \u003d dict([(x, InvalidInstanceIDMalformed) for x in EC2_MALFORMED_IDS])\nid_exception_map.update((x, InstanceNotFound) for x in EC2_VALID__IDS)\n\n(in tests)\n\nfor id, exception in id_exception_map.iteritems():\n   self.assertRaises()","commit_id":"801e747c830f059f26609fee5fe2079af76bf0c6"}]}