)]}'
{"doc/source/code-review.rst":[{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"df1d6d3867b23de363e45b64712486efee776cdd","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"If a new database table is added, ensure:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* utf8 is used only where necessary. uuid in latin1 is 1/3 the size of uuid in"},{"line_number":207,"context_line":"  utf8. If a table doesn\u0027t need to be utf8, i.e. it doesn\u0027t contain string"},{"line_number":208,"context_line":"  fields, then latin1 should be used"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_105af183","line":206,"range":{"start_line":206,"start_character":37,"end_line":206,"end_character":41},"updated":"2016-10-11 03:19:05.000000000","message":"s/uuid/UUID/","commit_id":"02670d725b2f7d36aa5da221c9f7c9c7006f544f"},{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"df1d6d3867b23de363e45b64712486efee776cdd","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"If a new database table is added, ensure:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* utf8 is used only where necessary. uuid in latin1 is 1/3 the size of uuid in"},{"line_number":207,"context_line":"  utf8. If a table doesn\u0027t need to be utf8, i.e. it doesn\u0027t contain string"},{"line_number":208,"context_line":"  fields, then latin1 should be used"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_50546953","line":206,"range":{"start_line":206,"start_character":71,"end_line":206,"end_character":75},"updated":"2016-10-11 03:19:05.000000000","message":"s/uuid/UUID/","commit_id":"02670d725b2f7d36aa5da221c9f7c9c7006f544f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"73cfe87b303f3c40e9f2870df9ea6cc9e43e1119","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"If a new database table is added, ensure:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* utf8 is used only where necessary. uuid in latin1 is 1/3 the size of uuid in"},{"line_number":207,"context_line":"  utf8. If a table doesn\u0027t need to be utf8, i.e. it doesn\u0027t contain string"},{"line_number":208,"context_line":"  fields, then latin1 should be used"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_14301356","line":206,"range":{"start_line":206,"start_character":37,"end_line":206,"end_character":41},"in_reply_to":"fa6399be_105af183","updated":"2016-10-11 12:05:43.000000000","message":"Done","commit_id":"02670d725b2f7d36aa5da221c9f7c9c7006f544f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"82855be914990790fbebbfb74343bcbc7aa0aa66","unresolved":false,"context_lines":[{"line_number":204,"context_line":"If a new database table is added, ensure:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* utf8 is used only where necessary. uuid in latin1 is 1/3 the size of uuid in"},{"line_number":207,"context_line":"  utf8. If a table doesn\u0027t need to be utf8, i.e. it doesn\u0027t contain string"},{"line_number":208,"context_line":"  fields, then latin1 should be used"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Microversion API"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_e43063a1","line":207,"updated":"2016-10-11 00:29:09.000000000","message":"It\u0027s not just when a table doesn\u0027t contain string fields (actually, in that case, it makes no difference at all what the charset and collation of the table is set to! ;) ). Rather, it\u0027s when a table *does* contain string fields but those string fields will always be interpreted using ascii encoding. Examples of such fields include hex-stringified UUID values, MD5 fingerprints, SHA1 hashes, base64-encoded data, etc.","commit_id":"02670d725b2f7d36aa5da221c9f7c9c7006f544f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"73cfe87b303f3c40e9f2870df9ea6cc9e43e1119","unresolved":false,"context_lines":[{"line_number":204,"context_line":"If a new database table is added, ensure:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* utf8 is used only where necessary. uuid in latin1 is 1/3 the size of uuid in"},{"line_number":207,"context_line":"  utf8. If a table doesn\u0027t need to be utf8, i.e. it doesn\u0027t contain string"},{"line_number":208,"context_line":"  fields, then latin1 should be used"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Microversion API"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_34351746","line":207,"in_reply_to":"fa6399be_e43063a1","updated":"2016-10-11 12:05:43.000000000","message":"Done","commit_id":"02670d725b2f7d36aa5da221c9f7c9c7006f544f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"68a191eff53d071d6edf0f46151404a144f1cb9e","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* utf8 is used only where necessary. uuid in latin1 is 1/3 the size of uuid in"},{"line_number":207,"context_line":"  utf8. If a table doesn\u0027t need to be utf8, i.e. it doesn\u0027t contain string"},{"line_number":208,"context_line":"  fields, then latin1 should be used"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Microversion API"},{"line_number":211,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_64da937a","line":208,"range":{"start_line":208,"start_character":32,"end_line":208,"end_character":36},"updated":"2016-10-11 00:19:22.000000000","message":"s/used/used./","commit_id":"02670d725b2f7d36aa5da221c9f7c9c7006f544f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"73cfe87b303f3c40e9f2870df9ea6cc9e43e1119","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* utf8 is used only where necessary. uuid in latin1 is 1/3 the size of uuid in"},{"line_number":207,"context_line":"  utf8. If a table doesn\u0027t need to be utf8, i.e. it doesn\u0027t contain string"},{"line_number":208,"context_line":"  fields, then latin1 should be used"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Microversion API"},{"line_number":211,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_141733a4","line":208,"range":{"start_line":208,"start_character":32,"end_line":208,"end_character":36},"in_reply_to":"fa6399be_64da937a","updated":"2016-10-11 12:05:43.000000000","message":"Done","commit_id":"02670d725b2f7d36aa5da221c9f7c9c7006f544f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"93661d261630151a147de9bd8627ea0ce1a67a30","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  hex-stringified UUID values, MD5 fingerprints, SHA1 hashes or base64-encoded"},{"line_number":206,"context_line":"  data, are always interpreted using ASCII encoding. A hex-stringified UUID"},{"line_number":207,"context_line":"  value in ``latin1`` is 1/3 the size of the same field in ``utf8``, impacting"},{"line_number":208,"context_line":"  performance without bringing any benefit. Stick with ``latin1``."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Microversion API"},{"line_number":211,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_25bcfc04","line":208,"range":{"start_line":208,"start_character":44,"end_line":208,"end_character":66},"updated":"2016-10-11 13:49:38.000000000","message":"Suggestion: \"So if the only string type columns in the table contain data as described above, stick with latin1\".\n\nI just don\u0027t want someone to get confused and think, well this table contains a column with a uuid, so we should use latin1, when the table also contains like a \u0027display_name\u0027 column.","commit_id":"f42fe4e84f214fd909fa77aba6bcedfa95d73325"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2bfa25c25c2b0f91b2db7c4496d8d91b9f290d6d","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  hex-stringified UUID values, MD5 fingerprints, SHA1 hashes or base64-encoded"},{"line_number":206,"context_line":"  data, are always interpreted using ASCII encoding. A hex-stringified UUID"},{"line_number":207,"context_line":"  value in ``latin1`` is 1/3 the size of the same field in ``utf8``, impacting"},{"line_number":208,"context_line":"  performance without bringing any benefit. Stick with ``latin1``."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Microversion API"},{"line_number":211,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_107818f2","line":208,"range":{"start_line":208,"start_character":44,"end_line":208,"end_character":66},"in_reply_to":"fa6399be_25bcfc04","updated":"2016-10-11 14:16:05.000000000","message":"Good call. Done.","commit_id":"f42fe4e84f214fd909fa77aba6bcedfa95d73325"}]}