)]}'
{"nova/conf/cinder.py":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"2227aca194c4c377eedbf518ff53af0483504b62","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    conf.register_group(cinder_group)"},{"line_number":102,"context_line":"    conf.register_opts(cinder_opts, group\u003dcinder_group)"},{"line_number":103,"context_line":"    ks_loading.register_session_conf_options(conf, group\u003dcinder_group.name)"},{"line_number":104,"context_line":"    ks_loading.register_auth_conf_options(conf, group\u003dcinder_group.name)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_9e4a187e","line":104,"updated":"2017-05-30 09:19:45.000000000","message":"Should we use keystoneauth adapter here?\n\nsee https://review.openstack.org/#/c/458257/8/nova/conf/glance.py","commit_id":"7dd9b580942d0dd6c1c021a0812b2c67096a0d3b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f0566b560e4a02c70bb181350596087d7bbdbf84","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def list_opts():"},{"line_number":108,"context_line":"    return {cinder_group: cinder_opts +"},{"line_number":109,"context_line":"                       ks_loading.get_session_conf_options() +"},{"line_number":110,"context_line":"                       ks_loading.get_auth_common_conf_options() +"},{"line_number":111,"context_line":"                       ks_loading.get_auth_plugin_conf_options(\u0027password\u0027) +"},{"line_number":112,"context_line":"                       ks_loading.get_auth_plugin_conf_options(\u0027v2password\u0027) +"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_24087b2a","line":109,"updated":"2017-07-13 21:12:05.000000000","message":"Isn\u0027t this really more of a separate change we could just do for keystone v3 support with the [cinder] section in nova.conf so you can use v3 things? I\u0027m surprised this hasn\u0027t already been done on it\u0027s own.","commit_id":"7dd9b580942d0dd6c1c021a0812b2c67096a0d3b"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"2227aca194c4c377eedbf518ff53af0483504b62","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                       ks_loading.get_auth_common_conf_options() +"},{"line_number":111,"context_line":"                       ks_loading.get_auth_plugin_conf_options(\u0027password\u0027) +"},{"line_number":112,"context_line":"                       ks_loading.get_auth_plugin_conf_options(\u0027v2password\u0027) +"},{"line_number":113,"context_line":"                       ks_loading.get_auth_plugin_conf_options(\u0027v3password\u0027)"},{"line_number":114,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_5e5c804a","line":113,"updated":"2017-05-30 09:19:45.000000000","message":"ditto","commit_id":"7dd9b580942d0dd6c1c021a0812b2c67096a0d3b"}],"nova/tests/unit/test_cinder.py":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"2227aca194c4c377eedbf518ff53af0483504b62","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":108,"context_line":"        cinder_client \u003d cinder.cinderclient(ctx)"},{"line_number":109,"context_line":"        auth \u003d cinder_client.client.auth"},{"line_number":110,"context_line":"        self.assertIsNotNone(auth)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_cinder_http_retries(self):"},{"line_number":113,"context_line":"        retries \u003d 42"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_21e3ed35","line":110,"updated":"2017-05-30 09:19:45.000000000","message":"Could you please explain why it\u0027s None here?","commit_id":"7dd9b580942d0dd6c1c021a0812b2c67096a0d3b"}],"nova/volume/cinder.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"550a60d178c12a42caec767c244987bf6a26ca78","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def _load_auth_plugin(self):"},{"line_number":61,"context_line":"    auth_plugin \u003d ks_loading.load_auth_from_conf_options(CONF,"},{"line_number":62,"context_line":"                                        nova.conf.cinder.cinder_group.name)"},{"line_number":63,"context_line":"    return auth_plugin"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def cinderclient(context):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_8946b921","line":63,"updated":"2017-02-10 12:34:47.000000000","message":"We must cache this auth plugin, else we will not catch the service tokens used to access cinder. Its not likely a big problem here, but lets do it anyways.","commit_id":"7ba3203727c00c5cf9720d9ed7bfcab4760b43e3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"550a60d178c12a42caec767c244987bf6a26ca78","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        _SESSION \u003d ks_loading.load_session_from_conf_options("},{"line_number":74,"context_line":"            CONF, nova.conf.cinder.cinder_group.name)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if context.is_admin and not context.auth_token:"},{"line_number":77,"context_line":"            auth \u003d _load_auth_plugin(CONF)"},{"line_number":78,"context_line":"    elif context.auth_token:"},{"line_number":79,"context_line":"        auth \u003d context.get_auth_plugin()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_e9e7353e","line":76,"range":{"start_line":76,"start_character":32,"end_line":76,"end_character":50},"updated":"2017-02-10 12:34:47.000000000","message":"Honestly, here, I think we should only care about the periodic tasks, where we don\u0027t have an auth_token.","commit_id":"7ba3203727c00c5cf9720d9ed7bfcab4760b43e3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f3da0f6ed67e5093f3e364d8b16458db9a17eead","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        _SESSION \u003d ks_loading.load_session_from_conf_options("},{"line_number":74,"context_line":"            CONF, nova.conf.cinder.cinder_group.name)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if context.is_admin and not context.auth_token:"},{"line_number":77,"context_line":"            auth \u003d _load_auth_plugin(CONF)"},{"line_number":78,"context_line":"    elif context.auth_token:"},{"line_number":79,"context_line":"        auth \u003d context.get_auth_plugin()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_7e297de5","line":76,"range":{"start_line":76,"start_character":32,"end_line":76,"end_character":50},"in_reply_to":"fa31d9ce_e9e7353e","updated":"2017-02-15 15:58:36.000000000","message":"Oopps, you are right. I miss read that.\n\n    is_periodic_task \u003d context.auth_token not context.is_admin\n    if is_periodic_task: \n         auth \u003d _load_auth_plugin(CONF)","commit_id":"7ba3203727c00c5cf9720d9ed7bfcab4760b43e3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"799cf83eada31fb2af86b64cf5dd3e1dbe8e1900","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    _SESSION \u003d None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def _load_auth_plugin(self):"},{"line_number":61,"context_line":"    global _AUTH_PLUGIN"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    if not _AUTH_PLUGIN:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_6489d3c8","line":60,"updated":"2017-07-13 21:07:36.000000000","message":"This is similar to but not exactly the same as what we do for neutronclient:\n\nhttps://github.com/openstack/nova/blob/ac20980702030424ce4bb3ddf2610d31716a8bd7/nova/network/neutronv2/api.py#L66","commit_id":"7dd9b580942d0dd6c1c021a0812b2c67096a0d3b"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"2227aca194c4c377eedbf518ff53af0483504b62","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    url \u003d None"},{"line_number":77,"context_line":"    endpoint_override \u003d None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    is_periodic_task \u003d context.is_admin and not context.auth_token"},{"line_number":80,"context_line":"    if is_periodic_task:"},{"line_number":81,"context_line":"        auth \u003d _load_auth_plugin(CONF)"},{"line_number":82,"context_line":"    elif context.auth_token:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_416381dd","line":79,"updated":"2017-05-30 09:19:45.000000000","message":"nit: name of the variable is not consistent with its content\nAre there other cases besides periodic task where such conditions could be?","commit_id":"7dd9b580942d0dd6c1c021a0812b2c67096a0d3b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"799cf83eada31fb2af86b64cf5dd3e1dbe8e1900","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    url \u003d None"},{"line_number":77,"context_line":"    endpoint_override \u003d None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    is_periodic_task \u003d context.is_admin and not context.auth_token"},{"line_number":80,"context_line":"    if is_periodic_task:"},{"line_number":81,"context_line":"        auth \u003d _load_auth_plugin(CONF)"},{"line_number":82,"context_line":"    elif context.auth_token:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_e495e3e5","line":79,"in_reply_to":"df140735_416381dd","updated":"2017-07-13 21:07:36.000000000","message":"So this is similar to what we do for neutronclient:\n\nhttps://github.com/openstack/nova/blob/ac20980702030424ce4bb3ddf2610d31716a8bd7/nova/network/neutronv2/api.py#L136","commit_id":"7dd9b580942d0dd6c1c021a0812b2c67096a0d3b"}],"releasenotes/notes/set_config_options_cinder-4683e47212951125.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f0566b560e4a02c70bb181350596087d7bbdbf84","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The following keystone auth options must be set in [cinder] section"},{"line_number":4,"context_line":"    of nova.conf if using cinder."},{"line_number":5,"context_line":"        * auth_type"},{"line_number":6,"context_line":"        * auth_url"},{"line_number":7,"context_line":"        * project_name"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f1a1f67_a43b6be9","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":33},"updated":"2017-07-13 21:12:05.000000000","message":"Why would these not be required before this change?","commit_id":"7dd9b580942d0dd6c1c021a0812b2c67096a0d3b"}]}