)]}'
{"nova/virt/hardware.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"60a7c1350cc65ca5bb58dddc6bebd1e0adbe4cf8","unresolved":false,"context_lines":[{"line_number":992,"context_line":""},{"line_number":993,"context_line":"def _get_numa_cpu_constraints(flavor, image_meta):"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"    def _numa_get_flavor_cpu_map_list(flavor):"},{"line_number":996,"context_line":"        hw_numa_cpus \u003d []"},{"line_number":997,"context_line":"        extra_specs \u003d flavor.get(\u0027extra_specs\u0027, {})"},{"line_number":998,"context_line":"        for cellid in range(objects.ImageMetaProps.NUMA_NODES_MAX):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d8446d4b","line":995,"updated":"2016-10-14 13:26:02.000000000","message":"here you created the method which will be used in the next line after this method. I think it has no sense. You can just remove this line and do all this stuff in body of \u0027_get_numa_cpu_constraints\u0027 method.","commit_id":"8da976a89d8f7286f43cba8a2397252ab6eb5b3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0d9a31e125f90aaa98411fc0aaf7b7c22358f6f","unresolved":false,"context_lines":[{"line_number":992,"context_line":""},{"line_number":993,"context_line":"def _get_numa_cpu_constraints(flavor, image_meta):"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"    def _numa_get_flavor_cpu_map_list(flavor):"},{"line_number":996,"context_line":"        hw_numa_cpus \u003d []"},{"line_number":997,"context_line":"        extra_specs \u003d flavor.get(\u0027extra_specs\u0027, {})"},{"line_number":998,"context_line":"        for cellid in range(objects.ImageMetaProps.NUMA_NODES_MAX):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_01010c38","line":995,"in_reply_to":"fa6399be_d8446d4b","updated":"2016-10-14 14:52:58.000000000","message":"This is the opposite of what you said in the first patch in this series ;)","commit_id":"8da976a89d8f7286f43cba8a2397252ab6eb5b3c"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"60a7c1350cc65ca5bb58dddc6bebd1e0adbe4cf8","unresolved":false,"context_lines":[{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"def _get_numa_mem_constraints(flavor, image_meta):"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    def _numa_get_flavor_mem_map_list(flavor):"},{"line_number":1023,"context_line":"        hw_numa_mem \u003d []"},{"line_number":1024,"context_line":"        extra_specs \u003d flavor.get(\u0027extra_specs\u0027, {})"},{"line_number":1025,"context_line":"        for cellid in range(objects.ImageMetaProps.NUMA_NODES_MAX):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d8e0ed2b","line":1022,"updated":"2016-10-14 13:26:02.000000000","message":"nit: Methods _numa_get_flavor_cpu_map_list and _numa_get_flavor_mem_map_list are almost equal. You can try to combine them. But this is optional.","commit_id":"8da976a89d8f7286f43cba8a2397252ab6eb5b3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0d9a31e125f90aaa98411fc0aaf7b7c22358f6f","unresolved":false,"context_lines":[{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"def _get_numa_mem_constraints(flavor, image_meta):"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    def _numa_get_flavor_mem_map_list(flavor):"},{"line_number":1023,"context_line":"        hw_numa_mem \u003d []"},{"line_number":1024,"context_line":"        extra_specs \u003d flavor.get(\u0027extra_specs\u0027, {})"},{"line_number":1025,"context_line":"        for cellid in range(objects.ImageMetaProps.NUMA_NODES_MAX):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_819b5c17","line":1022,"in_reply_to":"fa6399be_d8e0ed2b","updated":"2016-10-14 14:52:58.000000000","message":"Done","commit_id":"8da976a89d8f7286f43cba8a2397252ab6eb5b3c"}]}