)]}'
{"nova/cells/scheduler.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9de12ec0cf6c5ee9fa0d9c54c4f1d41a0db9dd00","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                except exception.NoCellsAvailable:"},{"line_number":228,"context_line":"                    if i \u003d\u003d max(0, CONF.cells.scheduler_retries):"},{"line_number":229,"context_line":"                        raise"},{"line_number":230,"context_line":"                    sleep_time \u003d max(1, CONF.cells.scheduler_retry_delay)"},{"line_number":231,"context_line":"                    LOG.info(_LI(\"No cells available when scheduling.  Will \""},{"line_number":232,"context_line":"                                 \"retry in %(sleep_time)s second(s)\"),"},{"line_number":233,"context_line":"                             {\u0027sleep_time\u0027: sleep_time})"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_8c608d37","side":"PARENT","line":230,"updated":"2016-12-13 12:58:33.000000000","message":"hmm, seems like we support folks using crazy values, so we should leave that support in for now.\n\nWe could deprecate it, etc, but its not worth it as cells v1 is deprecated.","commit_id":"a58c7e5173103755f5a60f0a3ecede77e662ada3"}],"nova/compute/manager.py":[{"author":{"_account_id":20382,"name":"YuYang","email":"yuyangwang1985@gmail.com","username":"YuYangWang"},"change_message_id":"aa097f43dc1f56b643bf6bbb04806f048fc033d0","unresolved":false,"context_lines":[{"line_number":6065,"context_line":"            self._last_bw_usage_poll \u003d curr_time"},{"line_number":6066,"context_line":"            LOG.info(_LI(\"Updating bandwidth usage cache\"))"},{"line_number":6067,"context_line":"            cells_update_interval \u003d CONF.cells.bandwidth_update_interval"},{"line_number":6068,"context_line":"            if (curr_time - self._last_bw_usage_cell_update \u003e"},{"line_number":6069,"context_line":"                    cells_update_interval):"},{"line_number":6070,"context_line":"                self._last_bw_usage_cell_update \u003d curr_time"},{"line_number":6071,"context_line":"                update_cells \u003d True"},{"line_number":6072,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_1910394e","line":6069,"range":{"start_line":6068,"start_character":11,"end_line":6069,"end_character":43},"updated":"2016-12-08 11:02:35.000000000","message":"cells_update_interval \u003c0 is impossibility?","commit_id":"10707c10c65149c700da6c209f150443d3d08a9b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c022dc61a1c8d8bb757599d4866053561905a577","unresolved":false,"context_lines":[{"line_number":6065,"context_line":"            self._last_bw_usage_poll \u003d curr_time"},{"line_number":6066,"context_line":"            LOG.info(_LI(\"Updating bandwidth usage cache\"))"},{"line_number":6067,"context_line":"            cells_update_interval \u003d CONF.cells.bandwidth_update_interval"},{"line_number":6068,"context_line":"            if (curr_time - self._last_bw_usage_cell_update \u003e"},{"line_number":6069,"context_line":"                    cells_update_interval):"},{"line_number":6070,"context_line":"                self._last_bw_usage_cell_update \u003d curr_time"},{"line_number":6071,"context_line":"                update_cells \u003d True"},{"line_number":6072,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_d9f7a1f3","line":6069,"range":{"start_line":6068,"start_character":11,"end_line":6069,"end_character":43},"in_reply_to":"3a71b18c_1910394e","updated":"2016-12-08 11:07:17.000000000","message":"Oh, good catch. We didn\u0027t actually add a min parameter to this so it should stay as it was","commit_id":"10707c10c65149c700da6c209f150443d3d08a9b"}],"nova/conf/cells.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5e6f76e50e7b8ccd62c1baa18b807502eabfefd4","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"Possible values:"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"* Positive integer number"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Related options:"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_a2bdedb8","line":296,"updated":"2016-10-13 16:44:07.000000000","message":"what does 0 mean? never update?","commit_id":"711c96247a44ff3477b22d82524c27f90ac2d621"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"29c0c52dbb06989ecdcbf03de9ccc41ea5b690a6","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"Possible values:"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"* Positive integer number"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Related options:"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_e4684d8a","line":296,"in_reply_to":"fa6399be_a2bdedb8","updated":"2016-11-21 16:57:52.000000000","message":"Done","commit_id":"711c96247a44ff3477b22d82524c27f90ac2d621"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5e6f76e50e7b8ccd62c1baa18b807502eabfefd4","unresolved":false,"context_lines":[{"line_number":431,"context_line":"\"\"\"),"},{"line_number":432,"context_line":"    cfg.IntOpt(\u0027scheduler_retry_delay\u0027,"},{"line_number":433,"context_line":"        default\u003d2,"},{"line_number":434,"context_line":"        min\u003d1,"},{"line_number":435,"context_line":"        help\u003d\"\"\""},{"line_number":436,"context_line":"Scheduler retry delay."},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_c2974138","line":434,"updated":"2016-10-13 16:44:07.000000000","message":"Surely 0 is OK, to mean no delay?","commit_id":"711c96247a44ff3477b22d82524c27f90ac2d621"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"29c0c52dbb06989ecdcbf03de9ccc41ea5b690a6","unresolved":false,"context_lines":[{"line_number":431,"context_line":"\"\"\"),"},{"line_number":432,"context_line":"    cfg.IntOpt(\u0027scheduler_retry_delay\u0027,"},{"line_number":433,"context_line":"        default\u003d2,"},{"line_number":434,"context_line":"        min\u003d1,"},{"line_number":435,"context_line":"        help\u003d\"\"\""},{"line_number":436,"context_line":"Scheduler retry delay."},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_c40271b4","line":434,"in_reply_to":"fa6399be_c2974138","updated":"2016-11-21 16:57:52.000000000","message":"Correct, fixed","commit_id":"711c96247a44ff3477b22d82524c27f90ac2d621"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5e6f76e50e7b8ccd62c1baa18b807502eabfefd4","unresolved":false,"context_lines":[{"line_number":466,"context_line":"Possible values:"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"* Interval time, in seconds."},{"line_number":469,"context_line":"* Negative value makes cells manager always hit the DB"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"\"\"\"),"},{"line_number":472,"context_line":"    cfg.StrOpt(\u0027cells_config\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_227c7d1e","line":469,"range":{"start_line":469,"start_character":2,"end_line":469,"end_character":54},"updated":"2016-10-13 16:44:07.000000000","message":"0 or negative?","commit_id":"711c96247a44ff3477b22d82524c27f90ac2d621"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"29c0c52dbb06989ecdcbf03de9ccc41ea5b690a6","unresolved":false,"context_lines":[{"line_number":466,"context_line":"Possible values:"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"* Interval time, in seconds."},{"line_number":469,"context_line":"* Negative value makes cells manager always hit the DB"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"\"\"\"),"},{"line_number":472,"context_line":"    cfg.StrOpt(\u0027cells_config\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_64eb5db1","line":469,"range":{"start_line":469,"start_character":2,"end_line":469,"end_character":54},"in_reply_to":"fa6399be_227c7d1e","updated":"2016-11-21 16:57:52.000000000","message":"0 and negative :)\n\nhttps://github.com/openstack/nova/blob/master/nova/cells/state.py#L207","commit_id":"711c96247a44ff3477b22d82524c27f90ac2d621"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3480a4d5d1549231ac197de292dcf0b0506b2c8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"cell_manager_opts \u003d ["},{"line_number":248,"context_line":"    # TODO(sfinucan): Add min parameter"},{"line_number":249,"context_line":"    cfg.IntOpt(\u0027instance_updated_at_threshold\u0027,"},{"line_number":250,"context_line":"        default\u003d3600,"},{"line_number":251,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_b4ca2019","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":39},"updated":"2016-12-07 12:04:33.000000000","message":"This should be removed now","commit_id":"10707c10c65149c700da6c209f150443d3d08a9b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"967493e67ea24f3c0c554ae2b81182ac939930ec","unresolved":false,"context_lines":[{"line_number":194,"context_line":"mute_weigher_opts \u003d ["},{"line_number":195,"context_line":"    cfg.FloatOpt(\u0027mute_weight_multiplier\u0027,"},{"line_number":196,"context_line":"        default\u003d-10000.0,"},{"line_number":197,"context_line":"        max\u003d0,"},{"line_number":198,"context_line":"        help\u003d\"\"\""},{"line_number":199,"context_line":"Mute weight multiplier."},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_0ccb9d54","line":197,"updated":"2016-12-13 12:57:29.000000000","message":"We should probably warn folks before changing that.\n\nSince this is all deprecated, I would just leave it for now.","commit_id":"988d72bd721cfff1750915aa37fecd673289469a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"967493e67ea24f3c0c554ae2b81182ac939930ec","unresolved":false,"context_lines":[{"line_number":229,"context_line":"weigher_opts \u003d ["},{"line_number":230,"context_line":"    cfg.FloatOpt(\u0027offset_weight_multiplier\u0027,"},{"line_number":231,"context_line":"        default\u003d1.0,"},{"line_number":232,"context_line":"        min\u003d0,"},{"line_number":233,"context_line":"        help\u003d\"\"\""},{"line_number":234,"context_line":"Offset weight multiplier"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_4c77553a","line":232,"updated":"2016-12-13 12:57:29.000000000","message":"negative weights are valid, if a bit crazy. I would drop this.","commit_id":"988d72bd721cfff1750915aa37fecd673289469a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"967493e67ea24f3c0c554ae2b81182ac939930ec","unresolved":false,"context_lines":[{"line_number":269,"context_line":"\"\"\"),"},{"line_number":270,"context_line":"    cfg.IntOpt(\"instance_update_num_instances\","},{"line_number":271,"context_line":"        default\u003d1,"},{"line_number":272,"context_line":"        min\u003d0,"},{"line_number":273,"context_line":"        help\u003d\"\"\""},{"line_number":274,"context_line":"Instance update num instances"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_6cd97121","line":272,"updated":"2016-12-13 12:57:29.000000000","message":"This one seems OK.","commit_id":"988d72bd721cfff1750915aa37fecd673289469a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"967493e67ea24f3c0c554ae2b81182ac939930ec","unresolved":false,"context_lines":[{"line_number":294,"context_line":"cell_messaging_opts \u003d ["},{"line_number":295,"context_line":"    cfg.IntOpt(\u0027max_hop_count\u0027,"},{"line_number":296,"context_line":"        default\u003d10,"},{"line_number":297,"context_line":"        min\u003d0,"},{"line_number":298,"context_line":"        help\u003d\"\"\""},{"line_number":299,"context_line":"Maximum hop count"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_2c705972","line":297,"updated":"2016-12-13 12:57:29.000000000","message":"Is that really 1? I think if its zero you can never send any messages.\nhttps://github.com/openstack/nova/blob/4f91ed3a547965ed96a22520edcfb783e7936e95/nova/cells/messaging.py#L422\n\nIts tempting to not bother.","commit_id":"988d72bd721cfff1750915aa37fecd673289469a"}]}