)]}'
{"nova/tests/unit/api/openstack/compute/test_volumes.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"50e6fe4acaeefe8fb30f645ea40091c58c7f90c9","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    def test_show_no_instance(self, mock_mr):"},{"line_number":373,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":374,"context_line":"                  \u0027/v2/servers/id/os-volume_attachments/uuid\u0027)"},{"line_number":375,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":376,"context_line":"        req.body \u003d jsonutils.dump_as_bytes({})"},{"line_number":377,"context_line":"        req.headers[\u0027content-type\u0027] \u003d \u0027application/json\u0027"},{"line_number":378,"context_line":"        req.environ[\u0027nova.context\u0027] \u003d self.context"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_f417b5eb","side":"PARENT","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":27},"updated":"2016-10-20 10:45:20.000000000","message":"you seems to be losing the method, which differs in many of these tests. Is that not an issue?","commit_id":"bf9fae91d746c50dd6b169ada937cb429b70f764"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4b692176c78393c43eaff07674e84e94f167e3cc","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    def test_show_no_instance(self, mock_mr):"},{"line_number":373,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":374,"context_line":"                  \u0027/v2/servers/id/os-volume_attachments/uuid\u0027)"},{"line_number":375,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":376,"context_line":"        req.body \u003d jsonutils.dump_as_bytes({})"},{"line_number":377,"context_line":"        req.headers[\u0027content-type\u0027] \u003d \u0027application/json\u0027"},{"line_number":378,"context_line":"        req.environ[\u0027nova.context\u0027] \u003d self.context"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_996369b1","side":"PARENT","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":27},"in_reply_to":"3a71b18c_ffefecad","updated":"2016-12-02 01:45:19.000000000","message":"Emm....yea, we are calling the controller method, so it didn\u0027t depend on those the req.method.\n\nOr we can use a helper function at here, like _get_req(method\u003d\u0027POST\u0027).\n\nBut yea, it didn\u0027t change anything.","commit_id":"bf9fae91d746c50dd6b169ada937cb429b70f764"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"44c03af5bfcd0c623f4a6fa1906f9945e60d2f24","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    def test_show_no_instance(self, mock_mr):"},{"line_number":373,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":374,"context_line":"                  \u0027/v2/servers/id/os-volume_attachments/uuid\u0027)"},{"line_number":375,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":376,"context_line":"        req.body \u003d jsonutils.dump_as_bytes({})"},{"line_number":377,"context_line":"        req.headers[\u0027content-type\u0027] \u003d \u0027application/json\u0027"},{"line_number":378,"context_line":"        req.environ[\u0027nova.context\u0027] \u003d self.context"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_ffefecad","side":"PARENT","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":27},"in_reply_to":"fa6399be_f417b5eb","updated":"2016-12-01 19:38:14.000000000","message":"Yeah, that is a nice point.\nThis req.method is not used at all in the tests.\nAnd some tests were using it wrongly like GET tests use \u0027POST\u0027 in this case. This test should be \"GET\" but \"POST\" now.\n\nI decide it is nice to remove them for avoiding confusions.","commit_id":"bf9fae91d746c50dd6b169ada937cb429b70f764"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d6979326f4069140a80e7c4a95b04f324bf4b194","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    def test_show_no_instance(self, mock_mr):"},{"line_number":373,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":374,"context_line":"                  \u0027/v2/servers/id/os-volume_attachments/uuid\u0027)"},{"line_number":375,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":376,"context_line":"        req.body \u003d jsonutils.dump_as_bytes({})"},{"line_number":377,"context_line":"        req.headers[\u0027content-type\u0027] \u003d \u0027application/json\u0027"},{"line_number":378,"context_line":"        req.environ[\u0027nova.context\u0027] \u003d self.context"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_c264c1e6","side":"PARENT","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":27},"in_reply_to":"fa6399be_f417b5eb","updated":"2016-11-25 13:09:24.000000000","message":"unless there are check in calling function (which I think we don\u0027t have), this is useless, because we call self.attachments.show directly below (and the POST is alos incorrect I guess?)","commit_id":"bf9fae91d746c50dd6b169ada937cb429b70f764"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d6979326f4069140a80e7c4a95b04f324bf4b194","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        mock_get_instance.return_value \u003d inst"},{"line_number":436,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":437,"context_line":"                  \u0027/v2/servers/id/os-volume_attachments/uuid\u0027, version\u003d\u00272.20\u0027)"},{"line_number":438,"context_line":"        req.method \u003d \u0027DELETE\u0027"},{"line_number":439,"context_line":"        req.headers[\u0027content-type\u0027] \u003d \u0027application/json\u0027"},{"line_number":440,"context_line":"        req.environ[\u0027nova.context\u0027] \u003d self.context"},{"line_number":441,"context_line":"        self.attachments.delete(req, FAKE_UUID, FAKE_UUID_A)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_a23b45d0","line":438,"range":{"start_line":438,"start_character":20,"end_line":438,"end_character":21},"updated":"2016-11-25 13:09:24.000000000","message":"nit: I think those can also be cleaned?","commit_id":"3fa658315cef66efd49c71bb1399ac69df5b2a44"}]}