)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c591d5c5cdf67d86825103904fb8939f5e29f1dc","unresolved":false,"context_lines":[{"line_number":2974,"context_line":"        \"\"\"Get all the aggregates.\"\"\""},{"line_number":2975,"context_line":"        aggregates \u003d self.db.aggregate_get_all(context)"},{"line_number":2976,"context_line":"        aggregate_list \u003d []"},{"line_number":2977,"context_line":"        for agg in aggregates:"},{"line_number":2978,"context_line":"            aggregate \u003d {}"},{"line_number":2979,"context_line":"            temp \u003d dict(agg.iteritems())"},{"line_number":2980,"context_line":"            aggregate[\u0027name\u0027] \u003d temp.pop(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fksw%3D","line":2977,"updated":"2013-07-28 06:22:06.000000000","message":"Consider:\naggregate \u003d dict(aggregate.iteritems())\nThen you can just prune the metadetails.\nAre you sure that the metadata and hosts are returned correctly here?","commit_id":"93222795badc662929d3ae7fd777ae4c238034c6"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c9a1b0b18e0983278b93faeb0724f1d26834d445","unresolved":false,"context_lines":[{"line_number":2974,"context_line":"        \"\"\"Get all the aggregates.\"\"\""},{"line_number":2975,"context_line":"        aggregates \u003d self.db.aggregate_get_all(context)"},{"line_number":2976,"context_line":"        aggregate_list \u003d []"},{"line_number":2977,"context_line":"        for agg in aggregates:"},{"line_number":2978,"context_line":"            aggregate \u003d {}"},{"line_number":2979,"context_line":"            temp \u003d dict(agg.iteritems())"},{"line_number":2980,"context_line":"            aggregate[\u0027name\u0027] \u003d temp.pop(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FkcE%3D","line":2977,"in_reply_to":"AAAAQn%2F%2Fksw%3D","updated":"2013-07-28 17:07:52.000000000","message":"That\u0027s a good suggestion. Yes the metadata and hosts is returned correctly, but my parsing here was actually broken. I\u0027ve reworked the patch and added unit tests to check both the metadata and hosts.","commit_id":"93222795badc662929d3ae7fd777ae4c238034c6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9d679d32eedb8c92c20e481d849281cc33d6ac68","unresolved":false,"context_lines":[{"line_number":3079,"context_line":"                                                    aggregate_payload)"},{"line_number":3080,"context_line":"        return self.get_aggregate(context, aggregate_id)"},{"line_number":3081,"context_line":""},{"line_number":3082,"context_line":"    def _get_aggregate_info(self, aggregate):"},{"line_number":3083,"context_line":"        \"\"\"Builds a dictionary with aggregate props, metadata and hosts.\"\"\""},{"line_number":3084,"context_line":"        result \u003d dict(aggregate.iteritems())"},{"line_number":3085,"context_line":"        result[\"metadata\"] \u003d result.pop(\u0027metadetails\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2Fh24%3D","line":3082,"updated":"2013-07-29 18:32:06.000000000","message":"can we change the name of this function to _reformat_aggregate_info? (or something). It\u0027s not really a get any more.","commit_id":"f849da76304641359a062111739035a5507774fd"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cabae357e314814cc5501c26f01df3425c7c22bc","unresolved":false,"context_lines":[{"line_number":3079,"context_line":"                                                    aggregate_payload)"},{"line_number":3080,"context_line":"        return self.get_aggregate(context, aggregate_id)"},{"line_number":3081,"context_line":""},{"line_number":3082,"context_line":"    def _get_aggregate_info(self, aggregate):"},{"line_number":3083,"context_line":"        \"\"\"Builds a dictionary with aggregate props, metadata and hosts.\"\"\""},{"line_number":3084,"context_line":"        result \u003d dict(aggregate.iteritems())"},{"line_number":3085,"context_line":"        result[\"metadata\"] \u003d result.pop(\u0027metadetails\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2Fhgs%3D","line":3082,"in_reply_to":"AAAAQn%2F%2Fh24%3D","updated":"2013-07-29 20:48:53.000000000","message":"Done","commit_id":"f849da76304641359a062111739035a5507774fd"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"856dac7caad77144075c87916dfe32520b95b414","unresolved":false,"context_lines":[{"line_number":3084,"context_line":"        metadata \u003d self.db.aggregate_metadata_get(context, aggregate[\u0027id\u0027])"},{"line_number":3085,"context_line":"        hosts \u003d self.db.aggregate_host_get_all(context, aggregate[\u0027id\u0027])"},{"line_number":3086,"context_line":"        result \u003d dict(aggregate.iteritems())"},{"line_number":3087,"context_line":"        # metadetails was not originally included here.  We need to pull it"},{"line_number":3088,"context_line":"        # back out to maintain API stability."},{"line_number":3089,"context_line":"        del result[\u0027metadetails\u0027]"},{"line_number":3090,"context_line":"        result[\"metadata\"] \u003d metadata"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FhRI%3D","side":"PARENT","line":3087,"updated":"2013-07-29 22:10:06.000000000","message":"Why remove this comment?","commit_id":"52b43c2f4cbe999e60d71e41bd5efbd919d623c4"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"017058c7107d52474f3d424cd57a75b357c95a3e","unresolved":false,"context_lines":[{"line_number":3084,"context_line":"        metadata \u003d self.db.aggregate_metadata_get(context, aggregate[\u0027id\u0027])"},{"line_number":3085,"context_line":"        hosts \u003d self.db.aggregate_host_get_all(context, aggregate[\u0027id\u0027])"},{"line_number":3086,"context_line":"        result \u003d dict(aggregate.iteritems())"},{"line_number":3087,"context_line":"        # metadetails was not originally included here.  We need to pull it"},{"line_number":3088,"context_line":"        # back out to maintain API stability."},{"line_number":3089,"context_line":"        del result[\u0027metadetails\u0027]"},{"line_number":3090,"context_line":"        result[\"metadata\"] \u003d metadata"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FhQY%3D","side":"PARENT","line":3087,"in_reply_to":"AAAAQn%2F%2FhRI%3D","updated":"2013-07-29 22:25:33.000000000","message":"Done","commit_id":"52b43c2f4cbe999e60d71e41bd5efbd919d623c4"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4ed46da8baaf873f0198006fa0442f11ddf03241","unresolved":false,"context_lines":[{"line_number":3082,"context_line":"    def _reformat_aggregate_info(self, aggregate):"},{"line_number":3083,"context_line":"        \"\"\"Builds a dictionary with aggregate props, metadata and hosts.\"\"\""},{"line_number":3084,"context_line":"        result \u003d dict(aggregate.iteritems())"},{"line_number":3085,"context_line":"        # metadetails was not originally included here. We need to rename it"},{"line_number":3086,"context_line":"        # to maintain API stability."},{"line_number":3087,"context_line":"        result[\"metadata\"] \u003d result.pop(\u0027metadetails\u0027)"},{"line_number":3088,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2Fdzw%3D","line":3085,"updated":"2013-07-30 18:26:47.000000000","message":"pop doesn\u0027t rename","commit_id":"149254194ee941352a1d1c46b8c4a64d241fdc55"}]}