)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"252b57eae7870aa21e5521895cf137f015121e14","unresolved":false,"context_lines":[{"line_number":698,"context_line":"            if data:"},{"line_number":699,"context_line":"                self.driver.check_instance_shared_storage_cleanup(context,"},{"line_number":700,"context_line":"                                                                  data)"},{"line_number":701,"context_line":"        return shared_storage or shared_path, shared_path"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    def _complete_partial_deletion(self, context, instance):"},{"line_number":704,"context_line":"        \"\"\"Complete deletion for instances in DELETED status but not marked as"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_3739afd9","line":701,"updated":"2016-10-17 17:06:07.000000000","message":"This looks super scary, so this method can return a single boolean or a 2-item tuple now? Everything calling this method expects to get the 2-item tuple back.","commit_id":"bf0c18d83068c8b9ed67f6648542efd32a417e42"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"5a470749b8c928f91fcb77e12ac99ac5b6b892d0","unresolved":false,"context_lines":[{"line_number":698,"context_line":"            if data:"},{"line_number":699,"context_line":"                self.driver.check_instance_shared_storage_cleanup(context,"},{"line_number":700,"context_line":"                                                                  data)"},{"line_number":701,"context_line":"        return shared_storage or shared_path, shared_path"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    def _complete_partial_deletion(self, context, instance):"},{"line_number":704,"context_line":"        \"\"\"Complete deletion for instances in DELETED status but not marked as"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_11baf0c0","line":701,"in_reply_to":"fa6399be_3739afd9","updated":"2016-10-17 20:56:08.000000000","message":"In fact it returns 2-item tuple only. Probably this would be better:\n\n return (shared_storage or shared_path), shared_path\n\nAnyway, i\u0027ll think over all of this again","commit_id":"bf0c18d83068c8b9ed67f6648542efd32a417e42"}]}