)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5dfe54e5e3705e931423b06efa2667fb26ecd666","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add debug logs to output host weights for weighers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova scheduler logging report ouput combined weight for hosts"},{"line_number":10,"context_line":"for each weigher. This change adds debug level logging in"},{"line_number":11,"context_line":"nova/weights.py which will display individual host weights"},{"line_number":12,"context_line":"for each weigher."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_60967b40","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":45},"updated":"2016-10-13 13:04:59.000000000","message":"Huh? :)","commit_id":"58a1b9d3e7e27933229c9a490bb54a56ed3f4e5f"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"ea37e493dfe34335a4478c71dabd4acb5f0cc698","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add debug logs to output host weights for weighers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova scheduler logging report ouput combined weight for hosts"},{"line_number":10,"context_line":"for each weigher. This change adds debug level logging in"},{"line_number":11,"context_line":"nova/weights.py which will display individual host weights"},{"line_number":12,"context_line":"for each weigher."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_3b9758ed","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":35},"updated":"2016-10-13 13:32:10.000000000","message":"output","commit_id":"58a1b9d3e7e27933229c9a490bb54a56ed3f4e5f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"56800ebdff7bc435979304de3c200a7e17badf9e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add debug logs to output host weights for weighers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova scheduler logging report output combined weight for hosts"},{"line_number":10,"context_line":"for each weigher. This change adds debug level logging in"},{"line_number":11,"context_line":"nova/weights.py which will display individual host weights"},{"line_number":12,"context_line":"for each weigher."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa6399be_072532c1","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":62},"updated":"2016-10-18 14:04:48.000000000","message":"This sentence still doesn\u0027t make any sense...?","commit_id":"fddfde889950a6f415ed6b31ec17f13fa3b39dc3"}],"nova/weights.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"e6f922aff44514d0fcc15a2529c2c4a85a3f9789","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if len(weighed_objs) \u003c\u003d 1:"},{"line_number":132,"context_line":"            return weighed_objs"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        LOG.debug(\" Host weights for every weigher\")"},{"line_number":135,"context_line":"        for weigher in weighers:"},{"line_number":136,"context_line":"            weights \u003d weigher.weigh_objects(weighed_objs, weighing_properties)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_531c0977","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":52},"updated":"2016-10-13 06:01:49.000000000","message":"Not sure I understand the purpose of this debug message. If it is, please fix redundant space at the beginning","commit_id":"02b8e670550983ab1f775c19243e2ce4c721d58e"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"b42c24c941d3254d808dcc6cd50a55a536f8cd33","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if len(weighed_objs) \u003c\u003d 1:"},{"line_number":132,"context_line":"            return weighed_objs"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        LOG.debug(\" Host weights for every weigher\")"},{"line_number":135,"context_line":"        for weigher in weighers:"},{"line_number":136,"context_line":"            weights \u003d weigher.weigh_objects(weighed_objs, weighing_properties)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_a5eb4577","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":52},"in_reply_to":"fa6399be_531c0977","updated":"2016-10-13 12:52:11.000000000","message":"Done","commit_id":"02b8e670550983ab1f775c19243e2ce4c721d58e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5dfe54e5e3705e931423b06efa2667fb26ecd666","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                maxval\u003dweigher.maxval)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"            for i, weight in enumerate(weights):"},{"line_number":144,"context_line":"                host_name \u003d \"\""},{"line_number":145,"context_line":"                if isinstance(weighed_objs[i].obj, state.CellState):"},{"line_number":146,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":147,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_80ae2f7f","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":30},"updated":"2016-10-13 13:04:59.000000000","message":"You don\u0027t need this","commit_id":"58a1b9d3e7e27933229c9a490bb54a56ed3f4e5f"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"ea37e493dfe34335a4478c71dabd4acb5f0cc698","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                maxval\u003dweigher.maxval)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"            for i, weight in enumerate(weights):"},{"line_number":144,"context_line":"                host_name \u003d \"\""},{"line_number":145,"context_line":"                if isinstance(weighed_objs[i].obj, state.CellState):"},{"line_number":146,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":147,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_db881cc8","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":30},"in_reply_to":"fa6399be_80ae2f7f","updated":"2016-10-13 13:32:10.000000000","message":"+1","commit_id":"58a1b9d3e7e27933229c9a490bb54a56ed3f4e5f"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"e97c5f410d483e3307b73f6125dcaa60dde5bfb8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                maxval\u003dweigher.maxval)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"            for i, weight in enumerate(weights):"},{"line_number":144,"context_line":"                host_name \u003d \"\""},{"line_number":145,"context_line":"                if isinstance(weighed_objs[i].obj, state.CellState):"},{"line_number":146,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":147,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_0dda4f17","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":30},"in_reply_to":"fa6399be_db881cc8","updated":"2016-10-13 16:00:46.000000000","message":"Done","commit_id":"58a1b9d3e7e27933229c9a490bb54a56ed3f4e5f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5dfe54e5e3705e931423b06efa2667fb26ecd666","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"            for i, weight in enumerate(weights):"},{"line_number":144,"context_line":"                host_name \u003d \"\""},{"line_number":145,"context_line":"                if isinstance(weighed_objs[i].obj, state.CellState):"},{"line_number":146,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":147,"context_line":"                else:"},{"line_number":148,"context_line":"                    host_name \u003d weighed_objs[i].obj.host"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_20c0032a","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":68},"updated":"2016-10-13 13:04:59.000000000","message":"Some comments on why this is necessary would be helpful","commit_id":"58a1b9d3e7e27933229c9a490bb54a56ed3f4e5f"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"e97c5f410d483e3307b73f6125dcaa60dde5bfb8","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"            for i, weight in enumerate(weights):"},{"line_number":144,"context_line":"                host_name \u003d \"\""},{"line_number":145,"context_line":"                if isinstance(weighed_objs[i].obj, state.CellState):"},{"line_number":146,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":147,"context_line":"                else:"},{"line_number":148,"context_line":"                    host_name \u003d weighed_objs[i].obj.host"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_edd0bbf8","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":68},"in_reply_to":"fa6399be_20c0032a","updated":"2016-10-13 16:00:46.000000000","message":"Done","commit_id":"58a1b9d3e7e27933229c9a490bb54a56ed3f4e5f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"56800ebdff7bc435979304de3c200a7e17badf9e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                # to retrieve hostname. Hence, we use \u0027name\u0027 attribute of"},{"line_number":147,"context_line":"                # CellState."},{"line_number":148,"context_line":"                if isinstance(weighed_objs[i].obj, state.CellState):"},{"line_number":149,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":150,"context_line":"                else:"},{"line_number":151,"context_line":"                    host_name \u003d weighed_objs[i].obj.host"},{"line_number":152,"context_line":"                LOG.debug(\"host: %(host)s, weigher: %(weigher)s, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_47580a57","line":149,"range":{"start_line":149,"start_character":20,"end_line":149,"end_character":29},"updated":"2016-10-18 14:04:48.000000000","message":"is this a host name or a cell name so?","commit_id":"fddfde889950a6f415ed6b31ec17f13fa3b39dc3"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"033303bd77b60b73e00b415082ba981803b9a031","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                # to retrieve hostname. Hence, we use \u0027name\u0027 attribute of"},{"line_number":147,"context_line":"                # CellState."},{"line_number":148,"context_line":"                if isinstance(weighed_objs[i].obj, state.CellState):"},{"line_number":149,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":150,"context_line":"                else:"},{"line_number":151,"context_line":"                    host_name \u003d weighed_objs[i].obj.host"},{"line_number":152,"context_line":"                LOG.debug(\"host: %(host)s, weigher: %(weigher)s, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_0d72b37c","line":149,"range":{"start_line":149,"start_character":20,"end_line":149,"end_character":29},"in_reply_to":"fa6399be_47580a57","updated":"2016-10-18 14:37:58.000000000","message":"inside \"if\" its cell_name. I wanted to keep consistent name for \"if\" and \"else\" so that it will be easy to use in debug statement.","commit_id":"fddfde889950a6f415ed6b31ec17f13fa3b39dc3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"75703c12e2f11c34edef91e85560887e01ff5626","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                # CellState or HostState. CellState has no attribute \u0027host\u0027"},{"line_number":146,"context_line":"                # to retrieve hostname. Hence, we use \u0027name\u0027 attribute of"},{"line_number":147,"context_line":"                # CellState."},{"line_number":148,"context_line":"                if isinstance(weighed_objs[i].obj, state.CellState):"},{"line_number":149,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":150,"context_line":"                else:"},{"line_number":151,"context_line":"                    host_name \u003d weighed_objs[i].obj.host"},{"line_number":152,"context_line":"                LOG.debug(\"host: %(host)s, weigher: %(weigher)s, \""},{"line_number":153,"context_line":"                          \"weight: %(weight)d \","},{"line_number":154,"context_line":"                          {\u0027host\u0027: host_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_b82aa22a","line":151,"range":{"start_line":148,"start_character":16,"end_line":151,"end_character":56},"updated":"2017-02-13 12:41:36.000000000","message":"I guess you could use hasattr here instead?\n\n    if hasattr(weighed_objs[i].obj, \u0027host\u0027):","commit_id":"ab808191a4b8a80b37dab7254ae26410420bd775"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"57418c4b3ea5f66224359d696ecfc4f7e1eb38c2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                if hasattr(weighed_objs[i].obj, \u0027host\u0027):"},{"line_number":148,"context_line":"                    host_name \u003d weighed_objs[i].obj.host"},{"line_number":149,"context_line":"                else:"},{"line_number":150,"context_line":"                    host_name \u003d weighed_objs[i].obj.name"},{"line_number":151,"context_line":"                LOG.debug(\"host: %(host)s, weigher: %(weigher)s, \""},{"line_number":152,"context_line":"                          \"weight: %(weight)d \","},{"line_number":153,"context_line":"                          {\u0027host\u0027: host_name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfeb2761_7b5f6c41","line":150,"updated":"2017-03-31 09:33:12.000000000","message":"If it\u0027s cell name it\u0027s not the same as the host name.\nCell is an object that contains several hosts.\nSo here we need to separate log messages or just ignore cellstate object because it\u0027s deprecated now.","commit_id":"f4803dfd083586b9eb9c4f47cdd9c3306b05d6bf"}]}
