)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"574a62f56bf50634734e8f36706820a95646dd1b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"* ``disk_prefix``: depends on this"},{"line_number":124,"context_line":"* ``cpu_mode``: depends on this"},{"line_number":125,"context_line":"* ``cpu_model``: depends on this"},{"line_number":126,"context_line":"* ``pointer_model``: pointer_model\u003d\u0027usbtablet\u0027 only works with kvm and qemu."},{"line_number":127,"context_line":"\"\"\"),"},{"line_number":128,"context_line":"    cfg.StrOpt(\u0027connection_uri\u0027,"},{"line_number":129,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_b1a8bd78","line":126,"updated":"2016-10-14 10:25:14.000000000","message":"Even if currently only libvirt implement that option, you can specify that for libvirt \u0027pointer_model\u003dusbtablet\u0027 only work with kvm and qemu and perahs add a not about spice and vnc, no ?","commit_id":"a99fea4140ba7d03fd09b3f6bef4d807b266d1a6"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca5c9ad4408fb34295f52fec0d1f02fb6c40bcdd","unresolved":false,"context_lines":[{"line_number":4580,"context_line":"            # until the next release O*. It means operators can continue"},{"line_number":4581,"context_line":"            # to use the deprecated option \"use_usb_tablet\" or set a"},{"line_number":4582,"context_line":"            # specific device to use"},{"line_number":4583,"context_line":"            pointer_model \u003d \"usbtablet\""},{"line_number":4584,"context_line":"            LOG.warning(_LW(\u0027The option \"use_usb_tablet\" has been \u0027"},{"line_number":4585,"context_line":"                            \u0027deprecated for Newton in favor of the more \u0027"},{"line_number":4586,"context_line":"                            \u0027generic \"pointer_model\". Please update \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_ac134d0c","side":"PARENT","line":4583,"updated":"2016-10-12 23:07:58.000000000","message":"Question to sahid, do we want to default to \u0027usbtablet\u0027 if CONF.pointer_model is None?","commit_id":"f7ed6535e742e27e4daf6a3cb81f514325cbc99b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fd6e3c3be55a93639897d700c70703b450ecbcba","unresolved":false,"context_lines":[{"line_number":4580,"context_line":"            # until the next release O*. It means operators can continue"},{"line_number":4581,"context_line":"            # to use the deprecated option \"use_usb_tablet\" or set a"},{"line_number":4582,"context_line":"            # specific device to use"},{"line_number":4583,"context_line":"            pointer_model \u003d \"usbtablet\""},{"line_number":4584,"context_line":"            LOG.warning(_LW(\u0027The option \"use_usb_tablet\" has been \u0027"},{"line_number":4585,"context_line":"                            \u0027deprecated for Newton in favor of the more \u0027"},{"line_number":4586,"context_line":"                            \u0027generic \"pointer_model\". Please update \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_b32645cc","side":"PARENT","line":4583,"in_reply_to":"fa6399be_ac134d0c","updated":"2016-10-13 06:04:29.000000000","message":"I think we were agree to let the default behavior of each drivers in that case. for libvirt and on x86 that will be mouse on PS2 only. So if None we should just pass on doing something.","commit_id":"f7ed6535e742e27e4daf6a3cb81f514325cbc99b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fd6e3c3be55a93639897d700c70703b450ecbcba","unresolved":false,"context_lines":[{"line_number":4595,"context_line":"                    CONF.spice.enabled and not CONF.spice.agent_enabled):"},{"line_number":4596,"context_line":"                return self._get_guest_usb_tablet(os_type)"},{"line_number":4597,"context_line":"            else:"},{"line_number":4598,"context_line":"                if CONF.pointer_model or CONF.libvirt.use_usb_tablet:"},{"line_number":4599,"context_line":"                    # For backward compatibility We don\u0027t want to break"},{"line_number":4600,"context_line":"                    # process of booting an instance if host is configured"},{"line_number":4601,"context_line":"                    # to use USB tablet without VNC or SPICE and SPICE"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_b35f2540","side":"PARENT","line":4598,"updated":"2016-10-13 06:04:29.000000000","message":"I think we can remove all of that block. During Newton operators which have configured pointer_model to use usbtablet but did not well have configured VNC or spice received log warning. Now we should just stop the process to boot the instance.","commit_id":"f7ed6535e742e27e4daf6a3cb81f514325cbc99b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"24c006f03a584f8d25f9f355cb42d482c8bfc3c3","unresolved":false,"context_lines":[{"line_number":4595,"context_line":"                    CONF.spice.enabled and not CONF.spice.agent_enabled):"},{"line_number":4596,"context_line":"                return self._get_guest_usb_tablet(os_type)"},{"line_number":4597,"context_line":"            else:"},{"line_number":4598,"context_line":"                if CONF.pointer_model or CONF.libvirt.use_usb_tablet:"},{"line_number":4599,"context_line":"                    # For backward compatibility We don\u0027t want to break"},{"line_number":4600,"context_line":"                    # process of booting an instance if host is configured"},{"line_number":4601,"context_line":"                    # to use USB tablet without VNC or SPICE and SPICE"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c10f4686","side":"PARENT","line":4598,"in_reply_to":"fa6399be_013a1ecc","updated":"2016-10-13 14:52:28.000000000","message":"I guess the exception will fall through here and we\u0027ll reschedule:\n\nhttps://github.com/openstack/nova/blob/14.0.1/nova/compute/manager.py#L1972","commit_id":"f7ed6535e742e27e4daf6a3cb81f514325cbc99b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"215248a891783cf0f826d8a911331c28e8133ec5","unresolved":false,"context_lines":[{"line_number":4595,"context_line":"                    CONF.spice.enabled and not CONF.spice.agent_enabled):"},{"line_number":4596,"context_line":"                return self._get_guest_usb_tablet(os_type)"},{"line_number":4597,"context_line":"            else:"},{"line_number":4598,"context_line":"                if CONF.pointer_model or CONF.libvirt.use_usb_tablet:"},{"line_number":4599,"context_line":"                    # For backward compatibility We don\u0027t want to break"},{"line_number":4600,"context_line":"                    # process of booting an instance if host is configured"},{"line_number":4601,"context_line":"                    # to use USB tablet without VNC or SPICE and SPICE"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_013a1ecc","side":"PARENT","line":4598,"in_reply_to":"fa6399be_1b02940b","updated":"2016-10-13 14:45:04.000000000","message":"Actually, if we do this, the server is going to fail to build on this host. Will we reschedule properly? I\u0027m thinking of the user POV where I just want usb input on my guest vm, but I don\u0027t know anything about where it\u0027s going to land during scheduling. If this fails to schedule I\u0027m going to get a NoValidHost but not know why, which sucks. We could log a warning and still boot the instance, but then we failed to satisfy the user request which isn\u0027t good either.","commit_id":"f7ed6535e742e27e4daf6a3cb81f514325cbc99b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40759d1294456f30cfe540ba5a8cc272edf4fddd","unresolved":false,"context_lines":[{"line_number":4595,"context_line":"                    CONF.spice.enabled and not CONF.spice.agent_enabled):"},{"line_number":4596,"context_line":"                return self._get_guest_usb_tablet(os_type)"},{"line_number":4597,"context_line":"            else:"},{"line_number":4598,"context_line":"                if CONF.pointer_model or CONF.libvirt.use_usb_tablet:"},{"line_number":4599,"context_line":"                    # For backward compatibility We don\u0027t want to break"},{"line_number":4600,"context_line":"                    # process of booting an instance if host is configured"},{"line_number":4601,"context_line":"                    # to use USB tablet without VNC or SPICE and SPICE"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_1b02940b","side":"PARENT","line":4598,"in_reply_to":"fa6399be_b35f2540","updated":"2016-10-13 13:39:05.000000000","message":"Yeah that\u0027s a valid point, I forgot that pointer_model is restricted by the choices definition in the option, so if you set usbtablet you need to have one of those other things enabled, and the config option help text is clear about that:\n\n  Interdependencies to other options:\n\n  * usbtablet must be configured with VNC enabled or SPICE enabled and SPICE\n    agent disabled. When used with libvirt the instance mode should be\n    configured as HVM.","commit_id":"f7ed6535e742e27e4daf6a3cb81f514325cbc99b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d150f1ef2ca4d070fccc9fd9398b35915cbc0681","unresolved":false,"context_lines":[{"line_number":4600,"context_line":"                    # process of booting an instance if host is configured"},{"line_number":4601,"context_line":"                    # to use USB tablet without VNC or SPICE and SPICE"},{"line_number":4602,"context_line":"                    # agent disable."},{"line_number":4603,"context_line":"                    LOG.warning(_LW(\u0027USB tablet requested for guests by host \u0027"},{"line_number":4604,"context_line":"                                    \u0027configuration. In order to accept this \u0027"},{"line_number":4605,"context_line":"                                    \u0027request VNC should be enabled or SPICE \u0027"},{"line_number":4606,"context_line":"                                    \u0027and SPICE agent disabled on host.\u0027))"},{"line_number":4607,"context_line":"                else:"},{"line_number":4608,"context_line":"                    raise exception.UnsupportedPointerModelRequested("},{"line_number":4609,"context_line":"                        model\u003d\"usbtablet\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_a77182aa","side":"PARENT","line":4606,"range":{"start_line":4603,"start_character":20,"end_line":4606,"end_character":73},"updated":"2016-10-13 15:24:00.000000000","message":"I think we probably need to keep this for debug in case a request landed here and it failed.","commit_id":"f7ed6535e742e27e4daf6a3cb81f514325cbc99b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8414a26ea2e83f18c2eeacbf90e00b2cc0556569","unresolved":false,"context_lines":[{"line_number":4603,"context_line":"                    LOG.warning(_LW(\u0027USB tablet requested for guests by host \u0027"},{"line_number":4604,"context_line":"                                    \u0027configuration. In order to accept this \u0027"},{"line_number":4605,"context_line":"                                    \u0027request VNC should be enabled or SPICE \u0027"},{"line_number":4606,"context_line":"                                    \u0027and SPICE agent disabled on host.\u0027))"},{"line_number":4607,"context_line":"                else:"},{"line_number":4608,"context_line":"                    raise exception.UnsupportedPointerModelRequested("},{"line_number":4609,"context_line":"                        model\u003d\"usbtablet\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_27f81249","side":"PARENT","line":4606,"in_reply_to":"fa6399be_a77182aa","updated":"2016-10-13 15:37:04.000000000","message":"Yes makes sense to keep it for debugging purpose.","commit_id":"f7ed6535e742e27e4daf6a3cb81f514325cbc99b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fd6e3c3be55a93639897d700c70703b450ecbcba","unresolved":false,"context_lines":[{"line_number":4604,"context_line":"            tablet.type \u003d \"tablet\""},{"line_number":4605,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4606,"context_line":"        else:"},{"line_number":4607,"context_line":"            if CONF.pointer_model:"},{"line_number":4608,"context_line":"                # For backward compatibility We don\u0027t want to break"},{"line_number":4609,"context_line":"                # process of booting an instance if virtual machine mode"},{"line_number":4610,"context_line":"                # is not configured as HVM."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_33195589","line":4607,"updated":"2016-10-13 06:04:29.000000000","message":"Here too, we should stop the process of booting the instance. You can remove that block safely.","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40759d1294456f30cfe540ba5a8cc272edf4fddd","unresolved":false,"context_lines":[{"line_number":4604,"context_line":"            tablet.type \u003d \"tablet\""},{"line_number":4605,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4606,"context_line":"        else:"},{"line_number":4607,"context_line":"            if CONF.pointer_model:"},{"line_number":4608,"context_line":"                # For backward compatibility We don\u0027t want to break"},{"line_number":4609,"context_line":"                # process of booting an instance if virtual machine mode"},{"line_number":4610,"context_line":"                # is not configured as HVM."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_36768da4","line":4607,"in_reply_to":"fa6399be_33195589","updated":"2016-10-13 13:39:05.000000000","message":"Done","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f112262494279354abbef6ca22330ddab2d8ad6","unresolved":false,"context_lines":[{"line_number":4604,"context_line":"            tablet.type \u003d \"tablet\""},{"line_number":4605,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4606,"context_line":"        else:"},{"line_number":4607,"context_line":"            if CONF.pointer_model:"},{"line_number":4608,"context_line":"                # For backward compatibility We don\u0027t want to break"},{"line_number":4609,"context_line":"                # process of booting an instance if virtual machine mode"},{"line_number":4610,"context_line":"                # is not configured as HVM."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8c8025f9","line":4607,"in_reply_to":"fa6399be_36768da4","updated":"2016-10-13 15:07:41.000000000","message":"Actually, this worries me. We have the following defaults:\n\n1. vnc.enabled \u003d True\n2. pointer_model \u003d \u0027usbtablet\u0027\n\nSo with just the defaults, we\u0027re going to get into this block.\n\nNow if the instance isn\u0027t booted with a specific vm_mode in the image meta, we\u0027re going to use _get_guest_os_type to get the os_type. That defaults to HVM for non-lxc/uml/xen cases, but if you\u0027re using one of those virt types you\u0027re not going to be able to boot instances by default. That\u0027s pretty bad.","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fb747662c1c5092ed7bcc4054f99d3e73dacb24d","unresolved":false,"context_lines":[{"line_number":4604,"context_line":"            tablet.type \u003d \"tablet\""},{"line_number":4605,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4606,"context_line":"        else:"},{"line_number":4607,"context_line":"            if CONF.pointer_model:"},{"line_number":4608,"context_line":"                # For backward compatibility We don\u0027t want to break"},{"line_number":4609,"context_line":"                # process of booting an instance if virtual machine mode"},{"line_number":4610,"context_line":"                # is not configured as HVM."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_32a69253","line":4607,"in_reply_to":"fa6399be_5284e65c","updated":"2016-10-13 15:50:31.000000000","message":"I think we defaulted pointer_model\u003d\u0027usbtablet\u0027 because use_usb_tablet defaulted to True, so we were being backward compatible with the default in the new option.\n\nI\u0027m going to push up a change and then we can see how it looks for handling this.","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9764ba75ada82708bc64b7a15f2a54ac430c1c3","unresolved":false,"context_lines":[{"line_number":4604,"context_line":"            tablet.type \u003d \"tablet\""},{"line_number":4605,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4606,"context_line":"        else:"},{"line_number":4607,"context_line":"            if CONF.pointer_model:"},{"line_number":4608,"context_line":"                # For backward compatibility We don\u0027t want to break"},{"line_number":4609,"context_line":"                # process of booting an instance if virtual machine mode"},{"line_number":4610,"context_line":"                # is not configured as HVM."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f2aedae4","line":4607,"in_reply_to":"fa6399be_8c8025f9","updated":"2016-10-13 15:36:23.000000000","message":"I\u0027m thinking for the sake of simplicity, we change the warning to an error log message here but don\u0027t fail the request in ocata, but update the error message to say this will cause build failures in pike.","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8414a26ea2e83f18c2eeacbf90e00b2cc0556569","unresolved":false,"context_lines":[{"line_number":4604,"context_line":"            tablet.type \u003d \"tablet\""},{"line_number":4605,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4606,"context_line":"        else:"},{"line_number":4607,"context_line":"            if CONF.pointer_model:"},{"line_number":4608,"context_line":"                # For backward compatibility We don\u0027t want to break"},{"line_number":4609,"context_line":"                # process of booting an instance if virtual machine mode"},{"line_number":4610,"context_line":"                # is not configured as HVM."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_5284e65c","line":4607,"in_reply_to":"fa6399be_8c8025f9","updated":"2016-10-13 15:37:04.000000000","message":"Yes that is pretty bad... I really think that pointer_model should be defaulted to None I can\u0027t exactly remember why we finally set it to usbtablet.\n\nSo we probably want to keep the code as it is now. Add a reno note to explain that the default of pointer_model is going to be None for the next release. Next release we remove that block.","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d150f1ef2ca4d070fccc9fd9398b35915cbc0681","unresolved":false,"context_lines":[{"line_number":4608,"context_line":"                # For backward compatibility We don\u0027t want to break"},{"line_number":4609,"context_line":"                # process of booting an instance if virtual machine mode"},{"line_number":4610,"context_line":"                # is not configured as HVM."},{"line_number":4611,"context_line":"                LOG.warning(_LW(\u0027USB tablet requested for guests by host \u0027"},{"line_number":4612,"context_line":"                                \u0027configuration. In order to accept this \u0027"},{"line_number":4613,"context_line":"                                \u0027request the machine mode should be \u0027"},{"line_number":4614,"context_line":"                                \u0027configured as HVM.\u0027))"},{"line_number":4615,"context_line":"            else:"},{"line_number":4616,"context_line":"                raise exception.UnsupportedPointerModelRequested("},{"line_number":4617,"context_line":"                    model\u003d\"usbtablet\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c7b11649","line":4614,"range":{"start_line":4611,"start_character":16,"end_line":4614,"end_character":54},"updated":"2016-10-13 15:24:00.000000000","message":"I think we probably need to keep this for debug in case of failures.","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca9b5371b897f349ab904abe5776d64a87866545","unresolved":false,"context_lines":[{"line_number":4595,"context_line":"                                \u0027metadata. In order to accept this \u0027"},{"line_number":4596,"context_line":"                                \u0027request VNC should be enabled or SPICE \u0027"},{"line_number":4597,"context_line":"                                \u0027and SPICE agent disabled on host.\u0027))"},{"line_number":4598,"context_line":"            raise exception.UnsupportedPointerModelRequested("},{"line_number":4599,"context_line":"                model\u003d\"usbtablet\")"},{"line_number":4600,"context_line":""},{"line_number":4601,"context_line":"    def _get_guest_usb_tablet(self, os_type, image_meta):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_35a91925","line":4598,"updated":"2016-10-13 17:07:53.000000000","message":"This is going to make the virtuozzo ci fail:\n\nhttp://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/83/385683/1/check/check-dsvm-tempest-vz7-exe-minimal/8a09bec/logs/screen-n-cpu.txt.gz\n\n2016-10-12 23:34:51.016 47633 WARNING nova.virt.libvirt.driver [req-07d0c959-ff51-495d-9fb0-9c4e10f0174b tempest-MigrationsAdminTest-1269995469 tempest-MigrationsAdminTest-1269995469] USB tablet requested for guests by host configuration. In order to accept this request VNC should be enabled or SPICE and SPICE agent disabled on host.","commit_id":"a99fea4140ba7d03fd09b3f6bef4d807b266d1a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a19eb87fd9eb5306592e445bff8889d7aee8a29","unresolved":false,"context_lines":[{"line_number":4595,"context_line":"                                \u0027metadata. In order to accept this \u0027"},{"line_number":4596,"context_line":"                                \u0027request VNC should be enabled or SPICE \u0027"},{"line_number":4597,"context_line":"                                \u0027and SPICE agent disabled on host.\u0027))"},{"line_number":4598,"context_line":"            raise exception.UnsupportedPointerModelRequested("},{"line_number":4599,"context_line":"                model\u003d\"usbtablet\")"},{"line_number":4600,"context_line":""},{"line_number":4601,"context_line":"    def _get_guest_usb_tablet(self, os_type, image_meta):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_04cea181","line":4598,"in_reply_to":"fa6399be_35a91925","updated":"2016-10-13 19:05:25.000000000","message":"Crap this also makes grenade fail:\n\nhttp://logs.openstack.org/83/385683/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/1d6d086/logs/new/screen-n-cpu.txt.gz?level\u003dTRACE#_2016-10-13_17_51_56_877\n\nProbably because https://review.openstack.org/#/c/367526/ isn\u0027t in newton.","commit_id":"a99fea4140ba7d03fd09b3f6bef4d807b266d1a6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"574a62f56bf50634734e8f36706820a95646dd1b","unresolved":false,"context_lines":[{"line_number":4619,"context_line":"                # CONF.libvirt.virt_type and will not be HVM if you\u0027re using"},{"line_number":4620,"context_line":"                # lxc/uml/xen which makes server creates fail by default."},{"line_number":4621,"context_line":"                # TODO(mriedem): This is an error in Ocata but will not fail."},{"line_number":4622,"context_line":"                # Change this to fail the server build in Pike."},{"line_number":4623,"context_line":"                LOG.error(_LE(\u0027USB tablet requested for guests by host \u0027"},{"line_number":4624,"context_line":"                              \u0027configuration. In order to accept this \u0027"},{"line_number":4625,"context_line":"                              \u0027request the machine mode should be \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_7188e5c5","line":4622,"updated":"2016-10-14 10:25:14.000000000","message":"Well as you said it is probably not good to have instances falling by default if operators configured libvirt with something else than qem/kvm. Is there something I missed ?","commit_id":"a99fea4140ba7d03fd09b3f6bef4d807b266d1a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8bada4bb55008f575ed48588c9846847c12f41d1","unresolved":false,"context_lines":[{"line_number":4572,"context_line":""},{"line_number":4573,"context_line":"        return guest"},{"line_number":4574,"context_line":""},{"line_number":4575,"context_line":"    def _get_guest_pointer_model(self, os_type, image_meta):"},{"line_number":4576,"context_line":"        img_pointer_model \u003d image_meta.properties.get(\u0027hw_pointer_model\u0027)"},{"line_number":4577,"context_line":"        pointer_model \u003d img_pointer_model or CONF.pointer_model"},{"line_number":4578,"context_line":"        if pointer_model \u003d\u003d \"usbtablet\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_861e126e","line":4575,"updated":"2016-10-14 14:35:36.000000000","message":"You know, looking back on this code in liberty for how use_usb_tablet was used:\n\nhttps://github.com/openstack/nova/blob/stable/liberty/nova/virt/libvirt/driver.py#L4385\n\nThat seems much more sane. Basically check if you can even do usbtablet based on the other configuration, and if you can, then and only then do you rely on the config option for use_usb_tablet, else you get the default.\n\nI really feel like we should probably just go back to that model, and let the image meta override the configuration on the compute if necessary.","commit_id":"0842b882ef255c7ffa8a83b23a3bc82a84eb0b80"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b13aa63bbfdc1ea2a05d9f6b40357420ab6f6f4a","unresolved":false,"context_lines":[{"line_number":4572,"context_line":""},{"line_number":4573,"context_line":"        return guest"},{"line_number":4574,"context_line":""},{"line_number":4575,"context_line":"    def _get_guest_pointer_model(self, os_type, image_meta):"},{"line_number":4576,"context_line":"        img_pointer_model \u003d image_meta.properties.get(\u0027hw_pointer_model\u0027)"},{"line_number":4577,"context_line":"        pointer_model \u003d img_pointer_model or CONF.pointer_model"},{"line_number":4578,"context_line":"        if pointer_model \u003d\u003d \"usbtablet\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_61a488b9","line":4575,"in_reply_to":"fa6399be_861e126e","updated":"2016-10-14 14:45:08.000000000","message":"But as sahid reminded me in IRC, if the user explicitly requests a server with an image that has hw_pointer_model\u003dusbtablet and we don\u0027t satisfy that request, then they\u0027ll probably be opening a ticket. But maybe we fail in that case, but not in the case that the image_meta doesn\u0027t have hw_pointer_model - so the decision is purely based on config values in the compute, which shouldn\u0027t break you by default.","commit_id":"0842b882ef255c7ffa8a83b23a3bc82a84eb0b80"}],"releasenotes/notes/rm-use-usb-tablet-bebb5c437e14fb0f.yaml":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fd6e3c3be55a93639897d700c70703b450ecbcba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated ``libvirt.use_usb_tablet`` configuration option has been"},{"line_number":4,"context_line":"    removed in favor of the ``pointer_model`` option."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_d63647e6","line":4,"updated":"2016-10-13 06:04:29.000000000","message":"Can you add a note to explain that, now instead of logging a warning for usbtablet without VNC or spice we stop to boot the instance, same behavior for a bad VM type.","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40759d1294456f30cfe540ba5a8cc272edf4fddd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated ``libvirt.use_usb_tablet`` configuration option has been"},{"line_number":4,"context_line":"    removed in favor of the ``pointer_model`` option."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_d640f136","line":4,"in_reply_to":"fa6399be_d63647e6","updated":"2016-10-13 13:39:05.000000000","message":"Sure.","commit_id":"ffd29d0c006bce7e0964225ffde52c429602969c"}]}