)]}'
{"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"4ae43c2cd89395d78fec9d535d07b529f8a80cbf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    microversion \u003d None"},{"line_number":28,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    user_data_contents \u003d six.b(\u0027#!/bin/bash\\n/bin/su\\necho \"I am in you!\"\\n\u0027)"},{"line_number":31,"context_line":"    user_data \u003d base64.b64encode(user_data_contents)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    common_req_names \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_e4a914e1","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":77},"updated":"2016-12-08 11:34:12.000000000","message":"in six.py:\nif PY3:\n    def b(s):\n        return s.encode(\"latin-1\")\n\nnot sure we need encode with \"latin-1\" here.\n\nAnother way to handle this:\noslo_serialization provide base64 module to handle base64 related stuff on Python 3.","commit_id":"5be88f99a5573b90303cfa6d85efc685a1189327"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a867a382a5eb329b508afbebfb7b5941463d3dd4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    microversion \u003d None"},{"line_number":29,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    user_data_contents \u003d six.b(\u0027#!/bin/bash\\n/bin/su\\necho \"I am in you!\"\\n\u0027)"},{"line_number":32,"context_line":"    user_data \u003d base64.b64encode(user_data_contents)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    common_req_names \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_a75aad4e","line":31,"updated":"2016-12-13 21:13:33.000000000","message":"A bit of comment explaining that base64 only accepts ASCII or bytes strings (and not unicode) could have been cool, but okay...","commit_id":"a2d7ebd39b99db9c5728e2a256568b8bbbc4734f"}],"tox.ini":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"4ae43c2cd89395d78fec9d535d07b529f8a80cbf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:functional]"},{"line_number":39,"context_line":"# TODO(melwitt): This can be removed when functional tests can be run"},{"line_number":40,"context_line":"# with python 3.x"},{"line_number":41,"context_line":"basepython \u003d python2.7"},{"line_number":42,"context_line":"usedevelop \u003d True"},{"line_number":43,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":44,"context_line":"       OS_TEST_PATH\u003d./nova/tests/functional"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a71b18c_e4e11400","side":"PARENT","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":22},"updated":"2016-12-08 11:34:12.000000000","message":"we can\u0027t run functional tests on Python 3 now, need more work to that happened:\n1. run python3 functional tests with blacklist to skip testcases which don\u0027t work on python 3\n\n2. reduce the items on blacklist to zero\n\n3. then remove this \"basepython\u003dpython2.7\"","commit_id":"2669f1c73b7dee923c399729d95eee4d83c7ea56"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2bef658024d9c723dfbdc143185c2c8f100e5e77","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:functional]"},{"line_number":39,"context_line":"# TODO(melwitt): This can be removed when functional tests can be run"},{"line_number":40,"context_line":"# with python 3.x"},{"line_number":41,"context_line":"basepython \u003d python2.7"},{"line_number":42,"context_line":"usedevelop \u003d True"},{"line_number":43,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":44,"context_line":"       OS_TEST_PATH\u003d./nova/tests/functional"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a71b18c_4ec56d3b","side":"PARENT","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":22},"in_reply_to":"3a71b18c_8efea5ac","updated":"2016-12-08 20:46:58.000000000","message":"Or even better, \"This can be removed when functional tests are gating with python 3.x\"","commit_id":"2669f1c73b7dee923c399729d95eee4d83c7ea56"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3fa03713ac396c4b3dff1a0a20622c273d9ddaf7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:functional]"},{"line_number":39,"context_line":"# TODO(melwitt): This can be removed when functional tests can be run"},{"line_number":40,"context_line":"# with python 3.x"},{"line_number":41,"context_line":"basepython \u003d python2.7"},{"line_number":42,"context_line":"usedevelop \u003d True"},{"line_number":43,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":44,"context_line":"       OS_TEST_PATH\u003d./nova/tests/functional"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a71b18c_8efea5ac","side":"PARENT","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":22},"in_reply_to":"3a71b18c_e4e11400","updated":"2016-12-08 20:45:50.000000000","message":"+1. I guess I should have worded this better to say, \"This can be removed when functional tests are passing with python 3.x\"","commit_id":"2669f1c73b7dee923c399729d95eee4d83c7ea56"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a867a382a5eb329b508afbebfb7b5941463d3dd4","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[testenv:functional]"},{"line_number":50,"context_line":"# TODO(melwitt): This can be removed when functional tests are gating with"},{"line_number":51,"context_line":"# python 3.x"},{"line_number":52,"context_line":"basepython \u003d python2.7"},{"line_number":53,"context_line":"usedevelop \u003d True"},{"line_number":54,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1a6eadb0_47ac79a0","line":51,"updated":"2016-12-13 21:13:33.000000000","message":"Well, it seems that the modification is not related to the bug report, right ? Anyway, I\u0027m fine tho.","commit_id":"a2d7ebd39b99db9c5728e2a256568b8bbbc4734f"}]}
