)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"0e00d02566d4246cccd6c422af434e5e88aa530d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The os-start/stop API tests of unexpected status are"},{"line_number":10,"context_line":"not covered enough in tests."},{"line_number":11,"context_line":"Add this for negative functional test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c44ae737ad39bc58dd3ebfd554176d6400fd9fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_16198979","line":12,"updated":"2016-10-13 13:37:00.000000000","message":"maybe some bug/wishlist?","commit_id":"d096fa7485ffc94944ca31f656b360a7d6c21dc8"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"2235f4ddacd24d3337716d003311c0794fa6e9f1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The os-start/stop API tests of unexpected status are"},{"line_number":10,"context_line":"not covered enough in tests."},{"line_number":11,"context_line":"Add this for negative functional test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c44ae737ad39bc58dd3ebfd554176d6400fd9fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_0e0bd47d","line":12,"in_reply_to":"fa6399be_16198979","updated":"2016-10-17 04:22:39.000000000","message":"I don\u0027t create a bug ticket because this patch is not bug but improvement of tests.","commit_id":"d096fa7485ffc94944ca31f656b360a7d6c21dc8"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"30181428c755cf1363c1b5c030d394f2e7f45f19","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # Start server in ACTIVE"},{"line_number":519,"context_line":"        post \u003d {\u0027os-start\u0027: {}}"},{"line_number":520,"context_line":"        self.assertRaises(client.OpenStackApiException,"},{"line_number":521,"context_line":"                          self.api.post_server_action, created_server_id, post)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        # Stop server"},{"line_number":524,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_b9eea61f","line":521,"range":{"start_line":520,"start_character":0,"end_line":521,"end_character":79},"updated":"2016-10-17 11:52:14.000000000","message":"The response status code(409) should be checked like line 627.","commit_id":"d096fa7485ffc94944ca31f656b360a7d6c21dc8"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"8dc19527de1cdc801c34010cd649a6e9d3d5255f","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # Start server in ACTIVE"},{"line_number":519,"context_line":"        post \u003d {\u0027os-start\u0027: {}}"},{"line_number":520,"context_line":"        self.assertRaises(client.OpenStackApiException,"},{"line_number":521,"context_line":"                          self.api.post_server_action, created_server_id, post)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        # Stop server"},{"line_number":524,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_94f503cd","line":521,"range":{"start_line":520,"start_character":0,"end_line":521,"end_character":79},"in_reply_to":"fa6399be_b9eea61f","updated":"2016-10-18 06:25:05.000000000","message":"Done","commit_id":"d096fa7485ffc94944ca31f656b360a7d6c21dc8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"30181428c755cf1363c1b5c030d394f2e7f45f19","unresolved":false,"context_lines":[{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        # Stop server in SHUTOFF"},{"line_number":530,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"},{"line_number":531,"context_line":"        self.assertRaises(client.OpenStackApiException,"},{"line_number":532,"context_line":"                          self.api.post_server_action, created_server_id, post)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # Cleanup"},{"line_number":535,"context_line":"        self._delete_server(created_server_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_19e07228","line":532,"range":{"start_line":531,"start_character":0,"end_line":532,"end_character":79},"updated":"2016-10-17 11:52:14.000000000","message":"ditto","commit_id":"d096fa7485ffc94944ca31f656b360a7d6c21dc8"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"8dc19527de1cdc801c34010cd649a6e9d3d5255f","unresolved":false,"context_lines":[{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        # Stop server in SHUTOFF"},{"line_number":530,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"},{"line_number":531,"context_line":"        self.assertRaises(client.OpenStackApiException,"},{"line_number":532,"context_line":"                          self.api.post_server_action, created_server_id, post)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # Cleanup"},{"line_number":535,"context_line":"        self._delete_server(created_server_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_b40207b3","line":532,"range":{"start_line":531,"start_character":0,"end_line":532,"end_character":79},"in_reply_to":"fa6399be_19e07228","updated":"2016-10-18 06:25:05.000000000","message":"Done","commit_id":"d096fa7485ffc94944ca31f656b360a7d6c21dc8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"30181428c755cf1363c1b5c030d394f2e7f45f19","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        with self.assertRaisesRegex(client.OpenStackApiException,"},{"line_number":625,"context_line":"                                    \".*Unexpected status code.*\") as cm:"},{"line_number":626,"context_line":"            self._create_server(True, desc)"},{"line_number":627,"context_line":"        self.assertEqual(400, cm.exception.response.status_code)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    def _update_assertRaisesRegex(self, server_id, desc):"},{"line_number":630,"context_line":"        # Verifies that a 400 error is thrown on update server"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_39ad36e9","line":627,"range":{"start_line":627,"start_character":8,"end_line":627,"end_character":64},"updated":"2016-10-17 11:52:14.000000000","message":"Here","commit_id":"d096fa7485ffc94944ca31f656b360a7d6c21dc8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"81bdc0725088c3466add22fcd9011c8547084e6a","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # Start server in ACTIVE"},{"line_number":519,"context_line":"        post \u003d {\u0027os-start\u0027: {}}"},{"line_number":520,"context_line":"        server \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":521,"context_line":"                                   self.api.post_server_action,"},{"line_number":522,"context_line":"                                   created_server_id, post)"},{"line_number":523,"context_line":"        self.assertEqual(409, server.response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_f90b8129","line":520,"range":{"start_line":520,"start_character":8,"end_line":520,"end_character":14},"updated":"2016-10-18 16:09:32.000000000","message":"IMO, this variable\u0027s name is not appropriate.\nIt is an instance of OpenStackApiException.\nSo change it to \u0027ex\u0027 or \u0027exception\u0027 or something...","commit_id":"ec6a2b8dd2700588a03188c9e6e2a77de250b90f"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"ad47e0a3a771cc290e221f53e316b7d6bd38634a","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # Start server in ACTIVE"},{"line_number":519,"context_line":"        post \u003d {\u0027os-start\u0027: {}}"},{"line_number":520,"context_line":"        server \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":521,"context_line":"                                   self.api.post_server_action,"},{"line_number":522,"context_line":"                                   created_server_id, post)"},{"line_number":523,"context_line":"        self.assertEqual(409, server.response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_6cf6bcfa","line":520,"range":{"start_line":520,"start_character":8,"end_line":520,"end_character":14},"in_reply_to":"fa6399be_f90b8129","updated":"2016-10-19 02:31:58.000000000","message":"Done","commit_id":"ec6a2b8dd2700588a03188c9e6e2a77de250b90f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"81bdc0725088c3466add22fcd9011c8547084e6a","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        # Stop server in SHUTOFF"},{"line_number":532,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"},{"line_number":533,"context_line":"        server \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":534,"context_line":"                                   self.api.post_server_action,"},{"line_number":535,"context_line":"                                   created_server_id, post)"},{"line_number":536,"context_line":"        self.assertEqual(409, server.response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_cb0d0039","line":533,"range":{"start_line":533,"start_character":8,"end_line":533,"end_character":14},"updated":"2016-10-18 16:09:32.000000000","message":"ditto","commit_id":"ec6a2b8dd2700588a03188c9e6e2a77de250b90f"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"ad47e0a3a771cc290e221f53e316b7d6bd38634a","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        # Stop server in SHUTOFF"},{"line_number":532,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"},{"line_number":533,"context_line":"        server \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":534,"context_line":"                                   self.api.post_server_action,"},{"line_number":535,"context_line":"                                   created_server_id, post)"},{"line_number":536,"context_line":"        self.assertEqual(409, server.response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_8cddd072","line":533,"range":{"start_line":533,"start_character":8,"end_line":533,"end_character":14},"in_reply_to":"fa6399be_cb0d0039","updated":"2016-10-19 02:31:58.000000000","message":"Done","commit_id":"ec6a2b8dd2700588a03188c9e6e2a77de250b90f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0644091f31da709a00209324fff7040cc6f74c71","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        # Cleanup"},{"line_number":507,"context_line":"        self._delete_server(created_server_id)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_stop_start_servers_negative(self):"},{"line_number":510,"context_line":"        # Create server"},{"line_number":511,"context_line":"        server \u003d self._build_minimal_create_server_request()"},{"line_number":512,"context_line":"        created_server \u003d self.api.post_server({\"server\": server})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_fa054514","line":509,"range":{"start_line":509,"start_character":8,"end_line":509,"end_character":40},"updated":"2016-11-21 18:56:17.000000000","message":"There is a lot of negative test patterns as you know.\nSo this test name doesn\u0027t seem to explain what negative test here. It would be nice to contain the meaning like \"_negative_409\" or something.","commit_id":"ded6d0af91590682b3ef0c3195c9cb181facd4e7"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"2c178351a40c49c6d8135e9728cb8d8e2ae3ecc8","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        # Cleanup"},{"line_number":507,"context_line":"        self._delete_server(created_server_id)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_stop_start_servers_negative(self):"},{"line_number":510,"context_line":"        # Create server"},{"line_number":511,"context_line":"        server \u003d self._build_minimal_create_server_request()"},{"line_number":512,"context_line":"        created_server \u003d self.api.post_server({\"server\": server})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_ff826a51","line":509,"range":{"start_line":509,"start_character":8,"end_line":509,"end_character":40},"in_reply_to":"7a77a97e_fa054514","updated":"2016-11-24 11:18:56.000000000","message":"Done","commit_id":"ded6d0af91590682b3ef0c3195c9cb181facd4e7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0644091f31da709a00209324fff7040cc6f74c71","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        found_server \u003d self._wait_for_state_change(created_server, \u0027BUILD\u0027)"},{"line_number":516,"context_line":"        self.assertEqual(\u0027ACTIVE\u0027, found_server[\u0027status\u0027])"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # Start server in ACTIVE"},{"line_number":519,"context_line":"        post \u003d {\u0027os-start\u0027: {}}"},{"line_number":520,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":521,"context_line":"                               self.api.post_server_action,"},{"line_number":522,"context_line":"                               created_server_id, post)"},{"line_number":523,"context_line":"        self.assertEqual(409, ex.response.status_code)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Stop server"},{"line_number":526,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_3d5df7ec","line":523,"range":{"start_line":518,"start_character":0,"end_line":523,"end_character":54},"updated":"2016-11-21 18:56:17.000000000","message":"TBH, I am not sure what negative test here..\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1124\n\nAs the above link, 409 cases are exception.InstanceNotReady, exception.InstanceIsLocked and exception.InstanceInvalidState.\nHowever, this server seems valid status and the server doesn\u0027t seem to fit these exception cases..\nWhat case do you want to test?\n\nI feel it is nice to describe it as NOTE on the code for long-term maintenance.","commit_id":"ded6d0af91590682b3ef0c3195c9cb181facd4e7"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"2c178351a40c49c6d8135e9728cb8d8e2ae3ecc8","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        found_server \u003d self._wait_for_state_change(created_server, \u0027BUILD\u0027)"},{"line_number":516,"context_line":"        self.assertEqual(\u0027ACTIVE\u0027, found_server[\u0027status\u0027])"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # Start server in ACTIVE"},{"line_number":519,"context_line":"        post \u003d {\u0027os-start\u0027: {}}"},{"line_number":520,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":521,"context_line":"                               self.api.post_server_action,"},{"line_number":522,"context_line":"                               created_server_id, post)"},{"line_number":523,"context_line":"        self.assertEqual(409, ex.response.status_code)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Stop server"},{"line_number":526,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_ceec192c","line":523,"range":{"start_line":518,"start_character":0,"end_line":523,"end_character":54},"in_reply_to":"7a77a97e_3d5df7ec","updated":"2016-11-24 11:18:56.000000000","message":"http://developer.openstack.org/api-ref/compute/?expanded\u003dstart-server-os-start-action-detail\n\nAs this API\u0027s preconditions, the server status must be SHUTOFF. \nBecause the tests of SHUTOFF server not exist now, I added this test. I added a NOTE about necessity of this test.","commit_id":"ded6d0af91590682b3ef0c3195c9cb181facd4e7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0644091f31da709a00209324fff7040cc6f74c71","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                               created_server_id, post)"},{"line_number":523,"context_line":"        self.assertEqual(409, ex.response.status_code)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Stop server"},{"line_number":526,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"},{"line_number":527,"context_line":"        self.api.post_server_action(created_server_id, post)"},{"line_number":528,"context_line":"        found_server \u003d self._wait_for_state_change(found_server, \u0027ACTIVE\u0027)"},{"line_number":529,"context_line":"        self.assertEqual(\u0027SHUTOFF\u0027, found_server[\u0027status\u0027])"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        # Stop server in SHUTOFF"},{"line_number":532,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_9d5c4bef","line":529,"range":{"start_line":525,"start_character":0,"end_line":529,"end_character":59},"updated":"2016-11-21 18:56:17.000000000","message":"ditto","commit_id":"ded6d0af91590682b3ef0c3195c9cb181facd4e7"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"2c178351a40c49c6d8135e9728cb8d8e2ae3ecc8","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                               created_server_id, post)"},{"line_number":523,"context_line":"        self.assertEqual(409, ex.response.status_code)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Stop server"},{"line_number":526,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"},{"line_number":527,"context_line":"        self.api.post_server_action(created_server_id, post)"},{"line_number":528,"context_line":"        found_server \u003d self._wait_for_state_change(found_server, \u0027ACTIVE\u0027)"},{"line_number":529,"context_line":"        self.assertEqual(\u0027SHUTOFF\u0027, found_server[\u0027status\u0027])"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        # Stop server in SHUTOFF"},{"line_number":532,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_0ece11b4","line":529,"range":{"start_line":525,"start_character":0,"end_line":529,"end_character":59},"in_reply_to":"7a77a97e_9d5c4bef","updated":"2016-11-24 11:18:56.000000000","message":"I added a NOTE.","commit_id":"ded6d0af91590682b3ef0c3195c9cb181facd4e7"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"49b31dc7b8771a414c9c9cff09d065ad8dcab17b","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        # Cleanup"},{"line_number":507,"context_line":"        self._delete_server(created_server_id)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_stop_start_servers_negative_409(self):"},{"line_number":510,"context_line":"        # Create server"},{"line_number":511,"context_line":"        server \u003d self._build_minimal_create_server_request()"},{"line_number":512,"context_line":"        created_server \u003d self.api.post_server({\"server\": server})"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_aa8412d4","line":509,"range":{"start_line":509,"start_character":41,"end_line":509,"end_character":44},"updated":"2016-11-24 22:32:49.000000000","message":"IMO, \u0027invalid_state\u0027 or \u0027invalid_server_state\u0027 would be better.","commit_id":"ef2064fd3c850bc22bf933e840e04f696c159256"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"f1e43c03cd3263f65248d3f6b2deddb51360ecd3","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        # Cleanup"},{"line_number":507,"context_line":"        self._delete_server(created_server_id)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_stop_start_servers_negative_409(self):"},{"line_number":510,"context_line":"        # Create server"},{"line_number":511,"context_line":"        server \u003d self._build_minimal_create_server_request()"},{"line_number":512,"context_line":"        created_server \u003d self.api.post_server({\"server\": server})"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_b4196224","line":509,"range":{"start_line":509,"start_character":41,"end_line":509,"end_character":44},"in_reply_to":"5a74a57a_aa8412d4","updated":"2016-11-29 05:34:10.000000000","message":"Done","commit_id":"ef2064fd3c850bc22bf933e840e04f696c159256"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72d4a03e19ba2f699b6e4e3012b7ec6668f55456","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        # NOTE(mkoshiya): When os-start API runs, the server status"},{"line_number":520,"context_line":"        # must be SHUTOFF."},{"line_number":521,"context_line":"        # By returning 409, I want to confirm that the ACTIVE server does not"},{"line_number":522,"context_line":"        # cause unexpected behavior such as rebooting."},{"line_number":523,"context_line":"        post \u003d {\u0027os-start\u0027: {}}"},{"line_number":524,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":525,"context_line":"                               self.api.post_server_action,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_8f93e04e","line":522,"range":{"start_line":522,"start_character":10,"end_line":522,"end_character":54},"updated":"2016-11-25 05:55:45.000000000","message":"but we did not confirm that right?","commit_id":"ef2064fd3c850bc22bf933e840e04f696c159256"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"f1e43c03cd3263f65248d3f6b2deddb51360ecd3","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        # NOTE(mkoshiya): When os-start API runs, the server status"},{"line_number":520,"context_line":"        # must be SHUTOFF."},{"line_number":521,"context_line":"        # By returning 409, I want to confirm that the ACTIVE server does not"},{"line_number":522,"context_line":"        # cause unexpected behavior such as rebooting."},{"line_number":523,"context_line":"        post \u003d {\u0027os-start\u0027: {}}"},{"line_number":524,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":525,"context_line":"                               self.api.post_server_action,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_b4c7a262","line":522,"range":{"start_line":522,"start_character":10,"end_line":522,"end_character":54},"in_reply_to":"5a74a57a_8f93e04e","updated":"2016-11-29 05:34:10.000000000","message":"I deleted it.","commit_id":"ef2064fd3c850bc22bf933e840e04f696c159256"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72d4a03e19ba2f699b6e4e3012b7ec6668f55456","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":525,"context_line":"                               self.api.post_server_action,"},{"line_number":526,"context_line":"                               created_server_id, post)"},{"line_number":527,"context_line":"        self.assertEqual(409, ex.response.status_code)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        # Stop server"},{"line_number":530,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_2faf2c82","line":527,"range":{"start_line":527,"start_character":53,"end_line":527,"end_character":54},"updated":"2016-11-25 05:55:45.000000000","message":"may be good to check server status also.\nself.assertEqual(\u0027ACTIVE\u0027, found_server[\u0027status\u0027])","commit_id":"ef2064fd3c850bc22bf933e840e04f696c159256"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"f1e43c03cd3263f65248d3f6b2deddb51360ecd3","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":525,"context_line":"                               self.api.post_server_action,"},{"line_number":526,"context_line":"                               created_server_id, post)"},{"line_number":527,"context_line":"        self.assertEqual(409, ex.response.status_code)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        # Stop server"},{"line_number":530,"context_line":"        post \u003d {\u0027os-stop\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_94e5460a","line":527,"range":{"start_line":527,"start_character":53,"end_line":527,"end_character":54},"in_reply_to":"5a74a57a_2faf2c82","updated":"2016-11-29 05:34:10.000000000","message":"Done","commit_id":"ef2064fd3c850bc22bf933e840e04f696c159256"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72d4a03e19ba2f699b6e4e3012b7ec6668f55456","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":542,"context_line":"                               self.api.post_server_action,"},{"line_number":543,"context_line":"                               created_server_id, post)"},{"line_number":544,"context_line":"        self.assertEqual(409, ex.response.status_code)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        # Cleanup"},{"line_number":547,"context_line":"        self._delete_server(created_server_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_8fba00bf","line":544,"range":{"start_line":544,"start_character":53,"end_line":544,"end_character":54},"updated":"2016-11-25 05:55:45.000000000","message":"ditto","commit_id":"ef2064fd3c850bc22bf933e840e04f696c159256"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"f1e43c03cd3263f65248d3f6b2deddb51360ecd3","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        ex \u003d self.assertRaises(client.OpenStackApiException,"},{"line_number":542,"context_line":"                               self.api.post_server_action,"},{"line_number":543,"context_line":"                               created_server_id, post)"},{"line_number":544,"context_line":"        self.assertEqual(409, ex.response.status_code)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        # Cleanup"},{"line_number":547,"context_line":"        self._delete_server(created_server_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_14c0564f","line":544,"range":{"start_line":544,"start_character":53,"end_line":544,"end_character":54},"in_reply_to":"5a74a57a_8fba00bf","updated":"2016-11-29 05:34:10.000000000","message":"Done","commit_id":"ef2064fd3c850bc22bf933e840e04f696c159256"}]}