)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7374d2b4b60e350660bd2606c37fa67af7420ec0","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    RESET \u003d \"reset\""},{"line_number":389,"context_line":"    DISABLED \u003d \"disabled\""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    ALL \u003d (NONE, PAUSE, POWEROFF, RESET, DISABLED)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class MonitorMetricType(BaseNovaEnum):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8a878911","line":391,"range":{"start_line":391,"start_character":11,"end_line":391,"end_character":17},"updated":"2016-10-18 14:16:32.000000000","message":"Can we remove \u0027NONE\u0027?","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4f1264c0d23b45f69de06a453400fd60ff705009","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    RESET \u003d \"reset\""},{"line_number":389,"context_line":"    DISABLED \u003d \"disabled\""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    ALL \u003d (NONE, PAUSE, POWEROFF, RESET, DISABLED)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class MonitorMetricType(BaseNovaEnum):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_994df09b","line":391,"range":{"start_line":391,"start_character":11,"end_line":391,"end_character":17},"in_reply_to":"fa6399be_79b65cdd","updated":"2016-10-19 16:06:00.000000000","message":"Also see:\n\nhttp://docs.openstack.org/cli-reference/glance-property-keys.html\n\nhttps://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Virtualization_Administration_Guide/section-libvirt-dom-xml-watchdog.html\n\nI\u0027m not sure how useful \u0027none\u0027 is, but it\u0027s a supported thing.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a1f1114c3b8a3b649a0c4a34659184cb3437c202","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    RESET \u003d \"reset\""},{"line_number":389,"context_line":"    DISABLED \u003d \"disabled\""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    ALL \u003d (NONE, PAUSE, POWEROFF, RESET, DISABLED)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class MonitorMetricType(BaseNovaEnum):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_79b65cdd","line":391,"range":{"start_line":391,"start_character":11,"end_line":391,"end_character":17},"in_reply_to":"fa6399be_8a878911","updated":"2016-10-19 15:58:31.000000000","message":"No, why? Anyone that has set hw_watchdog_action\u003dnone in their image meta would fail to boot an instance using that image if we removed the enum for \u0027none\u0027.\n\nIt\u0027s also defined in the metadef in glance:\n\nhttps://github.com/openstack/glance/blob/master/etc/metadefs/compute-watchdog.json#L29","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"}],"nova/objects/image_meta.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b284792c54ab59e7c7193922fec400a748cdebec","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":174,"context_line":"        if target_version \u003c (1, 16) and \u0027hw_watchdog_action\u0027 in primitive:"},{"line_number":175,"context_line":"            # Check to see if hw_watchdog_action was set to \u0027disabled\u0027 and if"},{"line_number":176,"context_line":"            # so, remove it since not specifying it is the same behavior."},{"line_number":177,"context_line":"            if primitive[\u0027hw_watchdog_action\u0027] \u003d\u003d \\"},{"line_number":178,"context_line":"                    fields.WatchdogAction.DISABLED:"},{"line_number":179,"context_line":"                primitive.pop(\u0027hw_watchdog_action\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_86cd3233","line":176,"updated":"2016-10-14 14:34:07.000000000","message":"Yes also if a host is running an older version that is going to fail when deserialize.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"325376f9dec1a1ade1f0b95294c2eb1ed1debd86","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":174,"context_line":"        if target_version \u003c (1, 16) and \u0027hw_watchdog_action\u0027 in primitive:"},{"line_number":175,"context_line":"            # Check to see if hw_watchdog_action was set to \u0027disabled\u0027 and if"},{"line_number":176,"context_line":"            # so, remove it since not specifying it is the same behavior."},{"line_number":177,"context_line":"            if primitive[\u0027hw_watchdog_action\u0027] \u003d\u003d \\"},{"line_number":178,"context_line":"                    fields.WatchdogAction.DISABLED:"},{"line_number":179,"context_line":"                primitive.pop(\u0027hw_watchdog_action\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_0cc94359","line":176,"in_reply_to":"fa6399be_86cd3233","updated":"2016-10-14 15:06:44.000000000","message":"But hw_watchdog_action existed before 1.16, but the \u0027disabled\u0027 enum didn\u0027t, so that\u0027s why we specific check that value.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"}],"nova/tests/unit/objects/test_image_meta.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"badb9aed01ad2ff241c39764c2ee994c69092a45","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            \u0027os_secure_boot\u0027: \u0027required\u0027,"},{"line_number":296,"context_line":"            \u0027hw_rescue_bus\u0027: \u0027ide\u0027,"},{"line_number":297,"context_line":"            \u0027hw_rescue_device\u0027: \u0027disk\u0027,"},{"line_number":298,"context_line":"            \u0027hw_watchdog_action\u0027: fields.WatchdogAction.DISABLED,"},{"line_number":299,"context_line":"        }"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        obj \u003d objects.ImageMetaProps(**props)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8788cc72","line":298,"updated":"2016-10-14 15:19:11.000000000","message":"This tests the case that hw_watchdog_action\u003d\u0027disabled\u0027.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"badb9aed01ad2ff241c39764c2ee994c69092a45","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        }"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        obj \u003d objects.ImageMetaProps(**props)"},{"line_number":302,"context_line":"        primitive \u003d obj.obj_to_primitive(\u00271.0\u0027)"},{"line_number":303,"context_line":"        self.assertFalse(any([x in primitive[\u0027nova_object.data\u0027]"},{"line_number":304,"context_line":"                              for x in props]))"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_07959c85","line":302,"updated":"2016-10-14 15:19:11.000000000","message":"We compat to 1.0, so \u003c1.16.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"badb9aed01ad2ff241c39764c2ee994c69092a45","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        obj \u003d objects.ImageMetaProps(**props)"},{"line_number":302,"context_line":"        primitive \u003d obj.obj_to_primitive(\u00271.0\u0027)"},{"line_number":303,"context_line":"        self.assertFalse(any([x in primitive[\u0027nova_object.data\u0027]"},{"line_number":304,"context_line":"                              for x in props]))"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        for bus in (\u0027lxc\u0027, \u0027uml\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_478b1468","line":303,"updated":"2016-10-14 15:19:11.000000000","message":"This tests that we popped hw_watchdog_action.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b284792c54ab59e7c7193922fec400a748cdebec","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            self.assertRaises(exception.ObjectActionError,"},{"line_number":309,"context_line":"                              obj.obj_to_primitive, \u00271.0\u0027)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test_obj_make_compatible_watchdog_action_not_disabled(self):"},{"line_number":312,"context_line":"        \"\"\"Tests that we don\u0027t pop the hw_watchdog_action if the value is not"},{"line_number":313,"context_line":"        \u0027disabled\u0027."},{"line_number":314,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_e6618e06","line":311,"updated":"2016-10-14 14:34:07.000000000","message":"Hum this test is little strange, no? I would expect to see one which asserts having that attribute set with DISABLED is going to be removed on a version \u003c 16.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"325376f9dec1a1ade1f0b95294c2eb1ed1debd86","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            self.assertRaises(exception.ObjectActionError,"},{"line_number":309,"context_line":"                              obj.obj_to_primitive, \u00271.0\u0027)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test_obj_make_compatible_watchdog_action_not_disabled(self):"},{"line_number":312,"context_line":"        \"\"\"Tests that we don\u0027t pop the hw_watchdog_action if the value is not"},{"line_number":313,"context_line":"        \u0027disabled\u0027."},{"line_number":314,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_2cad2788","line":311,"in_reply_to":"fa6399be_0caea3e5","updated":"2016-10-14 15:06:44.000000000","message":"The compat method only removes the hw_watchdog_action if the value is \u0027disabled\u0027 because before 1.16 we can\u0027t handle \u0027disabled\u0027 as it\u0027s not in the enum list. We can handle \u0027pause\u0027 though, so that\u0027s what\u0027s tested here. Removing hw_watchdog_action\u003d\u0027disabled\u0027 is fine since that\u0027s the default behavior in the libvirt driver anyway.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2fbbde22536575a026bccd3377cba4fbb7412d5d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            self.assertRaises(exception.ObjectActionError,"},{"line_number":309,"context_line":"                              obj.obj_to_primitive, \u00271.0\u0027)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test_obj_make_compatible_watchdog_action_not_disabled(self):"},{"line_number":312,"context_line":"        \"\"\"Tests that we don\u0027t pop the hw_watchdog_action if the value is not"},{"line_number":313,"context_line":"        \u0027disabled\u0027."},{"line_number":314,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_0caea3e5","line":311,"in_reply_to":"fa6399be_61bf2861","updated":"2016-10-14 15:03:24.000000000","message":"May be it\u0027s me but I do not understand very well why the test is testing whether the attribute is still in primitive where the condition added is to remove it in some circumstances\n\n I expected something like:\n\n      obj \u003d objects.ImageMetaProps(\n            hw_watchdog_action\u003dfields.WatchdogAction.DISABLED)\n      primitive \u003d obj.obj_to_primitive(\u00271.0\u0027)\n      self.assertNotIn(\u0027hw_watchdog_action\u0027, primitive[\u0027nova_object.data\u0027])\n\nno ?","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"424ce571b7dcb4da78d89ee0531cf8d2114a55f7","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            self.assertRaises(exception.ObjectActionError,"},{"line_number":309,"context_line":"                              obj.obj_to_primitive, \u00271.0\u0027)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test_obj_make_compatible_watchdog_action_not_disabled(self):"},{"line_number":312,"context_line":"        \"\"\"Tests that we don\u0027t pop the hw_watchdog_action if the value is not"},{"line_number":313,"context_line":"        \u0027disabled\u0027."},{"line_number":314,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_61bf2861","line":311,"in_reply_to":"fa6399be_e6618e06","updated":"2016-10-14 14:53:19.000000000","message":"That\u0027s exactly what the test above does.","commit_id":"3fc3919768fe073aaca4c52485684ca001221488"}]}