)]}'
{"nova/notifications/objects/instance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bb62069d71d3d37b6f6415cc77441e8e14aed876","unresolved":false,"context_lines":[{"line_number":291,"context_line":"# @base.notification_sample(\u0027instance-remove_fixed_ip-end.json\u0027)"},{"line_number":292,"context_line":"# @base.notification_sample(\u0027instance-resize_confirm-start.json\u0027)"},{"line_number":293,"context_line":"# @base.notification_sample(\u0027instance-resize_confirm-end.json\u0027)"},{"line_number":294,"context_line":"# @base.notification_sample(\u0027instance-resize_prep-start.json\u0027)"},{"line_number":295,"context_line":"# @base.notification_sample(\u0027instance-resize_revert-start.json\u0027)"},{"line_number":296,"context_line":"# @base.notification_sample(\u0027instance-resize_revert-end.json\u0027)"},{"line_number":297,"context_line":"# @base.notification_sample(\u0027instance-shelve_offload-start.json\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_82e005fc","line":294,"updated":"2016-10-20 02:28:31.000000000","message":"\u0027instance-resize_prep-end.json\u0027 should be added.","commit_id":"9aa68f24622db8e61d2ca4322121d3238f78e6c0"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"5b64c7206054e5fcf954060106c2677cb108d1f0","unresolved":false,"context_lines":[{"line_number":291,"context_line":"# @base.notification_sample(\u0027instance-remove_fixed_ip-end.json\u0027)"},{"line_number":292,"context_line":"# @base.notification_sample(\u0027instance-resize_confirm-start.json\u0027)"},{"line_number":293,"context_line":"# @base.notification_sample(\u0027instance-resize_confirm-end.json\u0027)"},{"line_number":294,"context_line":"# @base.notification_sample(\u0027instance-resize_prep-start.json\u0027)"},{"line_number":295,"context_line":"# @base.notification_sample(\u0027instance-resize_revert-start.json\u0027)"},{"line_number":296,"context_line":"# @base.notification_sample(\u0027instance-resize_revert-end.json\u0027)"},{"line_number":297,"context_line":"# @base.notification_sample(\u0027instance-shelve_offload-start.json\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_3ba83577","line":294,"in_reply_to":"fa6399be_82e005fc","updated":"2016-10-20 13:47:11.000000000","message":"I think this is not added as the current resize.prep also contains extra usage information [1], which is not handled in InstanceActionNotification. If we want to keep this extra usage information, we need to add an extended notification (implemented at [2]). So instance-resize_prep-end should be added to the extended notification, if we want to keep extra usage information.\n\n[1]: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3707\n[2]: https://review.openstack.org/#/c/384621/","commit_id":"9aa68f24622db8e61d2ca4322121d3238f78e6c0"}]}