)]}'
{"nova/tests/api/test_auth.py":[{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"7d90f3a17bc19c4084fe6891aee2b41420dd4d9c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                return webob.Response(status\u003d_(\"200 No Roles\"))"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                raise Exception(context.roles)"},{"line_number":84,"context_line":"                raise webob.exc.HTTPBadRequest(_(\"unexpected role header\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        self.middleware \u003d nova.api.auth.NovaKeystoneContext(role_check_app)"},{"line_number":87,"context_line":"        self.request \u003d webob.Request.blank(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fo6U%3D","side":"PARENT","line":84,"updated":"2013-07-26 01:16:27.000000000","message":"Which exception is meant to be thrown here? It seems the second one is more specific.","commit_id":"73397e7c2010eb44e4b8fed8ba5400ca9ed537e4"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"71d17bf5b8b8b3cf2cefb833e84196c69fb5d933","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                return webob.Response(status\u003d_(\"200 No Roles\"))"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                raise Exception(context.roles)"},{"line_number":84,"context_line":"                raise webob.exc.HTTPBadRequest(_(\"unexpected role header\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        self.middleware \u003d nova.api.auth.NovaKeystoneContext(role_check_app)"},{"line_number":87,"context_line":"        self.request \u003d webob.Request.blank(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fnpk%3D","side":"PARENT","line":84,"in_reply_to":"AAAAQn%2F%2Fo6U%3D","updated":"2013-07-26 11:48:42.000000000","message":"Done","commit_id":"73397e7c2010eb44e4b8fed8ba5400ca9ed537e4"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"54082c924e1e118b09103f319a16e2e621dd0167","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                return webob.Response(status\u003d_(\"200 No Roles\"))"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                raise Exception(context.roles)"},{"line_number":84,"context_line":"                raise webob.exc.HTTPBadRequest(_(\"unexpected role header\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        self.middleware \u003d nova.api.auth.NovaKeystoneContext(role_check_app)"},{"line_number":87,"context_line":"        self.request \u003d webob.Request.blank(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FoHQ%3D","side":"PARENT","line":84,"in_reply_to":"AAAAQn%2F%2Fo6U%3D","updated":"2013-07-26 08:07:56.000000000","message":"Well it\u0027s a test - and afaict - the else branch is never hit.","commit_id":"73397e7c2010eb44e4b8fed8ba5400ca9ed537e4"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"30ca0250eeaf9a74a8493e51e2e47e3603b1be23","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                return webob.Response(status\u003d_(\"200 No Roles\"))"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                raise Exception(context.roles)"},{"line_number":84,"context_line":"                raise webob.exc.HTTPBadRequest(_(\"unexpected role header\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        self.middleware \u003d nova.api.auth.NovaKeystoneContext(role_check_app)"},{"line_number":87,"context_line":"        self.request \u003d webob.Request.blank(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FoFA%3D","side":"PARENT","line":84,"in_reply_to":"AAAAQn%2F%2FoHQ%3D","updated":"2013-07-26 08:31:30.000000000","message":"Sure - but we can only raise one of the two exceptions.  If the BadRequest is wanted, then the previous Exception must be removed.","commit_id":"73397e7c2010eb44e4b8fed8ba5400ca9ed537e4"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c44e59da403a3c5ef6fc1633ce33bd53bb801b14","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            elif context.roles \u003d\u003d [\u0027\u0027]:"},{"line_number":81,"context_line":"                return webob.Response(status\u003d_(\"200 No Roles\"))"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                raise Exception(context.roles)"},{"line_number":84,"context_line":"                raise webob.exc.HTTPBadRequest(_(\"unexpected role header\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        self.middleware \u003d nova.api.auth.NovaKeystoneContext(role_check_app)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fg9E%3D","side":"PARENT","line":83,"updated":"2013-07-30 00:06:31.000000000","message":"How did this one get by before?  Is this part of the code untested?","commit_id":"84b730b70f362f195728f50361ab54513efefe66"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"205bf1058e4bc4203a75185692391da28be2f562","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            elif context.roles \u003d\u003d [\u0027\u0027]:"},{"line_number":82,"context_line":"                return webob.Response(status\u003d_(\"200 No Roles\"))"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                raise Exception(context.roles)"},{"line_number":85,"context_line":"                raise webob.exc.HTTPBadRequest(_(\"unexpected role header\"))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.middleware \u003d nova.api.auth.NovaKeystoneContext(role_check_app)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fd1E%3D","side":"PARENT","line":84,"updated":"2013-07-30 18:23:29.000000000","message":"Question still stands for this one.  How did this not get noticed before?    As this one changes behavior?","commit_id":"70311221ef0ce172a49ecb4b5cfe5208371bf986"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"21b8c5554ad2dd1bbc41115417a0c9256d09ec34","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            elif context.roles \u003d\u003d [\u0027\u0027]:"},{"line_number":82,"context_line":"                return webob.Response(status\u003d_(\"200 No Roles\"))"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                raise Exception(context.roles)"},{"line_number":85,"context_line":"                raise webob.exc.HTTPBadRequest(_(\"unexpected role header\"))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.middleware \u003d nova.api.auth.NovaKeystoneContext(role_check_app)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fc7w%3D","side":"PARENT","line":84,"in_reply_to":"AAAAQn%2F%2Fd1E%3D","updated":"2013-07-31 00:00:02.000000000","message":"I have no idea :)","commit_id":"70311221ef0ce172a49ecb4b5cfe5208371bf986"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"7a653ccfb13e609fe94a269d5215413ca2f1144c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            elif context.roles \u003d\u003d [\u0027\u0027]:"},{"line_number":82,"context_line":"                return webob.Response(status\u003d_(\"200 No Roles\"))"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                raise Exception(context.roles)"},{"line_number":85,"context_line":"                raise webob.exc.HTTPBadRequest(_(\"unexpected role header\"))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.middleware \u003d nova.api.auth.NovaKeystoneContext(role_check_app)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fbtk%3D","side":"PARENT","line":84,"in_reply_to":"AAAAQn%2F%2Fd1E%3D","updated":"2013-07-31 09:32:26.000000000","message":"If you look at the rest of the tests - you will see that else branch never gets hit. You can remove it completely afaict.","commit_id":"70311221ef0ce172a49ecb4b5cfe5208371bf986"}]}