)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"a8b61d9452e940e1bad5c2f717e9b2acb7d9c9fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix qemu-img convert image incompatability in alpine linux"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alpine linux runs qemu-img version, where you cannot put"},{"line_number":10,"context_line":"parameter for convert \"-f qcow2\" in the end of the line,"},{"line_number":11,"context_line":"because it expects location. Parameter must be included"},{"line_number":12,"context_line":"before source and destination."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a629dbe_78a682c2","line":9,"updated":"2016-11-08 12:15:23.000000000","message":"For posterity\u0027s sake, might want to explicitly spell out the version number, too.","commit_id":"ce257366438e09ed8e6be53f01ee00552fa94da3"}],"nova/tests/unit/virt/libvirt/test_utils.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"72ebd14e4b475515ef335666436a3f482532d7ff","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        self.executes \u003d []"},{"line_number":651,"context_line":"        expected_commands \u003d [(\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, \u0027raw\u0027,"},{"line_number":652,"context_line":"                              \u0027-f\u0027, \u0027qcow2\u0027,"},{"line_number":653,"context_line":"                              \u0027t.qcow2.part\u0027, \u0027t.qcow2.converted\u0027)"},{"line_number":654,"context_line":"                             (\u0027rm\u0027, \u0027t.qcow2.part\u0027),"},{"line_number":655,"context_line":"                             (\u0027mv\u0027, \u0027t.qcow2.converted\u0027, \u0027t.qcow2\u0027)]"},{"line_number":656,"context_line":"        images.fetch_to_raw(context, image_id, target)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_abe1d69c","line":653,"updated":"2016-10-17 18:46:25.000000000","message":"you missed a comma here","commit_id":"13462c3d459b2b973453a9f8460c3d35b36d712f"},{"author":{"_account_id":20194,"name":"Jakub Pavlik","email":"pavlk.jakub@gmail.com","username":"pupapaik"},"change_message_id":"5d88c794c1981fd6ca3ea9edca7bc9d2eb9d995e","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        self.executes \u003d []"},{"line_number":651,"context_line":"        expected_commands \u003d [(\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, \u0027raw\u0027,"},{"line_number":652,"context_line":"                              \u0027-f\u0027, \u0027qcow2\u0027,"},{"line_number":653,"context_line":"                              \u0027t.qcow2.part\u0027, \u0027t.qcow2.converted\u0027)"},{"line_number":654,"context_line":"                             (\u0027rm\u0027, \u0027t.qcow2.part\u0027),"},{"line_number":655,"context_line":"                             (\u0027mv\u0027, \u0027t.qcow2.converted\u0027, \u0027t.qcow2\u0027)]"},{"line_number":656,"context_line":"        images.fetch_to_raw(context, image_id, target)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_0878058f","line":653,"in_reply_to":"fa6399be_abe1d69c","updated":"2016-10-17 19:22:17.000000000","message":"Oh, thanks","commit_id":"13462c3d459b2b973453a9f8460c3d35b36d712f"}],"nova/virt/images.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"bb107b4a0f75c6dc7efd19a15b56eccf408192d4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"def _convert_image(source, dest, in_format, out_format, run_as_root):"},{"line_number":99,"context_line":"    cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format, source, dest)"},{"line_number":100,"context_line":"    if in_format is not None:"},{"line_number":101,"context_line":"        cmd \u003d cmd[:-2] + (\u0027-f\u0027, in_format) + cmd[-2:]"},{"line_number":102,"context_line":"    try:"},{"line_number":103,"context_line":"        utils.execute(*cmd, run_as_root\u003drun_as_root)"},{"line_number":104,"context_line":"    except processutils.ProcessExecutionError as exp:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_b1884bc8","line":101,"updated":"2016-10-18 12:23:45.000000000","message":"Perhaps something like:\n\n  if in_format is not None:\n      cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-f\u0027 in_format, \u0027-O\u0027, out_format, source, dest)\n  else:\n      cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format, source, dest)\n\nor\n\n   cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format)\n   if in_format is not None:\n       cmd \u003d cmd + (\u0027-f\u0027, in_format)\n   cmd \u003d cmd + (source, dest)\n\n\nwould be a bit more clear","commit_id":"3b94501f683b6452690b088a15aaff2eabff0289"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cdb099810893e5a7fab51a5feccd223b1f1910e4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"def _convert_image(source, dest, in_format, out_format, run_as_root):"},{"line_number":99,"context_line":"    cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format, source, dest)"},{"line_number":100,"context_line":"    if in_format is not None:"},{"line_number":101,"context_line":"        cmd \u003d cmd[:-2] + (\u0027-f\u0027, in_format) + cmd[-2:]"},{"line_number":102,"context_line":"    try:"},{"line_number":103,"context_line":"        utils.execute(*cmd, run_as_root\u003drun_as_root)"},{"line_number":104,"context_line":"    except processutils.ProcessExecutionError as exp:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_422abb7f","line":101,"in_reply_to":"fa6399be_b1884bc8","updated":"2016-10-18 13:04:47.000000000","message":"+1 - this could be more readable that this","commit_id":"3b94501f683b6452690b088a15aaff2eabff0289"}]}