)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3aa7e3fd421e9581f64c44a35a6ea41b7825f27e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Discrete Device Assignment is a new feature in Windows Server 2016,"},{"line_number":10,"context_line":"offering users the possibility of taking some of the PCI Express"},{"line_number":11,"context_line":"devices in their systems and pass them through directly to a guest VM."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I75a76768ce6b9e042b3c85ed9ec8391ed947b51b"},{"line_number":14,"context_line":"Partially-Implements: blueprint hyper-v-pci-passthrough"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_614bda87","line":12,"updated":"2016-10-20 14:42:48.000000000","message":"You should have a DocImpact tag in here for documenting this feature here:\n\nhttp://docs.openstack.org/admin-guide/compute-pci-passthrough.html","commit_id":"91141701d8afc3ad48d3f2ab1a340d39581b665e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3aa7e3fd421e9581f64c44a35a6ea41b7825f27e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"devices in their systems and pass them through directly to a guest VM."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I75a76768ce6b9e042b3c85ed9ec8391ed947b51b"},{"line_number":14,"context_line":"Partially-Implements: blueprint hyper-v-pci-passthrough"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_21fac243","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2016-10-20 14:42:48.000000000","message":"Are there more changes coming for this? If not, this should just be \u0027Implements blueprint hyper-v-pci-passthrough\u0027.","commit_id":"91141701d8afc3ad48d3f2ab1a340d39581b665e"}],"nova/virt/hyperv/hostops.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9a9a5430add0a92e363a9671c0dcfb7e66d57b33","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                   [(arch.I686, hv_type.HYPERV, vm_mode.HVM),"},{"line_number":163,"context_line":"                    (arch.X86_64, hv_type.HYPERV, vm_mode.HVM)],"},{"line_number":164,"context_line":"               \u0027numa_topology\u0027: None,"},{"line_number":165,"context_line":"               \u0027pci_passthrough_devices\u0027: pci_passthrough_devices,"},{"line_number":166,"context_line":"               }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        gpu_info \u003d self._get_remotefx_gpu_info()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_2e59518f","line":165,"updated":"2016-10-17 20:38:16.000000000","message":"you can just have:\n\n    \u0027pci_passthrough_devices\u0027: self._get_pci_passthrough_devices(),","commit_id":"91141701d8afc3ad48d3f2ab1a340d39581b665e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9a9a5430add0a92e363a9671c0dcfb7e66d57b33","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    def _get_pci_dev_info(self, pci_device):"},{"line_number":196,"context_line":"        dev_id \u003d pci_device.DeviceID"},{"line_number":197,"context_line":"        vendor_id \u003d str(re.findall( \u0027VEN_(.*)\u0026DEV\u0027, dev_id)[0])"},{"line_number":198,"context_line":"        product_id \u003d  str(re.findall( \u0027DEV_(.*)\u0026SUBSYS\u0027, dev_id)[0])"},{"line_number":199,"context_line":"        address \u003d pci_device.LocationPath"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        pci_dev_info \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8e1c1d15","line":198,"updated":"2016-10-17 20:38:16.000000000","message":"this can be done inside os-win.","commit_id":"91141701d8afc3ad48d3f2ab1a340d39581b665e"}],"nova/virt/hyperv/vmops.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9a9a5430add0a92e363a9671c0dcfb7e66d57b33","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                                                             network_info)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"                self.attach_config_drive(instance, configdrive_path, vm_gen)"},{"line_number":306,"context_line":"                self.assign_discrete_devices(instance)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"            self.power_on(instance)"},{"line_number":309,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8ed7bdbe","line":306,"updated":"2016-10-17 20:38:16.000000000","message":"unindent, this isn\u0027t necessary only if the instance requires configdrive.\n\nalso, do this in create_instance, as create_instance is used in cold resize as well.","commit_id":"91141701d8afc3ad48d3f2ab1a340d39581b665e"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"98b682dcc55c24d18013e7d80fd4bbf9d8360a8f","unresolved":false,"context_lines":[{"line_number":975,"context_line":"        discrete_device_locations \u003d flavor.extra_specs.get(\"pci_passthrough:alias\")"},{"line_number":976,"context_line":"        if discrete_device_locations:"},{"line_number":977,"context_line":"            self._vmutils.set_vm_automatic_shutdownaction(instance.name)"},{"line_number":978,"context_line":"            device_locations \u003d discrete_device_locations.split(\",\")"},{"line_number":979,"context_line":"            for device_location in device_locations:"},{"line_number":980,"context_line":"                self._vmutils.add_pci_passthrough(instance.name,"},{"line_number":981,"context_line":"                                                  device_location)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_bd86f9d8","line":978,"updated":"2016-11-01 18:36:36.000000000","message":"Are you putting device information directly in the flavor ?  It seems to me like the configuration is not consistent with other PCI devices for other hypervisors.\n\nSee how the pci_alias is used: https://github.com/openstack/nova/blob/master/nova/pci/request.py#L129\n\nYou can also refer to the guide: http://docs.openstack.org/admin-guide/compute-pci-passthrough.html","commit_id":"91141701d8afc3ad48d3f2ab1a340d39581b665e"}]}