)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd671dcdd91d4e40661476d87a06957c8e2830aa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should set return_value\u003d1 for compareCPU hook."},{"line_number":10,"context_line":"Otherwise we\u0027ll get an error:"},{"line_number":11,"context_line":"nova.exception.InvalidCPUInfo: Unacceptable CPU info: CPU doesn\u0027t have compatibility."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id9313eb46084e60cf0c7f5a77fe9a8a7dc86b8fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_7cc4983f","line":11,"range":{"start_line":11,"start_character":1,"end_line":11,"end_character":85},"updated":"2016-10-19 12:32:25.000000000","message":"This needs to be wrapped. Maybe indent it too?","commit_id":"b21c81bc536ded114d06b38f09a832e8555a654f"},{"author":{"_account_id":15847,"name":"Mikhail Feoktistov","email":"mfeoktistov@virtuozzo.com","username":"mfeoktistov"},"change_message_id":"8686144372c0119c29b866083188d0ad6e912d59","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should set return_value\u003d1 for compareCPU hook."},{"line_number":10,"context_line":"Otherwise we\u0027ll get an error:"},{"line_number":11,"context_line":"nova.exception.InvalidCPUInfo: Unacceptable CPU info: CPU doesn\u0027t have compatibility."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id9313eb46084e60cf0c7f5a77fe9a8a7dc86b8fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_8474ae9c","line":11,"range":{"start_line":11,"start_character":1,"end_line":11,"end_character":85},"in_reply_to":"fa6399be_7cc4983f","updated":"2016-10-19 13:05:22.000000000","message":"I agree, thank you!","commit_id":"b21c81bc536ded114d06b38f09a832e8555a654f"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd671dcdd91d4e40661476d87a06957c8e2830aa","unresolved":false,"context_lines":[{"line_number":6828,"context_line":"        self.flags(vncserver_listen\u003d\u0027192.0.2.12\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":6829,"context_line":"        self.flags(server_listen\u003d\u0027198.51.100.34\u0027, group\u003d\u0027spice\u0027)"},{"line_number":6830,"context_line":"        self.flags(proxyclient_address\u003d\u0027203.0.113.56\u0027, group\u003d\u0027serial_console\u0027)"},{"line_number":6831,"context_line":"        mock_cpu.return_value \u003d 1"},{"line_number":6832,"context_line":""},{"line_number":6833,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":6834,"context_line":"        instance_ref.vcpu_model \u003d test_vcpu_model.fake_vcpumodel"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_1cb39cea","line":6831,"range":{"start_line":6831,"start_character":0,"end_line":6831,"end_character":33},"updated":"2016-10-19 12:32:25.000000000","message":"you can set this as via the decorator instead:\n\n        @mock.patch.object(fakelibvirt.Connection, \u0027compareCPU\u0027,\n                           return_value\u003d1)","commit_id":"b21c81bc536ded114d06b38f09a832e8555a654f"},{"author":{"_account_id":15847,"name":"Mikhail Feoktistov","email":"mfeoktistov@virtuozzo.com","username":"mfeoktistov"},"change_message_id":"8686144372c0119c29b866083188d0ad6e912d59","unresolved":false,"context_lines":[{"line_number":6828,"context_line":"        self.flags(vncserver_listen\u003d\u0027192.0.2.12\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":6829,"context_line":"        self.flags(server_listen\u003d\u0027198.51.100.34\u0027, group\u003d\u0027spice\u0027)"},{"line_number":6830,"context_line":"        self.flags(proxyclient_address\u003d\u0027203.0.113.56\u0027, group\u003d\u0027serial_console\u0027)"},{"line_number":6831,"context_line":"        mock_cpu.return_value \u003d 1"},{"line_number":6832,"context_line":""},{"line_number":6833,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":6834,"context_line":"        instance_ref.vcpu_model \u003d test_vcpu_model.fake_vcpumodel"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_243682e7","line":6831,"range":{"start_line":6831,"start_character":0,"end_line":6831,"end_character":33},"in_reply_to":"fa6399be_1cb39cea","updated":"2016-10-19 13:05:22.000000000","message":"Yes, but all tests in this file which patch \"compareCPU\" set return value like \nmock_cpu.return_value \u003d 1\nSo I think it\u0027s better to use common style for this case.","commit_id":"b21c81bc536ded114d06b38f09a832e8555a654f"}]}
