)]}'
{"nova/virt/libvirt/volume/net.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be042cb94f030c4795adc0f3fc34f427f743293a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        auth_enabled \u003d netdisk_properties.get(\u0027auth_enabled\u0027)"},{"line_number":60,"context_line":"        if auth_enabled:"},{"line_number":61,"context_line":"            conf.auth_username \u003d netdisk_properties[\u0027auth_username\u0027]"},{"line_number":62,"context_line":"            conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":63,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":64,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":65,"context_line":"        elif CONF.libvirt.rbd_secret_uuid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_f13023a1","line":62,"range":{"start_line":62,"start_character":56,"end_line":62,"end_character":67},"updated":"2016-10-21 02:21:33.000000000","message":"The ceph job isn\u0027t setting this:\n\nhttp://logs.openstack.org/99/389399/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/9ef7a1b/logs/screen-n-cpu.txt.gz#_2016-10-21_00_55_46_487\n\nLooks like it\u0027s set in cinder.conf though:\n\nhttp://logs.openstack.org/99/389399/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/9ef7a1b/logs/etc/cinder/cinder.conf.txt.gz\n\nrbd_uuid \u003d 4fef2812-c785-4c21-af70-2ececf984cb7\n\nhttps://github.com/openstack/cinder/blob/51944602342bdf934268abc737fa4226d67207c0/cinder/volume/drivers/rbd.py#L836\n\nGah it\u0027s setting the wrong value....this is a bug in cinder or the ceph job.","commit_id":"6f64c2df2f789311c05e3dbbc0781775fae89e71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6cfb215d54bec2a1db9e06facb47c75f1e330584","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":63,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":64,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":65,"context_line":"        elif CONF.libvirt.rbd_secret_uuid:"},{"line_number":66,"context_line":"            # use the nova config values"},{"line_number":67,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":68,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":69,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":70,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _set_auth_config_iscsi(self, conf, netdisk_properties):"},{"line_number":73,"context_line":"        if netdisk_properties.get(\u0027auth_method\u0027) \u003d\u003d \u0027CHAP\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_d045d2b3","line":70,"range":{"start_line":65,"start_character":8,"end_line":70,"end_character":69},"updated":"2016-11-04 14:45:36.000000000","message":"Note: I\u0027m not entirely sure this is even valid to do. For example, if you\u0027re using different ceph backends for nova and cinder and the nova has auth setup but cinder doesn\u0027t, then I\u0027d think that configuring the connection with the nova values would break the cinder side.","commit_id":"d008492f85c65cde163a4bd4a284527378472f1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5a4423b06666fecb8ba86e1659d5fe9f92277187","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":63,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":64,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":65,"context_line":"        elif CONF.libvirt.rbd_secret_uuid:"},{"line_number":66,"context_line":"            # use the nova config values"},{"line_number":67,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":68,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":69,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":70,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _set_auth_config_iscsi(self, conf, netdisk_properties):"},{"line_number":73,"context_line":"        if netdisk_properties.get(\u0027auth_method\u0027) \u003d\u003d \u0027CHAP\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_9f6b6585","line":70,"range":{"start_line":65,"start_character":8,"end_line":70,"end_character":69},"in_reply_to":"ba5da102_643e082b","updated":"2016-11-04 16:07:09.000000000","message":"Alternatively we log a warning and continue doing this for ocata, and drop it in pike. That\u0027s a bit softer for an upgrade impact. I\u0027d still need a release note for the change in behavior about using ceph auth over nova.conf auth values.","commit_id":"d008492f85c65cde163a4bd4a284527378472f1a"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"dfa784cb1aa7c9c0fa514e8a309f0ed75c6404b5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":63,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":64,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":65,"context_line":"        elif CONF.libvirt.rbd_secret_uuid:"},{"line_number":66,"context_line":"            # use the nova config values"},{"line_number":67,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":68,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":69,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":70,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _set_auth_config_iscsi(self, conf, netdisk_properties):"},{"line_number":73,"context_line":"        if netdisk_properties.get(\u0027auth_method\u0027) \u003d\u003d \u0027CHAP\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_643e082b","line":70,"range":{"start_line":65,"start_character":8,"end_line":70,"end_character":69},"in_reply_to":"ba5da102_d045d2b3","updated":"2016-11-04 15:57:30.000000000","message":"I can\u0027t think of a *good* reason to keep this fallback behavior other then \"thats how we have always done it\".\n\nI vote we just remove the fallback and add a release note indicating the change in behavior and explaining how to properly configure auth on the cinder side.","commit_id":"d008492f85c65cde163a4bd4a284527378472f1a"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"af32aaac55cd4b06c982e3264544ca6dcf6407f6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":78,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":79,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":80,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _set_auth_config_iscsi(self, conf, netdisk_properties):"},{"line_number":83,"context_line":"        if netdisk_properties.get(\u0027auth_method\u0027) \u003d\u003d \u0027CHAP\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_669eef08","line":80,"updated":"2016-11-22 03:21:35.000000000","message":"This line located in both \u0027if\u0027 and \u0027elif\u0027 branch. Should it be not located in condition branch?  Move it after line 62?","commit_id":"b713ee24546291b51ff124f90b26de0aa9a6f2d2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"352a7ff0aa967c066f60ae3a26702686f838b788","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":78,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":79,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":80,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _set_auth_config_iscsi(self, conf, netdisk_properties):"},{"line_number":83,"context_line":"        if netdisk_properties.get(\u0027auth_method\u0027) \u003d\u003d \u0027CHAP\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_0c11f4af","line":80,"in_reply_to":"5a74a57a_70b600fa","updated":"2016-11-30 02:24:42.000000000","message":"There is a subtle difference here, which is we might do nothing in this method if auth_enabled is False and CONF.libvirt.rbd_secret_uuid is None, in that case nothing should be set. So moving it out was wrong.","commit_id":"b713ee24546291b51ff124f90b26de0aa9a6f2d2"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"41dd635583b5cb8e81c2a57bdab48eb46154f48a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":78,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":79,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":80,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _set_auth_config_iscsi(self, conf, netdisk_properties):"},{"line_number":83,"context_line":"        if netdisk_properties.get(\u0027auth_method\u0027) \u003d\u003d \u0027CHAP\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_70b600fa","line":80,"in_reply_to":"7a77a97e_669eef08","updated":"2016-11-28 22:14:44.000000000","message":"Agreed, but its minor.","commit_id":"b713ee24546291b51ff124f90b26de0aa9a6f2d2"}]}