)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c87ee198b2fcb20fdd7cb03c8c809015563b5f3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Configures cinder to use ceph and executes tempest"},{"line_number":10,"context_line":"tests against environment"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Ifcd11ac4dbf3d77fda2ff2fd39026c629f731073"},{"line_number":13,"context_line":"Change-Id: I2ae262cfcb974bbd3dda0fa428a75821facac45a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"9a629dbe_77925af7","line":12,"updated":"2016-11-12 01:56:32.000000000","message":"This is a do not merge tempest patch, so it\u0027s not going to land, is the nova change here a DNM / WIP patch too?","commit_id":"84509f1aa0478533aea1a20f1c4827bb66464e22"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"24ffc339712745905450b29e950047787003cfa2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Configures cinder to use ceph and executes tempest"},{"line_number":10,"context_line":"tests against environment"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Ifcd11ac4dbf3d77fda2ff2fd39026c629f731073"},{"line_number":13,"context_line":"Change-Id: I2ae262cfcb974bbd3dda0fa428a75821facac45a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"9a629dbe_75e151fe","line":12,"in_reply_to":"9a629dbe_77925af7","updated":"2016-11-14 12:09:51.000000000","message":"I\u0027ve updated this tempest patch, so it could be merged too.","commit_id":"84509f1aa0478533aea1a20f1c4827bb66464e22"}],"nova/tests/live_migration/hooks/ceph.sh":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"74ed0d5f28dcbe1b4b80367102f387f10e909e9f","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"function _wait_for_cinder {"},{"line_number":289,"context_line":"    for i in $(seq 1 3); do"},{"line_number":290,"context_line":"        cinder list"},{"line_number":291,"context_line":"        code\u003d$?"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_1b0a02d3","line":288,"updated":"2016-10-27 09:35:17.000000000","message":"We should probably try to generalise this to retry a given command for N number of times with timeout of T between each attempt. I remember we had something like this in TripleO, but it was like 2 years ago, so I can\u0027t find it right now :(","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1a870ab938dd63aec1ce0387e0975784a953ef2b","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"function _wait_for_cinder {"},{"line_number":289,"context_line":"    for i in $(seq 1 3); do"},{"line_number":290,"context_line":"        cinder list"},{"line_number":291,"context_line":"        code\u003d$?"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_ce960394","line":288,"in_reply_to":"ba5da102_1b0a02d3","updated":"2016-10-27 13:05:14.000000000","message":"Done","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"74ed0d5f28dcbe1b4b80367102f387f10e909e9f","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    echo \u0027DEBUG: changing cinder config:\u0027"},{"line_number":327,"context_line":"    _ceph_configure_cinder"},{"line_number":328,"context_line":"    echo \u0027DEBUG: list of cinder-related processes:\u0027"},{"line_number":329,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep cinder\""},{"line_number":330,"context_line":"    echo \u0027DEBUG: stopping c-vol\u0027"},{"line_number":331,"context_line":"    stop \u0027all\u0027 \u0027c-vol\u0027"},{"line_number":332,"context_line":"    echo \u0027DEBUG: stopping c-api\u0027"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_7b6dbe31","line":329,"updated":"2016-10-27 09:35:17.000000000","message":"nit: we could do\n\n  $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m command -a \"pgrep -a cinder\"\n\ninstead. That might be my personal preference, but I think it\u0027s more clear and that will also exclude the grep process itself from the list","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1a870ab938dd63aec1ce0387e0975784a953ef2b","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    echo \u0027DEBUG: changing cinder config:\u0027"},{"line_number":327,"context_line":"    _ceph_configure_cinder"},{"line_number":328,"context_line":"    echo \u0027DEBUG: list of cinder-related processes:\u0027"},{"line_number":329,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep cinder\""},{"line_number":330,"context_line":"    echo \u0027DEBUG: stopping c-vol\u0027"},{"line_number":331,"context_line":"    stop \u0027all\u0027 \u0027c-vol\u0027"},{"line_number":332,"context_line":"    echo \u0027DEBUG: stopping c-api\u0027"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_63527015","line":329,"in_reply_to":"ba5da102_7b6dbe31","updated":"2016-10-27 13:05:14.000000000","message":"Done","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"74ed0d5f28dcbe1b4b80367102f387f10e909e9f","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    echo \u0027DEBUG: stopping c-api\u0027"},{"line_number":333,"context_line":"    stop \u0027primary\u0027 \u0027c-api\u0027"},{"line_number":334,"context_line":"    echo \u0027DEBUG: list of processes after stop\u0027"},{"line_number":335,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep cinder\""},{"line_number":336,"context_line":"    echo \u0027DEBUG: starting c-api\u0027"},{"line_number":337,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh c-api \u0027/usr/local/bin/cinder-api --config-file\u003d/etc/cinder/cinder.conf\u0027\""},{"line_number":338,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_9b6a9219","line":335,"updated":"2016-10-27 09:35:17.000000000","message":"nit: ditto","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1a870ab938dd63aec1ce0387e0975784a953ef2b","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    echo \u0027DEBUG: stopping c-api\u0027"},{"line_number":333,"context_line":"    stop \u0027primary\u0027 \u0027c-api\u0027"},{"line_number":334,"context_line":"    echo \u0027DEBUG: list of processes after stop\u0027"},{"line_number":335,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep cinder\""},{"line_number":336,"context_line":"    echo \u0027DEBUG: starting c-api\u0027"},{"line_number":337,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh c-api \u0027/usr/local/bin/cinder-api --config-file\u003d/etc/cinder/cinder.conf\u0027\""},{"line_number":338,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_83578401","line":335,"in_reply_to":"ba5da102_9b6a9219","updated":"2016-10-27 13:05:14.000000000","message":"Done","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"74ed0d5f28dcbe1b4b80367102f387f10e909e9f","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    echo \u0027DEBUG: starting c-vol locally\u0027"},{"line_number":340,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh c-vol \u0027/usr/local/bin/cinder-volume --config-file /etc/cinder/cinder.conf\u0027\""},{"line_number":341,"context_line":"    echo \u0027DEBUG: starting cinder-vol on subnodes\u0027"},{"line_number":342,"context_line":"    for SUBNODE in $SUBNODES ; do"},{"line_number":343,"context_line":"        ssh $SUBNODE \"sudo -H -u $STACK_USER bash -c \u0027/tmp/start_process.sh c-vol \\\"/usr/local/bin/cinder-volume --config-file /etc/cinder/cinder.conf\\\"\u0027\""},{"line_number":344,"context_line":"    done"},{"line_number":345,"context_line":"    echo \u0027DEBUG: listing processes after restart\u0027"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_5ba47a56","line":342,"updated":"2016-10-27 09:35:17.000000000","message":"Hmm, why not use ansible for this?\n\nAnd, if it\u0027s just RBD that we are interested in, do we really need to run cinder-volume on other nodes at all? AFAIU, in in this case cinder-volume does not do anything on a node itself -  it merely proxies requests to ceph-mon. E.g. Fuel deploys cinder-volume\u0027s on controller nodes, if RBD driver is used for volumes.\n\nAm I missing something?","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1a870ab938dd63aec1ce0387e0975784a953ef2b","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    echo \u0027DEBUG: starting c-vol locally\u0027"},{"line_number":340,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh c-vol \u0027/usr/local/bin/cinder-volume --config-file /etc/cinder/cinder.conf\u0027\""},{"line_number":341,"context_line":"    echo \u0027DEBUG: starting cinder-vol on subnodes\u0027"},{"line_number":342,"context_line":"    for SUBNODE in $SUBNODES ; do"},{"line_number":343,"context_line":"        ssh $SUBNODE \"sudo -H -u $STACK_USER bash -c \u0027/tmp/start_process.sh c-vol \\\"/usr/local/bin/cinder-volume --config-file /etc/cinder/cinder.conf\\\"\u0027\""},{"line_number":344,"context_line":"    done"},{"line_number":345,"context_line":"    echo \u0027DEBUG: listing processes after restart\u0027"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_0391b499","line":342,"in_reply_to":"ba5da102_5ba47a56","updated":"2016-10-27 13:05:14.000000000","message":"there is an issue in Ansible running background process that way, I tried that approach on previous attempt, it doesn\u0027t work.\nWe need to update config of existing c-vol services that run on both nodes here.","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"74ed0d5f28dcbe1b4b80367102f387f10e909e9f","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        ssh $SUBNODE \"sudo -H -u $STACK_USER bash -c \u0027/tmp/start_process.sh c-vol \\\"/usr/local/bin/cinder-volume --config-file /etc/cinder/cinder.conf\\\"\u0027\""},{"line_number":344,"context_line":"    done"},{"line_number":345,"context_line":"    echo \u0027DEBUG: listing processes after restart\u0027"},{"line_number":346,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep cinder\""},{"line_number":347,"context_line":"    source $BASE/new/devstack/openrc"},{"line_number":348,"context_line":"    export OS_USERNAME\u003dadmin"},{"line_number":349,"context_line":"    export OS_PROJECT_NAME\u003dadmin"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_db740aff","line":346,"updated":"2016-10-27 09:35:17.000000000","message":"nit: ditto","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1a870ab938dd63aec1ce0387e0975784a953ef2b","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        ssh $SUBNODE \"sudo -H -u $STACK_USER bash -c \u0027/tmp/start_process.sh c-vol \\\"/usr/local/bin/cinder-volume --config-file /etc/cinder/cinder.conf\\\"\u0027\""},{"line_number":344,"context_line":"    done"},{"line_number":345,"context_line":"    echo \u0027DEBUG: listing processes after restart\u0027"},{"line_number":346,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep cinder\""},{"line_number":347,"context_line":"    source $BASE/new/devstack/openrc"},{"line_number":348,"context_line":"    export OS_USERNAME\u003dadmin"},{"line_number":349,"context_line":"    export OS_PROJECT_NAME\u003dadmin"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_43e9ec19","line":346,"in_reply_to":"ba5da102_db740aff","updated":"2016-10-27 13:05:14.000000000","message":"Done","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"74ed0d5f28dcbe1b4b80367102f387f10e909e9f","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    source $BASE/new/devstack/openrc"},{"line_number":348,"context_line":"    export OS_USERNAME\u003dadmin"},{"line_number":349,"context_line":"    export OS_PROJECT_NAME\u003dadmin"},{"line_number":350,"context_line":"    echo \u0027waitng for cinder to become available\u0027"},{"line_number":351,"context_line":"    set +e"},{"line_number":352,"context_line":"    _wait_for_cinder"},{"line_number":353,"context_line":"    set -e"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_7613135d","line":350,"range":{"start_line":350,"start_character":10,"end_line":350,"end_character":16},"updated":"2016-10-27 09:35:17.000000000","message":"typo: waiting","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1a870ab938dd63aec1ce0387e0975784a953ef2b","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    source $BASE/new/devstack/openrc"},{"line_number":348,"context_line":"    export OS_USERNAME\u003dadmin"},{"line_number":349,"context_line":"    export OS_PROJECT_NAME\u003dadmin"},{"line_number":350,"context_line":"    echo \u0027waitng for cinder to become available\u0027"},{"line_number":351,"context_line":"    set +e"},{"line_number":352,"context_line":"    _wait_for_cinder"},{"line_number":353,"context_line":"    set -e"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_c8b0bb8e","line":350,"range":{"start_line":350,"start_character":10,"end_line":350,"end_character":16},"in_reply_to":"ba5da102_7613135d","updated":"2016-10-27 13:05:14.000000000","message":"Done","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"74ed0d5f28dcbe1b4b80367102f387f10e909e9f","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    export OS_USERNAME\u003dadmin"},{"line_number":349,"context_line":"    export OS_PROJECT_NAME\u003dadmin"},{"line_number":350,"context_line":"    echo \u0027waitng for cinder to become available\u0027"},{"line_number":351,"context_line":"    set +e"},{"line_number":352,"context_line":"    _wait_for_cinder"},{"line_number":353,"context_line":"    set -e"},{"line_number":354,"context_line":"    lvm_type\u003d$(cinder type-list | awk -F \"|\"  \u0027NR\u003d\u003d4{ print $2}\u0027)"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_bbaaf617","line":351,"updated":"2016-10-27 09:35:17.000000000","message":"Do we really need to temporarily disable it? If it\u0027s about \"cinder list\" returning a non-zero code, than maybe just do something like:\n\n  cinder list || retcode\u003d$?\n\ninstead?","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1a870ab938dd63aec1ce0387e0975784a953ef2b","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    export OS_USERNAME\u003dadmin"},{"line_number":349,"context_line":"    export OS_PROJECT_NAME\u003dadmin"},{"line_number":350,"context_line":"    echo \u0027waitng for cinder to become available\u0027"},{"line_number":351,"context_line":"    set +e"},{"line_number":352,"context_line":"    _wait_for_cinder"},{"line_number":353,"context_line":"    set -e"},{"line_number":354,"context_line":"    lvm_type\u003d$(cinder type-list | awk -F \"|\"  \u0027NR\u003d\u003d4{ print $2}\u0027)"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ba5da102_eeaca7ef","line":351,"in_reply_to":"ba5da102_bbaaf617","updated":"2016-10-27 13:05:14.000000000","message":"moved generic version of this method to utils.sh, no need to set +-e now","commit_id":"d85905ed4a5d16d0eea46643afd76de0c94ddd05"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"8a0c8f6d1f87a86399831d57e820dae1cb16016b","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh c-vol \u0027/usr/local/bin/cinder-volume --config-file /etc/cinder/cinder.conf\u0027\""},{"line_number":315,"context_line":"    source $BASE/new/devstack/openrc"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    export OS_USERNAME\u003dadmin"},{"line_number":318,"context_line":"    export OS_PROJECT_NAME\u003dadmin"},{"line_number":319,"context_line":"    lvm_type\u003d$(cinder type-list | awk -F \"|\"  \u0027NR\u003d\u003d4{ print $2}\u0027)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ba5da102_5157ef01","side":"PARENT","line":316,"updated":"2016-10-27 15:07:08.000000000","message":"nit: unrelated change","commit_id":"0024b33f697079ace72432ee9d34a982aeff3c50"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"b30930bafc49ab3dfbead3ff43782c5c2a31d17c","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh c-vol \u0027/usr/local/bin/cinder-volume --config-file /etc/cinder/cinder.conf\u0027\""},{"line_number":315,"context_line":"    source $BASE/new/devstack/openrc"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    export OS_USERNAME\u003dadmin"},{"line_number":318,"context_line":"    export OS_PROJECT_NAME\u003dadmin"},{"line_number":319,"context_line":"    lvm_type\u003d$(cinder type-list | awk -F \"|\"  \u0027NR\u003d\u003d4{ print $2}\u0027)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ba5da102_d1813f91","side":"PARENT","line":316,"in_reply_to":"ba5da102_5157ef01","updated":"2016-10-27 15:24:04.000000000","message":"Done","commit_id":"0024b33f697079ace72432ee9d34a982aeff3c50"}],"nova/tests/live_migration/hooks/run_tests.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cc430c53ff4d762688550917e59a634270d4f419","unresolved":false,"context_lines":[{"line_number":46,"context_line":"configure_ceph_glance"},{"line_number":47,"context_line":"restart_glance"},{"line_number":48,"context_line":"configure_and_start_nova"},{"line_number":49,"context_line":"run_tempest \"Ceph nova\u0026glance test\" \"live_migration\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"echo \u00274. test with Ceph for volumes and root + ephemeral disk\u0027"},{"line_number":52,"context_line":"configure_and_start_cinder"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6895a0_5b947736","line":49,"updated":"2016-10-21 14:06:41.000000000","message":"Like #1 above, should we skip the volume-backed live migration tests when we\u0027re testing ceph + ephemeral?\n\n\"^.*test_live_migration(?!.*(test_volume_backed_live_migration))\"","commit_id":"40f2a5f38392409a2add90ce8272358ae0eaf0ff"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"3daa86d73c8d61164063b39bc6a97a17de24b90e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"configure_ceph_glance"},{"line_number":47,"context_line":"restart_glance"},{"line_number":48,"context_line":"configure_and_start_nova"},{"line_number":49,"context_line":"run_tempest \"Ceph nova\u0026glance test\" \"live_migration\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"echo \u00274. test with Ceph for volumes and root + ephemeral disk\u0027"},{"line_number":52,"context_line":"configure_and_start_cinder"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6895a0_fb49cbd1","line":49,"in_reply_to":"da6895a0_5b947736","updated":"2016-10-21 14:13:33.000000000","message":"I thnik we should, as we do not use ceph for volumes here","commit_id":"40f2a5f38392409a2add90ce8272358ae0eaf0ff"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"89ed264ba96d1e883699de55987f3b3c5029ef39","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"echo \u00274. test with Ceph for volumes and root + ephemeral disk\u0027"},{"line_number":52,"context_line":"configure_and_start_cinder"},{"line_number":53,"context_line":"run_tempest \"Ceph nova\u0026glance\u0026cinder test\" \"live_migration\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6895a0_db1de710","line":53,"updated":"2016-10-21 14:02:48.000000000","message":"This isn\u0027t running the volume-backed live migration tests:\n\nhttp://logs.openstack.org/46/389546/3/check/gate-grenade-dsvm-multinode-live-migration-nv/7fdbfb7/console.html#_2016-10-21_09_39_55_276750","commit_id":"40f2a5f38392409a2add90ce8272358ae0eaf0ff"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"3daa86d73c8d61164063b39bc6a97a17de24b90e","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"echo \u00274. test with Ceph for volumes and root + ephemeral disk\u0027"},{"line_number":52,"context_line":"configure_and_start_cinder"},{"line_number":53,"context_line":"run_tempest \"Ceph nova\u0026glance\u0026cinder test\" \"live_migration\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6895a0_db232704","line":53,"in_reply_to":"da6895a0_3b88a322","updated":"2016-10-21 14:13:33.000000000","message":"I\u0027ll  revert that patch and add depends-on to test all things","commit_id":"40f2a5f38392409a2add90ce8272358ae0eaf0ff"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f4143176c7fc70695c12de1cec05d2218f048566","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"echo \u00274. test with Ceph for volumes and root + ephemeral disk\u0027"},{"line_number":52,"context_line":"configure_and_start_cinder"},{"line_number":53,"context_line":"run_tempest \"Ceph nova\u0026glance\u0026cinder test\" \"live_migration\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6895a0_3b88a322","line":53,"in_reply_to":"da6895a0_db1de710","updated":"2016-10-21 14:05:21.000000000","message":"Ah because I disabled it globally:\n\nhttps://review.openstack.org/#/c/386967/","commit_id":"40f2a5f38392409a2add90ce8272358ae0eaf0ff"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"8a0c8f6d1f87a86399831d57e820dae1cb16016b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# 3. test with Ceph for root + ephemeral disks"},{"line_number":10,"context_line":"# 4. test with Ceph for volumes and root + ephemeral disk"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"set -ex"},{"line_number":13,"context_line":"cd $BASE/new/tempest"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source $BASE/new/devstack/functions"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ba5da102_b13e8bb6","line":12,"updated":"2016-10-27 15:07:08.000000000","message":"nit: unrelated change","commit_id":"ac652f0fc71553046e0b81b95fc39f22e8e2225c"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"b30930bafc49ab3dfbead3ff43782c5c2a31d17c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# 3. test with Ceph for root + ephemeral disks"},{"line_number":10,"context_line":"# 4. test with Ceph for volumes and root + ephemeral disk"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"set -ex"},{"line_number":13,"context_line":"cd $BASE/new/tempest"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source $BASE/new/devstack/functions"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ba5da102_f14643be","line":12,"in_reply_to":"ba5da102_b13e8bb6","updated":"2016-10-27 15:24:04.000000000","message":"Done","commit_id":"ac652f0fc71553046e0b81b95fc39f22e8e2225c"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"64735ec4ce823d4daa05574d4c56d0c2cc8dc6f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# 3. test with Ceph for root + ephemeral disks"},{"line_number":10,"context_line":"# 4. test with Ceph for volumes and root + ephemeral disk"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"set -xe"},{"line_number":13,"context_line":"cd $BASE/new/tempest"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source $BASE/new/devstack/functions"}],"source_content_type":"text/x-sh","patch_set":28,"id":"9a629dbe_d5577d24","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2016-11-14 12:22:20.000000000","message":"here it is:)","commit_id":"47478bec3ffb5cfdb157e9970afb49c705ffbb9b"},{"author":{"_account_id":24095,"name":"jeck","email":"xiexiaozhe@inspur.com","username":"jeckxie"},"change_message_id":"939164557bb693063f2322cb144a16985dc44f63","unresolved":false,"context_lines":[{"line_number":52,"context_line":"echo \u00274. test with Ceph for volumes and root + ephemeral disk\u0027"},{"line_number":53,"context_line":"configure_and_start_cinder"},{"line_number":54,"context_line":"run_tempest \"Ceph nova\u0026glance\u0026cinder test\" \"live_migration\""},{"line_number":55,"context_line":"set +e"}],"source_content_type":"text/x-sh","patch_set":28,"id":"9a629dbe_d5fbfd45","line":55,"range":{"start_line":55,"start_character":5,"end_line":55,"end_character":6},"updated":"2016-11-14 12:19:55.000000000","message":"don\u0027t need to set +e because no set -e is used","commit_id":"47478bec3ffb5cfdb157e9970afb49c705ffbb9b"}],"nova/tests/live_migration/hooks/utils.sh":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"8a0c8f6d1f87a86399831d57e820dae1cb16016b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        fi"},{"line_number":70,"context_line":"        sleep $timeout"},{"line_number":71,"context_line":"    done"},{"line_number":72,"context_line":"    die $LINENO \"Maximum of 3 retries reached. Failed to start c-api properly\""},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"function stop {"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ba5da102_d103ffb6","line":72,"updated":"2016-10-27 15:07:08.000000000","message":"This must not be about c-api in any way. I think you just forgot to clean it up when moving this function to utils.sh\n\nAnother suggestion would be to return the command error code on failure instead of exiting immediately, so that it\u0027s useful in different contexts. The call would then look like:\n\n  wait_for \"cinder list\" 3 3 || die $LINENO \"Maximum of 3 retries reached. Failed to start c-api properly\"","commit_id":"ac652f0fc71553046e0b81b95fc39f22e8e2225c"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"b30930bafc49ab3dfbead3ff43782c5c2a31d17c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        fi"},{"line_number":70,"context_line":"        sleep $timeout"},{"line_number":71,"context_line":"    done"},{"line_number":72,"context_line":"    die $LINENO \"Maximum of 3 retries reached. Failed to start c-api properly\""},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"function stop {"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ba5da102_713a3338","line":72,"in_reply_to":"ba5da102_d103ffb6","updated":"2016-10-27 15:24:04.000000000","message":"Done","commit_id":"ac652f0fc71553046e0b81b95fc39f22e8e2225c"}]}