)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9875642586d80335731a6d6f426f817a39da98a1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch resolves 2 TODOs from conf/console.py"},{"line_number":10,"context_line":"* all console options were moved to console group"},{"line_number":11,"context_line":"* public_hostname type changed from StrOpt to URIopt"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I154f18ab2943465db5e3e9fcee06f2a7269df898"},{"line_number":14,"context_line":"Implements: bp centralize-config-options-ocata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_75331ff7","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":52},"updated":"2016-11-04 11:11:55.000000000","message":"This is not valid still","commit_id":"61920ade54df90749be0b7b19f91f94a4fcff619"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1a9e379e652e42c151b1ef58d84f83a68353c6b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch resolves 2 TODOs from conf/console.py"},{"line_number":10,"context_line":"* all console options were moved to console group"},{"line_number":11,"context_line":"* public_hostname type changed from StrOpt to URIopt"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I154f18ab2943465db5e3e9fcee06f2a7269df898"},{"line_number":14,"context_line":"Implements: bp centralize-config-options-ocata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_56ec4f8f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":52},"in_reply_to":"ba5da102_75331ff7","updated":"2016-11-04 20:43:59.000000000","message":"+1","commit_id":"61920ade54df90749be0b7b19f91f94a4fcff619"}],"nova/cmd/console.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fec07c931b3b16f03472f1b9d9332b417a69a478","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-console\u0027,"},{"line_number":40,"context_line":"                                    topic\u003dCONF.console.topic)"},{"line_number":41,"context_line":"    service.serve(server)"},{"line_number":42,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_73cf807f","line":40,"range":{"start_line":40,"start_character":36,"end_line":40,"end_character":61},"updated":"2016-11-08 13:59:13.000000000","message":"This shouldn\u0027t change","commit_id":"a9ea95e2d4c1755e8c6534fceee8a5af2b90ba62"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"40b0bcbff859ed13ea053ae01c604f8374bd888b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-console\u0027,"},{"line_number":40,"context_line":"                                    topic\u003dCONF.console.topic)"},{"line_number":41,"context_line":"    service.serve(server)"},{"line_number":42,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_eebc876e","line":40,"range":{"start_line":40,"start_character":36,"end_line":40,"end_character":61},"in_reply_to":"9a629dbe_73cf807f","updated":"2016-11-08 14:24:17.000000000","message":"Oops. Thanks, I can\u0027t explain why I did change it.","commit_id":"a9ea95e2d4c1755e8c6534fceee8a5af2b90ba62"}],"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9875642586d80335731a6d6f426f817a39da98a1","unresolved":false,"context_lines":[{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        \"\"\""},{"line_number":1183,"context_line":"        # TODO(mdragon): perhaps make this variable by console_type?"},{"line_number":1184,"context_line":"        return \u0027%s.%s\u0027 % (CONF.console.topic, CONF.console_host)"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"    @wrap_exception()"},{"line_number":1187,"context_line":"    def get_console_pool_info(self, context, console_type):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_955ef310","line":1184,"range":{"start_line":1184,"start_character":51,"end_line":1184,"end_character":63},"updated":"2016-11-04 11:11:55.000000000","message":"I wonder should this be moved to the console group (it\u0027s currently in \u0027compute.py\u0027 and the DEFAULT group)","commit_id":"61920ade54df90749be0b7b19f91f94a4fcff619"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1a9e379e652e42c151b1ef58d84f83a68353c6b9","unresolved":false,"context_lines":[{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        \"\"\""},{"line_number":1183,"context_line":"        # TODO(mdragon): perhaps make this variable by console_type?"},{"line_number":1184,"context_line":"        return \u0027%s.%s\u0027 % (CONF.console.topic, CONF.console_host)"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"    @wrap_exception()"},{"line_number":1187,"context_line":"    def get_console_pool_info(self, context, console_type):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_36e7dbad","line":1184,"range":{"start_line":1184,"start_character":51,"end_line":1184,"end_character":63},"in_reply_to":"ba5da102_955ef310","updated":"2016-11-04 20:43:59.000000000","message":"I think that should be in a follow up patch.","commit_id":"61920ade54df90749be0b7b19f91f94a4fcff619"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fec07c931b3b16f03472f1b9d9332b417a69a478","unresolved":false,"context_lines":[{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        \"\"\""},{"line_number":1183,"context_line":"        # TODO(mdragon): perhaps make this variable by console_type?"},{"line_number":1184,"context_line":"        # TODO(macsz): move console_host config from default group in"},{"line_number":1185,"context_line":"        # compute options to console config group"},{"line_number":1186,"context_line":"        return \u0027%s.%s\u0027 % (CONF.console_topic, CONF.console_host)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_138c8434","line":1185,"range":{"start_line":1184,"start_character":0,"end_line":1185,"end_character":49},"updated":"2016-11-08 13:59:13.000000000","message":"nit: Can you put this TODO in the relevant \u0027nova/conf\u0027 file instead?","commit_id":"a9ea95e2d4c1755e8c6534fceee8a5af2b90ba62"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"40b0bcbff859ed13ea053ae01c604f8374bd888b","unresolved":false,"context_lines":[{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        \"\"\""},{"line_number":1183,"context_line":"        # TODO(mdragon): perhaps make this variable by console_type?"},{"line_number":1184,"context_line":"        # TODO(macsz): move console_host config from default group in"},{"line_number":1185,"context_line":"        # compute options to console config group"},{"line_number":1186,"context_line":"        return \u0027%s.%s\u0027 % (CONF.console_topic, CONF.console_host)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_2e3cbfe1","line":1185,"range":{"start_line":1184,"start_character":0,"end_line":1185,"end_character":49},"in_reply_to":"9a629dbe_138c8434","updated":"2016-11-08 14:24:17.000000000","message":"Done","commit_id":"a9ea95e2d4c1755e8c6534fceee8a5af2b90ba62"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6443c9c6e078d48b45c7b7a0cedf91d7e58c03f","unresolved":false,"context_lines":[{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        \"\"\""},{"line_number":1183,"context_line":"        # TODO(mdragon): perhaps make this variable by console_type?"},{"line_number":1184,"context_line":"        # TODO(macsz): move console_host config from default group in"},{"line_number":1185,"context_line":"        # compute options to console config group"},{"line_number":1186,"context_line":"        return \u0027%s.%s\u0027 % (CONF.console_topic, CONF.console_host)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_af0a5c1f","line":1185,"range":{"start_line":1184,"start_character":8,"end_line":1185,"end_character":49},"updated":"2016-11-25 05:23:33.000000000","message":"seems this is still todo as you are not moving console_host\n\nwhich is actually done in https://review.openstack.org/#/c/394934/","commit_id":"2c0fa5eccccb546f0958c6dae0ebd8c42cfb1c0d"}],"nova/conf/compute.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6443c9c6e078d48b45c7b7a0cedf91d7e58c03f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"compute_manager_opts \u003d ["},{"line_number":257,"context_line":"    # TODO(macsz): move console_host config from default group in"},{"line_number":258,"context_line":"    # compute options to console config group"},{"line_number":259,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":260,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":261,"context_line":"        sample_default\u003d\"socket.gethostname()\","}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_cf0dd838","line":258,"range":{"start_line":257,"start_character":0,"end_line":258,"end_character":45},"updated":"2016-11-25 05:23:33.000000000","message":"ditto","commit_id":"2c0fa5eccccb546f0958c6dae0ebd8c42cfb1c0d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2dd15d4c4dc1c82824488bb39ded79df436528ef","unresolved":false,"context_lines":[{"line_number":254,"context_line":"]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"compute_manager_opts \u003d ["},{"line_number":257,"context_line":"    # TODO(macsz): move console_host config from default group in"},{"line_number":258,"context_line":"    # compute options to console config group"},{"line_number":259,"context_line":"    cfg.StrOpt(\u0027console_host\u0027,"},{"line_number":260,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":261,"context_line":"        sample_default\u003d\"socket.gethostname()\","}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_4c78e88f","line":258,"range":{"start_line":257,"start_character":0,"end_line":258,"end_character":45},"in_reply_to":"5a74a57a_cf0dd838","updated":"2016-11-25 12:24:28.000000000","message":"So this could actually be different for every compute, it is really a compute option. I would not move myself.","commit_id":"2c0fa5eccccb546f0958c6dae0ebd8c42cfb1c0d"}],"nova/conf/console.py":[{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"87ac47ace0fec6ab729d73a01948c3c15be1d4a6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        default\u003d\u0027console\u0027,"},{"line_number":30,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":32,"context_line":"        deprecated_group\u003d\u0027console\u0027,"},{"line_number":33,"context_line":"        deprecated_name\u003d\u0027console_topic\u0027,"},{"line_number":34,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":35,"context_line":"There is no need to let users choose the RPC topic for all services - there"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_19fe4037","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":34},"updated":"2016-10-31 16:52:07.000000000","message":"Isn\u0027t deprecated_group\u003d\u0027default\u0027 here?","commit_id":"93d4863165c00891f363036cc201a7e817703767"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"65950208b8dd528006b39298689687932801149d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        default\u003d\u0027console\u0027,"},{"line_number":30,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":32,"context_line":"        deprecated_group\u003d\u0027console\u0027,"},{"line_number":33,"context_line":"        deprecated_name\u003d\u0027console_topic\u0027,"},{"line_number":34,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":35,"context_line":"There is no need to let users choose the RPC topic for all services - there"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_ba3610e5","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":34},"in_reply_to":"ba5da102_19fe4037","updated":"2016-11-01 11:34:21.000000000","message":"Oops, thanks!","commit_id":"93d4863165c00891f363036cc201a7e817703767"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d10f7248a50490bb671e64278132b9780836c72d","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* A string representing topic exchange name"},{"line_number":48,"context_line":"\"\"\"),"},{"line_number":49,"context_line":"    # TODO(pumaranikar): Move this config to stevedore plugin system."},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":51,"context_line":"        default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"},{"line_number":52,"context_line":"        deprecated_group\u003d\u0027console\u0027,"},{"line_number":53,"context_line":"        deprecated_name\u003d\u0027console_driver\u0027,"},{"line_number":54,"context_line":"        help\u003d\"\"\""},{"line_number":55,"context_line":"Nova-console proxy is used to set up multi-tenant VM console access."},{"line_number":56,"context_line":"This option allows pluggable driver program for the console session"},{"line_number":57,"context_line":"and represents driver to use for the console proxy."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Possible values:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* A string representing fully classified class name of console driver."},{"line_number":62,"context_line":"\"\"\"),"},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027allowed_origins\u0027,"},{"line_number":64,"context_line":"        default\u003d[],"},{"line_number":65,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_4482dd01","line":62,"range":{"start_line":49,"start_character":0,"end_line":62,"end_character":5},"updated":"2016-10-21 11:33:34.000000000","message":"If we resolve the TODO, would this option be retained? If not, perhaps we shouldn\u0027t rename this?","commit_id":"93d4863165c00891f363036cc201a7e817703767"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"65950208b8dd528006b39298689687932801149d","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* A string representing topic exchange name"},{"line_number":48,"context_line":"\"\"\"),"},{"line_number":49,"context_line":"    # TODO(pumaranikar): Move this config to stevedore plugin system."},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":51,"context_line":"        default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"},{"line_number":52,"context_line":"        deprecated_group\u003d\u0027console\u0027,"},{"line_number":53,"context_line":"        deprecated_name\u003d\u0027console_driver\u0027,"},{"line_number":54,"context_line":"        help\u003d\"\"\""},{"line_number":55,"context_line":"Nova-console proxy is used to set up multi-tenant VM console access."},{"line_number":56,"context_line":"This option allows pluggable driver program for the console session"},{"line_number":57,"context_line":"and represents driver to use for the console proxy."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Possible values:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* A string representing fully classified class name of console driver."},{"line_number":62,"context_line":"\"\"\"),"},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027allowed_origins\u0027,"},{"line_number":64,"context_line":"        default\u003d[],"},{"line_number":65,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_28063b1d","line":62,"range":{"start_line":49,"start_character":0,"end_line":62,"end_character":5},"in_reply_to":"da6895a0_4482dd01","updated":"2016-11-01 11:34:21.000000000","message":"AFAIK it would be retained.","commit_id":"93d4863165c00891f363036cc201a7e817703767"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9dd2ce3d9e918dff85d29b8dbf906178d627fafa","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* A list where each element is an allowed origin hostnames, else an empty list"},{"line_number":77,"context_line":"\"\"\"),"},{"line_number":78,"context_line":"    cfg.URIOpt(\u0027public_hostname\u0027,"},{"line_number":79,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":80,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":81,"context_line":"        deprecated_name\u003d\u0027console_public_hostname\u0027,"},{"line_number":82,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_69bb3a73","line":79,"range":{"start_line":79,"start_character":23,"end_line":79,"end_character":34},"updated":"2016-10-21 11:17:50.000000000","message":"This is the reason of tests failing - what could be a sensible replacement?","commit_id":"93d4863165c00891f363036cc201a7e817703767"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"65950208b8dd528006b39298689687932801149d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* A list where each element is an allowed origin hostnames, else an empty list"},{"line_number":77,"context_line":"\"\"\"),"},{"line_number":78,"context_line":"    cfg.URIOpt(\u0027public_hostname\u0027,"},{"line_number":79,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":80,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":81,"context_line":"        deprecated_name\u003d\u0027console_public_hostname\u0027,"},{"line_number":82,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_5ab5f4eb","line":79,"range":{"start_line":79,"start_character":23,"end_line":79,"end_character":34},"in_reply_to":"da6895a0_44fe5d6c","updated":"2016-11-01 11:34:21.000000000","message":"Done","commit_id":"93d4863165c00891f363036cc201a7e817703767"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d10f7248a50490bb671e64278132b9780836c72d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* A list where each element is an allowed origin hostnames, else an empty list"},{"line_number":77,"context_line":"\"\"\"),"},{"line_number":78,"context_line":"    cfg.URIOpt(\u0027public_hostname\u0027,"},{"line_number":79,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":80,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":81,"context_line":"        deprecated_name\u003d\u0027console_public_hostname\u0027,"},{"line_number":82,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_44fe5d6c","line":79,"range":{"start_line":79,"start_character":23,"end_line":79,"end_character":34},"in_reply_to":"da6895a0_69bb3a73","updated":"2016-10-21 11:33:34.000000000","message":"It\u0027s the fact that you changed this to a URIOpt, actually. The TODO was wrong, it seems :)","commit_id":"93d4863165c00891f363036cc201a7e817703767"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"98f4933df581f4ed816e41355bd17d2cc5b5fa15","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"\"\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"console_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027topic\u0027,"},{"line_number":29,"context_line":"        default\u003d\u0027console\u0027,"},{"line_number":30,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":32,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":33,"context_line":"        deprecated_name\u003d\u0027console_topic\u0027,"},{"line_number":34,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":35,"context_line":"There is no need to let users choose the RPC topic for all services - there"},{"line_number":36,"context_line":"is little gain from this. Furthermore, it makes it really easy to break Nova"},{"line_number":37,"context_line":"by using this option."},{"line_number":38,"context_line":"\"\"\","},{"line_number":39,"context_line":"        help\u003d\"\"\""},{"line_number":40,"context_line":"Represents the message queue topic name used by nova-console"},{"line_number":41,"context_line":"service when communicating via the AMQP server. The Nova API uses a message"},{"line_number":42,"context_line":"queue to communicate with nova-console to retrieve a console URL for that"},{"line_number":43,"context_line":"host."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* A string representing topic exchange name"},{"line_number":48,"context_line":"\"\"\"),"},{"line_number":49,"context_line":"    # TODO(pumaranikar): Move this config to stevedore plugin system."},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":51,"context_line":"        default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_42898674","line":48,"range":{"start_line":28,"start_character":0,"end_line":48,"end_character":5},"updated":"2016-11-01 13:49:06.000000000","message":"I missed this first go round. You shouldn\u0027t be changing the group that deprecated options belong to. It\u0027s unnecessary overhead for operators. Perhaps you could just remove it in a follow up patch instead?","commit_id":"64bab79ba536221d35ca48eb06e720ed34908b6d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"eb33ca58bf321c4ff591600a03f6662013a582fd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"\"\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"console_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027topic\u0027,"},{"line_number":29,"context_line":"        default\u003d\u0027console\u0027,"},{"line_number":30,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":32,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":33,"context_line":"        deprecated_name\u003d\u0027console_topic\u0027,"},{"line_number":34,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":35,"context_line":"There is no need to let users choose the RPC topic for all services - there"},{"line_number":36,"context_line":"is little gain from this. Furthermore, it makes it really easy to break Nova"},{"line_number":37,"context_line":"by using this option."},{"line_number":38,"context_line":"\"\"\","},{"line_number":39,"context_line":"        help\u003d\"\"\""},{"line_number":40,"context_line":"Represents the message queue topic name used by nova-console"},{"line_number":41,"context_line":"service when communicating via the AMQP server. The Nova API uses a message"},{"line_number":42,"context_line":"queue to communicate with nova-console to retrieve a console URL for that"},{"line_number":43,"context_line":"host."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* A string representing topic exchange name"},{"line_number":48,"context_line":"\"\"\"),"},{"line_number":49,"context_line":"    # TODO(pumaranikar): Move this config to stevedore plugin system."},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":51,"context_line":"        default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_0f311d5a","line":48,"range":{"start_line":28,"start_character":0,"end_line":48,"end_character":5},"in_reply_to":"ba5da102_42898674","updated":"2016-11-03 13:45:10.000000000","message":"Ok, will do.","commit_id":"64bab79ba536221d35ca48eb06e720ed34908b6d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2dd15d4c4dc1c82824488bb39ded79df436528ef","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    title\u003d\u0027Console Options\u0027,"},{"line_number":22,"context_line":"    help\u003d\"\"\""},{"line_number":23,"context_line":"Console options allow you to use remote console functionality to connect to"},{"line_number":24,"context_line":"instances."},{"line_number":25,"context_line":"\"\"\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"deprecated_console_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_4c9f08b4","line":24,"updated":"2016-11-25 12:24:28.000000000","message":"Really they are relating to the configuration of the console proxy service, rather than the functionality as such.","commit_id":"2c0fa5eccccb546f0958c6dae0ebd8c42cfb1c0d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9e28bac8075a08b6c7277a93577e23e69068d6de","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    title\u003d\u0027Console Options\u0027,"},{"line_number":22,"context_line":"    help\u003d\"\"\""},{"line_number":23,"context_line":"Console options allow you to use remote console functionality to connect to"},{"line_number":24,"context_line":"instances."},{"line_number":25,"context_line":"\"\"\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"deprecated_console_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_8cce80b2","line":24,"in_reply_to":"5a74a57a_4c9f08b4","updated":"2016-11-25 12:25:24.000000000","message":"I wonder if its worth adding a note about the console_host setting that is set on every compute that points to the console service?","commit_id":"2c0fa5eccccb546f0958c6dae0ebd8c42cfb1c0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4b836379fc7a69a955ef043bda68529d4de7176e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"console_opts \u003d ["},{"line_number":53,"context_line":"    # TODO(pumaranikar): Move this config to stevedore plugin system."},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":55,"context_line":"        default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"},{"line_number":56,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":57,"context_line":"        deprecated_name\u003d\u0027console_driver\u0027,"},{"line_number":58,"context_line":"        help\u003d\"\"\""},{"line_number":59,"context_line":"Nova-console proxy is used to set up multi-tenant VM console access."},{"line_number":60,"context_line":"This option allows pluggable driver program for the console session"},{"line_number":61,"context_line":"and represents driver to use for the console proxy."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Possible values:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* A string representing fully classified class name of console driver."},{"line_number":66,"context_line":"\"\"\"),"},{"line_number":67,"context_line":"    cfg.ListOpt(\u0027allowed_origins\u0027,"},{"line_number":68,"context_line":"        default\u003d[],"},{"line_number":69,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a71b18c_53aa901a","line":66,"range":{"start_line":53,"start_character":0,"end_line":66,"end_character":5},"updated":"2016-12-08 10:35:05.000000000","message":"So I\u0027m not so sure we want to rename this, as opposed to deprecating it altogether. I initially took the latter approach but I\u0027ve since changed my mind and started the walk to deprecating it altogether. Could you take a look at https://review.openstack.org/#/q/topic:feat/deprecate-console_driver-opt and tell me what you think? If we do decide to deprecate it, then it belongs in the \u0027deprecated_console_opts\u0027 group instead, of course","commit_id":"95895aaab12bf68910eabdc2a62d729ec19c51b3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"79c27f700c944fd045f91865feb45733e42d41bc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"console_opts \u003d ["},{"line_number":53,"context_line":"    # TODO(pumaranikar): Move this config to stevedore plugin system."},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":55,"context_line":"        default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"},{"line_number":56,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":57,"context_line":"        deprecated_name\u003d\u0027console_driver\u0027,"},{"line_number":58,"context_line":"        help\u003d\"\"\""},{"line_number":59,"context_line":"Nova-console proxy is used to set up multi-tenant VM console access."},{"line_number":60,"context_line":"This option allows pluggable driver program for the console session"},{"line_number":61,"context_line":"and represents driver to use for the console proxy."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Possible values:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* A string representing fully classified class name of console driver."},{"line_number":66,"context_line":"\"\"\"),"},{"line_number":67,"context_line":"    cfg.ListOpt(\u0027allowed_origins\u0027,"},{"line_number":68,"context_line":"        default\u003d[],"},{"line_number":69,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_bcd76522","line":66,"range":{"start_line":53,"start_character":0,"end_line":66,"end_character":5},"in_reply_to":"3a71b18c_53aa901a","updated":"2016-12-12 15:53:02.000000000","message":"+1 the deprecate approach.","commit_id":"95895aaab12bf68910eabdc2a62d729ec19c51b3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ecc81290e0e3b46d6a61cf83f969a27ec1beab6a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"console_group \u003d cfg.OptGroup(\u0027console\u0027,"},{"line_number":21,"context_line":"    title\u003d\u0027Console Options\u0027,"},{"line_number":22,"context_line":"    help\u003d\"\"\""},{"line_number":23,"context_line":"Options under this group allow to tune the configuration of the console proxy"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a6eadb0_2c8779b6","line":20,"updated":"2016-12-13 13:00:57.000000000","message":"Thinking about this, I think we should actually move these to the xenserver group?","commit_id":"d08cc4368010e38774cc8244f73e5bc06133f80f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"045d0bc3b7488217d1bee6332cd88697b3e20191","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"console_group \u003d cfg.OptGroup(\u0027console\u0027,"},{"line_number":21,"context_line":"    title\u003d\u0027Console Options\u0027,"},{"line_number":22,"context_line":"    help\u003d\"\"\""},{"line_number":23,"context_line":"Options under this group allow to tune the configuration of the console proxy"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a6eadb0_a44f10bc","line":20,"in_reply_to":"1a6eadb0_2c8779b6","updated":"2016-12-13 18:33:05.000000000","message":"Done","commit_id":"d08cc4368010e38774cc8244f73e5bc06133f80f"}],"nova/conf/xenserver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8f5092cec31f3f06085e52155130b212d22f4e2f","unresolved":false,"context_lines":[{"line_number":588,"context_line":"]"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"xenapi_console_opts \u003d ["},{"line_number":591,"context_line":"    cfg.ListOpt(\u0027console_allowed_origins\u0027,"},{"line_number":592,"context_line":"        default\u003d[],"},{"line_number":593,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":594,"context_line":"        help\u003d\"\"\""},{"line_number":595,"context_line":"Adds list of allowed origins to the console websocket proxy to allow"},{"line_number":596,"context_line":"connections from other origin hostnames."},{"line_number":597,"context_line":"Websocket proxy matches the host header with the origin header to"},{"line_number":598,"context_line":"prevent cross-site requests. This list specifies if any there are"},{"line_number":599,"context_line":"values other than host are allowed in the origin header."},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"Possible values:"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"* A list where each element is an allowed origin hostnames, else an empty list"},{"line_number":604,"context_line":"\"\"\"),"},{"line_number":605,"context_line":"    cfg.StrOpt(\u0027console_public_hostname\u0027,"},{"line_number":606,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":607,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a6eadb0_fd77a437","line":604,"range":{"start_line":591,"start_character":0,"end_line":604,"end_character":5},"updated":"2016-12-14 16:48:00.000000000","message":"This is a websocketproxy config option and should have been kept where it was","commit_id":"9fe6536601207930441e85e17dbbd83ba878fc20"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d484be18e40c1fa765652649209795491a0ff95b","unresolved":false,"context_lines":[{"line_number":590,"context_line":"xenapi_console_opts \u003d ["},{"line_number":591,"context_line":"    cfg.StrOpt(\u0027console_public_hostname\u0027,"},{"line_number":592,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":593,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":594,"context_line":"        help\u003d\"\"\""},{"line_number":595,"context_line":"Publicly visible name for this console host."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a6eadb0_8a86b211","line":593,"range":{"start_line":593,"start_character":26,"end_line":593,"end_character":33},"updated":"2016-12-19 16:02:51.000000000","message":"doesn\u0027t this have to be \u0027DEFAULT\u0027?","commit_id":"780d0f50c49b5aa30aa62c283f74b7d7cbb625da"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"8c0ada62220e365d64494a9e0e271a49510a56e6","unresolved":false,"context_lines":[{"line_number":590,"context_line":"xenapi_console_opts \u003d ["},{"line_number":591,"context_line":"    cfg.StrOpt(\u0027console_public_hostname\u0027,"},{"line_number":592,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":593,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":594,"context_line":"        help\u003d\"\"\""},{"line_number":595,"context_line":"Publicly visible name for this console host."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a6eadb0_fe6c3f38","line":593,"range":{"start_line":593,"start_character":26,"end_line":593,"end_character":33},"in_reply_to":"1a6eadb0_8a86b211","updated":"2016-12-19 19:01:31.000000000","message":"Good call. When we add opts to default group we use \u0027DEFAULT\u0027, and nearly in every deprecation we have \u0027default\u0027. I will raise a patch for this.","commit_id":"780d0f50c49b5aa30aa62c283f74b7d7cbb625da"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e2ec49d59111cca832c82ddd49a9e4c35591ba54","unresolved":false,"context_lines":[{"line_number":590,"context_line":"xenapi_console_opts \u003d ["},{"line_number":591,"context_line":"    cfg.StrOpt(\u0027console_public_hostname\u0027,"},{"line_number":592,"context_line":"        default\u003dsocket.gethostname(),"},{"line_number":593,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":594,"context_line":"        help\u003d\"\"\""},{"line_number":595,"context_line":"Publicly visible name for this console host."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a6eadb0_5e7e13af","line":593,"range":{"start_line":593,"start_character":26,"end_line":593,"end_character":33},"in_reply_to":"1a6eadb0_fe6c3f38","updated":"2016-12-19 19:06:08.000000000","message":"Not every. Just in conf/api file.","commit_id":"780d0f50c49b5aa30aa62c283f74b7d7cbb625da"}],"nova/console/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8f5092cec31f3f06085e52155130b212d22f4e2f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            pool_info[\u0027password\u0027] \u003d self.driver.fix_pool_password("},{"line_number":111,"context_line":"                                                    pool_info[\u0027password\u0027])"},{"line_number":112,"context_line":"            pool_info[\u0027host\u0027] \u003d self.host"},{"line_number":113,"context_line":"            pool_info[\u0027public_hostname\u0027] \u003d CONF.xenserver.public_hostname"},{"line_number":114,"context_line":"            pool_info[\u0027console_type\u0027] \u003d self.driver.console_type"},{"line_number":115,"context_line":"            pool_info[\u0027compute_host\u0027] \u003d instance_host"},{"line_number":116,"context_line":"            pool \u003d self.db.console_pool_create(context, pool_info)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a6eadb0_fdaec483","line":113,"range":{"start_line":113,"start_character":58,"end_line":113,"end_character":73},"updated":"2016-12-14 16:48:00.000000000","message":"console_public_hostname","commit_id":"9fe6536601207930441e85e17dbbd83ba878fc20"}],"nova/console/websocketproxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8f5092cec31f3f06085e52155130b212d22f4e2f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                expected_origin_hostname \u003d e.split(\u0027]\u0027)[0][1:]"},{"line_number":117,"context_line":"            else:"},{"line_number":118,"context_line":"                expected_origin_hostname \u003d e.split(\u0027:\u0027)[0]"},{"line_number":119,"context_line":"        expected_origin_hostnames \u003d CONF.xenserver.allowed_origins"},{"line_number":120,"context_line":"        expected_origin_hostnames.append(expected_origin_hostname)"},{"line_number":121,"context_line":"        origin_url \u003d self.headers.getheader(\u0027Origin\u0027)"},{"line_number":122,"context_line":"        # missing origin header indicates non-browser client which is OK"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a6eadb0_9dceb0b2","line":119,"range":{"start_line":119,"start_character":36,"end_line":119,"end_character":66},"updated":"2016-12-14 16:48:00.000000000","message":"The fact that you\u0027re using this in here - the code for the web socket proxy - would suggest that this particular option is /not/ a XenServer-only opt, surely?","commit_id":"9fe6536601207930441e85e17dbbd83ba878fc20"}],"nova/releasenotes/notes/move-console-opt-to-console-group-de693ac26bc9b090.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"47dd06333462ebe9eccaad64045fb0f6afa3d497","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba5da102_e2bc5a08","line":6,"updated":"2016-11-01 13:50:25.000000000","message":"Can you list what options exactly were removed, e.g.\n\n    - ``console_driver`` (now ``console.driver``)\n    - ...","commit_id":"64bab79ba536221d35ca48eb06e720ed34908b6d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"eb33ca58bf321c4ff591600a03f6662013a582fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba5da102_ef9789e9","line":6,"in_reply_to":"ba5da102_e2bc5a08","updated":"2016-11-03 13:45:10.000000000","message":"Done","commit_id":"64bab79ba536221d35ca48eb06e720ed34908b6d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6443c9c6e078d48b45c7b7a0cedf91d7e58c03f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The console options listed below were moved from the ``default`` group to"},{"line_number":5,"context_line":"    the ``console`` group and renamed."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``console_driver`` (now ``driver``)"},{"line_number":8,"context_line":"    * ``console_allowed_origins`` (now ``allowed_origins``)"},{"line_number":9,"context_line":"    * ``console_public_hostname`` (now ``public_hostname``)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5a74a57a_af589c33","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":59},"updated":"2016-11-25 05:23:33.000000000","message":"Should be very clear that old names are in deprecation period(not removed). How about something like that:\n\nOld names under ``default`` group are being deprecated and will be removed in future.\n\n    * ``console_driver``(group ``default``) -\u003e ``driver``  (group ``console``)\n    * ``console_allowed_origins`` (group ``default``) -\u003e ``allowed_origins`` (group ``console``)\n    * ``console_public_hostname`` (group ``default``) -\u003e ``public_hostname`` (group ``console``)","commit_id":"2c0fa5eccccb546f0958c6dae0ebd8c42cfb1c0d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2dd15d4c4dc1c82824488bb39ded79df436528ef","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The console options listed below were moved from the ``default`` group to"},{"line_number":5,"context_line":"    the ``console`` group and renamed."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``console_driver`` (now ``driver``)"},{"line_number":8,"context_line":"    * ``console_allowed_origins`` (now ``allowed_origins``)"},{"line_number":9,"context_line":"    * ``console_public_hostname`` (now ``public_hostname``)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5a74a57a_cc0f982c","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":59},"in_reply_to":"5a74a57a_af589c33","updated":"2016-11-25 12:24:28.000000000","message":"Yeah, +1 that idea. Its a little unclear in the note.","commit_id":"2c0fa5eccccb546f0958c6dae0ebd8c42cfb1c0d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2444039651caa3a980c95f1c1ed0554d4af7b598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5a74a57a_7808a228","updated":"2016-11-29 01:01:35.000000000","message":"this should go under releasenotes/ not nova/releasenotes","commit_id":"904534c10d7aaeca7ed68fcd40eea03200a146a7"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"8446031f55551e7fd6bf2858d35e0b2ad6d85aec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5a74a57a_ad87365f","in_reply_to":"5a74a57a_7808a228","updated":"2016-11-29 16:40:11.000000000","message":"Ops, I know, did not notice, I quess my dev setup somehow had a bad sync with my laptop.","commit_id":"904534c10d7aaeca7ed68fcd40eea03200a146a7"}],"nova/tests/unit/console/test_rpcapi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9875642586d80335731a6d6f426f817a39da98a1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        rpcapi \u003d console_rpcapi.ConsoleAPI()"},{"line_number":34,"context_line":"        self.assertIsNotNone(rpcapi.client)"},{"line_number":35,"context_line":"        self.assertEqual(rpcapi.client.target.topic,"},{"line_number":36,"context_line":"                         CONF.console_topic)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        orig_prepare \u003d rpcapi.client.prepare"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_f5a3affe","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":44},"updated":"2016-11-04 11:11:55.000000000","message":"unnecessary whitespace change","commit_id":"61920ade54df90749be0b7b19f91f94a4fcff619"}],"releasenotes/notes/move-console-opt-to-console-group-de693ac26bc9b090.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e75583b940b34893a4c7f06c2a63966975b20395","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The console options under the ``default`` group are being deprecated and"},{"line_number":5,"context_line":"     will be removed in the future."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``console_driver``(group ``default``) -\u003e ``driver``  (group ``console``)"},{"line_number":8,"context_line":"    * ``console_allowed_origins`` (group ``default``)"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a74a57a_69c7cd64","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":35},"updated":"2016-11-29 16:59:05.000000000","message":"This suggests the options are being deprecated, rather than simply renamed and moved to another group. Can you reword this?","commit_id":"65960a4fdd46fc872cc179a46602af288b320445"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e0a6db9343a6f3f4fac87249c743bc0e2967462b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The console options under the ``default`` group have been renamed and"},{"line_number":5,"context_line":"    moved to the ``console`` group``."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``console_driver``(group ``default``) -\u003e ``driver``  (group ``console``)"},{"line_number":8,"context_line":"    * ``console_allowed_origins`` (group ``default``)"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a71b18c_24230cbf","line":5,"range":{"start_line":5,"start_character":34,"end_line":5,"end_character":36},"updated":"2016-12-02 02:38:08.000000000","message":"\u003egroup``.\n`` is not needed.","commit_id":"6ed26ab2ee304ca310cbec178e017d2102a2db49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e0a6db9343a6f3f4fac87249c743bc0e2967462b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The console options under the ``default`` group have been renamed and"},{"line_number":5,"context_line":"    moved to the ``console`` group``."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``console_driver``(group ``default``) -\u003e ``driver``  (group ``console``)"},{"line_number":8,"context_line":"    * ``console_allowed_origins`` (group ``default``)"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a71b18c_e45d94ea","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":37},"updated":"2016-12-02 02:38:08.000000000","message":"nice but along with that deprecation note would be more clear as we are deprecating old name/group-\n\nThe console options under the ``default`` group have been renamed and moved to the ``console`` group``.\nOld name under the ``default`` group are being deprecated and will be removed in the future.","commit_id":"6ed26ab2ee304ca310cbec178e017d2102a2db49"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a3b7094f5938e4b3cdf8184911eb13f2c2d6d4d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The console options under the ``default`` group have been renamed and"},{"line_number":5,"context_line":"    moved to the ``console`` group``."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``console_driver``(group ``default``) -\u003e ``driver``  (group ``console``)"},{"line_number":8,"context_line":"    * ``console_allowed_origins`` (group ``default``)"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a71b18c_c7b869e8","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"3a71b18c_e45d94ea","updated":"2016-12-02 20:50:26.000000000","message":"You sir write like a poet.","commit_id":"6ed26ab2ee304ca310cbec178e017d2102a2db49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ead7308e41487187d54fda2638c5410c11d8ebca","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    to the ``console`` group. Old name under the ``default`` group are"},{"line_number":6,"context_line":"    being deprecated and will be removed in the future."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * ``console_driver``(group ``default``) -\u003e ``driver``  (group ``console``)"},{"line_number":9,"context_line":"    * ``console_allowed_origins`` (group ``default``)"},{"line_number":10,"context_line":"      -\u003e ``allowed_origins`` (group ``console``)"},{"line_number":11,"context_line":"    * ``console_public_hostname`` (group ``default``)"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a71b18c_75f1d700","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":25},"updated":"2016-12-05 09:38:33.000000000","message":"this is not good in http://docs-draft.openstack.org/47/389647/16/check/gate-nova-releasenotes/6545613//releasenotes/build/html/unreleased.html#b1-303\n\ni think you need to give space here","commit_id":"0bda694e1fccb717f5c4b1e0808105964e336c80"}]}