)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9d943c0ad03f7ba463761d2cfd166a86815a800a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This creates a get_schema() method for AddressBase FieldType. This"},{"line_number":10,"context_line":"method is used by the to_json_schema() method of versioned objects."},{"line_number":11,"context_line":"This also removes the NonNegativeInteger NonNegativeFloat and"},{"line_number":12,"context_line":"IPV4AndV6Address Fields, since they already are defined in ovo."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"implements bp json-schema-for-versioned-object"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_e66d9933","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":63},"updated":"2016-10-28 10:06:42.000000000","message":"This feels to me as a separate patch. Could you split it?","commit_id":"3324867c619281743d11b8b8d47deb9ef9215596"},{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"422de0e4c845f55768d5c13fcefb6417a7f3ddaf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This creates a get_schema() method for AddressBase FieldType. This"},{"line_number":10,"context_line":"method is used by the to_json_schema() method of versioned objects."},{"line_number":11,"context_line":"This also removes the NonNegativeInteger NonNegativeFloat and"},{"line_number":12,"context_line":"IPV4AndV6Address Fields, since they already are defined in ovo."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"implements bp json-schema-for-versioned-object"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_5b7d2c6d","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":63},"in_reply_to":"ba5da102_e66d9933","updated":"2016-10-28 19:42:33.000000000","message":"Will do","commit_id":"3324867c619281743d11b8b8d47deb9ef9215596"}],"nova/objects/fields.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9d943c0ad03f7ba463761d2cfd166a86815a800a","unresolved":false,"context_lines":[{"line_number":710,"context_line":"            raise ValueError(_(\u0027Value must match %s\u0027) % obj.PATTERN)"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    def get_schema(self):"},{"line_number":713,"context_line":"        if type(self.PATTERN) \u003d\u003d str:"},{"line_number":714,"context_line":"            return {\u0027type\u0027: [\u0027string\u0027], \u0027pattern\u0027: self.PATTERN}"},{"line_number":715,"context_line":"        else:"},{"line_number":716,"context_line":"            return super(AddressBase, self).get_schema()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_e6dbd9eb","line":713,"updated":"2016-10-28 10:06:42.000000000","message":"Do we need this check? I don\u0027t see any non str PATTERN in the derived classes.","commit_id":"3324867c619281743d11b8b8d47deb9ef9215596"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"18a2d7b2d7191d6de311154b723e8b192cbc31fb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"BooleanField \u003d fields.BooleanField"},{"line_number":40,"context_line":"UnspecifiedDefault \u003d fields.UnspecifiedDefault"},{"line_number":41,"context_line":"IntegerField \u003d fields.IntegerField"},{"line_number":42,"context_line":"NonNegativeIntegerField \u003d fields.NonNegativeIntegerField"},{"line_number":43,"context_line":"UUIDField \u003d fields.UUIDField"},{"line_number":44,"context_line":"FloatField \u003d fields.FloatField"},{"line_number":45,"context_line":"NonNegativeFloatField \u003d fields.NonNegativeFloatField"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_e2447a1c","line":42,"updated":"2016-11-22 20:41:05.000000000","message":"Nova currently requires ovo\u003e\u003d1.13.0:\n\nhttp://git.openstack.org/cgit/openstack/requirements/tree/global-requirements.txt#n126\n\noslo.versionedobjects\u003e\u003d1.13.0            # Apache-2.0\n\n\nThese fields you\u0027re replacing weren\u0027t released in ovo until 1.17.0:\n\nhttps://github.com/openstack/oslo.versionedobjects/commit/eb4d4a5b65c7994d76a72607f6c5faf0a0ffa888\n\nSo you need to bump the minimum required oslo.versionedobject in the requirements repo before we can do this.","commit_id":"149fbcd08878973b4195f5a8983c80aa68981913"}]}