)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"f6297e43c49a1137a3527783c8b03092831106f6","unresolved":false,"context_lines":[{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    # TODO(gibi): handle fault during the transformation of the first error"},{"line_number":357,"context_line":"    # notifications"},{"line_number":358,"context_line":"    if extra_usage_info:"},{"line_number":359,"context_line":"        payload \u003d instance_notification.ExtendedInstanceActionPayload("},{"line_number":360,"context_line":"            instance\u003dinstance,"},{"line_number":361,"context_line":"            fault\u003dNone,"},{"line_number":362,"context_line":"            ip_addresses\u003dips,"},{"line_number":363,"context_line":"            flavor\u003dflavor,"},{"line_number":364,"context_line":"            extra_usage_info\u003dextra_usage_info)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        notification \u003d instance_notification."},{"line_number":367,"context_line":"        ExtendedInstanceActionNotification("},{"line_number":368,"context_line":"            context\u003dcontext,"},{"line_number":369,"context_line":"            priority\u003dfields.NotificationPriority.INFO,"},{"line_number":370,"context_line":"            publisher\u003dnotification_base.NotificationPublisher("},{"line_number":371,"context_line":"                context\u003dcontext, host\u003dhost, binary\u003dbinary),"},{"line_number":372,"context_line":"            event_type\u003dnotification_base.EventType("},{"line_number":373,"context_line":"                object\u003d\u0027instance\u0027,"},{"line_number":374,"context_line":"                action\u003daction,"},{"line_number":375,"context_line":"                phase\u003dphase),"},{"line_number":376,"context_line":"            payload\u003dpayload)"},{"line_number":377,"context_line":"    else:"},{"line_number":378,"context_line":"        payload \u003d instance_notification.InstanceActionPayload("},{"line_number":379,"context_line":"            instance\u003dinstance,"},{"line_number":380,"context_line":"            fault\u003dNone,"},{"line_number":381,"context_line":"            ip_addresses\u003dips,"},{"line_number":382,"context_line":"            flavor\u003dflavor)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        notification \u003d instance_notification.InstanceActionNotification("},{"line_number":385,"context_line":"            context\u003dcontext,"},{"line_number":386,"context_line":"            priority\u003dfields.NotificationPriority.INFO,"},{"line_number":387,"context_line":"            publisher\u003dnotification_base.NotificationPublisher("},{"line_number":388,"context_line":"                context\u003dcontext, host\u003dhost, binary\u003dbinary),"},{"line_number":389,"context_line":"            event_type\u003dnotification_base.EventType("},{"line_number":390,"context_line":"                object\u003d\u0027instance\u0027,"},{"line_number":391,"context_line":"                action\u003daction,"},{"line_number":392,"context_line":"                phase\u003dphase),"},{"line_number":393,"context_line":"            payload\u003dpayload)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    notification.emit(context)"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_7b25b4a9","line":393,"range":{"start_line":358,"start_character":0,"end_line":393,"end_character":28},"updated":"2016-10-27 14:03:32.000000000","message":"In this way, the code duplication is not removed, but moved and merged to one method.","commit_id":"16e8d5aeff3417fb44b9323aedd64c7ccb2b3353"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"f6297e43c49a1137a3527783c8b03092831106f6","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"def notify_about_instance_action_extended(context, instance, host, action,"},{"line_number":399,"context_line":"                                          phase\u003dNone, binary\u003d\u0027nova-compute\u0027,"},{"line_number":400,"context_line":"                                          extra_usage_info\u003dNone):"},{"line_number":401,"context_line":"    \"\"\"Send versioned notification about the action made on the instance"},{"line_number":402,"context_line":"    :param instance: the instance which the action performed on"},{"line_number":403,"context_line":"    :param host: the host emitting the notification"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_fb31c4ed","line":400,"range":{"start_line":400,"start_character":42,"end_line":400,"end_character":65},"updated":"2016-10-27 14:03:32.000000000","message":"If you want to this in the we have now, I think that should not be None, as if it is None, then why don\u0027t we call the other notify method?","commit_id":"16e8d5aeff3417fb44b9323aedd64c7ccb2b3353"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"f6297e43c49a1137a3527783c8b03092831106f6","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    notification.emit(context)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"def notify_about_instance_action_extended(context, instance, host, action,"},{"line_number":399,"context_line":"                                          phase\u003dNone, binary\u003d\u0027nova-compute\u0027,"},{"line_number":400,"context_line":"                                          extra_usage_info\u003dNone):"},{"line_number":401,"context_line":"    \"\"\"Send versioned notification about the action made on the instance"},{"line_number":402,"context_line":"    :param instance: the instance which the action performed on"},{"line_number":403,"context_line":"    :param host: the host emitting the notification"},{"line_number":404,"context_line":"    :param action: the name of the action"},{"line_number":405,"context_line":"    :param phase: the phase of the action"},{"line_number":406,"context_line":"    :param binary: the binary emitting the notification"},{"line_number":407,"context_line":"    :param extra_usage_info: any additional usage information"},{"line_number":408,"context_line":"    \"\"\""},{"line_number":409,"context_line":"    notify_about_instance_action(context, instance, host, action, phase,"},{"line_number":410,"context_line":"                                 binary, extra_usage_info)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"def notify_about_volume_swap(context, instance, host, action, phase,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_7b5cd425","line":410,"range":{"start_line":398,"start_character":0,"end_line":410,"end_character":58},"updated":"2016-10-27 14:03:32.000000000","message":"I think this whole method has no meaning now, so we should just remove it and use the other one.","commit_id":"16e8d5aeff3417fb44b9323aedd64c7ccb2b3353"}]}