)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3d40eebb48b7edd18da83e06a9f166624074b11d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Co-Authored-By: stewie925 \u003cst3wty@att.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic025b08a260faad9d0ebc5a2d67476c10b91002d"},{"line_number":15,"context_line":"Implements: bp versioned-notification-transformation-ocata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa31d9ce_6481f8fa","line":15,"updated":"2017-02-15 11:44:23.000000000","message":"if you have to respin the patch then please change this to versioned-notification-transformation-pike","commit_id":"583e4a6ac5000a4fcabc5d311c5805d4e47a4c04"}],"doc/notification_samples/instance-resize_confirm-end.json":[{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"b6e5eda9d33f9b47e65dbfd0dd53db1bcda85d58","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        },"},{"line_number":65,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":66,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":67,"context_line":"        \"nova_object.version\":\"1.1\""},{"line_number":68,"context_line":"    },"},{"line_number":69,"context_line":"    \"priority\":\"INFO\","},{"line_number":70,"context_line":"    \"publisher_id\":\"nova-compute:compute\""}],"source_content_type":"application/json","patch_set":12,"id":"5a3905b3_b62a092e","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":35},"updated":"2017-01-24 20:04:10.000000000","message":"the InstanceActionPayload nova_object\u0027s version had to be changed from 1.0 to 1.1 in order for the functional test to pass.","commit_id":"583e4a6ac5000a4fcabc5d311c5805d4e47a4c04"}],"doc/notification_samples/instance-resize_confirm-start.json":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"58e4cf14b9bb022afa184dfdfc9eafd95e6160d9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            \"ramdisk_id\":\"\","},{"line_number":35,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":36,"context_line":"            \"state\":\"active\","},{"line_number":37,"context_line":"            \"task_state\":\"resize_confirmed\","},{"line_number":38,"context_line":"            \"power_state\":\"running\","},{"line_number":39,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":40,"context_line":"            \"terminated_at\":null,"}],"source_content_type":"application/json","patch_set":2,"id":"9a629dbe_0b03ad74","line":37,"updated":"2016-11-07 10:29:29.000000000","message":"It seems that the functional test fails on this line with:\nDifference: u\u0027resize_confirmed\u0027 !\u003d u\u0027resize_migrating\u0027 you should change the sample file accordingly.","commit_id":"0b14963b26fa6a060b2dbf3bb21d816da8b770a2"}],"nova/tests/functional/api/client.py":[{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"4853f16b7d4d675a13d46e59031c5e2fed91319c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":216,"context_line":"            kwargs[\u0027body\u0027] \u003d jsonutils.dumps(body)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        kwargs.setdefault(\u0027check_response_status\u0027, [200, 202, 204])"},{"line_number":219,"context_line":"        return APIResponse(self.api_request(relative_uri, **kwargs))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def api_put(self, relative_uri, body, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_69a2284d","line":218,"range":{"start_line":218,"start_character":62,"end_line":218,"end_character":65},"updated":"2016-11-30 21:51:37.000000000","message":"Had to add 204 to the list of check_response_status, as \u0027confirmResize\u0027 request is expected to return a response code of 204 per\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L808.","commit_id":"3079eb119e9f772602cc153ec8b9a87b97d05b07"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f27d166b37973482610ff7e89128329bc974e867","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":216,"context_line":"            kwargs[\u0027body\u0027] \u003d jsonutils.dumps(body)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        kwargs.setdefault(\u0027check_response_status\u0027, [200, 202, 204])"},{"line_number":219,"context_line":"        return APIResponse(self.api_request(relative_uri, **kwargs))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def api_put(self, relative_uri, body, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_9242493d","line":218,"range":{"start_line":218,"start_character":62,"end_line":218,"end_character":65},"in_reply_to":"5a74a57a_69a2284d","updated":"2016-12-02 11:19:57.000000000","message":"This would allow 204 for every post request that seems to much of a change.\nI suggest to change post_server_action, add a **kwargs param there that is passed in this api_post function and then your resize_confirm test can call post_server_action with an extra check_response_status\u003d[204] parameter. This way the change only affect your specific call and not every api_post call.","commit_id":"3079eb119e9f772602cc153ec8b9a87b97d05b07"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"80881d2fd0fc64b64103f23a425d268740b46103","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":216,"context_line":"            kwargs[\u0027body\u0027] \u003d jsonutils.dumps(body)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # Add \u0027204\u0027 to list of check_response_status if confirmResize,"},{"line_number":219,"context_line":"        # otherwise check_response_status  would only allow 200 or 202"},{"line_number":220,"context_line":"        if confirmResize:"},{"line_number":221,"context_line":"            kwargs.setdefault(\u0027check_response_status\u0027, [200, 202, 204])"},{"line_number":222,"context_line":"        else:"},{"line_number":223,"context_line":"            kwargs.setdefault(\u0027check_response_status\u0027, [200, 202])"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        return APIResponse(self.api_request(relative_uri, **kwargs))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def api_put(self, relative_uri, body, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_917dc7e9","line":224,"range":{"start_line":218,"start_character":0,"end_line":224,"end_character":0},"updated":"2016-12-03 01:33:37.000000000","message":"this logic ensures that check_response_status also includes code \u0027204\u0027 IF it is a resize_confirm action.","commit_id":"865e774f9a9c38072eb2e666014dfa4dc57c05c1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e4c2d7766450a1daf387c2a8e8235223f2d5d8bc","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            kwargs[\u0027body\u0027] \u003d jsonutils.dumps(body)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        kwargs.setdefault(\u0027check_response_status\u0027, [200, 202])"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        return APIResponse(self.api_request(relative_uri, **kwargs))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def api_put(self, relative_uri, body, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_36e86910","line":219,"updated":"2016-12-09 12:24:14.000000000","message":"this seems like an unnecessary change","commit_id":"3429ed61e6358e0ac6471219927ae56b731994e5"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cddd8c8e5f6dd50d304517cd4552dd6197617f4b","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def _test_resize_confirm_server(self, server):"},{"line_number":354,"context_line":"        self.flags(allow_resize_to_same_host\u003dTrue)"},{"line_number":355,"context_line":"        post \u003d {\u0027resize_confirmed\u0027: {\u0027flavorRef\u0027: \u00272\u0027}}"},{"line_number":356,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":357,"context_line":"        self._wait_for_state_change(self.api, server, \u0027VERIFY_RESIZE_CONFIRM\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self.assertEqual(2, len(fake_notifier.VERSIONED_NOTIFICATIONS))"},{"line_number":360,"context_line":"        self._verify_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_95a7d34e","line":357,"range":{"start_line":355,"start_character":0,"end_line":357,"end_character":78},"updated":"2016-10-26 12:33:18.000000000","message":"At the beginning, \u0027resize\u0027(*1) action or \u0027migrate\u0027(*2) action should be executed for the \u0027ACTIVE\u0027 server.\nAnd wait until server\u0027s status is changed to \u0027VERIFY_RESIZE\u0027.\n\n*1: http://developer.openstack.org/api-ref/compute/#resize-server-resize-action\n*2: http://developer.openstack.org/api-ref/compute/#migrate-server-migrate-action","commit_id":"826b8a3fc2699fffe3966d29eff54ced8f714042"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cddd8c8e5f6dd50d304517cd4552dd6197617f4b","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":371,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[1])"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        post \u003d {\u0027revertResize\u0027: None}"},{"line_number":374,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":375,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def _test_restore_server(self, server):"},{"line_number":378,"context_line":"        self.flags(reclaim_instance_interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_f53acfe6","line":375,"range":{"start_line":373,"start_character":0,"end_line":375,"end_character":63},"updated":"2016-10-26 12:33:18.000000000","message":"After \u0027resize confirm\u0027 is executed, the server\u0027s status becomes \u0027ACTIVE\u0027. So these lines are not necessary.","commit_id":"826b8a3fc2699fffe3966d29eff54ced8f714042"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"58e4cf14b9bb022afa184dfdfc9eafd95e6160d9","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                \u0027reservation_id\u0027: server[\u0027reservation_id\u0027],"},{"line_number":370,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":371,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[1])"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def _test_restore_server(self, server):"},{"line_number":374,"context_line":"        self.flags(reclaim_instance_interval\u003d30)"},{"line_number":375,"context_line":"        self.api.delete_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_cb7d35e9","line":372,"updated":"2016-11-07 10:29:29.000000000","message":"Please make sure that the instance is in ACTIVE state after your test step. This is needed so that other test steps can be executed successfully.","commit_id":"0b14963b26fa6a060b2dbf3bb21d816da8b770a2"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"8dc05f2ab1dadb7f3c84ee9d51e52f58974fd519","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":357,"context_line":"        self._wait_for_state_change(self.api, server, \u0027VERIFY_RESIZE\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self.assertEqual(2, len(fake_notifier.VERSIONED_NOTIFICATIONS))"},{"line_number":360,"context_line":"        self._verify_notification("},{"line_number":361,"context_line":"            \u0027instance-resize_confirm-start\u0027,"},{"line_number":362,"context_line":"            replacements\u003d{"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_8e9b8617","line":359,"range":{"start_line":359,"start_character":1,"end_line":359,"end_character":71},"updated":"2016-11-11 00:31:06.000000000","message":"Replicate lines 355-357 for resize_confirm.  For the post, specify  {\u0027confirmResize\u0027: None} in the request body.  After that, update number of versioned notification on line 359.\n\nUpdate the occurrences in lines 365 and 371.","commit_id":"9ac51850de9c7a019374b5e025136710216f0098"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"4853f16b7d4d675a13d46e59031c5e2fed91319c","unresolved":false,"context_lines":[{"line_number":535,"context_line":"                \u0027reservation_id\u0027: server[\u0027reservation_id\u0027],"},{"line_number":536,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":537,"context_line":"            actual\u003dfake_notifier.VERSIONED_NOTIFICATIONS[5])"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def _test_restore_server(self, server):"},{"line_number":540,"context_line":"        self.flags(reclaim_instance_interval\u003d30)"},{"line_number":541,"context_line":"        self.api.delete_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_dc185c78","line":538,"range":{"start_line":538,"start_character":0,"end_line":538,"end_character":0},"updated":"2016-11-30 21:51:37.000000000","message":"There is no need to add any logic to set server status to become \u0027active\u0027 as it will automatically set to \u0027active\u0027 after successful \u0027confirmResize\u0027 request.","commit_id":"3079eb119e9f772602cc153ec8b9a87b97d05b07"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"80881d2fd0fc64b64103f23a425d268740b46103","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        self._wait_for_state_change(self.api, server, \u0027VERIFY_RESIZE\u0027)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        post \u003d {\u0027confirmResize\u0027: None}"},{"line_number":522,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], post, confirmResize\u003dTrue)"},{"line_number":523,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        self.assertEqual(6, len(fake_notifier.VERSIONED_NOTIFICATIONS))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_11237706","line":522,"range":{"start_line":522,"start_character":56,"end_line":522,"end_character":69},"updated":"2016-12-03 01:33:37.000000000","message":"created this new boolean argument \u0027confirmResize\u0027 - it is only true for resize_confirm action.","commit_id":"865e774f9a9c38072eb2e666014dfa4dc57c05c1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"06a910a53f02ddfcb3ad07d872598b05e12485b6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._test_shelve_offload_server,"},{"line_number":73,"context_line":"            self._test_unshelve_server,"},{"line_number":74,"context_line":"            self._test_snapshot_server,"},{"line_number":75,"context_line":"            self._test_resize_server,"},{"line_number":76,"context_line":"            self._test_resize_confirm_server,"},{"line_number":77,"context_line":"        ]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        for action in actions:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a461143_ef24bdb0","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":45},"updated":"2017-01-25 13:11:17.000000000","message":"This will conflict with the resize_revert as both patch will expect that the _test_resize_server step left the instance in resize-confirm state.","commit_id":"583e4a6ac5000a4fcabc5d311c5805d4e47a4c04"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"2e39258576f5a4990dd895afc65d9c6b6a691e15","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._test_shelve_offload_server,"},{"line_number":73,"context_line":"            self._test_unshelve_server,"},{"line_number":74,"context_line":"            self._test_snapshot_server,"},{"line_number":75,"context_line":"            self._test_resize_server,"},{"line_number":76,"context_line":"            self._test_resize_confirm_server,"},{"line_number":77,"context_line":"        ]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        for action in actions:"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_d2c33836","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":45},"in_reply_to":"3a461143_7fc4a95e","updated":"2017-02-15 17:16:29.000000000","message":"Thank you guys.  Will follow Anusha\u0027s suggestion when I eventually merge  _test_revert_server in a later date.","commit_id":"583e4a6ac5000a4fcabc5d311c5805d4e47a4c04"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"a319ab8ada28afe024a6e5983580712db56882fe","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._test_shelve_offload_server,"},{"line_number":73,"context_line":"            self._test_unshelve_server,"},{"line_number":74,"context_line":"            self._test_snapshot_server,"},{"line_number":75,"context_line":"            self._test_resize_server,"},{"line_number":76,"context_line":"            self._test_resize_confirm_server,"},{"line_number":77,"context_line":"        ]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        for action in actions:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a461143_7fc4a95e","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":45},"in_reply_to":"3a461143_ef24bdb0","updated":"2017-01-26 21:45:41.000000000","message":"looks like _test_resize_confirm_server method is actually resizing the server first and then calling resize_confirm.\nWhere as resize_revert is depending on _test_resize_server to have the server in resize-confirm state.\nSo i think to avoid conflict they should be added in this order.\n_test_resize_server,\n_test_revert_server\n_test_resize_confirm_server","commit_id":"583e4a6ac5000a4fcabc5d311c5805d4e47a4c04"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"bedb0ceb8663d1fa2da2597e778603ac873c7c2e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            time.sleep(0.5)"},{"line_number":51,"context_line":"        self.fail(\"Timed out waiting for volume swap error to occur.\")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_instance_action(self):"},{"line_number":54,"context_line":"        # A single test case is used to test most of the instance action"},{"line_number":55,"context_line":"        # notifications to avoid booting up an instance for every action"},{"line_number":56,"context_line":"        # separately."}],"source_content_type":"text/x-python","patch_set":16,"id":"9ff52f3f_a555ea1f","line":53,"updated":"2017-04-12 23:46:31.000000000","message":"With the way the actions inside the test_instance_action function are being re-arranged, the notification samples for certain actions may need to be modified","commit_id":"4e7908ccc4524f7877d162e453f87ca6c5078240"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"bedb0ceb8663d1fa2da2597e778603ac873c7c2e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._test_shelve_offload_server,"},{"line_number":73,"context_line":"            self._test_unshelve_server,"},{"line_number":74,"context_line":"            self._test_resize_server,"},{"line_number":75,"context_line":"            self._test_revert_server,"},{"line_number":76,"context_line":"            self._test_snapshot_server,"},{"line_number":77,"context_line":"            self._test_rebuild_server,"},{"line_number":78,"context_line":"            self._test_reboot_server,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ff52f3f_9f18f375","line":75,"updated":"2017-04-12 23:46:31.000000000","message":"the call to _test_resize_confirm_server should be here but is missing","commit_id":"4e7908ccc4524f7877d162e453f87ca6c5078240"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"bedb0ceb8663d1fa2da2597e778603ac873c7c2e","unresolved":false,"context_lines":[{"line_number":755,"context_line":"    def _test_revert_server(self, server):"},{"line_number":756,"context_line":"        pass"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def test_resize_confirm_server(self):"},{"line_number":759,"context_line":"        server \u003d self._boot_a_server("},{"line_number":760,"context_line":"            extra_params\u003d{\u0027networks\u0027: [{\u0027port\u0027: self.neutron.port_1[\u0027id\u0027]}]})"},{"line_number":761,"context_line":"        self.flags(allow_resize_to_same_host\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ff52f3f_e5ff7232","line":758,"range":{"start_line":758,"start_character":8,"end_line":758,"end_character":41},"updated":"2017-04-12 23:46:31.000000000","message":"shouldnt this function name stay as _test_resize_confirm_server(self,server)?","commit_id":"4e7908ccc4524f7877d162e453f87ca6c5078240"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"58e4cf14b9bb022afa184dfdfc9eafd95e6160d9","unresolved":false,"context_lines":[{"line_number":5113,"context_line":"    def test_resize_instance_forced_shutdown(self):"},{"line_number":5114,"context_line":"        self._test_resize_instance(clean_shutdown\u003dFalse)"},{"line_number":5115,"context_line":""},{"line_number":5116,"context_line":"    @mock.patch.object(nova.compute.utils, \u0027notify_about_instance_action\u0027)"},{"line_number":5117,"context_line":"    @mock.patch(\u0027nova.context.RequestContext.elevated\u0027)"},{"line_number":5118,"context_line":"    @mock.patch.object(nova.quota.QUOTAS, \u0027commit\u0027)"},{"line_number":5119,"context_line":"    def _test_confirm_resize(self, mock_commit, mock_notify_action,"},{"line_number":5120,"context_line":"                             power_on, numa_topology\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_ebaaf984","line":5117,"range":{"start_line":5116,"start_character":0,"end_line":5117,"end_character":55},"updated":"2016-11-07 10:29:29.000000000","message":"you added two you mock to the test but you only added one new mock parameter to the test function this causes that your second mock will be passed in as power_on and this leads to the unit test failure as power_on is passed also from the caller. Please add a parameter for every mock.","commit_id":"0b14963b26fa6a060b2dbf3bb21d816da8b770a2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"58e4cf14b9bb022afa184dfdfc9eafd95e6160d9","unresolved":false,"context_lines":[{"line_number":5135,"context_line":"            old_vm_state \u003d vm_states.STOPPED"},{"line_number":5136,"context_line":"            p_state \u003d power_state.SHUTDOWN"},{"line_number":5137,"context_line":"        params \u003d {\u0027vm_state\u0027: old_vm_state, \u0027power_state\u0027: p_state}"},{"line_number":5138,"context_line":""},{"line_number":5139,"context_line":"        instance \u003d self._create_fake_instance_obj(params)"},{"line_number":5140,"context_line":""},{"line_number":5141,"context_line":"        self.flags(allow_resize_to_same_host\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_8b7eddac","line":5138,"updated":"2016-11-07 10:29:29.000000000","message":"This seems unnecessary","commit_id":"0b14963b26fa6a060b2dbf3bb21d816da8b770a2"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"cd0513141e78a696ea7813c2eafa8221ea960138","unresolved":false,"context_lines":[{"line_number":5113,"context_line":"    def test_resize_instance_forced_shutdown(self):"},{"line_number":5114,"context_line":"        self._test_resize_instance(clean_shutdown\u003dFalse)"},{"line_number":5115,"context_line":""},{"line_number":5116,"context_line":"    @mock.patch(\u0027nova.context.RequestContext.elevated\u0027)"},{"line_number":5117,"context_line":"    @mock.patch.object(nova.compute.utils, \u0027notify_about_instance_action\u0027)"},{"line_number":5118,"context_line":"    @mock.patch.object(nova.quota.QUOTAS, \u0027commit\u0027)"},{"line_number":5119,"context_line":"    def _test_confirm_resize(self, mock_commit, mock_notify, mock_elevated,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_befdb4b2","line":5116,"range":{"start_line":5116,"start_character":0,"end_line":5116,"end_character":55},"updated":"2016-11-11 20:06:25.000000000","message":"you don\u0027t need this.","commit_id":"9ac51850de9c7a019374b5e025136710216f0098"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"cd0513141e78a696ea7813c2eafa8221ea960138","unresolved":false,"context_lines":[{"line_number":5116,"context_line":"    @mock.patch(\u0027nova.context.RequestContext.elevated\u0027)"},{"line_number":5117,"context_line":"    @mock.patch.object(nova.compute.utils, \u0027notify_about_instance_action\u0027)"},{"line_number":5118,"context_line":"    @mock.patch.object(nova.quota.QUOTAS, \u0027commit\u0027)"},{"line_number":5119,"context_line":"    def _test_confirm_resize(self, mock_commit, mock_notify, mock_elevated,"},{"line_number":5120,"context_line":"                             power_on, numa_topology\u003dNone):"},{"line_number":5121,"context_line":"        # Common test case method for confirm_resize"},{"line_number":5122,"context_line":"        def fake(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_9eac708d","line":5119,"range":{"start_line":5119,"start_character":61,"end_line":5119,"end_character":75},"updated":"2016-11-11 20:06:25.000000000","message":"remove this as we are removing line 5116.","commit_id":"9ac51850de9c7a019374b5e025136710216f0098"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"cd0513141e78a696ea7813c2eafa8221ea960138","unresolved":false,"context_lines":[{"line_number":5205,"context_line":"        self.compute.confirm_resize(self.context, instance\u003dinstance,"},{"line_number":5206,"context_line":"                                    reservations\u003dreservations,"},{"line_number":5207,"context_line":"                                    migration\u003dmigration)"},{"line_number":5208,"context_line":""},{"line_number":5209,"context_line":"        instance.refresh()"},{"line_number":5210,"context_line":""},{"line_number":5211,"context_line":"        mock_context \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_3ead249b","line":5208,"range":{"start_line":5208,"start_character":0,"end_line":5208,"end_character":0},"updated":"2016-11-11 20:06:25.000000000","message":"you want to move up the assert calls - specifically ONLY lines 5215-5219 - up here.  Then fix the indentations.","commit_id":"9ac51850de9c7a019374b5e025136710216f0098"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"cd0513141e78a696ea7813c2eafa8221ea960138","unresolved":false,"context_lines":[{"line_number":5208,"context_line":""},{"line_number":5209,"context_line":"        instance.refresh()"},{"line_number":5210,"context_line":""},{"line_number":5211,"context_line":"        mock_context \u003d mock.Mock()"},{"line_number":5212,"context_line":"        with mock.patch.object(self.context, \u0027elevated\u0027,"},{"line_number":5213,"context_line":"            return_value\u003dmock_context) as mock_context_elevated:"},{"line_number":5214,"context_line":"            mock_context_elevated.assert_called_with()"},{"line_number":5215,"context_line":"            mock_notify.assert_has_calls(["},{"line_number":5216,"context_line":"                mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5217,"context_line":"                          action\u003d\u0027resize_confirm\u0027, phase\u003d\u0027start\u0027),"},{"line_number":5218,"context_line":"                mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5219,"context_line":"                          action\u003d\u0027resize_confirm\u0027, phase\u003d\u0027end\u0027)])"},{"line_number":5220,"context_line":""},{"line_number":5221,"context_line":"        flavor \u003d objects.Flavor.get_by_id(self.context,"},{"line_number":5222,"context_line":"                                          instance.instance_type_id)"},{"line_number":5223,"context_line":"        self.assertEqual(flavor.flavorid, \u00273\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_5efc98b7","line":5220,"range":{"start_line":5211,"start_character":0,"end_line":5220,"end_character":0},"updated":"2016-11-11 20:06:25.000000000","message":"remove these lines","commit_id":"9ac51850de9c7a019374b5e025136710216f0098"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f27d166b37973482610ff7e89128329bc974e867","unresolved":false,"context_lines":[{"line_number":5225,"context_line":"                                    migration\u003dmigration)"},{"line_number":5226,"context_line":"        mock_notify.assert_has_calls(["},{"line_number":5227,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5228,"context_line":"                      action\u003d\u0027resize\u0027, phase\u003d\u0027start\u0027),"},{"line_number":5229,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5230,"context_line":"                      action\u003d\u0027resize\u0027, phase\u003d\u0027end\u0027)])"},{"line_number":5231,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_12839957","line":5228,"range":{"start_line":5228,"start_character":22,"end_line":5228,"end_character":53},"updated":"2016-12-02 11:19:57.000000000","message":"This asserts resize.start but your change introduced resize_confirm.start I guess this doesn\u0027t test what you wanted to test.","commit_id":"3079eb119e9f772602cc153ec8b9a87b97d05b07"}]}