)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e66b2fa8fcf770de872328445a82cc550299a3bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     linbing \u003chawkerous@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-26 10:16:47 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  Optimize code: live_migration_tunnelled is a bool opt, hence, it\u0027s unnecessary to"},{"line_number":8,"context_line":"  check None in the code, because live_migration_tunnelled is just true"},{"line_number":9,"context_line":"  or false."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I4a8e0d3a95062b27a36c7da40f2eda40aa8ac396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_c5e850e5","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":11},"updated":"2016-10-26 03:52:45.000000000","message":"Please follow the guide to optimize the commit message:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"e2ab2d7f226c4fb03e8fb7bcca100c8ae25a8588"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"06edf5368005b9220a28d4f080fe054998b727af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     linbing \u003chawkerous@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-28 10:51:03 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  Delete checking a bool opt of None condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"   * live_migration_tunnelled is a bool opt, hence, it\u0027s unnecessary to"},{"line_number":10,"context_line":"   * check None in the code,live_migration_tunnelled is just true or false."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_610b8824","line":7,"updated":"2016-11-03 14:58:32.000000000","message":"You have extra whitespace at the start of line","commit_id":"7fb49be6d9cb0976bf5452aa23fb389ef9ff054c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"06edf5368005b9220a28d4f080fe054998b727af","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"   * live_migration_tunnelled is a bool opt, hence, it\u0027s unnecessary to"},{"line_number":10,"context_line":"   * check None in the code,live_migration_tunnelled is just true or false."},{"line_number":11,"context_line":"   * and also need to delete None condition test"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4a8e0d3a95062b27a36c7da40f2eda40aa8ac396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_a13840d4","line":11,"updated":"2016-11-03 14:58:32.000000000","message":"Don\u0027t insert bullet points into the middle of sentances like this.","commit_id":"7fb49be6d9cb0976bf5452aa23fb389ef9ff054c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3b8a8b0b1db7719e4259c42aafede91558ac7b7c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Live_migration_tunnelled is a bool opt, hence, it\u0027s unnecessary to"},{"line_number":10,"context_line":"check None in the code,live_migration_tunnelled is just true or false."},{"line_number":11,"context_line":"and also need to delete None condition test"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4a8e0d3a95062b27a36c7da40f2eda40aa8ac396"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_5e52bb69","line":11,"updated":"2018-07-31 19:31:18.000000000","message":"Even BoolOpt can be None if it is never set (has no default) but default\u003dFalse was added to the live_migration_tunnelled option in commit 61f122637b8c9952e28983de81638941dc4e7bc4. Because of that, I think we no longer need to handle None.","commit_id":"677088211041061106507e2b6396e7ce24d32afd"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e66b2fa8fcf770de872328445a82cc550299a3bd","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        return (live_migration_flags, block_migration_flags)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    def _handle_live_migration_tunnelled(self, migration_flags):"},{"line_number":562,"context_line":"        if CONF.libvirt.live_migration_tunnelled:"},{"line_number":563,"context_line":"            migration_flags |\u003d libvirt.VIR_MIGRATE_TUNNELLED"},{"line_number":564,"context_line":"        return migration_flags"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_e5e39403","line":562,"range":{"start_line":562,"start_character":8,"end_line":562,"end_character":49},"updated":"2016-10-26 03:52:45.000000000","message":"Test code is also needed.","commit_id":"e2ab2d7f226c4fb03e8fb7bcca100c8ae25a8588"}]}
