)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"de73186c8be5429985cc90f89b4a105e67031ce4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lee Yarwood \u003clyarwood@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-04 11:21:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM - encryptors: Switch to os-brick encryptor classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-bug: #1640506"},{"line_number":10,"context_line":"Change-Id: I37ffc90c0bd57029fced251b5cfd7cd4318a0292"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5201f7_3f904543","line":7,"updated":"2017-01-04 13:19:41.000000000","message":"Is DNM short for \"Do Not Merge\"? If so, just mark the workflow as -1.","commit_id":"78bfac506a1fef9d295370a82e9b3cf8f31ae168"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"870da5fe73afede41b26901c9ecb10482c05a869","unresolved":false,"context_lines":[{"line_number":11,"context_line":"possible by the following os-brick change that introduced new encryption"},{"line_number":12,"context_line":"provider constants during Ocata :"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Ic155bd29d46059832cce970bf60375e7e472eca6"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Thanks to the following bugfix also released for Ocata the constants"},{"line_number":17,"context_line":"present in os-brick also support the use of the deprecated legacy class"},{"line_number":18,"context_line":"paths from Nova, for example nova.volume.encryptors.luks.LuksEncryptor,"},{"line_number":19,"context_line":"while using the os-brick provided classes :"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"I3ec6e3fe919bc03d158da04a18fb8b651002ed52"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implements: blueprint switch-to-os-brick-encryptor-classes"},{"line_number":24,"context_line":"Change-Id: I37ffc90c0bd57029fced251b5cfd7cd4318a0292"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7ffa3b31_a7eae40b","line":21,"range":{"start_line":14,"start_character":0,"end_line":21,"end_character":41},"updated":"2017-04-20 14:27:00.000000000","message":"You need at least os-brick 1.11.0 for these changes, but we require 1.8.0 at a minimum today:\n\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt#L150\n\nSo you need to bump global-requirements for a new minimum (1.11.0 at this point).","commit_id":"682bf3d62a9db7f3777022eb601ef00a54be93a4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b2c5da517024ac676eea3d3d9f8a4999b6b1f88b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Implements: blueprint switch-to-os-brick-encryptor-classes"},{"line_number":25,"context_line":"Change-Id: I37ffc90c0bd57029fced251b5cfd7cd4318a0292"},{"line_number":26,"context_line":"Depends-On: I0c54ecec586a7c30b28855545cbad8e1c1888c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7ffa3b31_4f6e8b2f","line":26,"updated":"2017-04-20 21:47:40.000000000","message":"Bump the required version of os-brick in nova\u0027s requirements.txt too.","commit_id":"74d430174db2e63252158531ebe1bc7e469d3469"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5a1cc439e85e3c480609758cc561e88647cb763e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Implements: blueprint switch-to-os-brick-encryptor-classes"},{"line_number":25,"context_line":"Change-Id: I37ffc90c0bd57029fced251b5cfd7cd4318a0292"},{"line_number":26,"context_line":"Depends-On: I0c54ecec586a7c30b28855545cbad8e1c1888c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7ffa3b31_fc017e6b","line":26,"in_reply_to":"7ffa3b31_4f6e8b2f","updated":"2017-04-21 15:26:29.000000000","message":"This is what you want:\n\nhttps://review.openstack.org/#/c/458834/","commit_id":"74d430174db2e63252158531ebe1bc7e469d3469"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4de115cb3049a89eeef53588b435a093dd80132a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Ic155bd29d46059832cce970bf60375e7e472eca6"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Thanks to the following bugfix also released as part of 1.11.0 for Ocata"},{"line_number":17,"context_line":"the constants present in os-brick also support the use of the deprecated"},{"line_number":18,"context_line":"legacy class paths from Nova, for example"},{"line_number":19,"context_line":"nova.volume.encryptors.luks.LuksEncryptor, while using the os-brick"},{"line_number":20,"context_line":"provided classes :"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"I3ec6e3fe919bc03d158da04a18fb8b651002ed52"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Implements: blueprint switch-to-os-brick-encryptor-classes"},{"line_number":25,"context_line":"Change-Id: I37ffc90c0bd57029fced251b5cfd7cd4318a0292"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"5ff73747_87763306","line":22,"range":{"start_line":16,"start_character":0,"end_line":22,"end_character":41},"updated":"2017-04-25 09:49:37.000000000","message":"I assume the expectation is to deprecate support for these legacy classpaths?","commit_id":"73ebe88b986a8e3e0feeab7c52b35b2f3402e320"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f943de13bc6205f6b740c5bb34b212cd72ceb25c","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Ic155bd29d46059832cce970bf60375e7e472eca6"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Thanks to the following bugfix also released as part of 1.11.0 for Ocata"},{"line_number":17,"context_line":"the constants present in os-brick also support the use of the deprecated"},{"line_number":18,"context_line":"legacy class paths from Nova, for example"},{"line_number":19,"context_line":"nova.volume.encryptors.luks.LuksEncryptor, while using the os-brick"},{"line_number":20,"context_line":"provided classes :"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"I3ec6e3fe919bc03d158da04a18fb8b651002ed52"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Implements: blueprint switch-to-os-brick-encryptor-classes"},{"line_number":25,"context_line":"Change-Id: I37ffc90c0bd57029fced251b5cfd7cd4318a0292"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"5ff73747_3d2bf0eb","line":22,"range":{"start_line":16,"start_character":0,"end_line":22,"end_character":41},"in_reply_to":"5ff73747_87763306","updated":"2017-04-25 11:48:45.000000000","message":"Ic155bd29d46059832cce970bf60375e7e472eca6 deprecated these in Ocata for removal in Pike but as Tempest will need to support Newton until Queens I\u0027m going to delay this a cycle. Fun.","commit_id":"73ebe88b986a8e3e0feeab7c52b35b2f3402e320"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4ebe7aca5dd23bd2bab14e7e4e212388f9680521","unresolved":false,"context_lines":[{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"    def _get_volume_encryptor(self, connection_info, encryption):"},{"line_number":1184,"context_line":"        root_helper \u003d utils.get_root_helper()"},{"line_number":1185,"context_line":"        key_manager \u003d keymgr.API(CONF)"},{"line_number":1186,"context_line":"        return encryptors.get_volume_encryptor(root_helper\u003droot_helper,"},{"line_number":1187,"context_line":"                                               keymgr\u003dkey_manager,"},{"line_number":1188,"context_line":"                                               connection_info\u003dconnection_info,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7ffa3b31_4f78cbc2","line":1185,"range":{"start_line":1185,"start_character":33,"end_line":1185,"end_character":37},"updated":"2017-04-20 22:21:10.000000000","message":"nit: I believe this is redundant, the old encryptor base code in nova didn\u0027t pass in CONF:\n\nhttps://review.openstack.org/#/c/391597/17/nova/volume/encryptors/base.py@a35\n\nBut this is OK.","commit_id":"74d430174db2e63252158531ebe1bc7e469d3469"}]}