)]}'
{"nova/virt/driver.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e8937a80c4505618f12fd8599a3a23e652c98ed9","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param instance_id: The ID / name of the instance to lookup"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        return instance_id in self.list_instances()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def list_instances(self):"},{"line_number":134,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F9I0%3D","line":131,"updated":"2012-02-08 21:06:41.000000000","message":"I\u0027m a bit concerned about putting implementation code in this class.  The only other case of it has a note that it should be removed.","commit_id":"a4b2f44096da56abbc17a183991f7d199cf2da36"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"8d10971e757b508bfe9604f6e8ccc4aea3f71b7f","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param instance_id: The ID / name of the instance to lookup"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        return instance_id in self.list_instances()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def list_instances(self):"},{"line_number":134,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F9GU%3D","line":131,"in_reply_to":"AAAAEn%2F%2F9I0%3D","updated":"2012-02-08 21:33:21.000000000","message":"I have heard this class described as being abstract, and it is generally acceptable for abstract base classes to implement methods for which a good default implementation exists.  Why would it be desirable for subclasses to have to duplicate this default implementation?  Or is this class instead intended to define an interface?","commit_id":"a4b2f44096da56abbc17a183991f7d199cf2da36"}],"nova/virt/libvirt/connection.py":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"27a65f8bd8f83f00fbfb7fa334aaab9d92b7c281","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            return libvirt.openAuth(uri, auth, 0)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def instance_exists(self, instance_id):"},{"line_number":285,"context_line":"        \"\"\"Efficient override of base instance_exists method.\"\"\""},{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            _ignored \u003d self._conn.lookupByName(instance_id)"},{"line_number":288,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F89o%3D","line":285,"updated":"2012-02-09 00:19:19.000000000","message":"I think this doc string is useless. The base instance_exists method simply throws an exception..?","commit_id":"495c90efd683d6dba49c728322e78cc62647a5fc"}]}