)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"55de28198e7ffd53c97f06949466d40dc8961130","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notifications related configuration options have been moved from the"},{"line_number":10,"context_line":"default group to the ``notifications`` group."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint centralize-config-options-ocata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I09dc358fabc84f7bf37d40d48b0652a10d9b8903"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_4ec1cc2d","line":11,"updated":"2016-11-16 17:36:10.000000000","message":"Do we still use the keyword \"UpgradeImpact\" in the commit message of change which move/rename config options?","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"647c67833b312196965fdedd596963b9c85a4546","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notifications related configuration options have been moved from the"},{"line_number":10,"context_line":"default group to the ``notifications`` group."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint centralize-config-options-ocata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I09dc358fabc84f7bf37d40d48b0652a10d9b8903"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_535dc245","line":11,"in_reply_to":"7a77a97e_05f8637a","updated":"2016-11-17 15:55:26.000000000","message":"The more I think about this, I think we don\u0027t need it. That\u0027s what the \"upgrade\" section in the reno file is for.","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9328b71f25b8baed66aef7926c0f9c3ca9a60c6b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notifications related configuration options have been moved from the"},{"line_number":10,"context_line":"default group to the ``notifications`` group."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint centralize-config-options-ocata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I09dc358fabc84f7bf37d40d48b0652a10d9b8903"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_05f8637a","line":11,"in_reply_to":"7a77a97e_4ec1cc2d","updated":"2016-11-17 15:34:29.000000000","message":"We did not in all of the patches that are already merged. Not saying it was good, I will have to ask John about that, not sure here.","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da99206ee2ed83055b1e503136d8fa67628a5c16","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notifications related configuration options have been moved from the"},{"line_number":10,"context_line":"default group to the ``notifications`` group."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint centralize-config-options-ocata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I09dc358fabc84f7bf37d40d48b0652a10d9b8903"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_9e4921ba","line":11,"in_reply_to":"7a77a97e_535dc245","updated":"2016-11-17 16:07:48.000000000","message":"Yup - not needed with reno","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"64c4177ff24af436d4739a2d8b918023076a4f71","unresolved":false,"context_lines":[{"line_number":7,"context_line":"conf: added notifications group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notifications related configuration options have been moved from the"},{"line_number":10,"context_line":"default group to the ``notifications`` group."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint centralize-config-options-ocata"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_fe093585","line":10,"updated":"2016-11-17 16:18:59.000000000","message":"And also renamed to avoid the \"smurf-pattern\": https://blog.codinghorror.com/new-programming-jargon/","commit_id":"a399bc6c47e0cbe067436810628a98843c4c395f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"82094d3d10c1c5188706b1a9aaa7ab5a29765c17","unresolved":false,"context_lines":[{"line_number":7,"context_line":"conf: added notifications group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notifications related configuration options have been moved from the"},{"line_number":10,"context_line":"default group to the ``notifications`` group."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint centralize-config-options-ocata"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_f6a15147","line":10,"in_reply_to":"7a77a97e_fe093585","updated":"2016-11-17 20:44:33.000000000","message":"This post is awesome.","commit_id":"a399bc6c47e0cbe067436810628a98843c4c395f"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"90bcf09db6655aaad9891258994778ecc7ee942d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notifications related configuration options have been moved from the"},{"line_number":10,"context_line":"default group to the ``notifications`` group."},{"line_number":11,"context_line":"Also, ``default_notification_level`` has been removed to avoid naming"},{"line_number":12,"context_line":"redundancy."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Blueprint centralize-config-options-ocata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a77a97e_fafd4809","line":11,"range":{"start_line":11,"start_character":46,"end_line":11,"end_character":54},"updated":"2016-11-21 17:24:59.000000000","message":"Is this renamed or removed?","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a37668277c825edf667ce152cf7d2fd0b4e6d545","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notifications related configuration options have been moved from the"},{"line_number":10,"context_line":"default group to the ``notifications`` group."},{"line_number":11,"context_line":"Also, ``default_notification_level`` has been removed to avoid naming"},{"line_number":12,"context_line":"redundancy."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Blueprint centralize-config-options-ocata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a74a57a_2392ed9e","line":11,"range":{"start_line":11,"start_character":46,"end_line":11,"end_character":54},"in_reply_to":"7a77a97e_fafd4809","updated":"2016-11-25 01:42:26.000000000","message":"Good catch","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"}],"doc/source/notifications.rst":[{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"841944764ff7997409e4724e12506513075c2115","unresolved":false,"context_lines":[{"line_number":41,"context_line":"value of the oslo.messaging configuration options `driver` and `topics`."},{"line_number":42,"context_line":"There are notification configuration options in Nova which are specific for"},{"line_number":43,"context_line":"certain notification types like `notifications.notify_on_state_change`,"},{"line_number":44,"context_line":"`notifications.notify_api_faults`, `notifications.default_level`, etc."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The structure of the payload of the unversioned notifications is defined in the"},{"line_number":47,"context_line":"code that emits the notification and no documentation or enforced backward"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_4aadda86","line":44,"range":{"start_line":44,"start_character":15,"end_line":44,"end_character":32},"updated":"2016-11-28 17:54:19.000000000","message":"Missed changing this one to notify_on_api_faults.","commit_id":"16231143439d95b6685771209aed406b3644698e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7c7166b336d3ead65c886859ec556b9956ef59d4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"value of the oslo.messaging configuration options `driver` and `topics`."},{"line_number":42,"context_line":"There are notification configuration options in Nova which are specific for"},{"line_number":43,"context_line":"certain notification types like `notifications.notify_on_state_change`,"},{"line_number":44,"context_line":"`notifications.notify_api_faults`, `notifications.default_level`, etc."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The structure of the payload of the unversioned notifications is defined in the"},{"line_number":47,"context_line":"code that emits the notification and no documentation or enforced backward"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a6eadb0_bf351cdc","line":44,"range":{"start_line":44,"start_character":15,"end_line":44,"end_character":32},"updated":"2016-12-21 02:26:41.000000000","message":"It should be \u0027notify_on_api_faults\u0027.","commit_id":"d07d88fc73370e21af559276afc97f683949987a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"85e2bc2c2b2a46e32e0b2891f6caf170f26c8e48","unresolved":false,"context_lines":[{"line_number":41,"context_line":"value of the oslo.messaging configuration options `driver` and `topics`."},{"line_number":42,"context_line":"There are notification configuration options in Nova which are specific for"},{"line_number":43,"context_line":"certain notification types like `notifications.notify_on_state_change`,"},{"line_number":44,"context_line":"`notifications.notify_api_faults`, `notifications.default_level`, etc."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The structure of the payload of the unversioned notifications is defined in the"},{"line_number":47,"context_line":"code that emits the notification and no documentation or enforced backward"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa48f94a_1bf8677c","line":44,"range":{"start_line":44,"start_character":15,"end_line":44,"end_character":32},"in_reply_to":"1a6eadb0_bf351cdc","updated":"2016-12-21 18:31:42.000000000","message":"+1","commit_id":"d07d88fc73370e21af559276afc97f683949987a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"998653fc64bd5fc029f1c91ca16277496ce0394f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"value of the oslo.messaging configuration options `driver` and `topics`."},{"line_number":42,"context_line":"There are notification configuration options in Nova which are specific for"},{"line_number":43,"context_line":"certain notification types like `notifications.notify_on_state_change`,"},{"line_number":44,"context_line":"`notifications.notify_api_faults`, `notifications.default_level`, etc."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The structure of the payload of the unversioned notifications is defined in the"},{"line_number":47,"context_line":"code that emits the notification and no documentation or enforced backward"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da4df55a_cf1187ae","line":44,"range":{"start_line":44,"start_character":15,"end_line":44,"end_character":32},"in_reply_to":"fa48f94a_1bf8677c","updated":"2016-12-22 19:10:14.000000000","message":"Done","commit_id":"d07d88fc73370e21af559276afc97f683949987a"}],"nova/conf/notifications.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a9cdb2a490564e572786c28f87e02e15777fef4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":39,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    cfg.BoolOpt("},{"line_number":43,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":44,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_b52a172e","line":41,"updated":"2016-11-04 11:21:34.000000000","message":"nit: Can you remove these spaces? Perhaps in a follow-up change","commit_id":"7d28f0d26c9592c8f4b75869d793bbe5ebd09cc9"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"55de28198e7ffd53c97f06949466d40dc8961130","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"notifications_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    name\u003d\u0027notifications\u0027,"},{"line_number":21,"context_line":"    title\u003d\u0027Notifications options\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ALL_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_2ef3b0d7","line":21,"updated":"2016-11-16 17:36:10.000000000","message":"\"OptGroup\" objects can have a help text too. I think it would be useful to add one or two sentences here. Maybe something like this:\n\n    \"Most of the actions in Nova which manipulate the\n    system state generate notifications which is posted to\n    the messaging component (e.g. RabbitMQ) and can be \n    consumed by any service outside the Openstack. More\n    technical details at http://docs.openstack.org/developer/nova/notifications.html\"\n\nSource: https://www.openstack.org/summit/tokyo-2015/videos/presentation/tapping-into-openstacks-notification-system","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"92147009e746db5bde8876c068395c1acfc30790","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"notifications_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    name\u003d\u0027notifications\u0027,"},{"line_number":21,"context_line":"    title\u003d\u0027Notifications options\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ALL_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_39bbf90f","line":21,"in_reply_to":"7a77a97e_2ef3b0d7","updated":"2016-11-16 18:58:14.000000000","message":"+1. Agree and this makes it consistent with other cfg groups.","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9328b71f25b8baed66aef7926c0f9c3ca9a60c6b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"notifications_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    name\u003d\u0027notifications\u0027,"},{"line_number":21,"context_line":"    title\u003d\u0027Notifications options\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ALL_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_40b5e92e","line":21,"in_reply_to":"7a77a97e_39bbf90f","updated":"2016-11-17 15:34:29.000000000","message":"Done","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"92147009e746db5bde8876c068395c1acfc30790","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ALL_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt("},{"line_number":25,"context_line":"        \u0027notify_on_state_change\u0027,"},{"line_number":26,"context_line":"        choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":27,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":28,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_595fd5e4","line":25,"range":{"start_line":25,"start_character":9,"end_line":25,"end_character":31},"updated":"2016-11-16 18:58:14.000000000","message":"Should these options be renamed now? Like remove the \"notify\" prefix?","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9328b71f25b8baed66aef7926c0f9c3ca9a60c6b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ALL_OPTS \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt("},{"line_number":25,"context_line":"        \u0027notify_on_state_change\u0027,"},{"line_number":26,"context_line":"        choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":27,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":28,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_00af71e2","line":25,"range":{"start_line":25,"start_character":9,"end_line":25,"end_character":31},"in_reply_to":"7a77a97e_595fd5e4","updated":"2016-11-17 15:34:29.000000000","message":"In this case I would stay with notify prefix. Without it seems meaningless.","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"92147009e746db5bde8876c068395c1acfc30790","unresolved":false,"context_lines":[{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    cfg.BoolOpt("},{"line_number":43,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":44,"context_line":"        default\u003dFalse,"},{"line_number":45,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":46,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_196e3d95","line":43,"range":{"start_line":43,"start_character":9,"end_line":43,"end_character":26},"updated":"2016-11-16 18:58:14.000000000","message":"same","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9328b71f25b8baed66aef7926c0f9c3ca9a60c6b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    cfg.BoolOpt("},{"line_number":43,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":44,"context_line":"        default\u003dFalse,"},{"line_number":45,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":46,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_e098b5c2","line":43,"range":{"start_line":43,"start_character":9,"end_line":43,"end_character":26},"in_reply_to":"7a77a97e_196e3d95","updated":"2016-11-17 15:34:29.000000000","message":"Let\u0027s stay with notify.","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cda9e427c7d2c0ec128ef33af1aa8ccd8d7f1328","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\"\"\"),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027default_notification_level\u0027,"},{"line_number":53,"context_line":"        default\u003d\u0027INFO\u0027,"},{"line_number":54,"context_line":"        choices\u003d(\u0027DEBUG\u0027, \u0027INFO\u0027, \u0027WARN\u0027, \u0027ERROR\u0027, \u0027CRITICAL\u0027),"},{"line_number":55,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_927885c6","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":35},"updated":"2016-11-08 16:45:28.000000000","message":"Should this be renamed to \u0027default_level\u0027?","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"92147009e746db5bde8876c068395c1acfc30790","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\"\"\"),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027default_notification_level\u0027,"},{"line_number":53,"context_line":"        default\u003d\u0027INFO\u0027,"},{"line_number":54,"context_line":"        choices\u003d(\u0027DEBUG\u0027, \u0027INFO\u0027, \u0027WARN\u0027, \u0027ERROR\u0027, \u0027CRITICAL\u0027),"},{"line_number":55,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_b913890c","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":35},"in_reply_to":"7a77a97e_aeb500ef","updated":"2016-11-16 18:58:14.000000000","message":":) I see others have same opinion, so lets drop notification/notify from all option names.","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9328b71f25b8baed66aef7926c0f9c3ca9a60c6b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\"\"\"),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027default_notification_level\u0027,"},{"line_number":53,"context_line":"        default\u003d\u0027INFO\u0027,"},{"line_number":54,"context_line":"        choices\u003d(\u0027DEBUG\u0027, \u0027INFO\u0027, \u0027WARN\u0027, \u0027ERROR\u0027, \u0027CRITICAL\u0027),"},{"line_number":55,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_45a6db53","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":35},"in_reply_to":"7a77a97e_b913890c","updated":"2016-11-17 15:34:29.000000000","message":"I would stay with notify prefix, but yes - let\u0027s remove the notification prefix.\n\ncutting the notify out makes options meaningless.","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"55de28198e7ffd53c97f06949466d40dc8961130","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\"\"\"),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027default_notification_level\u0027,"},{"line_number":53,"context_line":"        default\u003d\u0027INFO\u0027,"},{"line_number":54,"context_line":"        choices\u003d(\u0027DEBUG\u0027, \u0027INFO\u0027, \u0027WARN\u0027, \u0027ERROR\u0027, \u0027CRITICAL\u0027),"},{"line_number":55,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_aeb500ef","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":35},"in_reply_to":"9a629dbe_927885c6","updated":"2016-11-16 17:36:10.000000000","message":"+1","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cda9e427c7d2c0ec128ef33af1aa8ccd8d7f1328","unresolved":false,"context_lines":[{"line_number":73,"context_line":"*  my_ip - IP address of this host"},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.StrOpt("},{"line_number":76,"context_line":"        \u0027notification_format\u0027,"},{"line_number":77,"context_line":"        choices\u003d[\u0027unversioned\u0027, \u0027versioned\u0027, \u0027both\u0027],"},{"line_number":78,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":79,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_52450d6e","line":76,"range":{"start_line":76,"start_character":9,"end_line":76,"end_character":28},"updated":"2016-11-08 16:45:28.000000000","message":"Should this be renamed to \u0027format\u0027?","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"55de28198e7ffd53c97f06949466d40dc8961130","unresolved":false,"context_lines":[{"line_number":73,"context_line":"*  my_ip - IP address of this host"},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.StrOpt("},{"line_number":76,"context_line":"        \u0027notification_format\u0027,"},{"line_number":77,"context_line":"        choices\u003d[\u0027unversioned\u0027, \u0027versioned\u0027, \u0027both\u0027],"},{"line_number":78,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":79,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_ceb87ce8","line":76,"range":{"start_line":76,"start_character":9,"end_line":76,"end_character":28},"in_reply_to":"9a629dbe_52450d6e","updated":"2016-11-16 17:36:10.000000000","message":"+1","commit_id":"54744391c41d653ecef3dfbc263c90e9a63bb07e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6ad42928e1486d9bfef91ba4f4ca803c4ac5db4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\"\"\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ALL_OPTS \u003d ["},{"line_number":30,"context_line":"    cfg.StrOpt("},{"line_number":31,"context_line":"        \u0027notify_on_state_change\u0027,"},{"line_number":32,"context_line":"        choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":33,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":34,"context_line":"        help\u003d\"\"\""},{"line_number":35,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":36,"context_line":"changes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Please refer to https://wiki.openstack.org/wiki/SystemUsageData for"},{"line_number":39,"context_line":"additional information on notifications."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* None - no notifications"},{"line_number":44,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":45,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.BoolOpt("},{"line_number":49,"context_line":"        \u0027notify_api_faults\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_78a436b9","line":46,"range":{"start_line":30,"start_character":0,"end_line":46,"end_character":5},"updated":"2016-11-18 10:18:57.000000000","message":"This seems like something that should be a bool opt, but I can\u0027t figure out how we\u0027d make it work. This\u0027ll do","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a37668277c825edf667ce152cf7d2fd0b4e6d545","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\"\"\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ALL_OPTS \u003d ["},{"line_number":30,"context_line":"    cfg.StrOpt("},{"line_number":31,"context_line":"        \u0027notify_on_state_change\u0027,"},{"line_number":32,"context_line":"        choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":33,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":34,"context_line":"        help\u003d\"\"\""},{"line_number":35,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":36,"context_line":"changes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Please refer to https://wiki.openstack.org/wiki/SystemUsageData for"},{"line_number":39,"context_line":"additional information on notifications."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* None - no notifications"},{"line_number":44,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":45,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.BoolOpt("},{"line_number":49,"context_line":"        \u0027notify_api_faults\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_0d7440cd","line":46,"range":{"start_line":30,"start_character":0,"end_line":46,"end_character":5},"in_reply_to":"7a77a97e_78a436b9","updated":"2016-11-25 01:42:26.000000000","message":"Sounds like we need... trool!","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6ad42928e1486d9bfef91ba4f4ca803c4ac5db4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.BoolOpt("},{"line_number":49,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":50,"context_line":"        default\u003dFalse,"},{"line_number":51,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":52,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_7808b6da","line":49,"range":{"start_line":49,"start_character":9,"end_line":49,"end_character":26},"updated":"2016-11-18 10:18:57.000000000","message":"could we rename this \u0027notify_on_api_faults\u0027, to synergize with the \u0027notify_on_state_change\u0027 option above? They do the same thing (switch it on) but for different notification types, right?","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a37668277c825edf667ce152cf7d2fd0b4e6d545","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.BoolOpt("},{"line_number":49,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":50,"context_line":"        default\u003dFalse,"},{"line_number":51,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":52,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_0d5b6055","line":49,"range":{"start_line":49,"start_character":9,"end_line":49,"end_character":26},"in_reply_to":"7a77a97e_7808b6da","updated":"2016-11-25 01:42:26.000000000","message":"Right. Renaming.","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6ad42928e1486d9bfef91ba4f4ca803c4ac5db4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"*  my_ip - IP address of this host"},{"line_number":81,"context_line":"\"\"\"),"},{"line_number":82,"context_line":"    cfg.StrOpt("},{"line_number":83,"context_line":"        # NOTE(macsz) While the conf name ``notifications_format`` in"},{"line_number":84,"context_line":"        # ``notifications`` group seems redundant, it is necessary."},{"line_number":85,"context_line":"        # Renaming to ``format`` will shadow the builtin method."},{"line_number":86,"context_line":"        \u0027notifications_format\u0027,"},{"line_number":87,"context_line":"        choices\u003d[\u0027unversioned\u0027, \u0027versioned\u0027, \u0027both\u0027],"},{"line_number":88,"context_line":"        default\u003d\u0027both\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_b8a40e08","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":64},"updated":"2016-11-18 10:18:57.000000000","message":"nit: you don\u0027t need this - no one will take a second look at this once it\u0027s in a group :)","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a37668277c825edf667ce152cf7d2fd0b4e6d545","unresolved":false,"context_lines":[{"line_number":80,"context_line":"*  my_ip - IP address of this host"},{"line_number":81,"context_line":"\"\"\"),"},{"line_number":82,"context_line":"    cfg.StrOpt("},{"line_number":83,"context_line":"        # NOTE(macsz) While the conf name ``notifications_format`` in"},{"line_number":84,"context_line":"        # ``notifications`` group seems redundant, it is necessary."},{"line_number":85,"context_line":"        # Renaming to ``format`` will shadow the builtin method."},{"line_number":86,"context_line":"        \u0027notifications_format\u0027,"},{"line_number":87,"context_line":"        choices\u003d[\u0027unversioned\u0027, \u0027versioned\u0027, \u0027both\u0027],"},{"line_number":88,"context_line":"        default\u003d\u0027both\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_ad134c65","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":64},"in_reply_to":"7a77a97e_b8a40e08","updated":"2016-11-25 01:42:26.000000000","message":"Yeah, right. It is super redundant.","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"90bcf09db6655aaad9891258994778ecc7ee942d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # NOTE(macsz) While the conf name ``notifications_format`` in"},{"line_number":84,"context_line":"        # ``notifications`` group seems redundant, it is necessary."},{"line_number":85,"context_line":"        # Renaming to ``format`` will shadow the builtin method."},{"line_number":86,"context_line":"        \u0027notifications_format\u0027,"},{"line_number":87,"context_line":"        choices\u003d[\u0027unversioned\u0027, \u0027versioned\u0027, \u0027both\u0027],"},{"line_number":88,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":89,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_5a5b9c2e","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":29},"updated":"2016-11-21 17:24:59.000000000","message":"this looks like you are renaming the option from notification_format to notifications_format, shouldn\u0027t we add deprecated_name here?","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a37668277c825edf667ce152cf7d2fd0b4e6d545","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # NOTE(macsz) While the conf name ``notifications_format`` in"},{"line_number":84,"context_line":"        # ``notifications`` group seems redundant, it is necessary."},{"line_number":85,"context_line":"        # Renaming to ``format`` will shadow the builtin method."},{"line_number":86,"context_line":"        \u0027notifications_format\u0027,"},{"line_number":87,"context_line":"        choices\u003d[\u0027unversioned\u0027, \u0027versioned\u0027, \u0027both\u0027],"},{"line_number":88,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":89,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_ed0d443f","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":29},"in_reply_to":"7a77a97e_5a5b9c2e","updated":"2016-11-25 01:42:26.000000000","message":"This is a typo, reverting to good old notification_format.","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"841944764ff7997409e4724e12506513075c2115","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.BoolOpt("},{"line_number":49,"context_line":"        \u0027notify_on_api_faults\u0027,"},{"line_number":50,"context_line":"        default\u003dFalse,"},{"line_number":51,"context_line":"        deprecated_group\u003d\u0027default\u0027,"},{"line_number":52,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_aa310e5c","line":49,"range":{"start_line":49,"start_character":9,"end_line":49,"end_character":29},"updated":"2016-11-28 17:54:19.000000000","message":"Hope this is not a typo:)\nHere the option is renamed, so i think its good to add deprecated_name.","commit_id":"16231143439d95b6685771209aed406b3644698e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"657ed350cdabb064280a4049dabc832a02819ac7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"*  my_ip - IP address of this host"},{"line_number":82,"context_line":"\"\"\"),"},{"line_number":83,"context_line":"    cfg.StrOpt("},{"line_number":84,"context_line":"        \u0027notification_format\u0027,"},{"line_number":85,"context_line":"        choices\u003d[\u0027unversioned\u0027, \u0027versioned\u0027, \u0027both\u0027],"},{"line_number":86,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":87,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_2f384bd3","line":84,"range":{"start_line":84,"start_character":9,"end_line":84,"end_character":28},"updated":"2016-12-13 13:02:46.000000000","message":"Nit: not sure if that should become format, but I actually like notification format.","commit_id":"b4ce5093b15a96161b362e4b1476b1906e161f83"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"298e17c0e09d1245dfd00bdbbf5c91c70464c0c1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"*  my_ip - IP address of this host"},{"line_number":82,"context_line":"\"\"\"),"},{"line_number":83,"context_line":"    cfg.StrOpt("},{"line_number":84,"context_line":"        \u0027notification_format\u0027,"},{"line_number":85,"context_line":"        choices\u003d[\u0027unversioned\u0027, \u0027versioned\u0027, \u0027both\u0027],"},{"line_number":86,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":87,"context_line":"        deprecated_group\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_be5727c9","line":84,"range":{"start_line":84,"start_character":9,"end_line":84,"end_character":28},"in_reply_to":"1a6eadb0_2f384bd3","updated":"2016-12-19 18:55:49.000000000","message":"It can\u0027t - we would shadow python\u0027s builtin \u0027format\u0027.","commit_id":"b4ce5093b15a96161b362e4b1476b1906e161f83"}],"nova/notifications/base.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6ad42928e1486d9bfef91ba4f4ca803c4ac5db4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                nova.context.RequestContext())"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        notifier \u003d rpc.get_notifier(\u0027api\u0027,"},{"line_number":73,"context_line":"                                    publisher_id\u003d("},{"line_number":74,"context_line":"                                        CONF.notifications.default_publisher_id"},{"line_number":75,"context_line":"                                        or CONF.host))"},{"line_number":76,"context_line":"        method \u003d getattr(notifier,"},{"line_number":77,"context_line":"                         CONF.notifications.default_level.lower(),"},{"line_number":78,"context_line":"                         notifier.info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_788b561f","line":75,"range":{"start_line":73,"start_character":36,"end_line":75,"end_character":54},"updated":"2016-11-18 10:18:57.000000000","message":"nit: Can you put this all on one line and remove the large indent?","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a37668277c825edf667ce152cf7d2fd0b4e6d545","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                nova.context.RequestContext())"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        notifier \u003d rpc.get_notifier(\u0027api\u0027,"},{"line_number":73,"context_line":"                                    publisher_id\u003d("},{"line_number":74,"context_line":"                                        CONF.notifications.default_publisher_id"},{"line_number":75,"context_line":"                                        or CONF.host))"},{"line_number":76,"context_line":"        method \u003d getattr(notifier,"},{"line_number":77,"context_line":"                         CONF.notifications.default_level.lower(),"},{"line_number":78,"context_line":"                         notifier.info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_8051f710","line":75,"range":{"start_line":73,"start_character":36,"end_line":75,"end_character":54},"in_reply_to":"7a77a97e_788b561f","updated":"2016-11-25 01:42:26.000000000","message":"Done","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"}],"nova/releasenotes/notes/move-notifications-opts-to-notifications-group-7dc9e76673472b8b.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a9cdb2a490564e572786c28f87e02e15777fef4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Notifications related configuration options have been moved from the"},{"line_number":5,"context_line":"    default group to the ``notifications`` group."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_35e60717","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":49},"updated":"2016-11-04 11:21:34.000000000","message":"Can you list the individual opts that have changed? Refer to releasenotes/notes/add-pci-config-to-pci-group-5648cc0f307f24f8.yaml for an example.","commit_id":"7d28f0d26c9592c8f4b75869d793bbe5ebd09cc9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"a060ac2fe8a1fe496313388ebed6e8d2c2bad3c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Notifications related configuration options have been moved from the"},{"line_number":5,"context_line":"    default group to the ``notifications`` group."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_36819bfc","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":49},"in_reply_to":"ba5da102_35e60717","updated":"2016-11-04 20:27:55.000000000","message":"I agree, all affected options should be listed here.","commit_id":"7d28f0d26c9592c8f4b75869d793bbe5ebd09cc9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6ad42928e1486d9bfef91ba4f4ca803c4ac5db4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``notify_on_state_change``"},{"line_number":8,"context_line":"    - ``notify_api_faults``"},{"line_number":9,"context_line":"    - ``default_notification_level`` and was renamed to ``default_level``"},{"line_number":10,"context_line":"    - ``default_publisher_id``"},{"line_number":11,"context_line":"    - ``notification_format``"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_58bf7aa9","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":73},"updated":"2016-11-18 10:18:57.000000000","message":"nit: looking at other renos, we generally do:\n\n    ``default_level`` (was ``default_notification_level``)\n\nMight be worth changing for consistency?","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a37668277c825edf667ce152cf7d2fd0b4e6d545","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``notify_on_state_change``"},{"line_number":8,"context_line":"    - ``notify_api_faults``"},{"line_number":9,"context_line":"    - ``default_notification_level`` and was renamed to ``default_level``"},{"line_number":10,"context_line":"    - ``default_publisher_id``"},{"line_number":11,"context_line":"    - ``notification_format``"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a74a57a_03ac11ec","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":73},"in_reply_to":"7a77a97e_58bf7aa9","updated":"2016-11-25 01:42:26.000000000","message":"Sure!","commit_id":"ebb53a07fa333ee33dc187071feb688d08e1ad3a"}],"nova/rpc.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"64c4177ff24af436d4739a2d8b918023076a4f71","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    NOTIFICATION_TRANSPORT \u003d messaging.get_notification_transport("},{"line_number":78,"context_line":"        conf, allowed_remote_exmods\u003dexmods, aliases\u003dTRANSPORT_ALIASES)"},{"line_number":79,"context_line":"    serializer \u003d RequestContextSerializer(JsonPayloadSerializer())"},{"line_number":80,"context_line":"    if conf.notifications.format \u003d\u003d \u0027unversioned\u0027:"},{"line_number":81,"context_line":"        LEGACY_NOTIFIER \u003d messaging.Notifier(NOTIFICATION_TRANSPORT,"},{"line_number":82,"context_line":"                                             serializer\u003dserializer)"},{"line_number":83,"context_line":"        NOTIFIER \u003d messaging.Notifier(NOTIFICATION_TRANSPORT,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_9915bbe6","line":80,"range":{"start_line":80,"start_character":26,"end_line":80,"end_character":32},"updated":"2016-11-17 16:18:59.000000000","message":"We shadow the builtin \"format\" now, I haven\u0027t thought about that before. Does anyone see this as an issue? I have no strong feelings here.","commit_id":"a399bc6c47e0cbe067436810628a98843c4c395f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c6e82d81c3914ff8f944e5566cd55e8214a9ae5","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    NOTIFICATION_TRANSPORT \u003d messaging.get_notification_transport("},{"line_number":78,"context_line":"        conf, allowed_remote_exmods\u003dexmods, aliases\u003dTRANSPORT_ALIASES)"},{"line_number":79,"context_line":"    serializer \u003d RequestContextSerializer(JsonPayloadSerializer())"},{"line_number":80,"context_line":"    if conf.notifications.format \u003d\u003d \u0027unversioned\u0027:"},{"line_number":81,"context_line":"        LEGACY_NOTIFIER \u003d messaging.Notifier(NOTIFICATION_TRANSPORT,"},{"line_number":82,"context_line":"                                             serializer\u003dserializer)"},{"line_number":83,"context_line":"        NOTIFIER \u003d messaging.Notifier(NOTIFICATION_TRANSPORT,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_bf897728","line":80,"range":{"start_line":80,"start_character":26,"end_line":80,"end_character":32},"in_reply_to":"7a77a97e_9915bbe6","updated":"2016-11-17 16:52:42.000000000","message":"Ohhhh, good point. Yeah, let\u0027s not do that.","commit_id":"a399bc6c47e0cbe067436810628a98843c4c395f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"82094d3d10c1c5188706b1a9aaa7ab5a29765c17","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    NOTIFICATION_TRANSPORT \u003d messaging.get_notification_transport("},{"line_number":78,"context_line":"        conf, allowed_remote_exmods\u003dexmods, aliases\u003dTRANSPORT_ALIASES)"},{"line_number":79,"context_line":"    serializer \u003d RequestContextSerializer(JsonPayloadSerializer())"},{"line_number":80,"context_line":"    if conf.notifications.format \u003d\u003d \u0027unversioned\u0027:"},{"line_number":81,"context_line":"        LEGACY_NOTIFIER \u003d messaging.Notifier(NOTIFICATION_TRANSPORT,"},{"line_number":82,"context_line":"                                             serializer\u003dserializer)"},{"line_number":83,"context_line":"        NOTIFIER \u003d messaging.Notifier(NOTIFICATION_TRANSPORT,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_bbc26132","line":80,"range":{"start_line":80,"start_character":26,"end_line":80,"end_character":32},"in_reply_to":"7a77a97e_bf897728","updated":"2016-11-17 20:44:33.000000000","message":"Reverting to the good, old notifications_format.","commit_id":"a399bc6c47e0cbe067436810628a98843c4c395f"}],"nova/tests/unit/test_notifier.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"64c4177ff24af436d4739a2d8b918023076a4f71","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        for config in cases:"},{"line_number":47,"context_line":"            mock_notifier.reset_mock()"},{"line_number":48,"context_line":"            mock_notifier.side_effect \u003d [\u0027first\u0027, \u0027second\u0027]"},{"line_number":49,"context_line":"            conf.notifications.notification_format \u003d config"},{"line_number":50,"context_line":"            rpc.init(conf)"},{"line_number":51,"context_line":"            self.assertEqual(cases[config], mock_notifier.call_args_list)"},{"line_number":52,"context_line":"            self.assertEqual(\u0027first\u0027, rpc.LEGACY_NOTIFIER)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_79745f35","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":50},"updated":"2016-11-17 16:18:59.000000000","message":"That should rise an error I hope, because it doesn\u0027t exist like this.","commit_id":"a399bc6c47e0cbe067436810628a98843c4c395f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"82094d3d10c1c5188706b1a9aaa7ab5a29765c17","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        for config in cases:"},{"line_number":47,"context_line":"            mock_notifier.reset_mock()"},{"line_number":48,"context_line":"            mock_notifier.side_effect \u003d [\u0027first\u0027, \u0027second\u0027]"},{"line_number":49,"context_line":"            conf.notifications.notification_format \u003d config"},{"line_number":50,"context_line":"            rpc.init(conf)"},{"line_number":51,"context_line":"            self.assertEqual(cases[config], mock_notifier.call_args_list)"},{"line_number":52,"context_line":"            self.assertEqual(\u0027first\u0027, rpc.LEGACY_NOTIFIER)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_e49b6216","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":50},"in_reply_to":"7a77a97e_79745f35","updated":"2016-11-17 20:44:33.000000000","message":"Yours is a not so empty hope. This is a good catch, but now, given your other observation about builtin I will leave as it is.","commit_id":"a399bc6c47e0cbe067436810628a98843c4c395f"}],"releasenotes/notes/move-notifications-opts-to-notifications-group-7dc9e76673472b8b.yaml":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"85e2bc2c2b2a46e32e0b2891f6caf170f26c8e48","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Following Notifications related configuration options have been moved from"},{"line_number":5,"context_line":"    the default group to the ``notifications`` group:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``notify_on_state_change``"},{"line_number":8,"context_line":"    - ``notify_on_api_faults`` (was ``notify_api_faults``)"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa48f94a_1b13075e","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":15},"updated":"2016-12-21 18:31:42.000000000","message":"nit: wrap with ``. Also this default should be uppercase.","commit_id":"d07d88fc73370e21af559276afc97f683949987a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"998653fc64bd5fc029f1c91ca16277496ce0394f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Following Notifications related configuration options have been moved from"},{"line_number":5,"context_line":"    the default group to the ``notifications`` group:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``notify_on_state_change``"},{"line_number":8,"context_line":"    - ``notify_on_api_faults`` (was ``notify_api_faults``)"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"da4df55a_6fc7bb12","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":15},"in_reply_to":"fa48f94a_1b13075e","updated":"2016-12-22 19:10:14.000000000","message":"Done","commit_id":"d07d88fc73370e21af559276afc97f683949987a"}]}