)]}'
{"nova/conf/network.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f941014cd6442d0c1c56136b15346f8cd26ca311","unresolved":false,"context_lines":[{"line_number":921,"context_line":"Related options:"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"* use_neutron"},{"line_number":924,"context_line":"\"\"\")"},{"line_number":925,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":926,"context_line":"        help\u003d\"\"\""},{"line_number":927,"context_line":"Firewall driver to use with ``nova-network`` service."}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_76a30550","line":924,"updated":"2016-12-19 14:58:26.000000000","message":"Missing comma.","commit_id":"c3975637a18e32a09649ab4c5c889218bd3c63ad"}],"nova/conf/virt.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"860d1ee26498550aa1ae7651fbf0408a7c1d4cf9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"* ``xfs``"},{"line_number":58,"context_line":"* ``ntfs`` (only for Windows guests)"},{"line_number":59,"context_line":"\"\"\"),"},{"line_number":60,"context_line":"    # TODO(sfinucan): This should be a BooleanOpt"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027preallocate_images\u0027,"},{"line_number":62,"context_line":"        default\u003d\u0027none\u0027,"},{"line_number":63,"context_line":"        choices\u003d(\u0027none\u0027, \u0027space\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_3f878fd8","side":"PARENT","line":60,"range":{"start_line":60,"start_character":6,"end_line":60,"end_character":49},"updated":"2016-11-08 12:49:03.000000000","message":"This TODO was not addressed, but I guess that it does not make much sense.","commit_id":"3273103907b1a8cc71454eaf34170563b2391122"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4e6aeac7d8fc7122155358a8ff50f1505ab5795","unresolved":false,"context_lines":[{"line_number":57,"context_line":"* ``xfs``"},{"line_number":58,"context_line":"* ``ntfs`` (only for Windows guests)"},{"line_number":59,"context_line":"\"\"\"),"},{"line_number":60,"context_line":"    # TODO(sfinucan): This should be a BooleanOpt"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027preallocate_images\u0027,"},{"line_number":62,"context_line":"        default\u003d\u0027none\u0027,"},{"line_number":63,"context_line":"        choices\u003d(\u0027none\u0027, \u0027space\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_42862c14","side":"PARENT","line":60,"range":{"start_line":60,"start_character":6,"end_line":60,"end_character":49},"in_reply_to":"9a629dbe_3f878fd8","updated":"2016-11-08 13:03:16.000000000","message":"It was :) Look at the commit message and follow up commit","commit_id":"3273103907b1a8cc71454eaf34170563b2391122"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"860d1ee26498550aa1ae7651fbf0408a7c1d4cf9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from nova.conf import paths"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"default_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":22,"context_line":"        help\u003d\"\"\""},{"line_number":23,"context_line":"Firewall driver to use with ``nova-network`` service."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_1fd2cbd2","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":33},"updated":"2016-11-08 12:49:03.000000000","message":"Given the status of nova-network, should we deprecate all related opts, like this one?","commit_id":"fb147a70e933c4b90fdba3df8809e54de2008c57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4e6aeac7d8fc7122155358a8ff50f1505ab5795","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from nova.conf import paths"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"default_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":22,"context_line":"        help\u003d\"\"\""},{"line_number":23,"context_line":"Firewall driver to use with ``nova-network`` service."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_e2b660db","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":33},"in_reply_to":"9a629dbe_1fd2cbd2","updated":"2016-11-08 13:03:16.000000000","message":"We probably should, but that\u0027s a separate change. I didn\u0027t move these options as I figured we would deprecate them soon enough","commit_id":"fb147a70e933c4b90fdba3df8809e54de2008c57"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"e1006c6e11da06b538d752d48c88326f66afd4cc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  ``nova.virt.libvirt.firewall.IptablesFirewallDriver`` to ensure the"},{"line_number":71,"context_line":"  libvirt firewall driver is enabled."},{"line_number":72,"context_line":"\"\"\"),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027preallocate_images\u0027,"},{"line_number":74,"context_line":"        default\u003d\u0027none\u0027,"},{"line_number":75,"context_line":"        choices\u003d(\u0027none\u0027, \u0027space\u0027),"},{"line_number":76,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_3a33ab63","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":36},"updated":"2016-12-05 22:55:39.000000000","message":"Forgot to bring your TODO with this \"# TODO(sfinucan): This should be a BooleanOpt\"?","commit_id":"ddd1540bace8b69e62ceca42a938ff14e75dbfd3"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"feca1d85dc356879a46bfd6089df4207b75981b6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  ``nova.virt.libvirt.firewall.IptablesFirewallDriver`` to ensure the"},{"line_number":71,"context_line":"  libvirt firewall driver is enabled."},{"line_number":72,"context_line":"\"\"\"),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027preallocate_images\u0027,"},{"line_number":74,"context_line":"        default\u003d\u0027none\u0027,"},{"line_number":75,"context_line":"        choices\u003d(\u0027none\u0027, \u0027space\u0027),"},{"line_number":76,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_120872d9","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":36},"in_reply_to":"3a71b18c_3a33ab63","updated":"2016-12-06 15:21:22.000000000","message":"In case of being boolean, the option name would have to be changed and might become confusing.\n\nI am ok with it as it is.","commit_id":"ddd1540bace8b69e62ceca42a938ff14e75dbfd3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407c2008f32dd7e0ef41e7670802d14988a64363","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    cfg.BoolOpt(\u0027remove_unused_base_images\u0027,"},{"line_number":263,"context_line":"        default\u003dTrue,"},{"line_number":264,"context_line":"        help\u003d\u0027Should unused base images be removed?\u0027),"},{"line_number":265,"context_line":"    cfg.IntOpt(\u0027remove_unused_original_minimum_age_seconds\u0027,"},{"line_number":266,"context_line":"        default\u003d(24 * 3600),"},{"line_number":267,"context_line":"        help\u003d\"\"\""},{"line_number":268,"context_line":"Unused unresized base images younger than this will not be removed."}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_79aa3f72","side":"PARENT","line":265,"updated":"2016-12-12 15:43:09.000000000","message":"Is that a typo? we should have deprecated_name if you want to keep that change.","commit_id":"a753babd9ae4e0d5fe017dacfbc5013f7fa54cfc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407c2008f32dd7e0ef41e7670802d14988a64363","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  ``nova.virt.libvirt.firewall.IptablesFirewallDriver`` to ensure the"},{"line_number":71,"context_line":"  libvirt firewall driver is enabled."},{"line_number":72,"context_line":"\"\"\"),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027preallocate_images\u0027,"},{"line_number":74,"context_line":"        default\u003d\u0027none\u0027,"},{"line_number":75,"context_line":"        choices\u003d(\u0027none\u0027, \u0027space\u0027),"},{"line_number":76,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_39da8779","line":73,"updated":"2016-12-12 15:43:09.000000000","message":"Nit: I would love the moves in a separate patch, but this has waited long enough.","commit_id":"95b7e0d04004edce77340ea7b8b9464e94b64bd3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407c2008f32dd7e0ef41e7670802d14988a64363","unresolved":false,"context_lines":[{"line_number":90,"context_line":"]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"virt_group \u003d cfg.OptGroup("},{"line_number":93,"context_line":"    name\u003d\u0027virt\u0027,"},{"line_number":94,"context_line":"    title\u003d\u0027Virt driver configuration.\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"virt_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_5903c3b8","line":93,"range":{"start_line":93,"start_character":10,"end_line":93,"end_character":14},"updated":"2016-12-12 15:43:09.000000000","message":"We have a load of \"compute\" options and a lot of \"virt\" options.\n\nI am wondering if they are truly different? Maybe they are.","commit_id":"95b7e0d04004edce77340ea7b8b9464e94b64bd3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407c2008f32dd7e0ef41e7670802d14988a64363","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"virt_opts \u003d ["},{"line_number":97,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":98,"context_line":"        deprecated_name\u003d\u0027compute_driver\u0027,"},{"line_number":99,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"Defines which driver to use for controlling virtualization."}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_396fe793","line":98,"range":{"start_line":98,"start_character":25,"end_line":98,"end_character":39},"updated":"2016-12-12 15:43:09.000000000","message":"hmm, but this is the driver for nova-compute, hence compute_driver.\n\nvirt.driver\u003dironic doesn\u0027t read well.\n\nFeels like this should stay in the DEFAULT group, as these drivers do not all use virt, as such.","commit_id":"95b7e0d04004edce77340ea7b8b9464e94b64bd3"}],"releasenotes/notes/add-virt-config-to-virt-group-e0acd6a053a88a84.yaml":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"e1006c6e11da06b538d752d48c88326f66afd4cc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      ``remove_unused_original_minimum_age``)"},{"line_number":24,"context_line":"    - ``pointer_model``"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    These options should no longer be included in the ``DEFAULT`` group."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a71b18c_1df0a9fd","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":72},"updated":"2016-12-05 22:55:39.000000000","message":"It\u0027s better to move this line above the options. It reads out better.","commit_id":"ddd1540bace8b69e62ceca42a938ff14e75dbfd3"}]}