)]}'
{"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"2f5bce7f65c7129815b9e94c5f36f9a9ec6fd9ff","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        project \u003d instance.get(\"project_id\")"},{"line_number":150,"context_line":"        if host:"},{"line_number":151,"context_line":"            return hashlib.sha224(str(project) + host).hexdigest()"},{"line_number":152,"context_line":"            # pylint: disable\u003dE1101"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _get_addresses(self, request, instance):"},{"line_number":155,"context_line":"        context \u003d request.environ[\"nova.context\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F85I%3D","line":152,"updated":"2012-02-09 03:54:28.000000000","message":"I really don\u0027t like seeing this here. If we ignored all of our pylint errors the code would be full of \u0027# pylint: disable\u003dEXXXX\u0027. You should remove this.","commit_id":"0e5fdb83796a69e0c6b72ddb43729ee85a81e3b1"},{"author":{"_account_id":2383,"name":"Philip Knouff","email":"philip.knouff@gmail.com","username":"philip-knouff"},"change_message_id":"91f9ecbf412071e154b787b9cb880483a2969f8f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        project \u003d instance.get(\"project_id\")"},{"line_number":150,"context_line":"        if host:"},{"line_number":151,"context_line":"            return hashlib.sha224(str(project) + host).hexdigest()"},{"line_number":152,"context_line":"            # pylint: disable\u003dE1101"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _get_addresses(self, request, instance):"},{"line_number":155,"context_line":"        context \u003d request.environ[\"nova.context\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F8wM%3D","line":152,"in_reply_to":"AAAAEn%2F%2F85I%3D","updated":"2012-02-09 15:35:38.000000000","message":"When I ran pylint manually on that file without disabling E1101 for that line, it said  \u0027Module hashlib has no member sha224\u0027 \nThis seems like an incorrect error since the module clearly supports sha224.","commit_id":"0e5fdb83796a69e0c6b72ddb43729ee85a81e3b1"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"cedbd745734b518e59a568c753b292200d464cb5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from hashlib import sha224 "},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.api.openstack import common"},{"line_number":22,"context_line":"from nova.api.openstack.compute.views import addresses as views_addresses"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F8tY%3D","line":19,"updated":"2012-02-09 17:19:56.000000000","message":"The nova HACKING file says you should import modules not classes, so this should stay:\n\n    import hashlib\n\nAlso, if you\u0027re using VIM, I find it infinitely helpful to add these lines to my .vimrc file:\n\n    \" Automatically remove trailing whitespace on file write\n    autocmd BufWritePre *.py,nova-* :%s/\\s\\+$//e\n\n    \" Display tabs at the beginning of a line in Python files\n    au BufRead,BufNewFile *.py,*.pyw match BadWhitespace /^\\t\\+/\n\n    \" Make trailing whitespace be flagged as bad.\n    au BufRead,BufNewFile *.py,*.pyw,*.c,*.h match BadWhitespace /\\s\\+$/\n\nThose will remove the need to ever worry about whitespace again when working with Python/Nova","commit_id":"7e61f9027cd608ca480c60f83422284eb2a6ff63"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"cedbd745734b518e59a568c753b292200d464cb5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        host \u003d instance.get(\"host\")"},{"line_number":149,"context_line":"        project \u003d str(instance.get(\"project_id\"))"},{"line_number":150,"context_line":"        if host:"},{"line_number":151,"context_line":"            return sha224(project + host).hexdigest()# pylint: disable\u003dE1101"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _get_addresses(self, request, instance):"},{"line_number":154,"context_line":"        context \u003d request.environ[\"nova.context\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F8s8%3D","line":151,"updated":"2012-02-09 17:19:56.000000000","message":"It may seem silly, but if you change the import to \"import hashlib\" above this might work better as:\n\n    host \u003d str(instance.get(\"host\"))\n    project \u003d str(instance.get(\"project_id\"))\n    if host:\n        sha_hash \u003d hashlib.sha224(host + project)  # pylint: disable\u003dE1101\n        return sha_hash.hexdigest()\n\nThis saves the 80 char line limit and adds 2 spaces between \")\" and \"#\" and the line. Pylint likes having 2 spaces between the end of a line and \u0027inline\u0027 comments.","commit_id":"7e61f9027cd608ca480c60f83422284eb2a6ff63"}],"nova/tests/api/openstack/compute/test_servers.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3c6f9d665a4832504b2e723d02858e504da0fe09","unresolved":false,"context_lines":[{"line_number":222,"context_line":"           project_ids and check that the hostId\u0027s are unique\"\"\""},{"line_number":223,"context_line":"        proj_state \u003d [1]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        def return_instance_with_host(self, *args):"},{"line_number":226,"context_line":"            project_id \u003d proj_state[0]"},{"line_number":227,"context_line":"            proj_state[0] +\u003d 1"},{"line_number":228,"context_line":"            return fakes.stub_instance(id\u003d1, uuid\u003dFAKE_UUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F870%3D","line":225,"updated":"2012-02-09 01:33:48.000000000","message":"How about you just set project_id to str(uuid.uuid4())? That will be cleaner than this proj_state mechanism","commit_id":"4a848463179b5ae54de29c948ac661f0bca1263f"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"2f5bce7f65c7129815b9e94c5f36f9a9ec6fd9ff","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import datetime"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import uuid"},{"line_number":22,"context_line":"import urlparse"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from lxml import etree"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F85E%3D","line":21,"updated":"2012-02-09 03:54:28.000000000","message":"This belongs after urlparse.","commit_id":"0e5fdb83796a69e0c6b72ddb43729ee85a81e3b1"}],"nova/tests/api/openstack/fakes.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3c6f9d665a4832504b2e723d02858e504da0fe09","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        metadata \u003d []"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    inst_type \u003d instance_types.get_instance_type_by_flavor_id(int(flavor_id))"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    if host is not None:"},{"line_number":479,"context_line":"        host \u003d str(host)"},{"line_number":480,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F87w%3D","side":"PARENT","line":477,"updated":"2012-02-09 01:33:48.000000000","message":"Please revert this change. It\u0027s not related to this patch.","commit_id":"6ca8e79dca4e8e9767fff61e95040aa61f51014b"}]}