)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbec1cdec81c149f22188d628c9fce198a362120","unresolved":false,"context_lines":[{"line_number":9,"context_line":"These are self-explanatory, with two exceptions:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- IntOpt does not take a \u0027choices\u0027 parameter"},{"line_number":12,"context_line":"- Adding a \u0027required\u0027 parameter makes testing impossible, as we don\u0027t"},{"line_number":13,"context_line":"  have a configuration file by default"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id3bb4224a30f2abe26c89af6bc5546127c4db739"},{"line_number":16,"context_line":"Implements: bp centralize-config-options-ocata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_02cb2b73","line":13,"range":{"start_line":12,"start_character":2,"end_line":13,"end_character":38},"updated":"2016-11-16 16:31:05.000000000","message":"nova has the config fixture it uses in the test, so this doesn\u0027t seem impossible:\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/conf_fixture.py","commit_id":"340b10699f68eec721820def0d2da711caf09d68"}],"nova/conf/database.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7b5e07e2dad6e826c8712e999c136e449e6ffc47","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        help\u003d\u0027The driver to use for database access\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# NOTE(markus_z): We cannot simply do:"},{"line_number":37,"context_line":"# conf.register_opts(oslo_db_options.database_opts, \u0027api_database\u0027)"},{"line_number":38,"context_line":"# If we reuse a db config option for two different groups (\"api_database\""},{"line_number":39,"context_line":"# and \"database\") and deprecate or rename a config option in one of these"},{"line_number":40,"context_line":"# groups, \"oslo.config\" cannot correctly determine which one to update."},{"line_number":41,"context_line":"# That\u0027s why we copied \u0026 pasted these config options for the \"api_database\""},{"line_number":42,"context_line":"# group here. See commit ba407e3 (\"Add support for multiple database engines\")"},{"line_number":43,"context_line":"# for more details."},{"line_number":44,"context_line":"api_db_group \u003d cfg.OptGroup(\u0027api_database\u0027,"},{"line_number":45,"context_line":"                            title\u003d\u0027API Database Options\u0027,"},{"line_number":46,"context_line":"                            help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_b856085a","line":43,"range":{"start_line":36,"start_character":0,"end_line":43,"end_character":19},"updated":"2016-11-25 18:01:12.000000000","message":"Maybe we made the wrong call back then?\n\nCan do we now have any renames or deprecations that wouldn\u0027t be the same across all the groups?\n\nSeems like the keystone auth stuff has the same issue.","commit_id":"340b10699f68eec721820def0d2da711caf09d68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbec1cdec81c149f22188d628c9fce198a362120","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.IntOpt(\u0027idle_timeout\u0027,"},{"line_number":66,"context_line":"               default\u003d3600,"},{"line_number":67,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027max_pool_size\u0027,"},{"line_number":69,"context_line":"               default\u003d5,"},{"line_number":70,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":71,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027,"},{"line_number":72,"context_line":"               default\u003d10,"},{"line_number":73,"context_line":"               help\u003d\u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_e2f9cf81","line":70,"range":{"start_line":68,"start_character":4,"end_line":70,"end_character":24},"updated":"2016-11-16 16:31:05.000000000","message":"I\u0027m probably missing something, but why aren\u0027t we getting these config values from oslo.db instead of re-defining them in nova? If for some reason oslo.db makes a change that invalidates this default, or they do something and find a better default, then we\u0027re lagging behind.","commit_id":"340b10699f68eec721820def0d2da711caf09d68"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1ab0d234a6a986fc13129532da5b16fb9bb0bcf2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.IntOpt(\u0027idle_timeout\u0027,"},{"line_number":66,"context_line":"               default\u003d3600,"},{"line_number":67,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027max_pool_size\u0027,"},{"line_number":69,"context_line":"               default\u003d5,"},{"line_number":70,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":71,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027,"},{"line_number":72,"context_line":"               default\u003d10,"},{"line_number":73,"context_line":"               help\u003d\u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_93a5cfb6","line":70,"range":{"start_line":68,"start_character":4,"end_line":70,"end_character":24},"in_reply_to":"7a77a97e_e2f9cf81","updated":"2016-11-16 17:14:32.000000000","message":"For the sake of completeness, the discussion why there was a copy\u0026paste of these config options is at https://review.openstack.org/#/c/159266/14/nova/db/sqlalchemy/api.py@125\n\nWhen I made that TODO note, oslo_db didn\u0027t have a default value here but relied on the default value in SQLAlchemy itself. The default in oslo_db came later with https://github.com/openstack/oslo.db/commit/d594f62fd99623ee26134fa132bbb739d9e9de1c\n\nIf we would use the approach of ksa at https://github.com/openstack/nova/blob/master/nova/conf/ironic.py#L105 a change in the config options defined in oslo_db will then *always* have impact on *all* 3 places, namely the sections \"database\", \"api_database\" and \"placement_database\". I\u0027m not sure if this would be a beneficial behavior.","commit_id":"340b10699f68eec721820def0d2da711caf09d68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1d58149ccced72ceb8f91c4a21df2eb2b9b55e18","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.IntOpt(\u0027idle_timeout\u0027,"},{"line_number":66,"context_line":"               default\u003d3600,"},{"line_number":67,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027max_pool_size\u0027,"},{"line_number":69,"context_line":"               default\u003d5,"},{"line_number":70,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":71,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027,"},{"line_number":72,"context_line":"               default\u003d10,"},{"line_number":73,"context_line":"               help\u003d\u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_e25f0f3f","line":70,"range":{"start_line":68,"start_character":4,"end_line":70,"end_character":24},"in_reply_to":"7a77a97e_e2f9cf81","updated":"2016-11-16 16:34:45.000000000","message":"e.g. https://github.com/openstack/nova/blob/master/nova/conf/ironic.py#L105","commit_id":"340b10699f68eec721820def0d2da711caf09d68"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"00848321992124e48cf588762376afc032b0c4fb","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"api_db_opts \u003d ["},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":54,"context_line":"               required\u003dTrue,"},{"line_number":55,"context_line":"               secret\u003dTrue,"},{"line_number":56,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027sqlite_synchronous\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a430d35_fd03660d","line":54,"updated":"2017-02-03 23:53:02.000000000","message":"hmm, can you explain why exactly is this config option mandatory? especially for compute nodes? \n\nmaking it mandatory might break compute nodes when upgrading to Pike, as they most probably don\u0027t have this config option set. ( http://64.119.130.115/nova/393695/7/Hyper-V_logs/c2-r22-u18-n03-compute01/process_error.txt.gz )","commit_id":"7430f5a93744e24a7fbdb0926e3d3d5f9c47db65"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"767d67e38612343d1185efcf4fa32e5a57023b58","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    # SQLAlchemy default. Otherwise we wouldn\u0027t provide a stable default."},{"line_number":82,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"},{"line_number":83,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":84,"context_line":"    # TODO(markus_z): This should probably make use of the \"choices\" attribute."},{"line_number":85,"context_line":"    # \"oslo.db\" uses only the values [\u003c0, 0, 50, 100] see module"},{"line_number":86,"context_line":"    # /oslo_db/sqlalchemy/engines.py method \"_setup_logging\""},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027connection_debug\u0027,"},{"line_number":88,"context_line":"               default\u003d0,"},{"line_number":89,"context_line":"               help\u003d\u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a22e58a_4e4ea7c2","side":"PARENT","line":86,"range":{"start_line":84,"start_character":1,"end_line":86,"end_character":60},"updated":"2017-03-14 07:26:51.000000000","message":"types.Integer accept choices (mainly for PortOpt) but IntOpt not yet. Not sure if any plan for oslo to support that.\n\nIf they have plan then can we keep this TODO as of now ?","commit_id":"0be6bdfc36e8b88e34cbe92164d14070572bf918"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d2d321320aee22c35db8af59242f463f4ee3295a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    # SQLAlchemy default. Otherwise we wouldn\u0027t provide a stable default."},{"line_number":82,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"},{"line_number":83,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":84,"context_line":"    # TODO(markus_z): This should probably make use of the \"choices\" attribute."},{"line_number":85,"context_line":"    # \"oslo.db\" uses only the values [\u003c0, 0, 50, 100] see module"},{"line_number":86,"context_line":"    # /oslo_db/sqlalchemy/engines.py method \"_setup_logging\""},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027connection_debug\u0027,"},{"line_number":88,"context_line":"               default\u003d0,"},{"line_number":89,"context_line":"               help\u003d\u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_9dde1b0f","side":"PARENT","line":86,"range":{"start_line":84,"start_character":1,"end_line":86,"end_character":60},"in_reply_to":"5a22e58a_4e4ea7c2","updated":"2017-03-28 13:48:54.000000000","message":"IntOpt still does not have a choices param, but do we really want choices here?","commit_id":"0be6bdfc36e8b88e34cbe92164d14070572bf918"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c165e467d1ae0dafa683d7be7477bad867208a13","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003d10,"},{"line_number":73,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027,"},{"line_number":75,"context_line":"               min\u003d0,"},{"line_number":76,"context_line":"               default\u003d10,"},{"line_number":77,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_e8959b41","line":75,"updated":"2017-06-13 18:05:40.000000000","message":"Regarding the comments on releasenotes/breakages: I think the only thing that could possibly break here is if someone has already set \u0027retry_interval\u0027 to less than 0. The new \u0027min\u003d0\u0027 requirement would cause a failure, right?","commit_id":"4f5329778e27b1b46eeda82122d0731d870e676a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71f23e935b0ed0175edf294f27a0d6a1f4ecd046","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003d10,"},{"line_number":73,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027,"},{"line_number":75,"context_line":"               min\u003d0,"},{"line_number":76,"context_line":"               default\u003d10,"},{"line_number":77,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_009fb05f","line":75,"in_reply_to":"5f201791_a87816f8","updated":"2017-06-22 08:28:06.000000000","message":"Can\u0027t do any harm. Added now","commit_id":"4f5329778e27b1b46eeda82122d0731d870e676a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"930c3e1a01b890ac6e635773fa9ae48723b867c7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003d10,"},{"line_number":73,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027,"},{"line_number":75,"context_line":"               min\u003d0,"},{"line_number":76,"context_line":"               default\u003d10,"},{"line_number":77,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_a87816f8","line":75,"in_reply_to":"7f231b9d_23ce8959","updated":"2017-06-20 20:48:02.000000000","message":"It wouldn\u0027t, but could someone think that -1 means retry forever? -1 has special meanings in some cases, like disable or retry forever. Do we at least need an upgrade or \u0027other\u0027 release note for highlighting this restriction now?","commit_id":"4f5329778e27b1b46eeda82122d0731d870e676a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89aeaff27ed1e5a479472f3059dcdc9b5a8afefe","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003d10,"},{"line_number":73,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027,"},{"line_number":75,"context_line":"               min\u003d0,"},{"line_number":76,"context_line":"               default\u003d10,"},{"line_number":77,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_23ce8959","line":75,"in_reply_to":"7f231b9d_e8959b41","updated":"2017-06-19 09:20:44.000000000","message":"Hmm, I guess it could, but a negative value wouldn\u0027t really make sense, would it?","commit_id":"4f5329778e27b1b46eeda82122d0731d870e676a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96394920722cfcd3ed5d501dced80369b043739a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"               default\u003d3600,"},{"line_number":67,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027max_pool_size\u0027,"},{"line_number":69,"context_line":"               default\u003d5,"},{"line_number":70,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":71,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027,"},{"line_number":72,"context_line":"               default\u003d10,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_3e185b73","line":69,"updated":"2017-06-23 16:28:24.000000000","message":"Default in oslo.db is 5 also:\n\nhttps://github.com/openstack/oslo.db/blob/6eda258/oslo_db/options.py#L64-L71","commit_id":"1dd81d382c04815fe99f9384b1192bde3e10c408"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96394920722cfcd3ed5d501dced80369b043739a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003d10,"},{"line_number":73,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027,"},{"line_number":75,"context_line":"               min\u003d0,"},{"line_number":76,"context_line":"               default\u003d10,"},{"line_number":77,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_835b9852","line":75,"updated":"2017-06-23 16:28:24.000000000","message":"FYI this option in oslo.db has no minimum:\n\nhttps://github.com/openstack/oslo.db/blob/6eda258/oslo_db/options.py#L81-L86","commit_id":"1dd81d382c04815fe99f9384b1192bde3e10c408"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96394920722cfcd3ed5d501dced80369b043739a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"               default\u003d10,"},{"line_number":77,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"},{"line_number":79,"context_line":"               default\u003d10,"},{"line_number":80,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":81,"context_line":"    cfg.IntOpt(\u0027connection_debug\u0027,"},{"line_number":82,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_033548f7","line":79,"updated":"2017-06-23 16:28:24.000000000","message":"Default in oslo.db is 50:\n\nhttps://github.com/openstack/oslo.db/blob/6eda258/oslo_db/options.py#L88-L95","commit_id":"1dd81d382c04815fe99f9384b1192bde3e10c408"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96394920722cfcd3ed5d501dced80369b043739a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                default\u003dFalse,"},{"line_number":86,"context_line":"                help\u003d\u0027\u0027),"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027pool_timeout\u0027,"},{"line_number":88,"context_line":"               default\u003d30,"},{"line_number":89,"context_line":"               help\u003d\u0027\u0027)"},{"line_number":90,"context_line":"]  # noqa"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_c3175051","line":88,"updated":"2017-06-23 16:28:24.000000000","message":"No default in oslo.db:\n\nhttps://github.com/openstack/oslo.db/blob/6eda258/oslo_db/options.py#L108-L112","commit_id":"1dd81d382c04815fe99f9384b1192bde3e10c408"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6691d0a8f929492b5c085df5eac38999a1ca0f38","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        default\u003d10,"},{"line_number":73,"context_line":"        help\u003d\u0027\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027,"},{"line_number":75,"context_line":"        min\u003d0,"},{"line_number":76,"context_line":"        default\u003d10,"},{"line_number":77,"context_line":"        help\u003d\u0027\u0027),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027max_overflow\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df7087c5_e0bb426f","line":75,"updated":"2018-03-12 17:07:23.000000000","message":"I think we should just keep this the same as oslo.db where we cut and paste this from:\nhttps://github.com/openstack/oslo.db/blob/9c6695969f6502f52bc86f22af0758715fdc57c0/oslo_db/options.py#L95\n\nIt is passed strait to sleep, so I guess that does what it does.","commit_id":"3c4ada8b4bb74e443a64c6982b11eec570554836"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6691d0a8f929492b5c085df5eac38999a1ca0f38","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            if alt_db_opt.name \u003d\u003d db_opt.name:"},{"line_number":103,"context_line":"                # NOTE(markus_z): We can append alternative DB specific help"},{"line_number":104,"context_line":"                # texts here if needed."},{"line_number":105,"context_line":"                alt_db_opt.help \u003d db_opt.help + alt_db_opt.help"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":15,"id":"df7087c5_20505a32","line":105,"updated":"2018-03-12 17:07:23.000000000","message":"I guess we could also copy the defaults across, etc? Probably something for a follow on patch really.","commit_id":"3c4ada8b4bb74e443a64c6982b11eec570554836"}],"releasenotes/notes/api_database-retry_interval-force-minimum-value-979a559bab669d11.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96394920722cfcd3ed5d501dced80369b043739a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[api_database] retry_interval`` previously allowed minimum values."},{"line_number":5,"context_line":"    These made no sense, so this option is not restricted to positive values"},{"line_number":6,"context_line":"    or zero."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f201791_438ea0d0","line":4,"range":{"start_line":4,"start_character":61,"end_line":4,"end_character":68},"updated":"2017-06-23 16:28:24.000000000","message":"Did you mean \"negative\"?","commit_id":"1dd81d382c04815fe99f9384b1192bde3e10c408"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96394920722cfcd3ed5d501dced80369b043739a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[api_database] retry_interval`` previously allowed minimum values."},{"line_number":5,"context_line":"    These made no sense, so this option is not restricted to positive values"},{"line_number":6,"context_line":"    or zero."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f201791_23bf2462","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":46},"updated":"2017-06-23 16:28:24.000000000","message":"Did you mean \"now\"?","commit_id":"1dd81d382c04815fe99f9384b1192bde3e10c408"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96394920722cfcd3ed5d501dced80369b043739a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[api_database] retry_interval`` previously allowed minimum values."},{"line_number":5,"context_line":"    These made no sense, so this option is not restricted to positive values"},{"line_number":6,"context_line":"    or zero."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f201791_83add832","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":9},"updated":"2017-06-23 16:28:24.000000000","message":"Did you mean \"this\"?","commit_id":"1dd81d382c04815fe99f9384b1192bde3e10c408"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ee9680bfb015f26888e831e84b7d546107086c8b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[api_database] retry_interval`` previously allowed negative values."},{"line_number":5,"context_line":"    This made no sense, so this option is now restricted to positive values or"},{"line_number":6,"context_line":"    zero."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df7087c5_8025a6c4","line":6,"updated":"2018-03-12 17:07:52.000000000","message":"This seems like a breaking change without first doing warnings etc, I am tempted to skip it for now.","commit_id":"3c4ada8b4bb74e443a64c6982b11eec570554836"}]}