)]}'
{"nova/tests/functional/api_sample_tests/test_cloudpipe.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test_cloud_pipe_create(self):"},{"line_number":53,"context_line":"        # Get api samples of cloud pipe extension creation."},{"line_number":54,"context_line":"        self.flags(vpn_image_id\u003dfake.get_valid_image_id(), group\u003d\u0027cloudpipe\u0027)"},{"line_number":55,"context_line":"        subs \u003d {\u0027project_id\u0027: uuid.UUID(uuidutils.generate_uuid()).hex}"},{"line_number":56,"context_line":"        response \u003d self._do_post(\u0027os-cloudpipe\u0027, \u0027cloud-pipe-create-req\u0027,"},{"line_number":57,"context_line":"                                 subs)"},{"line_number":58,"context_line":"        subs[\u0027image_id\u0027] \u003d CONF.cloudpipe.vpn_image_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_721ef10c","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":71},"updated":"2016-11-19 05:08:40.000000000","message":"I think we can use direct uuidutils.generate_uuid(). \n\ncurrently this is generating uuid then getting hex and then again generate uuid. too much unnecessary things.","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"},{"author":{"_account_id":9337,"name":"liaonanhai","email":"nanhai.liao@kylin-cloud.com","username":"liaonanhai"},"change_message_id":"8c93bb214554e693f08cbb98f5f6bcb40483ba38","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test_cloud_pipe_create(self):"},{"line_number":53,"context_line":"        # Get api samples of cloud pipe extension creation."},{"line_number":54,"context_line":"        self.flags(vpn_image_id\u003dfake.get_valid_image_id(), group\u003d\u0027cloudpipe\u0027)"},{"line_number":55,"context_line":"        subs \u003d {\u0027project_id\u0027: uuid.UUID(uuidutils.generate_uuid()).hex}"},{"line_number":56,"context_line":"        response \u003d self._do_post(\u0027os-cloudpipe\u0027, \u0027cloud-pipe-create-req\u0027,"},{"line_number":57,"context_line":"                                 subs)"},{"line_number":58,"context_line":"        subs[\u0027image_id\u0027] \u003d CONF.cloudpipe.vpn_image_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_16a67fad","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":71},"in_reply_to":"7a77a97e_721ef10c","updated":"2016-11-20 23:57:34.000000000","message":"thank you,\nuuid.uuid4().hex output like this: cdf454d287b14238a999800a83b8522d\nbut uuidutils.generate_uuid() output like this: 1124caf0-9d45-40cd-9be1-827a3042cf25","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}],"nova/tests/unit/api/openstack/compute/test_aggregates.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Tests for the aggregates admin api.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"from webob import exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_utils import uuidutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from nova.api.openstack.compute import aggregates as aggregates_v21"},{"line_number":24,"context_line":"from nova.compute import api as compute_api"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_12dcdd44","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":32},"updated":"2016-11-19 05:08:40.000000000","message":"import should be together","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}],"nova/tests/unit/api/openstack/compute/test_cloudpipe.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"project_id \u003d uuid_lib.UUID(uuidutils.generate_uuid()).hex"},{"line_number":37,"context_line":"uuid \u003d uuidutils.generate_uuid()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_92f0edca","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":57},"updated":"2016-11-19 05:08:40.000000000","message":"why not just uuidutils.generate_uuid()","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"},{"author":{"_account_id":9323,"name":"lvdongbing","email":"dongbing.lv@kylin-cloud.com","username":"lvdongbing"},"change_message_id":"ec3fcd1941c07a38dace00d885e46d4bdaad06fe","unresolved":false,"context_lines":[{"line_number":33,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"project_id \u003d str(uuid_lib.uuid4().hex)"},{"line_number":37,"context_line":"uuid \u003d uuidutils.generate_uuid()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_ab02d6b1","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":38},"updated":"2016-12-07 01:52:32.000000000","message":"nanhai, after this patch(https://review.openstack.org/398788) merged, we can directly use following code to generate uuid without dashes: uuidutils.generate_uuid(dashed\u003dFalse)","commit_id":"42bed603ecb7f08c3026f5768016050cdb073843"}],"nova/tests/unit/api/openstack/compute/test_evacuate.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":"import testtools"},{"line_number":17,"context_line":"import webob"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_utils import uuidutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.api.openstack.compute import evacuate as evacuate_v21"},{"line_number":22,"context_line":"from nova.compute import api as compute_api"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_b2eb29db","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":32},"updated":"2016-11-19 05:08:40.000000000","message":"should be together","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}],"nova/tests/unit/api/openstack/compute/test_floating_ips.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_utils import uuidutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from nova.api.openstack.compute import floating_ips as fips_v21"},{"line_number":24,"context_line":"from nova.api.openstack import extensions"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_d2bc25de","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":32},"updated":"2016-11-19 05:08:40.000000000","message":"ditto","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}],"nova/tests/unit/compute/test_compute_utils.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        if \u0027xen\u0027 in self.id():"},{"line_number":91,"context_line":"            self.flags(compute_driver\u003d\u0027xenapi.XenAPIDriver\u0027)"},{"line_number":92,"context_line":"            self.instance \u003d objects.Instance("},{"line_number":93,"context_line":"                uuid\u003duuid.UUID(uuidutils.generate_uuid()).hex,"},{"line_number":94,"context_line":"                root_device_name\u003dNone,"},{"line_number":95,"context_line":"                default_ephemeral_device\u003dNone)"},{"line_number":96,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_52d1f521","line":93,"range":{"start_line":93,"start_character":16,"end_line":93,"end_character":61},"updated":"2016-11-19 05:08:40.000000000","message":"use direct uuidutils.generate_uuid()","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                default_ephemeral_device\u003dNone)"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            self.instance \u003d objects.Instance("},{"line_number":98,"context_line":"                uuid\u003duuid.UUID(uuidutils.generate_uuid()).hex,"},{"line_number":99,"context_line":"                root_device_name\u003d\u0027/dev/vda\u0027,"},{"line_number":100,"context_line":"                default_ephemeral_device\u003d\u0027/dev/vdb\u0027)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_92c70d63","line":98,"range":{"start_line":98,"start_character":16,"end_line":98,"end_character":62},"updated":"2016-11-19 05:08:40.000000000","message":"ditto","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":8875,"context_line":"        self.uuidstrs \u003d []"},{"line_number":8876,"context_line":"        for _ in range(6):"},{"line_number":8877,"context_line":"            self.uuidstrs.append("},{"line_number":8878,"context_line":"                stdlib_uuid.UUID(uuidutils.generate_uuid()).hex)"},{"line_number":8879,"context_line":""},{"line_number":8880,"context_line":"    def _assert_shadow_tables_empty_except(self, *exceptions):"},{"line_number":8881,"context_line":"        \"\"\"Ensure shadow tables are empty"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_f2a681bf","line":8878,"range":{"start_line":8878,"start_character":16,"end_line":8878,"end_character":63},"updated":"2016-11-19 05:08:40.000000000","message":"ditto","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}],"nova/tests/unit/db/test_migration_utils.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        table_name \u003d \"__test_deletefromselect_table__\""},{"line_number":63,"context_line":"        uuidstrs \u003d []"},{"line_number":64,"context_line":"        for unused in range(10):"},{"line_number":65,"context_line":"            uuidstrs.append(uuid.UUID(uuidutils.generate_uuid()).hex)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":68,"context_line":"        test_table \u003d Table(table_name, self.meta,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_32ad599b","line":65,"range":{"start_line":65,"start_character":28,"end_line":65,"end_character":69},"updated":"2016-11-19 05:08:40.000000000","message":"ditto","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}],"nova/tests/unit/network/test_api.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        fake_flavor \u003d flavors.get_default_flavor()"},{"line_number":257,"context_line":"        fake_flavor[\u0027rxtx_factor\u0027] \u003d 1.21"},{"line_number":258,"context_line":"        fake_instance \u003d objects.Instance("},{"line_number":259,"context_line":"            uuid\u003duuid.UUID(uuidutils.generate_uuid()).hex,"},{"line_number":260,"context_line":"            project_id\u003d\u0027fake_project_id\u0027,"},{"line_number":261,"context_line":"            instance_type_id\u003dfake_flavor[\u0027id\u0027],"},{"line_number":262,"context_line":"            flavor\u003dfake_flavor,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_52981578","line":259,"range":{"start_line":259,"start_character":17,"end_line":259,"end_character":58},"updated":"2016-11-19 05:08:40.000000000","message":"ditto","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c112697f36ca660afd31d6163d0aca1a3acc10f6","unresolved":false,"context_lines":[{"line_number":5382,"context_line":"    @requests_mock.mock()"},{"line_number":5383,"context_line":"    def _test_get_client_for_admin(self, req_mock,"},{"line_number":5384,"context_line":"                                   use_id\u003dFalse, admin_context\u003dFalse):"},{"line_number":5385,"context_line":"        token_value \u003d uuid.UUID(uuidutils.generate_uuid()).hex"},{"line_number":5386,"context_line":"        auth_url \u003d \u0027http://anyhost/auth\u0027"},{"line_number":5387,"context_line":"        token_resp \u003d V2Token(token_id\u003dtoken_value)"},{"line_number":5388,"context_line":"        req_mock.post(auth_url + \u0027/tokens\u0027, json\u003dtoken_resp)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_7293515b","line":5385,"range":{"start_line":5385,"start_character":22,"end_line":5385,"end_character":62},"updated":"2016-11-19 05:08:40.000000000","message":"ditto","commit_id":"22d843ed453d32a92fb79b531ec366e9d22873ab"}]}