)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"cacf0da5d782aa8398cd2cf296ecde6450088668","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds in the default migration flags"},{"line_number":10,"context_line":"VIR_MIGRATE_PERSIST_DEST which ensures that the domain XML migrated is"},{"line_number":11,"context_line":"going to be set in libvird on destination node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7878e3cd227ed2cf6eb7c001e57c5fc830c0ec18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_4ebf45fb","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":26},"updated":"2016-11-08 08:43:26.000000000","message":"Should be libvirt?","commit_id":"a6053dd608a96ae57521a74b0d6f0f24d7efe75c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79b92cc892e9b57652bdd0dae1c549c9c64264c5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds in the default migration flags"},{"line_number":10,"context_line":"VIR_MIGRATE_PERSIST_DEST which ensures that the domain XML migrated is"},{"line_number":11,"context_line":"going to be set in libvird on destination node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7878e3cd227ed2cf6eb7c001e57c5fc830c0ec18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_59746d34","line":11,"in_reply_to":"9a629dbe_4ebf45fb","updated":"2016-11-08 09:07:44.000000000","message":"libvirtd actually","commit_id":"a6053dd608a96ae57521a74b0d6f0f24d7efe75c"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be41ae82c2f591dc52a84e3a68079d22accf536f","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"        # Adding VIR_MIGRATE_PERSIST_DEST to persist the VM on the"},{"line_number":554,"context_line":"        # destination host"},{"line_number":555,"context_line":"        migration_flags |\u003d libvirt.VIR_MIGRATE_PERSIST_DEST"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        live_migration_flags \u003d block_migration_flags \u003d migration_flags"},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_1729df35","line":555,"updated":"2017-10-09 19:19:06.000000000","message":"Shouldn\u0027t this be added based on libvirt version? Looking at:\n\nhttp://libvirt.org/git/?p\u003dlibvirt.git;a\u003dblob;f\u003ddocs/news-2016.html.in#l437\n\nThis was added to libvirt 2.3.0 but when you added this to nova, we required libvirt at a minimum of 1.2.1.","commit_id":"a6053dd608a96ae57521a74b0d6f0f24d7efe75c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2d98a19c8bf187b1be157989737ebd95ffe494e4","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"        # Adding VIR_MIGRATE_PERSIST_DEST to persist the VM on the"},{"line_number":554,"context_line":"        # destination host"},{"line_number":555,"context_line":"        migration_flags |\u003d libvirt.VIR_MIGRATE_PERSIST_DEST"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        live_migration_flags \u003d block_migration_flags \u003d migration_flags"},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_778a531b","line":555,"in_reply_to":"7f515b1d_1729df35","updated":"2017-10-09 19:21:49.000000000","message":"Nevermind the flag has been around for a very long time:\n\nhttp://libvirt.org/git/?p\u003dlibvirt.git;a\u003dcommit;h\u003d632be336898c9efef258e1f2d1c3df199a98a4aa","commit_id":"a6053dd608a96ae57521a74b0d6f0f24d7efe75c"}]}
