)]}'
{"nova/scheduler/client/report.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"eb0fe2335d26545833f2db4b1d2c51af4146e459","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027total\u0027: compute_node.memory_mb,"},{"line_number":79,"context_line":"            \u0027reserved\u0027: CONF.reserved_host_memory_mb,"},{"line_number":80,"context_line":"            \u0027min_unit\u0027: 1,"},{"line_number":81,"context_line":"            \u0027max_unit\u0027: compute_node.memory_mb,"},{"line_number":82,"context_line":"            \u0027step_size\u0027: 1,"},{"line_number":83,"context_line":"            \u0027allocation_ratio\u0027: compute_node.ram_allocation_ratio,"},{"line_number":84,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_da8a7d63","line":81,"updated":"2016-11-11 15:47:24.000000000","message":"Hmm, should this be (memory - reserved) instead of memory?","commit_id":"00bc0cb53d6113fae9a7714386953d1d75db71c1"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"26b6f3fab1330328ce772196ff49a8df97e20332","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027total\u0027: compute_node.memory_mb,"},{"line_number":79,"context_line":"            \u0027reserved\u0027: CONF.reserved_host_memory_mb,"},{"line_number":80,"context_line":"            \u0027min_unit\u0027: 1,"},{"line_number":81,"context_line":"            \u0027max_unit\u0027: compute_node.memory_mb,"},{"line_number":82,"context_line":"            \u0027step_size\u0027: 1,"},{"line_number":83,"context_line":"            \u0027allocation_ratio\u0027: compute_node.ram_allocation_ratio,"},{"line_number":84,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_7aded1dd","line":81,"in_reply_to":"9a629dbe_da8a7d63","updated":"2016-11-11 16:02:15.000000000","message":"No, I don\u0027t think so. The reserved host memory is accounted for in the reserved field. So there\u0027s actually already a check against reserved amounts. The max_unit should be the maximum value that can be requested that makes sense for that provider. The reserved amount can and will change over time; we don\u0027t want to have to ensure that the two values stay in sync with each other.","commit_id":"00bc0cb53d6113fae9a7714386953d1d75db71c1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"eb0fe2335d26545833f2db4b1d2c51af4146e459","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            \u0027total\u0027: compute_node.local_gb,"},{"line_number":87,"context_line":"            \u0027reserved\u0027: CONF.reserved_host_disk_mb * 1024,"},{"line_number":88,"context_line":"            \u0027min_unit\u0027: 1,"},{"line_number":89,"context_line":"            \u0027max_unit\u0027: compute_node.local_gb,"},{"line_number":90,"context_line":"            \u0027step_size\u0027: 1,"},{"line_number":91,"context_line":"            \u0027allocation_ratio\u0027: compute_node.disk_allocation_ratio,"},{"line_number":92,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_faebc110","line":89,"updated":"2016-11-11 15:47:24.000000000","message":"Same here.","commit_id":"00bc0cb53d6113fae9a7714386953d1d75db71c1"}]}