)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"09a6a74f2ed7cc5bcb5622b9abfa444352b1d741","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix notification doc generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The doc generator only picked up the event types related to"},{"line_number":10,"context_line":"instance actions because doc generator looked up the registered"},{"line_number":11,"context_line":"notification classes but only the instance related ones was"},{"line_number":12,"context_line":"imported in the doc generation environment so the other notification"},{"line_number":13,"context_line":"classes were not registered."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit explicitly imports the modules that defines the notification"},{"line_number":16,"context_line":"classes to make the doc complete."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_464f3392","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":28},"updated":"2016-11-15 15:57:42.000000000","message":"...and the award for the longest sentence goes to :)","commit_id":"47b62ccd2d76e922a03e97e7cf6fc47e0ae28930"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52ad512d034bc4bd806ea6a481eda7d23a0a3510","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix notification doc generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The doc generator only picked up the event types related to"},{"line_number":10,"context_line":"instance actions because doc generator looked up the registered"},{"line_number":11,"context_line":"notification classes but only the instance related ones was"},{"line_number":12,"context_line":"imported in the doc generation environment so the other notification"},{"line_number":13,"context_line":"classes were not registered."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit explicitly imports the modules that defines the notification"},{"line_number":16,"context_line":"classes to make the doc complete."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_4eaba9d6","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":28},"in_reply_to":"7a77a97e_464f3392","updated":"2016-11-24 11:11:31.000000000","message":"Sorry, in my native language this sounded good but I agree that this is better to be split.","commit_id":"47b62ccd2d76e922a03e97e7cf6fc47e0ae28930"}],"doc/ext/versioned_notifications.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"09a6a74f2ed7cc5bcb5622b9abfa444352b1d741","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return self._build_markup(notifications)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _collect_notifications(self):"},{"line_number":49,"context_line":"        # Make sure that all the notification classes are defined so the"},{"line_number":50,"context_line":"        # registration mechanism can pick them up later."},{"line_number":51,"context_line":"        from nova.notifications.objects import exception"},{"line_number":52,"context_line":"        from nova.notifications.objects import instance"},{"line_number":53,"context_line":"        from nova.notifications.objects import service"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        base.NovaObjectRegistry.register_notification_objects()"},{"line_number":56,"context_line":"        notifications \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_68531de2","line":53,"range":{"start_line":49,"start_character":0,"end_line":53,"end_character":54},"updated":"2016-11-15 15:57:42.000000000","message":"Why do we import these here instead of at the top of the file?","commit_id":"47b62ccd2d76e922a03e97e7cf6fc47e0ae28930"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52ad512d034bc4bd806ea6a481eda7d23a0a3510","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return self._build_markup(notifications)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _collect_notifications(self):"},{"line_number":49,"context_line":"        # Make sure that all the notification classes are defined so the"},{"line_number":50,"context_line":"        # registration mechanism can pick them up later."},{"line_number":51,"context_line":"        from nova.notifications.objects import exception"},{"line_number":52,"context_line":"        from nova.notifications.objects import instance"},{"line_number":53,"context_line":"        from nova.notifications.objects import service"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        base.NovaObjectRegistry.register_notification_objects()"},{"line_number":56,"context_line":"        notifications \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_8b8f73cb","line":53,"range":{"start_line":49,"start_character":0,"end_line":53,"end_character":54},"in_reply_to":"7a77a97e_68531de2","updated":"2016-11-24 11:11:31.000000000","message":"I guess this was my \u0027Temporary insanity\u0027 moment. Fixed now.","commit_id":"47b62ccd2d76e922a03e97e7cf6fc47e0ae28930"}]}