)]}'
{"nova/network/security_group/neutron_driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"68a6eca9cfa74e2450910c20c31b53b726786e23","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        :type security_groups: list"},{"line_number":551,"context_line":"        :returns: nova.objects.security_group.SecurityGroupList"},{"line_number":552,"context_line":"        \"\"\""},{"line_number":553,"context_line":"        return secgroup_obj.make_secgroup_list(security_groups)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def get_default_rule(self, context, id):"},{"line_number":556,"context_line":"        msg \u003d _(\"Network driver does not support this function.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_8b525ddc","line":553,"updated":"2016-11-14 21:22:24.000000000","message":"Can\u0027t we just move this to the common base class now?","commit_id":"4f4ea5a983e58c9cb5c477f801e71dbe7815abb3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40408058d6940364a009d9971c1a1cfb73261b8f","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        :type security_groups: list"},{"line_number":551,"context_line":"        :returns: nova.objects.security_group.SecurityGroupList"},{"line_number":552,"context_line":"        \"\"\""},{"line_number":553,"context_line":"        return secgroup_obj.make_secgroup_list(security_groups)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def get_default_rule(self, context, id):"},{"line_number":556,"context_line":"        msg \u003d _(\"Network driver does not support this function.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_13876310","line":553,"in_reply_to":"7a77a97e_8b525ddc","updated":"2016-11-14 23:08:06.000000000","message":"Yeah we could since both secgroup API drivers are doing the same thing.","commit_id":"4f4ea5a983e58c9cb5c477f801e71dbe7815abb3"}],"nova/network/security_group/security_group_base.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1dee9344c73a68131afb74016df489eb1bb0faa7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def populate_security_groups(self, security_groups):"},{"line_number":171,"context_line":"        \"\"\"Build and return a SecurityGroupList."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :param security_groups: list of requested security group uuids or the"},{"line_number":174,"context_line":"            special \u0027default\u0027 security group."},{"line_number":175,"context_line":"        :type security_groups: list"},{"line_number":176,"context_line":"        :returns: nova.objects.security_group.SecurityGroupList"},{"line_number":177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_c235e846","line":174,"range":{"start_line":173,"start_character":32,"end_line":174,"end_character":44},"updated":"2016-11-15 18:07:18.000000000","message":"Doesn\u0027t this need to be rewritten now that it\u0027s in the base class? It\u0027s not a list of uuids for nova-network, right?","commit_id":"ee6c8803074df89809e51f4ffb06da16d8b64f33"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0b4be976411ade4ab2567e28320cb7c3b00aa4fb","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def populate_security_groups(self, security_groups):"},{"line_number":171,"context_line":"        \"\"\"Build and return a SecurityGroupList."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :param security_groups: list of requested security group uuids or the"},{"line_number":174,"context_line":"            special \u0027default\u0027 security group."},{"line_number":175,"context_line":"        :type security_groups: list"},{"line_number":176,"context_line":"        :returns: nova.objects.security_group.SecurityGroupList"},{"line_number":177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_a24f0c91","line":174,"range":{"start_line":173,"start_character":32,"end_line":174,"end_character":44},"in_reply_to":"7a77a97e_c235e846","updated":"2016-11-15 18:09:46.000000000","message":"Yeah good point, I lifted this from the neutron secgroup driver API code. I\u0027ll modify.","commit_id":"ee6c8803074df89809e51f4ffb06da16d8b64f33"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"880b89f5fa2174da0e6cf216c43eed4dc5d7cbc5","unresolved":false,"context_lines":[{"line_number":4721,"context_line":""},{"line_number":4722,"context_line":"    def test_populate_instance_for_create_neutron_secgroups(self):"},{"line_number":4723,"context_line":"        \"\"\"Tests that a list of security groups passed in do not actually get"},{"line_number":4724,"context_line":"        stored on with the instance when using neuron."},{"line_number":4725,"context_line":"        \"\"\""},{"line_number":4726,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":4727,"context_line":"        flavor \u003d self._create_flavor()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_c7fd616f","line":4724,"range":{"start_line":4724,"start_character":15,"end_line":4724,"end_character":22},"updated":"2016-11-11 02:52:25.000000000","message":"typo","commit_id":"9d6a460196ef72a1052fcb3a51c8c8a16744c1b6"}]}