)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a7f74c54b39d772b98e2e5b045b5ec4ec0ee7753","unresolved":false,"context_lines":[{"line_number":10,"context_line":"notifications are transformed to the versioned framework."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia86c8804b284ed4ad72a1993c454ec373c063b99"},{"line_number":13,"context_line":"Implements: bp versioned-notification-transformation-ocata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa31d9ce_44c07450","line":13,"updated":"2017-02-15 11:43:25.000000000","message":"if you have to respin the patch then please change this to versioned-notification-transformation-pike","commit_id":"ab348dba797b9b6021467e1382fcae520fcce7e9"}],"doc/notification_samples/instance-resize_revert-end.json":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6af149f34a7437a722041f78b2c474fc3fd13314","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"event_type\":\"instance.resize_revert.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\": \"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"}],"source_content_type":"application/json","patch_set":12,"id":"5f201791_3c0ae3d1","line":5,"updated":"2017-06-22 00:18:09.000000000","message":"Add \"\u0027auto_disk_config\u0027: \u0027MANUAL\u0027,\"","commit_id":"a1733c576a840929a1ac4a212709df9cc32cd1ca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"de5797a89e33d1a98c4dbb6d2cceab817f0f266c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"event_type\":\"instance.resize_revert.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\": \"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"}],"source_content_type":"application/json","patch_set":12,"id":"3f1d235d_5393fe5b","line":5,"in_reply_to":"5f201791_3c0ae3d1","updated":"2017-07-04 12:35:11.000000000","message":"Done","commit_id":"a1733c576a840929a1ac4a212709df9cc32cd1ca"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6af149f34a7437a722041f78b2c474fc3fd13314","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":69,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":70,"context_line":"        \"nova_object.version\":\"1.1\""},{"line_number":71,"context_line":"    },"},{"line_number":72,"context_line":"    \"priority\":\"INFO\","},{"line_number":73,"context_line":"    \"publisher_id\":\"nova-compute:compute\""}],"source_content_type":"application/json","patch_set":12,"id":"5f201791_1c0f27e2","line":70,"range":{"start_line":70,"start_character":31,"end_line":70,"end_character":34},"updated":"2017-06-22 00:18:09.000000000","message":"s/1.1/1.2/","commit_id":"a1733c576a840929a1ac4a212709df9cc32cd1ca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"de5797a89e33d1a98c4dbb6d2cceab817f0f266c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":69,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":70,"context_line":"        \"nova_object.version\":\"1.1\""},{"line_number":71,"context_line":"    },"},{"line_number":72,"context_line":"    \"priority\":\"INFO\","},{"line_number":73,"context_line":"    \"publisher_id\":\"nova-compute:compute\""}],"source_content_type":"application/json","patch_set":12,"id":"3f1d235d_339c0269","line":70,"range":{"start_line":70,"start_character":31,"end_line":70,"end_character":34},"in_reply_to":"5f201791_1c0f27e2","updated":"2017-07-04 12:35:11.000000000","message":"Done","commit_id":"a1733c576a840929a1ac4a212709df9cc32cd1ca"}],"doc/notification_samples/instance-resize_revert-start.json":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6af149f34a7437a722041f78b2c474fc3fd13314","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"event_type\":\"instance.resize_revert.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\": \"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"}],"source_content_type":"application/json","patch_set":12,"id":"5f201791_fc134b0c","line":5,"updated":"2017-06-22 00:18:09.000000000","message":"Add \"\u0027auto_disk_config\u0027: \u0027MANUAL\u0027,\"","commit_id":"a1733c576a840929a1ac4a212709df9cc32cd1ca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"de5797a89e33d1a98c4dbb6d2cceab817f0f266c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"event_type\":\"instance.resize_revert.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\": \"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"}],"source_content_type":"application/json","patch_set":12,"id":"3f1d235d_13990678","line":5,"in_reply_to":"5f201791_fc134b0c","updated":"2017-07-04 12:35:11.000000000","message":"Done","commit_id":"a1733c576a840929a1ac4a212709df9cc32cd1ca"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6af149f34a7437a722041f78b2c474fc3fd13314","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":69,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":70,"context_line":"        \"nova_object.version\":\"1.1\""},{"line_number":71,"context_line":"    },"},{"line_number":72,"context_line":"    \"priority\":\"INFO\","},{"line_number":73,"context_line":"    \"publisher_id\":\"nova-compute:compute\""}],"source_content_type":"application/json","patch_set":12,"id":"5f201791_dcf88fc5","line":70,"range":{"start_line":70,"start_character":31,"end_line":70,"end_character":34},"updated":"2017-06-22 00:18:09.000000000","message":"s/1.1/1.2/","commit_id":"a1733c576a840929a1ac4a212709df9cc32cd1ca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"de5797a89e33d1a98c4dbb6d2cceab817f0f266c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":69,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":70,"context_line":"        \"nova_object.version\":\"1.1\""},{"line_number":71,"context_line":"    },"},{"line_number":72,"context_line":"    \"priority\":\"INFO\","},{"line_number":73,"context_line":"    \"publisher_id\":\"nova-compute:compute\""}],"source_content_type":"application/json","patch_set":12,"id":"3f1d235d_f38b2a1c","line":70,"range":{"start_line":70,"start_character":31,"end_line":70,"end_character":34},"in_reply_to":"5f201791_dcf88fc5","updated":"2017-07-04 12:35:11.000000000","message":"Done","commit_id":"a1733c576a840929a1ac4a212709df9cc32cd1ca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4e0028f503dd644606f837b207ff579f545e9e63","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"architecture\": \"x86_64\","},{"line_number":6,"context_line":"            \"auto_disk_config\":\"MANUAL\","},{"line_number":7,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":8,"context_line":"            \"block_devices\": [{"},{"line_number":9,"context_line":"                \"nova_object.data\": {"},{"line_number":10,"context_line":"                    \"boot_index\": null,"},{"line_number":11,"context_line":"                    \"delete_on_termination\": false,"},{"line_number":12,"context_line":"                    \"device_name\": \"/dev/sdb\","},{"line_number":13,"context_line":"                    \"tag\": null,"},{"line_number":14,"context_line":"                    \"volume_id\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\""},{"line_number":15,"context_line":"                },"},{"line_number":16,"context_line":"                \"nova_object.name\": \"BlockDevicePayload\","},{"line_number":17,"context_line":"                \"nova_object.namespace\": \"nova\","},{"line_number":18,"context_line":"                \"nova_object.version\": \"1.0\""},{"line_number":19,"context_line":"            }],"},{"line_number":20,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":21,"context_line":"            \"deleted_at\":null,"},{"line_number":22,"context_line":"            \"display_name\":\"some-server\","}],"source_content_type":"application/json","patch_set":16,"id":"ff82abbf_cff79ef5","line":19,"range":{"start_line":8,"start_character":0,"end_line":19,"end_character":15},"updated":"2017-11-21 14:09:31.000000000","message":"Would it make sense to de-duplicate these, as seen here\n\nhttps://review.openstack.org/#/c/521562/1/doc/notification_samples/keypair-create-end.json\n\nI\u0027m not saying do it, because I don\u0027t know if we do partial referencing","commit_id":"f9df074686645a54d44c0fc6494bcdc80ecc0095"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d06ec633897b95bb956dfec8b87fcc72b99e7eef","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"architecture\": \"x86_64\","},{"line_number":6,"context_line":"            \"auto_disk_config\":\"MANUAL\","},{"line_number":7,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":8,"context_line":"            \"block_devices\": [{"},{"line_number":9,"context_line":"                \"nova_object.data\": {"},{"line_number":10,"context_line":"                    \"boot_index\": null,"},{"line_number":11,"context_line":"                    \"delete_on_termination\": false,"},{"line_number":12,"context_line":"                    \"device_name\": \"/dev/sdb\","},{"line_number":13,"context_line":"                    \"tag\": null,"},{"line_number":14,"context_line":"                    \"volume_id\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\""},{"line_number":15,"context_line":"                },"},{"line_number":16,"context_line":"                \"nova_object.name\": \"BlockDevicePayload\","},{"line_number":17,"context_line":"                \"nova_object.namespace\": \"nova\","},{"line_number":18,"context_line":"                \"nova_object.version\": \"1.0\""},{"line_number":19,"context_line":"            }],"},{"line_number":20,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":21,"context_line":"            \"deleted_at\":null,"},{"line_number":22,"context_line":"            \"display_name\":\"some-server\","}],"source_content_type":"application/json","patch_set":16,"id":"ff82abbf_033de8c2","line":19,"range":{"start_line":8,"start_character":0,"end_line":19,"end_character":15},"in_reply_to":"ff82abbf_cff79ef5","updated":"2017-11-27 13:40:42.000000000","message":"Done.","commit_id":"f9df074686645a54d44c0fc6494bcdc80ecc0095"}],"nova/compute/manager.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ed3f61c397e0aeff758f9479b993a9f9668be9d6","unresolved":false,"context_lines":[{"line_number":3686,"context_line":"            compute_utils.notify_about_instance_action(context, instance,"},{"line_number":3687,"context_line":"                self.host, action\u003dfields.NotificationAction.RESIZE_REVERT,"},{"line_number":3688,"context_line":"                    phase\u003dfields.NotificationPhase.END)"},{"line_number":3689,"context_line":""},{"line_number":3690,"context_line":"#            quotas.commit()"},{"line_number":3691,"context_line":""},{"line_number":3692,"context_line":"    def _prep_resize(self, context, image, instance, instance_type,"},{"line_number":3693,"context_line":"            request_spec, filter_properties, node, clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff346bd7_135e8a43","line":3690,"range":{"start_line":3689,"start_character":0,"end_line":3690,"end_character":28},"updated":"2017-07-27 10:14:45.000000000","message":"It should be removed.","commit_id":"824007f6a34953e8d82798aa59e6b07bb76d0819"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1feeb7812ec5584e48b63f294a08607c5b434bbc","unresolved":false,"context_lines":[{"line_number":3686,"context_line":"            compute_utils.notify_about_instance_action(context, instance,"},{"line_number":3687,"context_line":"                self.host, action\u003dfields.NotificationAction.RESIZE_REVERT,"},{"line_number":3688,"context_line":"                    phase\u003dfields.NotificationPhase.END)"},{"line_number":3689,"context_line":""},{"line_number":3690,"context_line":"#            quotas.commit()"},{"line_number":3691,"context_line":""},{"line_number":3692,"context_line":"    def _prep_resize(self, context, image, instance, instance_type,"},{"line_number":3693,"context_line":"            request_spec, filter_properties, node, clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_1d503c5d","line":3690,"range":{"start_line":3689,"start_character":0,"end_line":3690,"end_character":28},"in_reply_to":"ff346bd7_135e8a43","updated":"2017-10-20 15:25:31.000000000","message":"Done","commit_id":"824007f6a34953e8d82798aa59e6b07bb76d0819"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"46e1a430fb4dfc2e0c659dd26ece03afee5edd90","unresolved":false,"context_lines":[{"line_number":5486,"context_line":"        self.compute.revert_resize(self.context,"},{"line_number":5487,"context_line":"                migration\u003dmigration, instance\u003dinstance,"},{"line_number":5488,"context_line":"                reservations\u003dreservations)"},{"line_number":5489,"context_line":"        mock_notify.assert_has_calls(["},{"line_number":5490,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5491,"context_line":"                      action\u003d\u0027resize_revert\u0027, phase\u003d\u0027start\u0027),"},{"line_number":5492,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5493,"context_line":"                      action\u003d\u0027resize_revert\u0027, phase\u003d\u0027end\u0027)])"},{"line_number":5494,"context_line":""},{"line_number":5495,"context_line":"        instance.refresh()"},{"line_number":5496,"context_line":"        if remove_old_vm_state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_cc9abd13","line":5493,"range":{"start_line":5489,"start_character":0,"end_line":5493,"end_character":60},"updated":"2016-11-12 01:14:12.000000000","message":"for some reason, the unit test errored where the actual call shows \" action\u003d\u0027resize\u0027 \" when the expected call should have been \" action\u003d\u0027resize_revert\u0027 \" :(\n\nAdvice appreciated.","commit_id":"c449254e82ba95c1e8fc138068447cde8d90d5c5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a955ef7c7f7c0255b880a83892fd24dc65294234","unresolved":false,"context_lines":[{"line_number":5486,"context_line":"        self.compute.revert_resize(self.context,"},{"line_number":5487,"context_line":"                migration\u003dmigration, instance\u003dinstance,"},{"line_number":5488,"context_line":"                reservations\u003dreservations)"},{"line_number":5489,"context_line":"        mock_notify.assert_has_calls(["},{"line_number":5490,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5491,"context_line":"                      action\u003d\u0027resize_revert\u0027, phase\u003d\u0027start\u0027),"},{"line_number":5492,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5493,"context_line":"                      action\u003d\u0027resize_revert\u0027, phase\u003d\u0027end\u0027)])"},{"line_number":5494,"context_line":""},{"line_number":5495,"context_line":"        instance.refresh()"},{"line_number":5496,"context_line":"        if remove_old_vm_state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_02c16b80","line":5493,"range":{"start_line":5489,"start_character":0,"end_line":5493,"end_character":60},"in_reply_to":"7a77a97e_42fa91be","updated":"2016-11-16 16:26:39.000000000","message":"Sorry my mistake, the test_finish_revert_resize_migration_context does not call the   _test_finish_revert_resize. However this test case runs successfully and actually emits notifications. So we have to figure out why this works and how the 4 failing test is different from this.","commit_id":"c449254e82ba95c1e8fc138068447cde8d90d5c5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d39d69fc69e70f677d6016912fa052dedd87a5ba","unresolved":false,"context_lines":[{"line_number":5486,"context_line":"        self.compute.revert_resize(self.context,"},{"line_number":5487,"context_line":"                migration\u003dmigration, instance\u003dinstance,"},{"line_number":5488,"context_line":"                reservations\u003dreservations)"},{"line_number":5489,"context_line":"        mock_notify.assert_has_calls(["},{"line_number":5490,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5491,"context_line":"                      action\u003d\u0027resize_revert\u0027, phase\u003d\u0027start\u0027),"},{"line_number":5492,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5493,"context_line":"                      action\u003d\u0027resize_revert\u0027, phase\u003d\u0027end\u0027)])"},{"line_number":5494,"context_line":""},{"line_number":5495,"context_line":"        instance.refresh()"},{"line_number":5496,"context_line":"        if remove_old_vm_state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_42fa91be","line":5493,"range":{"start_line":5489,"start_character":0,"end_line":5493,"end_character":60},"in_reply_to":"7a77a97e_ec8cc437","updated":"2016-11-16 12:43:07.000000000","message":"The test_finish_revert_resize_migration_context test case [1] also calls _test_finish_revert_resize and it is passing for me.\nIn the 4 failing test cases the finish_revert_resize in compute/manager.py doesn\u0027t even get called.\nStill looking...","commit_id":"c449254e82ba95c1e8fc138068447cde8d90d5c5"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"d9e3b41e8b6609e81a11d23a38259f78c2b8f2d2","unresolved":false,"context_lines":[{"line_number":5486,"context_line":"        self.compute.revert_resize(self.context,"},{"line_number":5487,"context_line":"                migration\u003dmigration, instance\u003dinstance,"},{"line_number":5488,"context_line":"                reservations\u003dreservations)"},{"line_number":5489,"context_line":"        mock_notify.assert_has_calls(["},{"line_number":5490,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5491,"context_line":"                      action\u003d\u0027resize_revert\u0027, phase\u003d\u0027start\u0027),"},{"line_number":5492,"context_line":"            mock.call(self.context, instance, \u0027fake-mini\u0027,"},{"line_number":5493,"context_line":"                      action\u003d\u0027resize_revert\u0027, phase\u003d\u0027end\u0027)])"},{"line_number":5494,"context_line":""},{"line_number":5495,"context_line":"        instance.refresh()"},{"line_number":5496,"context_line":"        if remove_old_vm_state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_ec8cc437","line":5493,"range":{"start_line":5489,"start_character":0,"end_line":5493,"end_character":60},"in_reply_to":"9a629dbe_cc9abd13","updated":"2016-11-15 00:48:47.000000000","message":"hi gibi, we had a quick chat earlier this morning, but sorry I still couldnt pinpoint the issue here. All four test cases that call the \"_test_finish_revert_resize\" function are failing.","commit_id":"c449254e82ba95c1e8fc138068447cde8d90d5c5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d66cd078b2f84d9b68d9ca9253ee9160e18e455b","unresolved":false,"context_lines":[{"line_number":5511,"context_line":"        self.compute.finish_revert_resize(self.context,"},{"line_number":5512,"context_line":"                migration\u003dmigration,"},{"line_number":5513,"context_line":"                instance\u003dinstance, reservations\u003dreservations)"},{"line_number":5514,"context_line":""},{"line_number":5515,"context_line":"        self.assertIsNone(instance.task_state)"},{"line_number":5516,"context_line":""},{"line_number":5517,"context_line":"        flavor \u003d objects.Flavor.get_by_id(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_b3e9eb82","line":5514,"updated":"2016-11-16 17:21:36.000000000","message":"Finally I got it. The finish_revert_resize is function that contains the actual notification sending so you have to move the assert here.","commit_id":"c449254e82ba95c1e8fc138068447cde8d90d5c5"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"52f118c50af3a1d3dd0b707fc3c2f61bed7efb07","unresolved":false,"context_lines":[{"line_number":5511,"context_line":"        self.compute.finish_revert_resize(self.context,"},{"line_number":5512,"context_line":"                migration\u003dmigration,"},{"line_number":5513,"context_line":"                instance\u003dinstance, reservations\u003dreservations)"},{"line_number":5514,"context_line":""},{"line_number":5515,"context_line":"        self.assertIsNone(instance.task_state)"},{"line_number":5516,"context_line":""},{"line_number":5517,"context_line":"        flavor \u003d objects.Flavor.get_by_id(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d9c5a58e","line":5514,"in_reply_to":"7a77a97e_b3e9eb82","updated":"2016-11-16 18:54:31.000000000","message":"Thank you Balazs! This solution works.","commit_id":"c449254e82ba95c1e8fc138068447cde8d90d5c5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08ffd681226237a835abfd209c919c4e0670050a","unresolved":false,"context_lines":[{"line_number":5563,"context_line":"            self.compute.revert_resize, \u00270000:0b:00.1\u0027)"},{"line_number":5564,"context_line":""},{"line_number":5565,"context_line":"    @mock.patch.object(nova.compute.utils, \u0027notify_about_instance_action\u0027)"},{"line_number":5566,"context_line":"    @mock.patch.object(nova.quota.QUOTAS, \u0027commit\u0027)"},{"line_number":5567,"context_line":"    def _test_finish_revert_resize(self, mock_commit, mock_notify, power_on,"},{"line_number":5568,"context_line":"                                   remove_old_vm_state\u003dFalse,"},{"line_number":5569,"context_line":"                                   numa_topology\u003dNone):"}],"source_content_type":"text/x-python","patch_set":19,"id":"df87a7cf_f9eee086","line":5566,"range":{"start_line":5566,"start_character":4,"end_line":5566,"end_character":51},"updated":"2017-12-05 01:41:10.000000000","message":"This has to be old isn\u0027t it? We don\u0027t do quota reserve/commit anymore.","commit_id":"d370880f6dbc65ab22224ccc5ec22324fdfda436"}]}