)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4c1f3e5848ac9330bdbe53afb979dbd2f0bcd0b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-19 18:59:10 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make test_compute_api work with CONF.use_default\u003dTrue by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few network API methods that need to be mocked out"},{"line_number":10,"context_line":"in the compute API tests when using Neutron."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_074b79b1","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":48},"updated":"2016-11-30 12:51:52.000000000","message":"use_neutron?","commit_id":"17b775703a23eaad63b64eaa67acde57df440f9f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f277e9140f1772b7b522de10903e42b53f422db5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-19 18:59:10 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make test_compute_api work with CONF.use_default\u003dTrue by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few network API methods that need to be mocked out"},{"line_number":10,"context_line":"in the compute API tests when using Neutron."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_bcb3b309","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":48},"in_reply_to":"5a74a57a_074b79b1","updated":"2016-11-30 15:14:58.000000000","message":"Yup, typo.","commit_id":"17b775703a23eaad63b64eaa67acde57df440f9f"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"36f40b652078f012496e721d3d2e409d9fd6a153","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            objects\u003d[objects.NetworkRequest(address\u003daddress,"},{"line_number":191,"context_line":"                                            port_id\u003dport)])"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        with mock.patch.object(self.compute_api.network_api,"},{"line_number":194,"context_line":"                               \u0027create_pci_requests_for_sriov_ports\u0027):"},{"line_number":195,"context_line":"            self.compute_api.create(self.context, instance_type, \u0027image_id\u0027,"},{"line_number":196,"context_line":"                                    requested_networks\u003drequested_networks,"},{"line_number":197,"context_line":"                                    max_count\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_2e913bf1","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":70},"updated":"2016-11-15 11:59:29.000000000","message":"See below","commit_id":"ebe817db840ce74821cc86f5f5a0a7ce99915fec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"36f40b652078f012496e721d3d2e409d9fd6a153","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        for min_count, message in [(20, \u002720-40\u0027), (40, \u002740\u0027)]:"},{"line_number":230,"context_line":"            try:"},{"line_number":231,"context_line":"                with mock.patch.object(self.compute_api.network_api,"},{"line_number":232,"context_line":"                                       \u0027validate_networks\u0027,"},{"line_number":233,"context_line":"                                       return_value\u003d40):"},{"line_number":234,"context_line":"                    self.compute_api.create(self.context, instance_type,"},{"line_number":235,"context_line":"                                            \"image_href\", min_count\u003dmin_count,"},{"line_number":236,"context_line":"                                            max_count\u003d40)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_ee8663b8","line":233,"range":{"start_line":231,"start_character":0,"end_line":233,"end_character":56},"updated":"2016-11-15 11:59:29.000000000","message":"nit: Could we use the decorator pattern instead, to help keep indentation under control here?","commit_id":"ebe817db840ce74821cc86f5f5a0a7ce99915fec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c89e35d342d43665aa871ab530617b58603c13ab","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        for min_count, message in [(20, \u002720-40\u0027), (40, \u002740\u0027)]:"},{"line_number":230,"context_line":"            try:"},{"line_number":231,"context_line":"                with mock.patch.object(self.compute_api.network_api,"},{"line_number":232,"context_line":"                                       \u0027validate_networks\u0027,"},{"line_number":233,"context_line":"                                       return_value\u003d40):"},{"line_number":234,"context_line":"                    self.compute_api.create(self.context, instance_type,"},{"line_number":235,"context_line":"                                            \"image_href\", min_count\u003dmin_count,"},{"line_number":236,"context_line":"                                            max_count\u003d40)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_a3c2f650","line":233,"range":{"start_line":231,"start_character":0,"end_line":233,"end_character":56},"in_reply_to":"7a77a97e_ee8663b8","updated":"2016-11-20 00:10:18.000000000","message":"Not unless you throw this into an inner method and decorate that, which means more churn in here.\n\nI could drop the args to the mock down a line and straighten them out if it\u0027s really a problem.","commit_id":"ebe817db840ce74821cc86f5f5a0a7ce99915fec"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"021334f11583feb9193e9cc966b7d8eef045805c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                                            port_id\u003dport)])"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        with mock.patch.object(self.compute_api.network_api,"},{"line_number":195,"context_line":"                               \u0027create_pci_requests_for_sriov_ports\u0027):"},{"line_number":196,"context_line":"            self.compute_api.create(self.context, instance_type, \u0027image_id\u0027,"},{"line_number":197,"context_line":"                                    requested_networks\u003drequested_networks,"},{"line_number":198,"context_line":"                                    max_count\u003dNone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_b6139965","line":195,"range":{"start_line":195,"start_character":67,"end_line":195,"end_character":70},"updated":"2016-12-03 00:40:25.000000000","message":"we could use fakes.stub_out_nw_api instead of many of mocked one but this is also fine.","commit_id":"eda26f95529031f2db945968ab052e3bb81d230c"}]}