)]}'
{"nova/scheduler/client/report.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"946e1c478efb0c58fca21f05a8b23863a206988d","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        compute_node.save()"},{"line_number":368,"context_line":"        self._ensure_resource_provider(compute_node.uuid,"},{"line_number":369,"context_line":"                                       compute_node.hypervisor_hostname)"},{"line_number":370,"context_line":"        inv_data \u003d _compute_node_to_inventory_dict(compute_node)"},{"line_number":371,"context_line":"        self._update_inventory(compute_node.uuid, inv_data)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def _get_allocations_for_instance(self, rp_uuid, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_b40570c3","line":370,"updated":"2016-11-24 11:59:34.000000000","message":"/me nods with approval at the step forward.","commit_id":"f1cd928bf5daac3b344d0c6cd095aabec14cdbff"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"7f517026b088ec57710911629ff9049c07a03834","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                 \u0027code\u0027: r.status_code,"},{"line_number":437,"context_line":"                 \u0027text\u0027: r.text})"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def update_instance_allocation(self, compute_node, instance, sign):"},{"line_number":440,"context_line":"        if sign \u003e 0:"},{"line_number":441,"context_line":"            self._allocate_for_instance(compute_node.uuid, instance)"},{"line_number":442,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_6e004802","line":439,"range":{"start_line":439,"start_character":41,"end_line":439,"end_character":53},"updated":"2016-11-16 17:25:00.000000000","message":"Is this unchanged for a reason? Seems it would be more consistent to change it here, and then pass the UUID from the resource tracker.","commit_id":"f1cd928bf5daac3b344d0c6cd095aabec14cdbff"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"007d3492a1e12755e7f537cc2417cc371e069cf5","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                 \u0027code\u0027: r.status_code,"},{"line_number":437,"context_line":"                 \u0027text\u0027: r.text})"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def update_instance_allocation(self, compute_node, instance, sign):"},{"line_number":440,"context_line":"        if sign \u003e 0:"},{"line_number":441,"context_line":"            self._allocate_for_instance(compute_node.uuid, instance)"},{"line_number":442,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_99a6cd0e","line":439,"range":{"start_line":439,"start_character":41,"end_line":439,"end_character":53},"in_reply_to":"7a77a97e_6e004802","updated":"2016-11-16 18:52:29.000000000","message":"Yes, it\u0027s left unchanged for a specific reason: it\u0027s a public scheduler report client interface method and what is being passed there is an objects.ComputeNode object directly from the resource tracker.\n\nWhen/if we get to a situation where the resource tracker and this report client mostly merge together and we no longer pass ComputeNode objects around (but instead just ResourceProvider and InventoryList/AllocationList objects), we should change this.","commit_id":"f1cd928bf5daac3b344d0c6cd095aabec14cdbff"}]}