)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"81cd04394e058d6b626f3c4d68d7b521005c3b9a","unresolved":false,"context_lines":[{"line_number":3721,"context_line":"                        exc_info, instance_type, quotas, request_spec,"},{"line_number":3722,"context_line":"                        filter_properties)"},{"line_number":3723,"context_line":"            finally:"},{"line_number":3724,"context_line":"                extra_usage_info \u003d dict("},{"line_number":3725,"context_line":"                        new_instance_type\u003dinstance_type.name,"},{"line_number":3726,"context_line":"                        new_instance_type_id\u003dinstance_type.id)"},{"line_number":3727,"context_line":""},{"line_number":3728,"context_line":"                self._notify_about_instance_usage("},{"line_number":3729,"context_line":"                    context, instance, \"resize.prep.end\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_d5920f57","line":3726,"range":{"start_line":3724,"start_character":0,"end_line":3726,"end_character":62},"updated":"2016-11-15 15:15:48.000000000","message":"We have to understand that this extra info that is available in the legacy notification is also accessible in the versioned notification out of the box. If not then the we have to extend the payload of the notification with this information. \n\nI dig the resize process a bit and it seems that the flavor referenced by the instance only changes at confirmResize. So the resize_confirm versioned notification contains the new flavor but the resize_pre versioned notification doesn\u0027t at the moment.","commit_id":"0cbf95e03b2baba5608dc99c5a33d4ecab0206e1"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"caee7832d941d9aaade58b1192e3f492f1d8b152","unresolved":false,"context_lines":[{"line_number":3721,"context_line":"                        exc_info, instance_type, quotas, request_spec,"},{"line_number":3722,"context_line":"                        filter_properties)"},{"line_number":3723,"context_line":"            finally:"},{"line_number":3724,"context_line":"                extra_usage_info \u003d dict("},{"line_number":3725,"context_line":"                        new_instance_type\u003dinstance_type.name,"},{"line_number":3726,"context_line":"                        new_instance_type_id\u003dinstance_type.id)"},{"line_number":3727,"context_line":""},{"line_number":3728,"context_line":"                self._notify_about_instance_usage("},{"line_number":3729,"context_line":"                    context, instance, \"resize.prep.end\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_c8e6f1e7","line":3726,"range":{"start_line":3724,"start_character":0,"end_line":3726,"end_character":62},"in_reply_to":"7a77a97e_cb86eeb8","updated":"2016-11-22 03:44:23.000000000","message":"Done","commit_id":"0cbf95e03b2baba5608dc99c5a33d4ecab0206e1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2e1ab99fe822314c932b82e053fc9e005d8b7b52","unresolved":false,"context_lines":[{"line_number":3721,"context_line":"                        exc_info, instance_type, quotas, request_spec,"},{"line_number":3722,"context_line":"                        filter_properties)"},{"line_number":3723,"context_line":"            finally:"},{"line_number":3724,"context_line":"                extra_usage_info \u003d dict("},{"line_number":3725,"context_line":"                        new_instance_type\u003dinstance_type.name,"},{"line_number":3726,"context_line":"                        new_instance_type_id\u003dinstance_type.id)"},{"line_number":3727,"context_line":""},{"line_number":3728,"context_line":"                self._notify_about_instance_usage("},{"line_number":3729,"context_line":"                    context, instance, \"resize.prep.end\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_cb86eeb8","line":3726,"range":{"start_line":3724,"start_character":0,"end_line":3726,"end_character":62},"in_reply_to":"7a77a97e_d5920f57","updated":"2016-11-15 15:31:59.000000000","message":"I discussed this with mriedem on IRC[1] and we agreed that we have to follow the legacy behavior. Could you please create an extended InstanceActionPayload class that contains an additional new_flavor field that is initialized from the new_instance_type available in this context?\n\nYou can use the the volume_swap notification [2] as an example how to do the extension. If anything is unclear just ping me on IRC (gibi).\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-nova/latest.log.html#t2016-11-15T15:20:59\n[2] https://review.openstack.org/#/c/340715/","commit_id":"0cbf95e03b2baba5608dc99c5a33d4ecab0206e1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2a23ced78a1026d2545d1d68a7c87827bf543ec1","unresolved":false,"context_lines":[{"line_number":3705,"context_line":"                context, instance, self.host,"},{"line_number":3706,"context_line":"                action\u003dfields.NotificationAction.RESIZE_PREP,"},{"line_number":3707,"context_line":"                phase\u003dfields.NotificationPhase.START,"},{"line_number":3708,"context_line":"                new_instance_type\u003dinstance_type.name,"},{"line_number":3709,"context_line":"                new_instance_type_id\u003dinstance_type.id)"},{"line_number":3710,"context_line":"            try:"},{"line_number":3711,"context_line":"                self._prep_resize(context, image, instance,"},{"line_number":3712,"context_line":"                                  instance_type, quotas,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_d51ae87b","line":3709,"range":{"start_line":3708,"start_character":0,"end_line":3709,"end_character":54},"updated":"2016-11-22 16:03:29.000000000","message":"just pass the new_instance_type","commit_id":"297cf32c4e02d68282034a1629e9a127ffea546c"}],"nova/compute/utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2a23ced78a1026d2545d1d68a7c87827bf543ec1","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"def notify_about_resize_instance(context, instance, host, action, phase,"},{"line_number":419,"context_line":"                                 new_instance_type, new_instance_type_id,"},{"line_number":420,"context_line":"                                 exception\u003dNone):"},{"line_number":421,"context_line":"    \"\"\"Send versioned notification about the instance resize action"},{"line_number":422,"context_line":"       on the instance"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_f53a84e6","line":419,"range":{"start_line":419,"start_character":33,"end_line":419,"end_character":72},"updated":"2016-11-22 16:03:29.000000000","message":"just pass the new_instance_type","commit_id":"297cf32c4e02d68282034a1629e9a127ffea546c"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"3a061f03bbb029a19e2f724450d98a738f3820b5","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    return ips"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"def _get_fault_and_priority_from_exc(exception):"},{"line_number":343,"context_line":"    fault \u003d None"},{"line_number":344,"context_line":"    priority \u003d fields.NotificationPriority.INFO"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    if exception:"},{"line_number":347,"context_line":"        priority \u003d fields.NotificationPriority.ERROR"},{"line_number":348,"context_line":"        fault \u003d notification_exception.ExceptionPayload.from_exception("},{"line_number":349,"context_line":"            exception)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    return fault, priority"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"def notify_about_instance_action(context, instance, host, action, phase\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_b43695b2","line":351,"range":{"start_line":342,"start_character":0,"end_line":351,"end_character":26},"updated":"2016-12-01 11:04:51.000000000","message":"Here it is","commit_id":"958d2c736a32d4dad33f9d8133230755a4f90ef8"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"3a061f03bbb029a19e2f724450d98a738f3820b5","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    flavor \u003d instance_notification.FlavorPayload(instance\u003dinstance)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    if exception:"},{"line_number":442,"context_line":"        priority \u003d fields.NotificationPriority.ERROR"},{"line_number":443,"context_line":"        fault \u003d notification_exception.ExceptionPayload.from_exception("},{"line_number":444,"context_line":"            exception)"},{"line_number":445,"context_line":"    else:"},{"line_number":446,"context_line":"        priority \u003d fields.NotificationPriority.INFO"},{"line_number":447,"context_line":"        fault \u003d None"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    if new_flavor:"},{"line_number":450,"context_line":"        new_flavor \u003d instance_notification.FlavorPayload(instance\u003dinstance,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_94e4393c","line":447,"range":{"start_line":441,"start_character":0,"end_line":447,"end_character":20},"updated":"2016-12-01 11:04:51.000000000","message":"This snippet in moved into a separate helper method, introduced in [1]. That should be used here.\n\n[1]: https://review.openstack.org/#/c/397715","commit_id":"958d2c736a32d4dad33f9d8133230755a4f90ef8"}],"nova/notifications/objects/instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2a23ced78a1026d2545d1d68a7c87827bf543ec1","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":158,"context_line":"    fields \u003d {"},{"line_number":159,"context_line":"        \u0027new_instance_type\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":160,"context_line":"        \u0027new_instance_type_id\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def __init__(self, instance, fault, ip_addresses, flavor,"},{"line_number":164,"context_line":"                 new_instance_type, new_instance_type_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_55d6d8c3","line":161,"range":{"start_line":159,"start_character":1,"end_line":161,"end_character":1},"updated":"2016-11-22 16:03:29.000000000","message":"I think we can simply add a new_flavor field instead:\n\n\u0027new_flavor\u0027: fields.ObjectField(\u0027FlavorPayload\u0027),\n\nand initialize it from the new_instance_type in the manager.","commit_id":"297cf32c4e02d68282034a1629e9a127ffea546c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"ec61b61fc8d8100cc2cb09a720601a369e6dc118","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":158,"context_line":"    fields \u003d {"},{"line_number":159,"context_line":"        \u0027new_instance_type\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":160,"context_line":"        \u0027new_instance_type_id\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def __init__(self, instance, fault, ip_addresses, flavor,"},{"line_number":164,"context_line":"                 new_instance_type, new_instance_type_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_b21a296d","line":161,"range":{"start_line":159,"start_character":1,"end_line":161,"end_character":1},"in_reply_to":"7a77a97e_55d6d8c3","updated":"2016-11-23 06:44:14.000000000","message":"Done","commit_id":"297cf32c4e02d68282034a1629e9a127ffea546c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2a23ced78a1026d2545d1d68a7c87827bf543ec1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                fault\u003dfault,"},{"line_number":168,"context_line":"                ip_addresses\u003dip_addresses,"},{"line_number":169,"context_line":"                flavor\u003dflavor,"},{"line_number":170,"context_line":"                old_volume_id\u003dnew_instance_type,"},{"line_number":171,"context_line":"                new_volume_id\u003dnew_instance_type_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"@nova_base.NovaObjectRegistry.register_notification"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_558418b0","line":171,"range":{"start_line":170,"start_character":1,"end_line":171,"end_character":51},"updated":"2016-11-22 16:03:29.000000000","message":"the name of the parameters looks bad I guess it is copy paste error","commit_id":"297cf32c4e02d68282034a1629e9a127ffea546c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"d6ba774a43fc02faf2429b4086c870723ca576ea","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                fault\u003dfault,"},{"line_number":168,"context_line":"                ip_addresses\u003dip_addresses,"},{"line_number":169,"context_line":"                flavor\u003dflavor,"},{"line_number":170,"context_line":"                old_volume_id\u003dnew_instance_type,"},{"line_number":171,"context_line":"                new_volume_id\u003dnew_instance_type_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"@nova_base.NovaObjectRegistry.register_notification"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_370c4b42","line":171,"range":{"start_line":170,"start_character":1,"end_line":171,"end_character":51},"in_reply_to":"7a77a97e_558418b0","updated":"2016-11-23 06:36:26.000000000","message":"Done","commit_id":"297cf32c4e02d68282034a1629e9a127ffea546c"}]}