)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2301d534961e26f470c41c5b04b0c1d5731e1338","unresolved":false,"context_lines":[{"line_number":7,"context_line":"refactor: remove code duplication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The same code fragment appeared in two places. This change extracts the"},{"line_number":10,"context_line":"common bits to a function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id317477cb278aa1b6d038516e202aff1bd6129a6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAQn%2F%2FWbw%3D","line":10,"updated":"2013-08-01 15:43:51.000000000","message":"I\u0027d like to see a little more information here.  What does the code fragment do?  How have you refactored it to eliminate the duplication?  The summary could also stand to be a little bit more explicit…","commit_id":"534360a593ba306ca2aa46e6644edc8c587ae27e"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"518820c95d6438506508d44bdf254dc36fa61379","unresolved":false,"context_lines":[{"line_number":7,"context_line":"refactor: remove code duplication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The same code fragment appeared in two places. This change extracts the"},{"line_number":10,"context_line":"common bits to a function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id317477cb278aa1b6d038516e202aff1bd6129a6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAQn%2F%2FWEc%3D","line":10,"in_reply_to":"AAAAQn%2F%2FWbw%3D","updated":"2013-08-01 17:23:50.000000000","message":"the code fragment creates the kernel and the ramdisk, as its name suggests. I did it in order to remove code duplication. All this information should be in the next commit message.","commit_id":"534360a593ba306ca2aa46e6644edc8c587ae27e"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f7685f584ee6559836745420ac5244027a1c9b64","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor: extract _create_kernel_and_ramdisk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to get rid of duplicated code."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id317477cb278aa1b6d038516e202aff1bd6129a6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAQn%2F%2FV5M%3D","line":9,"updated":"2013-08-01 18:05:44.000000000","message":"I\u0027d still like more of a write-up here.  Maybe something like:\n\n    xenapi: Reduce code duplication in vmops\n\n    A code fragment that creates kernel and ramdisk appeared in several\n    locations in vmops.  This eliminates that duplication by wrapping it in\n    a new _create_kernel_and_ramdisk() method.\n\nSee https://wiki.openstack.org/wiki/GitCommitMessages for more about what we like in commit messages.\n\n(It might also be a good idea to create a bug report and link it to the commit message; this will help us track it and may be instrumental in getting this change into the actual release.)","commit_id":"e5c18737a56c5a6d8aead2080a8d82b215f03267"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"d0a9c11fc6a31fa137e493f57599f683e28b95e7","unresolved":false,"context_lines":[{"line_number":1928,"context_line":"        return sr_uuid_map"},{"line_number":1929,"context_line":""},{"line_number":1930,"context_line":""},{"line_number":1931,"context_line":"def create_kernel_and_ramdisk(instance, context, session, name_label):"},{"line_number":1932,"context_line":"    kernel_file \u003d None"},{"line_number":1933,"context_line":"    ramdisk_file \u003d None"},{"line_number":1934,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FWi8%3D","line":1931,"updated":"2013-08-01 15:13:02.000000000","message":"Shouldn\u0027t it be a method part of the VMOps class? I don\u0027t see why it should be different/separated from other methods. Although it does not need to access any internal method/attribute. Will it be used somewhere else?","commit_id":"534360a593ba306ca2aa46e6644edc8c587ae27e"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"518820c95d6438506508d44bdf254dc36fa61379","unresolved":false,"context_lines":[{"line_number":1928,"context_line":"        return sr_uuid_map"},{"line_number":1929,"context_line":""},{"line_number":1930,"context_line":""},{"line_number":1931,"context_line":"def create_kernel_and_ramdisk(instance, context, session, name_label):"},{"line_number":1932,"context_line":"    kernel_file \u003d None"},{"line_number":1933,"context_line":"    ramdisk_file \u003d None"},{"line_number":1934,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FWG4%3D","line":1931,"in_reply_to":"AAAAQn%2F%2FWi8%3D","updated":"2013-08-01 17:23:50.000000000","message":"Done","commit_id":"534360a593ba306ca2aa46e6644edc8c587ae27e"}]}